From: Rob Herring <robh@kernel.org> To: Suzuki K Poulose <suzuki.poulose@arm.com>, Mao Jinlong <quic_jinlmao@quicinc.com> Cc: Mathieu Poirier <mathieu.poirier@linaro.org>, Alexander Shishkin <alexander.shishkin@linux.intel.com>, Konrad Dybcio <konradybcio@gmail.com>, Mike Leach <mike.leach@linaro.org>, Leo Yan <leo.yan@linaro.org>, Greg Kroah-Hartman <gregkh@linuxfoundation.org>, Coresight ML <coresight@lists.linaro.org>, linux-arm-kernel <linux-arm-kernel@lists.infradead.org>, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>, Tingwei Zhang <quic_tingweiz@quicinc.com>, Yuanfang Zhang <quic_yuanfang@quicinc.com>, Tao Zhang <quic_taozha@quicinc.com>, Trilok Soni <quic_tsoni@quicinc.com>, Hao Zhang <quic_hazha@quicinc.com>, linux-arm-msm <linux-arm-msm@vger.kernel.org>, Bjorn Andersson <bjorn.andersson@linaro.org> Subject: Re: [PATCH v7 08/10] dt-bindings: arm: Adds CoreSight TPDA hardware definitions Date: Mon, 23 May 2022 09:24:57 -0500 [thread overview] Message-ID: <CAL_JsqK8Z_J2xaOsBM-U4hhHPgQCudd=SGmPqwdipArWmTXJYw@mail.gmail.com> (raw) In-Reply-To: <beba5968-3115-3c09-cda6-67095ca55226@arm.com> On Mon, May 23, 2022 at 4:44 AM Suzuki K Poulose <suzuki.poulose@arm.com> wrote: > > Cc: Rob Herring > Will or will not have any effect... Please use get_maintainers.pl and send your patches to the right lists/maintainers. DT patches only get reviewed if sent to DT list. So please resend to the DT list. But before you do, I can tell this binding hasn't been tested so fix all the warnings first. Rob > > > On 09/05/2022 14:39, Mao Jinlong wrote: > > Adds new coresight-tpda.yaml file describing the bindings required > > to define tpda in the device trees. > > > > Reviewed-by: Mike Leach <mike.leach@linaro.org> > > Signed-off-by: Tao Zhang <quic_taozha@quicinc.com> > > Signed-off-by: Mao Jinlong <quic_jinlmao@quicinc.com> > > --- > > .../bindings/arm/coresight-tpda.yaml | 119 ++++++++++++++++++ > > MAINTAINERS | 1 + > > 2 files changed, 120 insertions(+) > > create mode 100644 Documentation/devicetree/bindings/arm/coresight-tpda.yaml > > > > diff --git a/Documentation/devicetree/bindings/arm/coresight-tpda.yaml b/Documentation/devicetree/bindings/arm/coresight-tpda.yaml > > new file mode 100644 > > index 000000000000..4948ac13e7f8 > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/arm/coresight-tpda.yaml > > @@ -0,0 +1,119 @@ > > +# SPDX-License-Identifier: GPL-2.0-only or BSD-2-Clause > > +# Copyright (c) 2022 Qualcomm Innovation Center, Inc. All rights reserved. > > +%YAML 1.2 > > +--- > > +$id: http://devicetree.org/schemas/arm/coresight-tpda.yaml# > > +$schema: http://devicetree.org/meta-schemas/core.yaml# > > + > > +title: Trace, Profiling and Diagnostics Aggregator - TPDA > > + > > +description: | > > + TPDAs are responsible for packetization and timestamping of data sets > > + utilizing the MIPI STPv2 packet protocol. Pulling data sets from one or > > + more attached TPDM and pushing the resultant (packetized) data out a > > + master ATB interface. Performing an arbitrated ATB interleaving (funneling) > > + task for free-flowing data from TPDM (i.e. CMB and DSB data set flows). > > + > > +maintainers: > > + - Mao Jinlong <quic_jinlmao@quicinc.com> > > + - Tao Zhang <quic_taozha@quicinc.com> > > + > > +properties: > > + $nodename: > > + pattern: "^tpda(@[0-9a-f]+)$" > > + compatible: > > + items: > > + - const: qcom,coresight-tpda > > + - const: arm,primecell > > + > > + reg: > > + maxItems: 1 > > + > > + clocks: > > + maxItems: 1 > > + > > + clock-names: > > + items: > > + - const: apb_pclk > > + > > + in-ports: > > + type: object > > + description: | > > + Input connections from TPDM to TPDA > > + $ref: /schemas/graph.yaml#/properties/ports > > + > > --->8--- > > + properties: > > + '#address-cells': > > + const: 1 > > + > > + '#size-cells': > > + const: 0 > > + > > + patternProperties: > > + "^port@[0-9a-f]+$": > > + type: object > > + required: > > + - reg > > + > > + required: > > + - '#size-cells' > > + - '#address-cells' > > ---8<--- > > I believe the above snippet is not needed and is covered by the generic > ports. > > > > + > > + out-ports: > > + type: object > > + description: | > > + Output connections from the TPDA to legacy CoreSight trace bus. > > + $ref: /schemas/graph.yaml#/properties/ports > > + > > + properties: > > + port: > > + description: > > + Output connection from the TPDA to legacy CoreSight Trace bus. > > + $ref: /schemas/graph.yaml#/properties/port > > + > > +required: > > + - compatible > > + - reg > > + - clocks > > + - clock-names > > + - in-ports > > + - out-ports > > + > > +additionalProperties: false > > + > > +examples: > > + # minimum tpda definition. > > + - | > > + tpda@6004000 { > > + compatible = "qcom,coresight-tpda", "arm,primecell"; > > + reg = <0x6004000 0x1000>; > > + > > + qcom,tpda-atid = <65>; > > + > > + clocks = <&aoss_qmp>; > > + clock-names = "apb_pclk"; > > + > > + in-ports { > > + #address-cells = <1>; > > + #size-cells = <0>; > > + > > + port@0 { > > + reg = <0>; > > + tpda_qdss_0_in_tpdm_dcc: endpoint { > > + remote-endpoint = > > + <&tpdm_dcc_out_tpda_qdss_0>; > > + }; > > + }; > > + }; > > + > > + out-ports { > > + port { > > + tpda_qdss_out_funnel_in0: endpoint { > > + remote-endpoint = > > + <&funnel_in0_in_tpda_qdss>; > > + }; > > + }; > > + }; > > + }; > > + > > +... > > diff --git a/MAINTAINERS b/MAINTAINERS > > index 28d32b3f3f5c..5d2d8c0ee340 100644 > > --- a/MAINTAINERS > > +++ b/MAINTAINERS > > @@ -1978,6 +1978,7 @@ T: git git://git.kernel.org/pub/scm/linux/kernel/git/coresight/linux.git > > F: Documentation/ABI/testing/sysfs-bus-coresight-devices-* > > F: Documentation/devicetree/bindings/arm/coresight-cpu-debug.txt > > F: Documentation/devicetree/bindings/arm/coresight-cti.yaml > > +F: Documentation/devicetree/bindings/arm/coresight-tpda.yaml > > F: Documentation/devicetree/bindings/arm/coresight-tpdm.yaml > > F: Documentation/devicetree/bindings/arm/coresight.txt > > F: Documentation/devicetree/bindings/arm/ete.yaml > > Otherwise looks good to me. > > Suzuki
WARNING: multiple messages have this Message-ID (diff)
From: Rob Herring <robh@kernel.org> To: Suzuki K Poulose <suzuki.poulose@arm.com>, Mao Jinlong <quic_jinlmao@quicinc.com> Cc: Mathieu Poirier <mathieu.poirier@linaro.org>, Alexander Shishkin <alexander.shishkin@linux.intel.com>, Konrad Dybcio <konradybcio@gmail.com>, Mike Leach <mike.leach@linaro.org>, Leo Yan <leo.yan@linaro.org>, Greg Kroah-Hartman <gregkh@linuxfoundation.org>, Coresight ML <coresight@lists.linaro.org>, linux-arm-kernel <linux-arm-kernel@lists.infradead.org>, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>, Tingwei Zhang <quic_tingweiz@quicinc.com>, Yuanfang Zhang <quic_yuanfang@quicinc.com>, Tao Zhang <quic_taozha@quicinc.com>, Trilok Soni <quic_tsoni@quicinc.com>, Hao Zhang <quic_hazha@quicinc.com>, linux-arm-msm <linux-arm-msm@vger.kernel.org>, Bjorn Andersson <bjorn.andersson@linaro.org> Subject: Re: [PATCH v7 08/10] dt-bindings: arm: Adds CoreSight TPDA hardware definitions Date: Mon, 23 May 2022 09:24:57 -0500 [thread overview] Message-ID: <CAL_JsqK8Z_J2xaOsBM-U4hhHPgQCudd=SGmPqwdipArWmTXJYw@mail.gmail.com> (raw) In-Reply-To: <beba5968-3115-3c09-cda6-67095ca55226@arm.com> On Mon, May 23, 2022 at 4:44 AM Suzuki K Poulose <suzuki.poulose@arm.com> wrote: > > Cc: Rob Herring > Will or will not have any effect... Please use get_maintainers.pl and send your patches to the right lists/maintainers. DT patches only get reviewed if sent to DT list. So please resend to the DT list. But before you do, I can tell this binding hasn't been tested so fix all the warnings first. Rob > > > On 09/05/2022 14:39, Mao Jinlong wrote: > > Adds new coresight-tpda.yaml file describing the bindings required > > to define tpda in the device trees. > > > > Reviewed-by: Mike Leach <mike.leach@linaro.org> > > Signed-off-by: Tao Zhang <quic_taozha@quicinc.com> > > Signed-off-by: Mao Jinlong <quic_jinlmao@quicinc.com> > > --- > > .../bindings/arm/coresight-tpda.yaml | 119 ++++++++++++++++++ > > MAINTAINERS | 1 + > > 2 files changed, 120 insertions(+) > > create mode 100644 Documentation/devicetree/bindings/arm/coresight-tpda.yaml > > > > diff --git a/Documentation/devicetree/bindings/arm/coresight-tpda.yaml b/Documentation/devicetree/bindings/arm/coresight-tpda.yaml > > new file mode 100644 > > index 000000000000..4948ac13e7f8 > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/arm/coresight-tpda.yaml > > @@ -0,0 +1,119 @@ > > +# SPDX-License-Identifier: GPL-2.0-only or BSD-2-Clause > > +# Copyright (c) 2022 Qualcomm Innovation Center, Inc. All rights reserved. > > +%YAML 1.2 > > +--- > > +$id: http://devicetree.org/schemas/arm/coresight-tpda.yaml# > > +$schema: http://devicetree.org/meta-schemas/core.yaml# > > + > > +title: Trace, Profiling and Diagnostics Aggregator - TPDA > > + > > +description: | > > + TPDAs are responsible for packetization and timestamping of data sets > > + utilizing the MIPI STPv2 packet protocol. Pulling data sets from one or > > + more attached TPDM and pushing the resultant (packetized) data out a > > + master ATB interface. Performing an arbitrated ATB interleaving (funneling) > > + task for free-flowing data from TPDM (i.e. CMB and DSB data set flows). > > + > > +maintainers: > > + - Mao Jinlong <quic_jinlmao@quicinc.com> > > + - Tao Zhang <quic_taozha@quicinc.com> > > + > > +properties: > > + $nodename: > > + pattern: "^tpda(@[0-9a-f]+)$" > > + compatible: > > + items: > > + - const: qcom,coresight-tpda > > + - const: arm,primecell > > + > > + reg: > > + maxItems: 1 > > + > > + clocks: > > + maxItems: 1 > > + > > + clock-names: > > + items: > > + - const: apb_pclk > > + > > + in-ports: > > + type: object > > + description: | > > + Input connections from TPDM to TPDA > > + $ref: /schemas/graph.yaml#/properties/ports > > + > > --->8--- > > + properties: > > + '#address-cells': > > + const: 1 > > + > > + '#size-cells': > > + const: 0 > > + > > + patternProperties: > > + "^port@[0-9a-f]+$": > > + type: object > > + required: > > + - reg > > + > > + required: > > + - '#size-cells' > > + - '#address-cells' > > ---8<--- > > I believe the above snippet is not needed and is covered by the generic > ports. > > > > + > > + out-ports: > > + type: object > > + description: | > > + Output connections from the TPDA to legacy CoreSight trace bus. > > + $ref: /schemas/graph.yaml#/properties/ports > > + > > + properties: > > + port: > > + description: > > + Output connection from the TPDA to legacy CoreSight Trace bus. > > + $ref: /schemas/graph.yaml#/properties/port > > + > > +required: > > + - compatible > > + - reg > > + - clocks > > + - clock-names > > + - in-ports > > + - out-ports > > + > > +additionalProperties: false > > + > > +examples: > > + # minimum tpda definition. > > + - | > > + tpda@6004000 { > > + compatible = "qcom,coresight-tpda", "arm,primecell"; > > + reg = <0x6004000 0x1000>; > > + > > + qcom,tpda-atid = <65>; > > + > > + clocks = <&aoss_qmp>; > > + clock-names = "apb_pclk"; > > + > > + in-ports { > > + #address-cells = <1>; > > + #size-cells = <0>; > > + > > + port@0 { > > + reg = <0>; > > + tpda_qdss_0_in_tpdm_dcc: endpoint { > > + remote-endpoint = > > + <&tpdm_dcc_out_tpda_qdss_0>; > > + }; > > + }; > > + }; > > + > > + out-ports { > > + port { > > + tpda_qdss_out_funnel_in0: endpoint { > > + remote-endpoint = > > + <&funnel_in0_in_tpda_qdss>; > > + }; > > + }; > > + }; > > + }; > > + > > +... > > diff --git a/MAINTAINERS b/MAINTAINERS > > index 28d32b3f3f5c..5d2d8c0ee340 100644 > > --- a/MAINTAINERS > > +++ b/MAINTAINERS > > @@ -1978,6 +1978,7 @@ T: git git://git.kernel.org/pub/scm/linux/kernel/git/coresight/linux.git > > F: Documentation/ABI/testing/sysfs-bus-coresight-devices-* > > F: Documentation/devicetree/bindings/arm/coresight-cpu-debug.txt > > F: Documentation/devicetree/bindings/arm/coresight-cti.yaml > > +F: Documentation/devicetree/bindings/arm/coresight-tpda.yaml > > F: Documentation/devicetree/bindings/arm/coresight-tpdm.yaml > > F: Documentation/devicetree/bindings/arm/coresight.txt > > F: Documentation/devicetree/bindings/arm/ete.yaml > > Otherwise looks good to me. > > Suzuki _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-05-23 14:25 UTC|newest] Thread overview: 58+ messages / expand[flat|nested] mbox.gz Atom feed top 2022-05-09 13:39 [PATCH v7 00/10] Coresight: Add support for TPDM and TPDA Mao Jinlong 2022-05-09 13:39 ` Mao Jinlong 2022-05-09 13:39 ` [PATCH v7 01/10] coresight: core: Use IDR for non-cpu bound sources' paths Mao Jinlong 2022-05-09 13:39 ` Mao Jinlong 2022-05-09 13:39 ` [PATCH v7 02/10] Coresight: Add coresight TPDM source driver Mao Jinlong 2022-05-09 13:39 ` Mao Jinlong 2022-05-23 8:57 ` Suzuki K Poulose 2022-05-23 8:57 ` Suzuki K Poulose 2022-05-24 7:00 ` Jinlong Mao 2022-05-24 7:00 ` Jinlong Mao 2022-06-01 9:21 ` Jinlong Mao 2022-06-01 9:21 ` Jinlong Mao 2022-06-01 9:30 ` Suzuki K Poulose 2022-06-01 9:30 ` Suzuki K Poulose 2022-06-01 9:56 ` Jinlong Mao 2022-06-01 9:56 ` Jinlong Mao 2022-06-02 3:14 ` Jinlong Mao 2022-06-02 3:14 ` Jinlong Mao 2022-05-09 13:39 ` [PATCH v7 03/10] dt-bindings: arm: Adds CoreSight TPDM hardware definitions Mao Jinlong 2022-05-09 13:39 ` Mao Jinlong 2022-05-23 9:02 ` Suzuki K Poulose 2022-05-23 9:02 ` Suzuki K Poulose 2022-05-09 13:39 ` [PATCH v7 04/10] coresight-tpdm: Add DSB dataset support Mao Jinlong 2022-05-09 13:39 ` Mao Jinlong 2022-05-23 9:11 ` Suzuki K Poulose 2022-05-23 9:11 ` Suzuki K Poulose 2022-05-23 9:24 ` Suzuki K Poulose 2022-05-23 9:24 ` Suzuki K Poulose 2022-05-24 7:15 ` Jinlong Mao 2022-05-24 7:15 ` Jinlong Mao 2022-05-24 7:07 ` Jinlong Mao 2022-05-24 7:07 ` Jinlong Mao 2022-05-09 13:39 ` [PATCH v7 05/10] coresight-tpdm: Add integration test support Mao Jinlong 2022-05-09 13:39 ` Mao Jinlong 2022-05-23 9:17 ` Suzuki K Poulose 2022-05-23 9:17 ` Suzuki K Poulose 2022-05-24 7:14 ` Jinlong Mao 2022-05-24 7:14 ` Jinlong Mao 2022-05-09 13:39 ` [PATCH v7 06/10] docs: sysfs: coresight: Add sysfs ABI documentation for TPDM Mao Jinlong 2022-05-09 13:39 ` Mao Jinlong 2022-05-09 13:39 ` [PATCH v7 07/10] Coresight: Add TPDA link driver Mao Jinlong 2022-05-09 13:39 ` Mao Jinlong 2022-05-23 9:40 ` Suzuki K Poulose 2022-05-23 9:40 ` Suzuki K Poulose 2022-05-24 7:32 ` Jinlong Mao 2022-05-24 7:32 ` Jinlong Mao 2022-05-09 13:39 ` [PATCH v7 08/10] dt-bindings: arm: Adds CoreSight TPDA hardware definitions Mao Jinlong 2022-05-09 13:39 ` Mao Jinlong 2022-05-23 9:44 ` Suzuki K Poulose 2022-05-23 9:44 ` Suzuki K Poulose 2022-05-23 14:24 ` Rob Herring [this message] 2022-05-23 14:24 ` Rob Herring 2022-05-24 7:34 ` Jinlong Mao 2022-05-24 7:34 ` Jinlong Mao 2022-05-09 13:39 ` [PATCH v7 09/10] arm64: dts: qcom: sm8250: Add coresight components Mao Jinlong 2022-05-09 13:39 ` Mao Jinlong 2022-05-09 13:39 ` [PATCH v7 10/10] arm64: dts: qcom: sm8250: Add tpdm mm/prng Mao Jinlong 2022-05-09 13:39 ` Mao Jinlong
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to='CAL_JsqK8Z_J2xaOsBM-U4hhHPgQCudd=SGmPqwdipArWmTXJYw@mail.gmail.com' \ --to=robh@kernel.org \ --cc=alexander.shishkin@linux.intel.com \ --cc=bjorn.andersson@linaro.org \ --cc=coresight@lists.linaro.org \ --cc=gregkh@linuxfoundation.org \ --cc=konradybcio@gmail.com \ --cc=leo.yan@linaro.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-arm-msm@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=mathieu.poirier@linaro.org \ --cc=mike.leach@linaro.org \ --cc=quic_hazha@quicinc.com \ --cc=quic_jinlmao@quicinc.com \ --cc=quic_taozha@quicinc.com \ --cc=quic_tingweiz@quicinc.com \ --cc=quic_tsoni@quicinc.com \ --cc=quic_yuanfang@quicinc.com \ --cc=suzuki.poulose@arm.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.