All of lore.kernel.org
 help / color / mirror / Atom feed
From: Minkyu Kang <promsoft@gmail.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 03/10 V6] Exynos5420: Add clock initialization for 5420
Date: Wed, 13 Nov 2013 11:45:34 +0900	[thread overview]
Message-ID: <CALrBrZ1OQjes=Z4UCTVfycu_F3fKWnNcjZFYk43BOhjU8OsHRQ@mail.gmail.com> (raw)
In-Reply-To: <1383031393-6093-4-git-send-email-rajeshwari.s@samsung.com>

Dear Rajeshwari S Shinde,


On 29 October 2013 16:23, Rajeshwari S Shinde <rajeshwari.s@samsung.com>wrote:

> This patch adds code for clock initialization and clock settings
> of various IP's and controllers, required for Exynos5420
>
> Signed-off-by: Rajeshwari S Shinde <rajeshwari.s@samsung.com>
> Signed-off-by: Akshay Saraswat <akshay.s@samsung.com>
> Acked-by: Simon Glass <sjg@chromium.org>
> ---
> Changes in V2:
>         - None
> Changes in V3:
>         - None
> Changes in V4:
>         - Corrected the multiline commenting style
> Changes in V5:
>         - None
> Changes in V6:
>         - None
>  arch/arm/cpu/armv7/exynos/clock.c              | 270 ++++++++-
>  arch/arm/cpu/armv7/exynos/clock_init.h         |  17 +
>  arch/arm/cpu/armv7/exynos/clock_init_exynos5.c | 352 +++++++++++-
>  arch/arm/cpu/armv7/exynos/exynos5_setup.h      | 740
> +++++++++++++++++++------
>  arch/arm/include/asm/arch-exynos/clk.h         |   1 +
>  arch/arm/include/asm/arch-exynos/clock.h       | 494 +++++++++++++++++
>  6 files changed, 1673 insertions(+), 201 deletions(-)
>
> diff --git a/arch/arm/cpu/armv7/exynos/clock.c
> b/arch/arm/cpu/armv7/exynos/clock.c
> index 36fedd6..b52e61a 100644
> --- a/arch/arm/cpu/armv7/exynos/clock.c
> +++ b/arch/arm/cpu/armv7/exynos/clock.c
> @@ -96,7 +96,7 @@ static int exynos_get_pll_clk(int pllreg, unsigned int
> r, unsigned int k)
>
>         freq = CONFIG_SYS_CLK_FREQ;
>
> -       if (pllreg == EPLL) {
> +       if (pllreg == EPLL || pllreg == RPLL) {
>                 k = k & 0xffff;
>                 /* FOUT = (MDIV + K / 65536) * FIN / (PDIV * 2^SDIV) */
>                 fout = (m + k / PLL_DIV_65536) * (freq / (p * (1 << s)));
> @@ -117,7 +117,7 @@ static int exynos_get_pll_clk(int pllreg, unsigned int
> r, unsigned int k)
>                         div = PLL_DIV_1024;
>                 else if (proid_is_exynos4412())
>                         div = PLL_DIV_65535;
> -               else if (proid_is_exynos5250())
> +               else if (cpu_is_exynos5())
>

please don't mix proid_is... and cpu_is...


>                         div = PLL_DIV_65536;
>                 else
>                         return 0;
> @@ -362,6 +362,43 @@ unsigned long clock_get_periph_rate(int peripheral)
>                 return 0;
>  }
>
> +/* exynos5420: return pll clock frequency */
> +static unsigned long exynos5420_get_pll_clk(int pllreg)
> +{
> +       struct exynos5420_clock *clk =
> +               (struct exynos5420_clock *)samsung_get_base_clock();
> +       unsigned long r, k = 0;
> +
> +       switch (pllreg) {
> +       case APLL:
> +               r = readl(&clk->apll_con0);
> +               break;
> +       case MPLL:
> +               r = readl(&clk->mpll_con0);
> +               break;
> +       case EPLL:
> +               r = readl(&clk->epll_con0);
> +               k = readl(&clk->epll_con1);
> +               break;
> +       case VPLL:
> +               r = readl(&clk->vpll_con0);
> +               k = readl(&clk->vpll_con1);
> +               break;
> +       case BPLL:
> +               r = readl(&clk->bpll_con0);
> +               break;
> +       case RPLL:
> +               r = readl(&clk->rpll_con0);
> +               k = readl(&clk->rpll_con1);
> +               break;
> +       default:
> +               printf("Unsupported PLL (%d)\n", pllreg);
> +               return 0;
> +       }
> +
> +       return exynos_get_pll_clk(pllreg, r, k);
> +}
> +
>  /* exynos4: return ARM clock frequency */
>  static unsigned long exynos4_get_arm_clk(void)
>  {
> @@ -485,6 +522,27 @@ static unsigned long exynos4x12_get_pwm_clk(void)
>         return pclk;
>  }
>
> +/* exynos5420: return pwm clock frequency */
> +static unsigned long exynos5420_get_pwm_clk(void)
> +{
> +       struct exynos5420_clock *clk =
> +               (struct exynos5420_clock *)samsung_get_base_clock();
> +       unsigned long pclk, sclk;
> +       unsigned int ratio;
> +
> +       /*
> +        * CLK_DIV_PERIC3
> +        * PWM_RATIO [3:0]
> +        */
> +       ratio = readl(&clk->div_peric0);
> +       ratio = (ratio >> 28) & 0xf;
> +       sclk = get_pll_clk(MPLL);
> +
> +       pclk = sclk / (ratio + 1);
> +
> +       return pclk;
> +}
> +
>  /* exynos4: return uart clock frequency */
>  static unsigned long exynos4_get_uart_clk(int dev_index)
>  {
> @@ -624,6 +682,53 @@ static unsigned long exynos5_get_uart_clk(int
> dev_index)
>         return uclk;
>  }
>
> +/* exynos5420: return uart clock frequency */
> +static unsigned long exynos5420_get_uart_clk(int dev_index)
> +{
> +       struct exynos5420_clock *clk =
> +               (struct exynos5420_clock *)samsung_get_base_clock();
> +       unsigned long uclk, sclk;
> +       unsigned int sel;
> +       unsigned int ratio;
> +
> +       /*
> +        * CLK_SRC_PERIC0
> +        * UART0_SEL [3:0]
> +        * UART1_SEL [7:4]
> +        * UART2_SEL [8:11]
> +        * UART3_SEL [12:15]
> +        * UART4_SEL [16:19]
> +        * UART5_SEL [23:20]
> +        */
> +       sel = readl(&clk->src_peric0);
> +       sel = (sel >> ((dev_index * 4) + 4)) & 0x7;
> +
> +       if (sel == 0x3)
> +               sclk = get_pll_clk(MPLL);
> +       else if (sel == 0x6)
> +               sclk = get_pll_clk(EPLL);
> +       else if (sel == 0x7)
> +               sclk = get_pll_clk(RPLL);
> +       else
> +               return 0;
> +
> +       /*
> +        * CLK_DIV_PERIC0
> +        * UART0_RATIO [3:0]
> +        * UART1_RATIO [7:4]
> +        * UART2_RATIO [8:11]
> +        * UART3_RATIO [12:15]
> +        * UART4_RATIO [16:19]
> +        * UART5_RATIO [23:20]
> +        */
> +       ratio = readl(&clk->div_peric0);
> +       ratio = (ratio >> ((dev_index * 4) + 8)) & 0xf;
> +
> +       uclk = sclk / (ratio + 1);
> +
> +       return uclk;
> +}
> +
>  static unsigned long exynos4_get_mmc_clk(int dev_index)
>  {
>         struct exynos4_clock *clk =
> @@ -718,6 +823,34 @@ static unsigned long exynos5_get_mmc_clk(int
> dev_index)
>         return uclk;
>  }
>
> +static unsigned long exynos5420_get_mmc_clk(int dev_index)
> +{
> +       struct exynos5420_clock *clk =
> +               (struct exynos5420_clock *)samsung_get_base_clock();
> +       unsigned long uclk, sclk;
> +       unsigned int sel, ratio;
> +       int shift = 0;
> +
> +       sel = readl(&clk->src_fsys);
> +       sel = (sel >> ((dev_index * 4) + 8)) & 0x7;
> +
> +       if (sel == 0x3)
> +               sclk = get_pll_clk(MPLL);
> +       else if (sel == 0x6)
> +               sclk = get_pll_clk(EPLL);
> +       else
> +               return 0;
> +
> +       ratio = readl(&clk->div_fsys1);
> +
> +       shift = dev_index * 10;
> +
> +       ratio = (ratio >> shift) & 0x3ff;
> +       uclk = (sclk / (ratio + 1));
> +
> +       return uclk;
> +}
> +
>  /* exynos4: set the mmc clock */
>  static void exynos4_set_mmc_clk(int dev_index, unsigned int div)
>  {
> @@ -804,6 +937,23 @@ static void exynos5_set_mmc_clk(int dev_index,
> unsigned int div)
>         writel(val, addr);
>  }
>
> +/* exynos5: set the mmc clock */
> +static void exynos5420_set_mmc_clk(int dev_index, unsigned int div)
> +{
> +       struct exynos5420_clock *clk =
> +               (struct exynos5420_clock *)samsung_get_base_clock();
> +       unsigned int addr;
> +       unsigned int val, shift;
> +
> +       addr = (unsigned int)&clk->div_fsys1;
> +       shift = dev_index * 10;
> +
> +       val = readl(addr);
> +       val &= ~(0x3ff << shift);
> +       val |= (div & 0x3ff) << shift;
> +       writel(val, addr);
> +}
> +
>  /* get_lcd_clk: return lcd clock frequency */
>  static unsigned long exynos4_get_lcd_clk(void)
>  {
> @@ -1324,6 +1474,84 @@ static int exynos5_set_spi_clk(enum periph_id
> periph_id,
>         return 0;
>  }
>
> +static int exynos5420_set_spi_clk(enum periph_id periph_id,
> +                                       unsigned int rate)
> +{
> +       struct exynos5420_clock *clk =
> +               (struct exynos5420_clock *)samsung_get_base_clock();
> +       int main;
> +       unsigned int fine, val;
> +       unsigned shift, pre_shift;
> +       unsigned div_mask = 0xf, pre_div_mask = 0xff;
> +
> +       main = clock_calc_best_scalar(4, 8, 400000000, rate, &fine);
> +       if (main < 0) {
> +               debug("%s: Cannot set clock rate for periph %d",
> +                     __func__, periph_id);
> +               return -1;
> +       }
> +       main = main - 1;
> +       fine = fine - 1;
> +
> +       switch (periph_id) {
> +       case PERIPH_ID_SPI0:
> +               val = readl(&clk->div_peric1);
> +               val &= ~(div_mask << 20);
> +               val |= (main << 20);
> +               writel(val, &clk->div_peric1);
> +
> +               val = readl(&clk->div_peric4);
> +               val &= ~(pre_div_mask << 8);
> +               val |= (fine << 8);
> +               writel(val, &clk->div_peric4);
> +               break;
> +       case PERIPH_ID_SPI1:
> +               val = readl(&clk->div_peric1);
> +               val &= ~(div_mask << 24);
> +               val |= (main << 24);
> +               writel(val, &clk->div_peric1);
> +
> +               val = readl(&clk->div_peric4);
> +               val &= ~(pre_div_mask << 16);
> +               val |= (fine << 16);
> +               writel(val, &clk->div_peric4);
> +               break;
> +       case PERIPH_ID_SPI2:
> +               val = readl(&clk->div_peric1);
> +               val &= ~(div_mask << 28);
> +               val |= (main << 28);
> +               writel(val, &clk->div_peric1);
> +
> +               val = readl(&clk->div_peric4);
> +               val &= ~(pre_div_mask << 24);
> +               val |= (fine << 24);
> +               writel(val, &clk->div_peric4);
> +               break;
>

I think we can use same code for SPI0/1/2.


> +       case PERIPH_ID_SPI3:
> +               shift = 16;
> +               pre_shift = 0;
> +               clrsetbits_le32(&clk->div_isp1, div_mask << shift,
> +                               (main & div_mask) << shift);
> +               clrsetbits_le32(&clk->div_isp1, pre_div_mask << pre_shift,
> +                               (fine & pre_div_mask) << pre_shift);
> +               break;
> +       case PERIPH_ID_SPI4:
> +               shift = 20;
> +               pre_shift = 8;
> +               clrsetbits_le32(&clk->div_isp1, div_mask << shift,
> +                               (main & div_mask) << shift);
> +               clrsetbits_le32(&clk->div_isp1, pre_div_mask << pre_shift,
> +                               (fine & pre_div_mask) << pre_shift);
> +               break;
> +       default:
> +               debug("%s: Unsupported peripheral ID %d\n", __func__,
> +                     periph_id);
> +               return -1;
> +       }
> +
> +       return 0;
> +}
> +
>  static unsigned long exynos4_get_i2c_clk(void)
>  {
>         struct exynos4_clock *clk =
> @@ -1341,9 +1569,11 @@ static unsigned long exynos4_get_i2c_clk(void)
>
>  unsigned long get_pll_clk(int pllreg)
>  {
> -       if (cpu_is_exynos5())
> +       if (cpu_is_exynos5()) {
> +               if (proid_is_exynos5420())
> +                       return exynos5420_get_pll_clk(pllreg);
>                 return exynos5_get_pll_clk(pllreg);
> -       else {
> +       } else {
>                 if (proid_is_exynos4412())
>                         return exynos4x12_get_pll_clk(pllreg);
>                 return exynos4_get_pll_clk(pllreg);
> @@ -1375,9 +1605,11 @@ unsigned long get_i2c_clk(void)
>
>  unsigned long get_pwm_clk(void)
>  {
> -       if (cpu_is_exynos5())
> +       if (cpu_is_exynos5()) {
> +               if (proid_is_exynos5420())
> +                       return exynos5420_get_pwm_clk();
>                 return clock_get_periph_rate(PERIPH_ID_PWM0);
> -       else {
> +       } else {
>                 if (proid_is_exynos4412())
>                         return exynos4x12_get_pwm_clk();
>                 return exynos4_get_pwm_clk();
> @@ -1386,9 +1618,11 @@ unsigned long get_pwm_clk(void)
>
>  unsigned long get_uart_clk(int dev_index)
>  {
> -       if (cpu_is_exynos5())
> +       if (cpu_is_exynos5()) {
> +               if (proid_is_exynos5420())
> +                       return exynos5420_get_uart_clk(dev_index);
>                 return exynos5_get_uart_clk(dev_index);
> -       else {
> +       } else {
>                 if (proid_is_exynos4412())
>                         return exynos4x12_get_uart_clk(dev_index);
>                 return exynos4_get_uart_clk(dev_index);
> @@ -1397,17 +1631,22 @@ unsigned long get_uart_clk(int dev_index)
>
>  unsigned long get_mmc_clk(int dev_index)
>  {
> -       if (cpu_is_exynos5())
> +       if (cpu_is_exynos5()) {
> +               if (proid_is_exynos5420())
> +                       return exynos5420_get_mmc_clk(dev_index);
>                 return exynos5_get_mmc_clk(dev_index);
> -       else
> +       } else {
>                 return exynos4_get_mmc_clk(dev_index);
> +       }
>  }
>
>  void set_mmc_clk(int dev_index, unsigned int div)
>  {
> -       if (cpu_is_exynos5())
> +       if (cpu_is_exynos5()) {
> +               if (proid_is_exynos5420())
> +                       return exynos5420_set_mmc_clk(dev_index, div);
>                 exynos5_set_mmc_clk(dev_index, div);
> -       else {
> +       } else {
>                 if (proid_is_exynos4412())
>                         exynos4x12_set_mmc_clk(dev_index, div);
>                 exynos4_set_mmc_clk(dev_index, div);
> @@ -1438,10 +1677,13 @@ void set_mipi_clk(void)
>
>  int set_spi_clk(int periph_id, unsigned int rate)
>  {
> -       if (cpu_is_exynos5())
> +       if (cpu_is_exynos5()) {
> +               if (proid_is_exynos5420())
> +                       return exynos5420_set_spi_clk(periph_id, rate);
>                 return exynos5_set_spi_clk(periph_id, rate);
> -       else
> +       } else {
>                 return 0;
> +       }
>  }
>
>  int set_i2s_clk_prescaler(unsigned int src_frq, unsigned int dst_frq,
> diff --git a/arch/arm/cpu/armv7/exynos/clock_init.h
> b/arch/arm/cpu/armv7/exynos/clock_init.h
> index c28ff3a..a875d0b 100644
> --- a/arch/arm/cpu/armv7/exynos/clock_init.h
> +++ b/arch/arm/cpu/armv7/exynos/clock_init.h
> @@ -10,7 +10,11 @@
>  #define __EXYNOS_CLOCK_INIT_H
>
>  enum {
> +#ifdef CONFIG_EXYNOS5420
> +       MEM_TIMINGS_MSR_COUNT   = 5,
> +#else
>         MEM_TIMINGS_MSR_COUNT   = 4,
> +#endif
>  };
>
>  /* These are the ratio's for configuring ARM clock */
> @@ -59,6 +63,18 @@ struct mem_timings {
>         unsigned bpll_mdiv;
>         unsigned bpll_pdiv;
>         unsigned bpll_sdiv;
> +       unsigned kpll_mdiv;
> +       unsigned kpll_pdiv;
> +       unsigned kpll_sdiv;
> +       unsigned dpll_mdiv;
> +       unsigned dpll_pdiv;
> +       unsigned dpll_sdiv;
> +       unsigned ipll_mdiv;
> +       unsigned ipll_pdiv;
> +       unsigned ipll_sdiv;
> +       unsigned spll_mdiv;
> +       unsigned spll_pdiv;
> +       unsigned spll_sdiv;
>         unsigned pclk_cdrex_ratio;
>         unsigned direct_cmd_msr[MEM_TIMINGS_MSR_COUNT];
>
> @@ -115,6 +131,7 @@ struct mem_timings {
>         uint8_t send_zq_init;           /* 1 to send this command */
>         unsigned impedance;             /* drive strength impedeance */
>         uint8_t gate_leveling_enable;   /* check gate leveling is enabled
> */
> +       uint8_t read_leveling_enable;   /* check h/w read leveling is
> enabled */
>  };
>
>  /**
> diff --git a/arch/arm/cpu/armv7/exynos/clock_init_exynos5.c
> b/arch/arm/cpu/armv7/exynos/clock_init_exynos5.c
> index a24c2f3..e7f1496 100644
> --- a/arch/arm/cpu/armv7/exynos/clock_init_exynos5.c
> +++ b/arch/arm/cpu/armv7/exynos/clock_init_exynos5.c
> @@ -24,6 +24,24 @@
>  DECLARE_GLOBAL_DATA_PTR;
>
>  struct arm_clk_ratios arm_clk_ratios[] = {
> +#ifdef CONFIG_EXYNOS5420
> +       {
> +               .arm_freq_mhz = 900,
> +
> +               .apll_mdiv = 0x96,
> +               .apll_pdiv = 0x2,
> +               .apll_sdiv = 0x1,
> +
> +               .arm2_ratio = 0x0,
> +               .apll_ratio = 0x3,
> +               .pclk_dbg_ratio = 0x6,
> +               .atb_ratio = 0x6,
> +               .periph_ratio = 0x7,
> +               .acp_ratio = 0x0,
> +               .cpud_ratio = 0x2,
> +               .arm_ratio = 0x0,
> +       }
> +#else
>         {
>                 .arm_freq_mhz = 600,
>
> @@ -115,8 +133,133 @@ struct arm_clk_ratios arm_clk_ratios[] = {
>                 .cpud_ratio = 0x3,
>                 .arm_ratio = 0x0,
>         }
> +#endif
>  };
> +
>  struct mem_timings mem_timings[] = {
> +#ifdef CONFIG_EXYNOS5420
> +       {
> +               .mem_manuf = MEM_MANUF_SAMSUNG,
> +               .mem_type = DDR_MODE_DDR3,
> +               .frequency_mhz = 800,
> +
> +               /* MPLL @800MHz*/
> +               .mpll_mdiv = 0xc8,
> +               .mpll_pdiv = 0x3,
> +               .mpll_sdiv = 0x1,
> +               /* CPLL @666MHz */
> +               .cpll_mdiv = 0xde,
> +               .cpll_pdiv = 0x4,
> +               .cpll_sdiv = 0x1,
> +               /* EPLL @600MHz */
> +               .epll_mdiv = 0x64,
> +               .epll_pdiv = 0x2,
> +               .epll_sdiv = 0x1,
> +               /* VPLL @430MHz */
> +               .vpll_mdiv = 0xd7,
> +               .vpll_pdiv = 0x3,
> +               .vpll_sdiv = 0x2,
> +               /* BPLL @800MHz */
> +               .bpll_mdiv = 0xc8,
> +               .bpll_pdiv = 0x3,
> +               .bpll_sdiv = 0x1,
> +               /* KPLL @600MHz */
> +               .kpll_mdiv = 0x190,
> +               .kpll_pdiv = 0x4,
> +               .kpll_sdiv = 0x2,
> +               /* DPLL @600MHz */
> +               .dpll_mdiv = 0x190,
> +               .dpll_pdiv = 0x4,
> +               .dpll_sdiv = 0x2,
> +               /* IPLL @370MHz */
> +               .ipll_mdiv = 0xb9,
> +               .ipll_pdiv = 0x3,
> +               .ipll_sdiv = 0x2,
> +               /* SPLL @400MHz */
> +               .spll_mdiv = 0xc8,
> +               .spll_pdiv = 0x3,
> +               .spll_sdiv = 0x2,
> +
> +               .direct_cmd_msr = {
> +                       0x00020018, 0x00030000, 0x00010046, 0x00000d70,
> +                       0x00000c70
> +               },
> +               .timing_ref = 0x000000bb,
> +               .timing_row = 0x6836650f,
> +               .timing_data = 0x3630580b,
> +               .timing_power = 0x41000a26,
> +               .phy0_dqs = 0x08080808,
> +               .phy1_dqs = 0x08080808,
> +               .phy0_dq = 0x08080808,
> +               .phy1_dq = 0x08080808,
> +               .phy0_tFS = 0x8,
> +               .phy1_tFS = 0x8,
> +               .phy0_pulld_dqs = 0xf,
> +               .phy1_pulld_dqs = 0xf,
> +
> +               .lpddr3_ctrl_phy_reset = 0x1,
> +               .ctrl_start_point = 0x10,
> +               .ctrl_inc = 0x10,
> +               .ctrl_start = 0x1,
> +               .ctrl_dll_on = 0x1,
> +               .ctrl_ref = 0x8,
> +
> +               .ctrl_force = 0x1a,
> +               .ctrl_rdlat = 0x0b,
> +               .ctrl_bstlen = 0x08,
> +
> +               .fp_resync = 0x8,
> +               .iv_size = 0x7,
> +               .dfi_init_start = 1,
> +               .aref_en = 1,
> +
> +               .rd_fetch = 0x3,
> +
> +               .zq_mode_dds = 0x7,
> +               .zq_mode_term = 0x1,
> +               .zq_mode_noterm = 1,
> +
> +               /*
> +               * Dynamic Clock: Always Running
> +               * Memory Burst length: 8
> +               * Number of chips: 1
> +               * Memory Bus width: 32 bit
> +               * Memory Type: DDR3
> +               * Additional Latancy for PLL: 0 Cycle
> +               */
> +               .memcontrol = DMC_MEMCONTROL_CLK_STOP_DISABLE |
> +                       DMC_MEMCONTROL_DPWRDN_DISABLE |
> +                       DMC_MEMCONTROL_DPWRDN_ACTIVE_PRECHARGE |
> +                       DMC_MEMCONTROL_TP_DISABLE |
> +                       DMC_MEMCONTROL_DSREF_DISABLE |
> +                       DMC_MEMCONTROL_ADD_LAT_PALL_CYCLE(0) |
> +                       DMC_MEMCONTROL_MEM_TYPE_DDR3 |
> +                       DMC_MEMCONTROL_MEM_WIDTH_32BIT |
> +                       DMC_MEMCONTROL_NUM_CHIP_1 |
> +                       DMC_MEMCONTROL_BL_8 |
> +                       DMC_MEMCONTROL_PZQ_DISABLE |
> +                       DMC_MEMCONTROL_MRR_BYTE_7_0,
> +               .memconfig = DMC_MEMCONFIG_CHIP_MAP_SPLIT |
> +                       DMC_MEMCONFIGX_CHIP_COL_10 |
> +                       DMC_MEMCONFIGX_CHIP_ROW_15 |
> +                       DMC_MEMCONFIGX_CHIP_BANK_8,
> +               .prechconfig_tp_cnt = 0xff,
> +               .dpwrdn_cyc = 0xff,
> +               .dsref_cyc = 0xffff,
> +               .concontrol = DMC_CONCONTROL_DFI_INIT_START_DISABLE |
> +                       DMC_CONCONTROL_TIMEOUT_LEVEL0 |
> +                       DMC_CONCONTROL_RD_FETCH_DISABLE |
> +                       DMC_CONCONTROL_EMPTY_DISABLE |
> +                       DMC_CONCONTROL_AREF_EN_DISABLE |
> +                       DMC_CONCONTROL_IO_PD_CON_DISABLE,
> +               .dmc_channels = 1,
> +               .chips_per_channel = 1,
> +               .chips_to_configure = 1,
> +               .send_zq_init = 1,
> +               .gate_leveling_enable = 1,
> +               .read_leveling_enable = 0,
> +       }
> +#else
>         {
>                 .mem_manuf = MEM_MANUF_ELPIDA,
>                 .mem_type = DDR_MODE_DDR3,
> @@ -324,6 +467,7 @@ struct mem_timings mem_timings[] = {
>                 .impedance = IMP_OUTPUT_DRV_40_OHM,
>                 .gate_leveling_enable = 1,
>         }
> +#endif
>  };
>
>  /**
> @@ -399,7 +543,7 @@ struct mem_timings *clock_get_mem_timings(void)
>         return NULL;
>  }
>
> -void system_clock_init()
> +static void exynos5250_system_clock_init(void)
>  {
>         struct exynos5_clock *clk =
>                 (struct exynos5_clock *)samsung_get_base_clock();
> @@ -436,19 +580,13 @@ void system_clock_init()
>         } while ((val | MUX_BPLL_SEL_MASK) != val);
>
>         /* PLL locktime */
> -       writel(APLL_LOCK_VAL, &clk->apll_lock);
> -
> -       writel(MPLL_LOCK_VAL, &clk->mpll_lock);
> -
> -       writel(BPLL_LOCK_VAL, &clk->bpll_lock);
> -
> -       writel(CPLL_LOCK_VAL, &clk->cpll_lock);
> -
> -       writel(GPLL_LOCK_VAL, &clk->gpll_lock);
> -
> -       writel(EPLL_LOCK_VAL, &clk->epll_lock);
> -
> -       writel(VPLL_LOCK_VAL, &clk->vpll_lock);
> +       writel(mem->apll_pdiv * PLL_LOCK_FACTOR, &clk->apll_lock);
> +       writel(mem->mpll_pdiv * PLL_LOCK_FACTOR, &clk->mpll_lock);
> +       writel(mem->bpll_pdiv * PLL_LOCK_FACTOR, &clk->bpll_lock);
> +       writel(mem->cpll_pdiv * PLL_LOCK_FACTOR, &clk->cpll_lock);
> +       writel(mem->gpll_pdiv * PLL_X_LOCK_FACTOR, &clk->gpll_lock);
> +       writel(mem->epll_pdiv * PLL_X_LOCK_FACTOR, &clk->epll_lock);
> +       writel(mem->vpll_pdiv * PLL_X_LOCK_FACTOR, &clk->vpll_lock);
>
>         writel(CLK_REG_DISABLE, &clk->pll_div2_sel);
>
> @@ -640,6 +778,192 @@ void system_clock_init()
>         writel(val, &clk->div_fsys2);
>  }
>
> +static void exynos5420_system_clock_init(void)
> +{
> +       struct exynos5420_clock *clk =
> +               (struct exynos5420_clock *)EXYNOS5_CLOCK_BASE;
> +       struct mem_timings *mem;
> +       struct arm_clk_ratios *arm_clk_ratio;
> +       u32 val;
> +
> +       mem = clock_get_mem_timings();
> +       arm_clk_ratio = get_arm_ratios();
> +
> +       /* PLL locktime */
> +       writel(arm_clk_ratio->apll_pdiv * PLL_LOCK_FACTOR,
> &clk->apll_lock);
> +       writel(mem->mpll_pdiv * PLL_LOCK_FACTOR, &clk->mpll_lock);
> +       writel(mem->bpll_pdiv * PLL_LOCK_FACTOR, &clk->bpll_lock);
> +       writel(mem->cpll_pdiv * PLL_LOCK_FACTOR, &clk->cpll_lock);
> +       writel(mem->dpll_pdiv * PLL_LOCK_FACTOR, &clk->dpll_lock);
> +       writel(mem->epll_pdiv * PLL_X_LOCK_FACTOR, &clk->epll_lock);
> +       writel(mem->vpll_pdiv * PLL_LOCK_FACTOR, &clk->vpll_lock);
> +       writel(mem->ipll_pdiv * PLL_LOCK_FACTOR, &clk->ipll_lock);
> +       writel(mem->spll_pdiv * PLL_LOCK_FACTOR, &clk->spll_lock);
> +       writel(mem->kpll_pdiv * PLL_LOCK_FACTOR, &clk->kpll_lock);
> +
> +       setbits_le32(&clk->src_cpu, MUX_HPM_SEL_MASK);
> +
> +       writel(0, &clk->src_top6);
> +
> +       writel(0, &clk->src_cdrex);
> +       writel(SRC_KFC_HPM_SEL, &clk->src_kfc);
> +       writel(HPM_RATIO,  &clk->div_cpu1);
> +       writel(CLK_DIV_CPU0_VAL,  &clk->div_cpu0);
> +
> +       /* switch A15 clock source to OSC clock before changing APLL */
> +       clrbits_le32(&clk->src_cpu, APLL_FOUT);
> +
> +       /* Set APLL */
> +       writel(APLL_CON1_VAL, &clk->apll_con1);
> +       val = set_pll(arm_clk_ratio->apll_mdiv,
> +                     arm_clk_ratio->apll_pdiv,
> +                     arm_clk_ratio->apll_sdiv);
> +       writel(val, &clk->apll_con0);
> +       while ((readl(&clk->apll_con0) & PLL_LOCKED) == 0)
> +               ;
> +
> +       /* now it is safe to switch to APLL */
> +       setbits_le32(&clk->src_cpu, APLL_FOUT);
> +
> +       writel(SRC_KFC_HPM_SEL, &clk->src_kfc);
> +       writel(CLK_DIV_KFC_VAL, &clk->div_kfc0);
> +
> +       /* switch A7 clock source to OSC clock before changing KPLL */
> +       clrbits_le32(&clk->src_kfc, KPLL_FOUT);
> +
> +       /* Set KPLL*/
> +       writel(KPLL_CON1_VAL, &clk->kpll_con1);
> +       val = set_pll(mem->kpll_mdiv, mem->kpll_pdiv, mem->kpll_sdiv);
> +       writel(val, &clk->kpll_con0);
> +       while ((readl(&clk->kpll_con0) & PLL_LOCKED) == 0)
> +               ;
> +
> +       /* now it is safe to switch to KPLL */
> +       setbits_le32(&clk->src_kfc, KPLL_FOUT);
> +
> +       /* Set MPLL */
> +       writel(MPLL_CON1_VAL, &clk->mpll_con1);
> +       val = set_pll(mem->mpll_mdiv, mem->mpll_pdiv, mem->mpll_sdiv);
> +       writel(val, &clk->mpll_con0);
> +       while ((readl(&clk->mpll_con0) & PLL_LOCKED) == 0)
> +               ;
> +
> +       /* Set DPLL */
> +       writel(DPLL_CON1_VAL, &clk->dpll_con1);
> +       val = set_pll(mem->dpll_mdiv, mem->dpll_pdiv, mem->dpll_sdiv);
> +       writel(val, &clk->dpll_con0);
> +       while ((readl(&clk->dpll_con0) & PLL_LOCKED) == 0)
> +               ;
> +
> +       /* Set EPLL */
> +       writel(EPLL_CON2_VAL, &clk->epll_con2);
> +       writel(EPLL_CON1_VAL, &clk->epll_con1);
> +       val = set_pll(mem->epll_mdiv, mem->epll_pdiv, mem->epll_sdiv);
> +       writel(val, &clk->epll_con0);
> +       while ((readl(&clk->epll_con0) & PLL_LOCKED) == 0)
> +               ;
> +
> +       /* Set CPLL */
> +       writel(CPLL_CON1_VAL, &clk->cpll_con1);
> +       val = set_pll(mem->cpll_mdiv, mem->cpll_pdiv, mem->cpll_sdiv);
> +       writel(val, &clk->cpll_con0);
> +       while ((readl(&clk->cpll_con0) & PLL_LOCKED) == 0)
> +               ;
> +
> +       /* Set IPLL */
> +       writel(IPLL_CON1_VAL, &clk->ipll_con1);
> +       val = set_pll(mem->ipll_mdiv, mem->ipll_pdiv, mem->ipll_sdiv);
> +       writel(val, &clk->ipll_con0);
> +       while ((readl(&clk->ipll_con0) & PLL_LOCKED) == 0)
> +               ;
> +
> +       /* Set VPLL */
> +       writel(VPLL_CON1_VAL, &clk->vpll_con1);
> +       val = set_pll(mem->vpll_mdiv, mem->vpll_pdiv, mem->vpll_sdiv);
> +       writel(val, &clk->vpll_con0);
> +       while ((readl(&clk->vpll_con0) & PLL_LOCKED) == 0)
> +               ;
> +
> +       /* Set BPLL */
> +       writel(BPLL_CON1_VAL, &clk->bpll_con1);
> +       val = set_pll(mem->bpll_mdiv, mem->bpll_pdiv, mem->bpll_sdiv);
> +       writel(val, &clk->bpll_con0);
> +       while ((readl(&clk->bpll_con0) & PLL_LOCKED) == 0)
> +               ;
> +
> +       /* Set SPLL */
> +       writel(SPLL_CON1_VAL, &clk->spll_con1);
> +       val = set_pll(mem->spll_mdiv, mem->spll_pdiv, mem->spll_sdiv);
> +       writel(val, &clk->spll_con0);
> +       while ((readl(&clk->spll_con0) & PLL_LOCKED) == 0)
> +               ;
> +
> +       writel(CLK_DIV_CDREX0_VAL, &clk->div_cdrex0);
> +       writel(CLK_DIV_CDREX1_VAL, &clk->div_cdrex1);
> +
> +       writel(CLK_SRC_TOP0_VAL, &clk->src_top0);
> +       writel(CLK_SRC_TOP1_VAL, &clk->src_top1);
> +       writel(CLK_SRC_TOP2_VAL, &clk->src_top2);
> +       writel(CLK_SRC_TOP7_VAL, &clk->src_top7);
> +
> +       writel(CLK_DIV_TOP0_VAL, &clk->div_top0);
> +       writel(CLK_DIV_TOP1_VAL, &clk->div_top1);
> +       writel(CLK_DIV_TOP2_VAL, &clk->div_top2);
> +
> +       writel(0, &clk->src_top10);
> +       writel(0, &clk->src_top11);
> +       writel(0, &clk->src_top12);
> +
> +       writel(CLK_SRC_TOP3_VAL, &clk->src_top3);
> +       writel(CLK_SRC_TOP4_VAL, &clk->src_top4);
> +       writel(CLK_SRC_TOP5_VAL, &clk->src_top5);
> +
> +       /* DISP1 BLK CLK SELECTION */
> +       writel(CLK_SRC_DISP1_0_VAL, &clk->src_disp10);
> +       writel(CLK_DIV_DISP1_0_VAL, &clk->div_disp10);
> +
> +       /* AUDIO BLK */
> +       writel(AUDIO0_SEL_EPLL, &clk->src_mau);
> +       writel(DIV_MAU_VAL, &clk->div_mau);
> +
> +       /* FSYS */
> +       writel(CLK_SRC_FSYS0_VAL, &clk->src_fsys);
> +       writel(CLK_DIV_FSYS0_VAL, &clk->div_fsys0);
> +       writel(CLK_DIV_FSYS1_VAL, &clk->div_fsys1);
> +       writel(CLK_DIV_FSYS2_VAL, &clk->div_fsys2);
> +
> +       writel(CLK_SRC_ISP_VAL, &clk->src_isp);
> +       writel(CLK_DIV_ISP0_VAL, &clk->div_isp0);
> +       writel(CLK_DIV_ISP1_VAL, &clk->div_isp1);
> +
> +       writel(CLK_SRC_PERIC0_VAL, &clk->src_peric0);
> +       writel(CLK_SRC_PERIC1_VAL, &clk->src_peric1);
> +
> +       writel(CLK_DIV_PERIC0_VAL, &clk->div_peric0);
> +       writel(CLK_DIV_PERIC1_VAL, &clk->div_peric1);
> +       writel(CLK_DIV_PERIC2_VAL, &clk->div_peric2);
> +       writel(CLK_DIV_PERIC3_VAL, &clk->div_peric3);
> +       writel(CLK_DIV_PERIC4_VAL, &clk->div_peric4);
> +
> +       writel(CLK_DIV_CPERI1_VAL, &clk->div_cperi1);
> +
> +       writel(CLK_DIV2_RATIO, &clk->clkdiv2_ratio);
> +       writel(CLK_DIV4_RATIO, &clk->clkdiv4_ratio);
> +       writel(CLK_DIV_G2D, &clk->div_g2d);
> +
> +       writel(CLK_SRC_TOP6_VAL, &clk->src_top6);
> +       writel(CLK_SRC_CDREX_VAL, &clk->src_cdrex);
> +       writel(CLK_SRC_KFC_VAL, &clk->src_kfc);
> +}
> +
> +void system_clock_init(void)
> +{
> +       if (proid_is_exynos5420())
> +               exynos5420_system_clock_init();
> +       else
> +               exynos5250_system_clock_init();
> +}
> +
>  void clock_init_dp_clock(void)
>  {
>         struct exynos5_clock *clk =
> diff --git a/arch/arm/cpu/armv7/exynos/exynos5_setup.h
> b/arch/arm/cpu/armv7/exynos/exynos5_setup.h
> index 696b386..8e05a00 100644
> --- a/arch/arm/cpu/armv7/exynos/exynos5_setup.h
> +++ b/arch/arm/cpu/armv7/exynos/exynos5_setup.h
> @@ -12,42 +12,16 @@
>  #include <config.h>
>  #include <asm/arch/dmc.h>
>
> -/* APLL_CON1   */
> -#define APLL_CON1_VAL  (0x00203800)
> -
> -/* MPLL_CON1   */
> -#define MPLL_CON1_VAL   (0x00203800)
> -
> -/* CPLL_CON1   */
> -#define CPLL_CON1_VAL  (0x00203800)
> -
> -/* GPLL_CON1   */
> -#define GPLL_CON1_VAL  (0x00203800)
> -
> -/* EPLL_CON1, CON2     */
> -#define EPLL_CON1_VAL  0x00000000
> -#define EPLL_CON2_VAL  0x00000080
> -
> -/* VPLL_CON1, CON2     */
> -#define VPLL_CON1_VAL  0x00000000
> -#define VPLL_CON2_VAL  0x00000080
> +#define NOT_AVAILABLE          0
> +#define DATA_MASK              0xFFFFF
>
> -/* BPLL_CON1   */
> -#define BPLL_CON1_VAL  0x00203800
> +#define ENABLE_BIT             0x1
> +#define DISABLE_BIT            0x0
> +#define CA_SWAP_EN             (1 << 0)
>
>  /* Set PLL */
>  #define set_pll(mdiv, pdiv, sdiv)      (1<<31 | mdiv<<16 | pdiv<<8 | sdiv)
>
> -/* CLK_SRC_CPU */
> -/* 0 = MOUTAPLL,  1 = SCLKMPLL */
> -#define MUX_HPM_SEL             0
> -#define MUX_CPU_SEL             0
> -#define MUX_APLL_SEL            1
> -
> -#define CLK_SRC_CPU_VAL                ((MUX_HPM_SEL << 20)    \
> -                               | (MUX_CPU_SEL << 16)  \
> -                               | (MUX_APLL_SEL))
> -
>  /* MEMCONTROL register bit fields */
>  #define DMC_MEMCONTROL_CLK_STOP_DISABLE        (0 << 0)
>  #define DMC_MEMCONTROL_DPWRDN_DISABLE  (0 << 1)
> @@ -78,6 +52,7 @@
>
>  /* MEMCONFIG0 register bit fields */
>  #define DMC_MEMCONFIGX_CHIP_MAP_INTERLEAVED     (1 << 12)
> +#define DMC_MEMCONFIG_CHIP_MAP_SPLIT           (2 << 12)
>  #define DMC_MEMCONFIGX_CHIP_COL_10              (3 << 8)
>  #define DMC_MEMCONFIGX_CHIP_ROW_14              (2 << 4)
>  #define DMC_MEMCONFIGX_CHIP_ROW_15              (3 << 4)
> @@ -90,6 +65,16 @@
>         DMC_MEMBASECONFIGX_CHIP_MASK(0x780)     \
>  )
>
> +/* As we use channel interleaving, therefore value of the base address
> + * register must be set as half of the bus base address
> + * RAM start addess is 0x2000_0000 which means chip_base is 0x20, so
> + * we need to set half 0x10 to the membaseconfigx registers
> + * see exynos5420 UM section 17.17.3.21 for more
> + */
>

please fix this multiline comment.


> +#define DMC_CHIP_BASE_0 0x10
> +#define DMC_CHIP_BASE_1 0x50
> +#define DMC_CHIP_MASK  0x7C0
> +
>  #define DMC_MEMBASECONFIG0_VAL  DMC_MEMBASECONFIG_VAL(0x40)
>  #define DMC_MEMBASECONFIG1_VAL  DMC_MEMBASECONFIG_VAL(0x80)
>
> @@ -113,29 +98,24 @@
>
>  /* COJCONTROL register bit fields */
>  #define DMC_CONCONTROL_IO_PD_CON_DISABLE       (0 << 3)
> +#define DMC_CONCONTROL_IO_PD_CON_ENABLE                (1 << 3)
>  #define DMC_CONCONTROL_AREF_EN_DISABLE         (0 << 5)
> +#define DMC_CONCONTROL_AREF_EN_ENABLE          (1 << 5)
>  #define DMC_CONCONTROL_EMPTY_DISABLE           (0 << 8)
>  #define DMC_CONCONTROL_EMPTY_ENABLE            (1 << 8)
>  #define DMC_CONCONTROL_RD_FETCH_DISABLE                (0x0 << 12)
>  #define DMC_CONCONTROL_TIMEOUT_LEVEL0          (0xFFF << 16)
>  #define DMC_CONCONTROL_DFI_INIT_START_DISABLE  (0 << 28)
>
> -/* CLK_DIV_CPU0_VAL */
> -#define CLK_DIV_CPU0_VAL       ((ARM2_RATIO << 28)             \
> -                               | (APLL_RATIO << 24)            \
> -                               | (PCLK_DBG_RATIO << 20)        \
> -                               | (ATB_RATIO << 16)             \
> -                               | (PERIPH_RATIO << 12)          \
> -                               | (ACP_RATIO << 8)              \
> -                               | (CPUD_RATIO << 4)             \
> -                               | (ARM_RATIO))
> +#define DMC_CONCONTROL_VAL     0x1FFF2101
>
> +#define DREX_CONCONTROL_VAL    DMC_CONCONTROL_VAL                      \
> +                               | DMC_CONCONTROL_AREF_EN_ENABLE         \
> +                               | DMC_CONCONTROL_IO_PD_CON_ENABLE
>
> -/* CLK_FSYS */
> -#define CLK_SRC_FSYS0_VAL              0x66666
> -#define CLK_DIV_FSYS0_VAL             0x0BB00000
> +#define DMC_CONCONTROL_IO_PD_CON(x)            (x << 6)
>
> -/* CLK_DIV_CPU1        */
> +/* CLK_DIV_CPU1 */
>  #define HPM_RATIO               0x2
>  #define COPY_RATIO              0x0
>
> @@ -164,10 +144,370 @@
>  /* CLK_DIV_SYSLFT */
>  #define CLK_DIV_SYSLFT_VAL      0x00000311
>
> +#define MUX_APLL_SEL_MASK      (1 << 0)
> +#define MUX_MPLL_SEL_MASK      (1 << 8)
> +#define MPLL_SEL_MOUT_MPLLFOUT (2 << 8)
> +#define MUX_CPLL_SEL_MASK      (1 << 8)
> +#define MUX_EPLL_SEL_MASK      (1 << 12)
> +#define MUX_VPLL_SEL_MASK      (1 << 16)
> +#define MUX_GPLL_SEL_MASK      (1 << 28)
> +#define MUX_BPLL_SEL_MASK      (1 << 0)
> +#define MUX_HPM_SEL_MASK       (1 << 20)
> +#define HPM_SEL_SCLK_MPLL      (1 << 21)
> +#define PLL_LOCKED             (1 << 29)
> +#define APLL_CON0_LOCKED       (1 << 29)
> +#define MPLL_CON0_LOCKED       (1 << 29)
> +#define BPLL_CON0_LOCKED       (1 << 29)
> +#define CPLL_CON0_LOCKED       (1 << 29)
> +#define EPLL_CON0_LOCKED       (1 << 29)
> +#define GPLL_CON0_LOCKED       (1 << 29)
> +#define VPLL_CON0_LOCKED       (1 << 29)
> +#define CLK_REG_DISABLE                0x0
> +#define TOP2_VAL               0x0110000
> +
> +/* SCLK_SRC_ISP - set SPI0/1 to 6 = SCLK_MPLL_USER */
> +#define SPI0_ISP_SEL           6
> +#define SPI1_ISP_SEL           6
> +#define SCLK_SRC_ISP_VAL       (SPI1_ISP_SEL << 4) \
> +                               | (SPI0_ISP_SEL << 0)
> +
> +/* SCLK_DIV_ISP - set SPI0/1 to 0xf = divide by 16 */
> +#define SPI0_ISP_RATIO         0xf
> +#define SPI1_ISP_RATIO         0xf
> +#define SCLK_DIV_ISP_VAL       (SPI1_ISP_RATIO << 12) \
> +                               | (SPI0_ISP_RATIO << 0)
> +
> +/* CLK_DIV_FSYS2 */
> +#define MMC2_RATIO_MASK                0xf
> +#define MMC2_RATIO_VAL         0x3
> +#define MMC2_RATIO_OFFSET      0
> +
> +#define MMC2_PRE_RATIO_MASK    0xff
> +#define MMC2_PRE_RATIO_VAL     0x9
> +#define MMC2_PRE_RATIO_OFFSET  8
> +
> +#define MMC3_RATIO_MASK                0xf
> +#define MMC3_RATIO_VAL         0x1
> +#define MMC3_RATIO_OFFSET      16
> +
> +#define MMC3_PRE_RATIO_MASK    0xff
> +#define MMC3_PRE_RATIO_VAL     0x0
> +#define MMC3_PRE_RATIO_OFFSET  24
> +
> +/* CLK_SRC_LEX */
> +#define CLK_SRC_LEX_VAL         0x0
> +
> +/* CLK_DIV_LEX */
> +#define CLK_DIV_LEX_VAL         0x10
> +
> +/* CLK_DIV_R0X */
> +#define CLK_DIV_R0X_VAL         0x10
> +
> +/* CLK_DIV_L0X */
> +#define CLK_DIV_R1X_VAL         0x10
> +
> +/* CLK_DIV_ISP2 */
> +#define CLK_DIV_ISP2_VAL        0x1
> +
> +/* CLK_SRC_KFC */
> +#define SRC_KFC_HPM_SEL                (1 << 15)
> +
> +/* CLK_SRC_KFC */
> +#define CLK_SRC_KFC_VAL                0x00008001
> +
> +/* CLK_DIV_KFC */
> +#define CLK_DIV_KFC_VAL                0x03300110
> +
> +/* CLK_DIV2_RATIO */
> +#define CLK_DIV2_RATIO         0x10111150
> +
> +/* CLK_DIV4_RATIO */
> +#define CLK_DIV4_RATIO         0x00000003
> +
> +/* CLK_DIV_G2D */
> +#define CLK_DIV_G2D            0x00000010
> +
> +/*
> + * DIV_DISP1_0
> + * For DP, divisor should be 2
> + */
> +#define CLK_DIV_DISP1_0_FIMD1  (2 << 0)
> +
> +/* CLK_GATE_IP_DISP1 */
> +#define CLK_GATE_DP1_ALLOW     (1 << 4)
> +
> +/* AUDIO CLK SEL */
> +#define AUDIO0_SEL_EPLL                (0x6 << 28)
> +#define AUDIO0_RATIO           0x5
> +#define PCM0_RATIO             0x3
> +#define DIV_MAU_VAL            (PCM0_RATIO << 24 | AUDIO0_RATIO << 20)
> +
>

please remove blank line.


> +
> +/* CLK_SRC_CDREX */
> +#define MUX_MCLK_CDR_MSPLL     (1 << 4)
> +#define MUX_BPLL_SEL_FOUTBPLL   (1 << 0)
> +#define BPLL_SEL_MASK   0x7
> +#define FOUTBPLL        2
> +
> +#define DDR3PHY_CTRL_PHY_RESET (1 << 0)
> +#define DDR3PHY_CTRL_PHY_RESET_OFF     (0 << 0)
> +
> +#define PHY_CON0_RESET_VAL     0x17020a40
> +#define P0_CMD_EN              (1 << 14)
> +#define BYTE_RDLVL_EN          (1 << 13)
> +#define CTRL_SHGATE            (1 << 8)
> +
> +#define PHY_CON1_RESET_VAL     0x09210100
> +#define RDLVL_PASS_ADJ_VAL     0x6
> +#define RDLVL_PASS_ADJ_OFFSET  16
> +#define CTRL_GATEDURADJ_MASK   (0xf << 20)
> +#define READ_LEVELLING_DDR3    0x0100
> +
> +#define PHY_CON2_RESET_VAL     0x00010004
> +#define INIT_DESKEW_EN         (1 << 6)
> +#define DLL_DESKEW_EN          (1 << 12)
> +#define RDLVL_GATE_EN          (1 << 24)
> +#define RDLVL_EN               (1 << 25)
> +#define RDLVL_INCR_ADJ         (0x1 << 16)
> +
> +/* DREX_PAUSE */
> +#define DREX_PAUSE_EN  (1 << 0)
> +
> +#define BYPASS_EN      (1 << 22)
> +
> +/********-----MEMMORY VAL----------***/
>

/* MEMORY VAL */


> +#define PHY_CON0_VAL   0x17021A00
> +
> +#define PHY_CON12_RESET_VAL    0x10100070
> +#define PHY_CON12_VAL          0x10107F50
> +#define CTRL_START             (1 << 6)
> +#define CTRL_DLL_ON            (1 << 5)
> +#define CTRL_FORCE_MASK                (0x7F << 8)
> +#define CTRL_LOCK_COARSE_MASK  (0x7F << 10)
> +
>

please remove blank line.


> +
> +#define CTRL_OFFSETD_RESET_VAL 0x8
> +#define CTRL_OFFSETD_VAL       0x7F
> +
> +#define CTRL_OFFSETR0          0x7F
> +#define CTRL_OFFSETR1          0x7F
> +#define CTRL_OFFSETR2          0x7F
> +#define CTRL_OFFSETR3          0x7F
> +#define PHY_CON4_VAL   (CTRL_OFFSETR0 << 0 | \
> +                               CTRL_OFFSETR1 << 8 | \
> +                               CTRL_OFFSETR2 << 16 | \
> +                               CTRL_OFFSETR3 << 24)
> +#define PHY_CON4_RESET_VAL     0x08080808
> +
> +#define CTRL_OFFSETW0          0x7F
> +#define CTRL_OFFSETW1          0x7F
> +#define CTRL_OFFSETW2          0x7F
> +#define CTRL_OFFSETW3          0x7F
> +#define PHY_CON6_VAL   (CTRL_OFFSETW0 << 0 | \
> +                               CTRL_OFFSETW1 << 8 | \
> +                               CTRL_OFFSETW2 << 16 | \
> +                               CTRL_OFFSETW3 << 24)
> +#define PHY_CON6_RESET_VAL     0x08080808
> +
> +#define PHY_CON14_RESET_VAL    0x001F0000
> +#define CTRL_PULLD_DQS         0xF
> +#define CTRL_PULLD_DQS_OFFSET  0
> +
> +/*ZQ Configurations */
>

please add space before ZQ.


> +#define PHY_CON16_RESET_VAL    0x08000304
> +
> +#define ZQ_CLK_EN              (1 << 27)
> +#define ZQ_CLK_DIV_EN          (1 << 18)
> +#define ZQ_MANUAL_STR          (1 << 1)
> +#define ZQ_DONE                        (1 << 0)
> +#define ZQ_MODE_DDS_OFFSET     24
> +
> +#define CTRL_RDLVL_GATE_ENABLE 1
> +#define CTRL_RDLVL_GATE_DISABLE        0
> +#define CTRL_RDLVL_DATA_ENABLE 2
> +
> +/* Direct Command */
> +#define DIRECT_CMD_NOP                 0x07000000
> +#define DIRECT_CMD_PALL                        0x01000000
> +#define DIRECT_CMD_ZQINIT              0x0a000000
> +#define DIRECT_CMD_CHANNEL_SHIFT       28
> +#define DIRECT_CMD_CHIP_SHIFT          20
> +#define DIRECT_CMD_BANK_SHIFT          16
> +#define DIRECT_CMD_REFA                (5 << 24)
> +#define DIRECT_CMD_MRS1                0x71C00
> +#define DIRECT_CMD_MRS2                0x10BFC
> +#define DIRECT_CMD_MRS3                0x0050C
> +#define DIRECT_CMD_MRS4                0x00868
> +#define DIRECT_CMD_MRS5                0x00C04
> +
> +/* Drive Strength */
> +#define IMPEDANCE_48_OHM       4
> +#define IMPEDANCE_40_OHM       5
> +#define IMPEDANCE_34_OHM       6
> +#define IMPEDANCE_30_OHM       7
> +#define PHY_CON39_VAL_48_OHM   0x09240924
> +#define PHY_CON39_VAL_40_OHM   0x0B6D0B6D
> +#define PHY_CON39_VAL_34_OHM   0x0DB60DB6
> +#define PHY_CON39_VAL_30_OHM   0x0FFF0FFF
> +
>

please remove blank line.


> +
> +#define CTRL_BSTLEN_OFFSET     8
> +#define CTRL_RDLAT_OFFSET      0
> +
> +#define CMD_DEFAULT_LPDDR3     0xF
> +#define CMD_DEFUALT_OFFSET     0
> +#define T_WRDATA_EN            0x7
> +#define T_WRDATA_EN_DDR3       0x8
> +#define T_WRDATA_EN_OFFSET     16
> +#define T_WRDATA_EN_MASK       0x1f
> +
> +#define PHY_CON31_VAL  0x0C183060
> +#define PHY_CON32_VAL  0x60C18306
> +#define PHY_CON33_VAL  0x00000030
> +
> +#define PHY_CON31_RESET_VAL    0x0
> +#define PHY_CON32_RESET_VAL    0x0
> +#define PHY_CON33_RESET_VAL    0x0
> +
> +#define SL_DLL_DYN_CON_EN      (1 << 1)
> +#define FP_RESYNC      (1 << 3)
> +#define CTRL_START     (1 << 6)
> +
> +#define DMC_AREF_EN            (1 << 5)
> +#define DMC_CONCONTROL_EMPTY   (1 << 8)
> +#define DFI_INIT_START         (1 << 28)
> +
> +#define DMC_MEMCONTROL_VAL     0x00312700
> +#define CLK_STOP_EN            (1 << 0)
> +#define DPWRDN_EN              (1 << 1)
> +#define DSREF_EN               (1 << 5)
> +
> +#define MEMBASECONFIG_CHIP_MASK_VAL    0x7E0
> +#define MEMBASECONFIG_CHIP_MASK_OFFSET 0
> +#define MEMBASECONFIG0_CHIP_BASE_VAL   0x20
> +#define MEMBASECONFIG1_CHIP_BASE_VAL   0x40
> +#define CHIP_BASE_OFFSET               16
> +
> +#define MEMCONFIG_VAL  0x1323
> +#define PRECHCONFIG_DEFAULT_VAL        0xFF000000
> +#define PWRDNCONFIG_DEFAULT_VAL        0xFFFF00FF
> +
> +#define TIMINGAREF_VAL 0x5d
> +#define TIMINGROW_VAL  0x345A8692
> +#define TIMINGDATA_VAL 0x3630065C
> +#define TIMINGPOWER_VAL        0x50380336
> +#define DFI_INIT_COMPLETE      (1 << 3)
> +
> +#define BRBRSVCONTROL_VAL      0x00000033
> +#define BRBRSVCONFIG_VAL       0x88778877
> +
> +/* Clock Gating Control (CGCONTROL) register */
> +#define MEMIF_CG_EN    (1 << 3) /* Memory interface clock gating */
> +#define SCG_CG_EN      (1 << 2) /* Scheduler clock gating */
> +#define BUSIF_WR_CG_EN (1 << 1) /* Bus interface write channel clock
> gating */
> +#define BUSIF_RD_CG_EN (1 << 0) /* Bus interface read channel clock
> gating */
> +#define DMC_INTERNAL_CG        (MEMIF_CG_EN | SCG_CG_EN | \
> +                                BUSIF_WR_CG_EN | BUSIF_RD_CG_EN)
> +
> +/* DMC PHY Control0 register */
> +#define PHY_CONTROL0_RESET_VAL 0x0
> +#define MEM_TERM_EN    (1 << 31)       /* Termination enable for memory */
> +#define PHY_TERM_EN    (1 << 30)       /* Termination enable for PHY */
> +#define DMC_CTRL_SHGATE        (1 << 29)       /* Duration of DQS gating
> signal */
> +#define FP_RSYNC       (1 << 3)        /* Force DLL resyncronization */
> +
> +/* Driver strength for CK, CKE, CS & CA */
> +#define IMP_OUTPUT_DRV_40_OHM  0x5
> +#define IMP_OUTPUT_DRV_30_OHM  0x7
> +#define DA_3_DS_OFFSET         25
> +#define DA_2_DS_OFFSET         22
> +#define DA_1_DS_OFFSET         19
> +#define DA_0_DS_OFFSET         16
> +#define CA_CK_DRVR_DS_OFFSET   9
> +#define CA_CKE_DRVR_DS_OFFSET  6
> +#define CA_CS_DRVR_DS_OFFSET   3
> +#define CA_ADR_DRVR_DS_OFFSET  0
> +
> +#define PHY_CON42_CTRL_BSTLEN_SHIFT    8
> +#define PHY_CON42_CTRL_RDLAT_SHIFT     0
> +
> +/*
> + * Definitions that differ with SoC's.
> + * Below is the part defining macros for smdk5250.
> + * Else part introduces macros for smdk5420.
> + */
> +#ifndef CONFIG_SMDK5420
> +
> +/* APLL_CON1 */
> +#define APLL_CON1_VAL  (0x00203800)
> +
> +/* MPLL_CON1 */
> +#define MPLL_CON1_VAL   (0x00203800)
> +
> +/* CPLL_CON1 */
> +#define CPLL_CON1_VAL  (0x00203800)
> +
> +/* DPLL_CON1 */
> +#define DPLL_CON1_VAL  (NOT_AVAILABLE)
> +
> +/* GPLL_CON1 */
> +#define GPLL_CON1_VAL  (0x00203800)
> +
> +/* EPLL_CON1, CON2 */
> +#define EPLL_CON1_VAL  0x00000000
> +#define EPLL_CON2_VAL  0x00000080
> +
> +/* VPLL_CON1, CON2 */
> +#define VPLL_CON1_VAL  0x00000000
> +#define VPLL_CON2_VAL  0x00000080
> +
> +/* RPLL_CON1, CON2 */
> +#define RPLL_CON1_VAL  NOT_AVAILABLE
> +#define RPLL_CON2_VAL  NOT_AVAILABLE
> +
> +/* BPLL_CON1 */
> +#define BPLL_CON1_VAL  0x00203800
> +
> +/* SPLL_CON1 */
> +#define SPLL_CON1_VAL  NOT_AVAILABLE
> +
> +/* IPLL_CON1 */
> +#define IPLL_CON1_VAL  NOT_AVAILABLE
> +
> +/* KPLL_CON1 */
> +#define KPLL_CON1_VAL  NOT_AVAILABLE
> +
> +/* CLK_SRC_ISP */
> +#define CLK_SRC_ISP_VAL                NOT_AVAILABLE
> +#define CLK_DIV_ISP0_VAL       0x31
> +#define CLK_DIV_ISP1_VAL       0x0
> +
> +/* CLK_FSYS */
> +#define CLK_SRC_FSYS0_VAL              0x66666
> +#define CLK_DIV_FSYS0_VAL             0x0BB00000
> +#define CLK_DIV_FSYS1_VAL             NOT_AVAILABLE
> +#define CLK_DIV_FSYS2_VAL             NOT_AVAILABLE
> +
> +/* CLK_SRC_CPU */
> +/* 0 = MOUTAPLL,  1 = SCLKMPLL */
> +#define MUX_HPM_SEL             0
> +#define MUX_CPU_SEL             0
> +#define MUX_APLL_SEL            1
> +
> +#define CLK_SRC_CPU_VAL                ((MUX_HPM_SEL << 20)    \
> +                               | (MUX_CPU_SEL << 16)  \
> +                               | (MUX_APLL_SEL))
> +
>  /* CLK_SRC_CDREX */
>  #define CLK_SRC_CDREX_VAL       0x1
>
>  /* CLK_DIV_CDREX */
> +#define CLK_DIV_CDREX0_VAL     NOT_AVAILABLE
> +#define CLK_DIV_CDREX1_VAL     NOT_AVAILABLE
> +
> +/* CLK_DIV_CPU0_VAL */
> +#define CLK_DIV_CPU0_VAL       NOT_AVAILABLE
> +
>  #define MCLK_CDREX2_RATIO       0x0
>  #define ACLK_EFCON_RATIO        0x1
>  #define MCLK_DPHY_RATIO                0x1
> @@ -247,6 +587,11 @@
>                                 | (MUX_ACLK_300_DISP1_SUB_SEL << 6)     \
>                                 | (MUX_ACLK_200_DISP1_SUB_SEL << 4))
>
> +#define CLK_SRC_TOP4_VAL       NOT_AVAILABLE
> +#define CLK_SRC_TOP5_VAL       NOT_AVAILABLE
> +#define CLK_SRC_TOP6_VAL       NOT_AVAILABLE
> +#define CLK_SRC_TOP7_VAL       NOT_AVAILABLE
> +
>  /* CLK_DIV_TOP0        */
>  #define ACLK_300_DISP1_RATIO   0x2
>  #define ACLK_400_G3D_RATIO     0x0
> @@ -279,40 +624,11 @@
>                                 | (ACLK_400_IOP_RATIO << 16)            \
>                                 | (ACLK_300_GSCL_RATIO << 12))
>
> -/* APLL_LOCK   */
> -#define APLL_LOCK_VAL  (0x546)
> -/* MPLL_LOCK   */
> -#define MPLL_LOCK_VAL  (0x546)
> -/* CPLL_LOCK   */
> -#define CPLL_LOCK_VAL  (0x546)
> -/* GPLL_LOCK   */
> -#define GPLL_LOCK_VAL  (0x546)
> -/* EPLL_LOCK   */
> -#define EPLL_LOCK_VAL  (0x3A98)
> -/* VPLL_LOCK   */
> -#define VPLL_LOCK_VAL  (0x3A98)
> -/* BPLL_LOCK   */
> -#define BPLL_LOCK_VAL  (0x546)
> +#define CLK_DIV_TOP2_VAL       NOT_AVAILABLE
>
> -#define MUX_APLL_SEL_MASK      (1 << 0)
> -#define MUX_MPLL_SEL_MASK      (1 << 8)
> -#define MPLL_SEL_MOUT_MPLLFOUT (2 << 8)
> -#define MUX_CPLL_SEL_MASK      (1 << 8)
> -#define MUX_EPLL_SEL_MASK      (1 << 12)
> -#define MUX_VPLL_SEL_MASK      (1 << 16)
> -#define MUX_GPLL_SEL_MASK      (1 << 28)
> -#define MUX_BPLL_SEL_MASK      (1 << 0)
> -#define MUX_HPM_SEL_MASK       (1 << 20)
> -#define HPM_SEL_SCLK_MPLL      (1 << 21)
> -#define APLL_CON0_LOCKED       (1 << 29)
> -#define MPLL_CON0_LOCKED       (1 << 29)
> -#define BPLL_CON0_LOCKED       (1 << 29)
> -#define CPLL_CON0_LOCKED       (1 << 29)
> -#define EPLL_CON0_LOCKED       (1 << 29)
> -#define GPLL_CON0_LOCKED       (1 << 29)
> -#define VPLL_CON0_LOCKED       (1 << 29)
> -#define CLK_REG_DISABLE                0x0
> -#define TOP2_VAL               0x0110000
> +/* PLL Lock Value Factor */
> +#define PLL_LOCK_FACTOR                250
> +#define PLL_X_LOCK_FACTOR      3000
>
>  /* CLK_SRC_PERIC0 */
>  #define PWM_SEL                6
> @@ -336,18 +652,6 @@
>                                 | (SPI1_SEL << 20) \
>                                 | (SPI0_SEL << 16))
>
> -/* SCLK_SRC_ISP - set SPI0/1 to 6 = SCLK_MPLL_USER */
> -#define SPI0_ISP_SEL           6
> -#define SPI1_ISP_SEL           6
> -#define SCLK_SRC_ISP_VAL       (SPI1_ISP_SEL << 4) \
> -                               | (SPI0_ISP_SEL << 0)
> -
> -/* SCLK_DIV_ISP - set SPI0/1 to 0xf = divide by 16 */
> -#define SPI0_ISP_RATIO         0xf
> -#define SPI1_ISP_RATIO         0xf
> -#define SCLK_DIV_ISP_VAL       (SPI1_ISP_RATIO << 12) \
> -                               | (SPI0_ISP_RATIO << 0)
> -
>  /* CLK_DIV_PERIL0      */
>  #define UART5_RATIO    7
>  #define UART4_RATIO    7
> @@ -380,105 +684,200 @@
>  #define PWM_RATIO              8
>  #define CLK_DIV_PERIC3_VAL     (PWM_RATIO << 0)
>
> -/* CLK_DIV_FSYS2 */
> -#define MMC2_RATIO_MASK                0xf
> -#define MMC2_RATIO_VAL         0x3
> -#define MMC2_RATIO_OFFSET      0
>
> -#define MMC2_PRE_RATIO_MASK    0xff
> -#define MMC2_PRE_RATIO_VAL     0x9
> -#define MMC2_PRE_RATIO_OFFSET  8
> +/* CLK_DIV_PERIC4 */
> +#define CLK_DIV_PERIC4_VAL     NOT_AVAILABLE
>
> -#define MMC3_RATIO_MASK                0xf
> -#define MMC3_RATIO_VAL         0x1
> -#define MMC3_RATIO_OFFSET      16
> +/* CLK_SRC_DISP1_0 */
> +#define CLK_SRC_DISP1_0_VAL    0x6
> +#define CLK_DIV_DISP1_0_VAL    NOT_AVAILABLE
>
> -#define MMC3_PRE_RATIO_MASK    0xff
> -#define MMC3_PRE_RATIO_VAL     0x0
> -#define MMC3_PRE_RATIO_OFFSET  24
> +#define APLL_FOUT              (1 << 0)
> +#define KPLL_FOUT              NOT_AVAILABLE
>
> -/* CLK_SRC_LEX */
> -#define CLK_SRC_LEX_VAL         0x0
> +#define CLK_DIV_CPERI1_VAL     NOT_AVAILABLE
>
> -/* CLK_DIV_LEX */
> -#define CLK_DIV_LEX_VAL         0x10
> +#else
>
> -/* CLK_DIV_R0X */
> -#define CLK_DIV_R0X_VAL         0x10
> +/* APLL_CON1 */
> +#define APLL_CON1_VAL  (0x0020F300)
>
> -/* CLK_DIV_L0X */
> -#define CLK_DIV_R1X_VAL         0x10
> +/* MPLL_CON1 */
> +#define MPLL_CON1_VAL   (0x0020F300)
>
> -/* CLK_DIV_ISP0 */
> -#define CLK_DIV_ISP0_VAL        0x31
>
> -/* CLK_DIV_ISP1 */
> -#define CLK_DIV_ISP1_VAL        0x0
> +/* CPLL_CON1 */
> +#define CPLL_CON1_VAL  0x0020f300
>
> -/* CLK_DIV_ISP2 */
> -#define CLK_DIV_ISP2_VAL        0x1
> +/* DPLL_CON1 */
> +#define DPLL_CON1_VAL  (0x0020F300)
>
> -/* CLK_SRC_DISP1_0 */
> -#define CLK_SRC_DISP1_0_VAL    0x6
> +/* GPLL_CON1 */
> +#define GPLL_CON1_VAL  (NOT_AVAILABLE)
>
> -/*
> - * DIV_DISP1_0
> - * For DP, divisor should be 2
> - */
> -#define CLK_DIV_DISP1_0_FIMD1  (2 << 0)
>
> -/* CLK_GATE_IP_DISP1 */
> -#define CLK_GATE_DP1_ALLOW     (1 << 4)
> +/* EPLL_CON1, CON2 */
> +#define EPLL_CON1_VAL  0x00000000
> +#define EPLL_CON2_VAL  0x00000080
>
> -#define DDR3PHY_CTRL_PHY_RESET (1 << 0)
> -#define DDR3PHY_CTRL_PHY_RESET_OFF     (0 << 0)
> +/* VPLL_CON1, CON2 */
> +#define VPLL_CON1_VAL  0x0020f300
> +#define VPLL_CON2_VAL  NOT_AVAILABLE
>
> -#define PHY_CON0_RESET_VAL     0x17020a40
> -#define P0_CMD_EN              (1 << 14)
> -#define BYTE_RDLVL_EN          (1 << 13)
> -#define CTRL_SHGATE            (1 << 8)
> +/* RPLL_CON1, CON2 */
> +#define RPLL_CON1_VAL  0x00000000
> +#define RPLL_CON2_VAL  0x00000080
>
> -#define PHY_CON1_RESET_VAL     0x09210100
> -#define CTRL_GATEDURADJ_MASK   (0xf << 20)
> +/* BPLL_CON1 */
> +#define BPLL_CON1_VAL  0x0020f300
>
> -#define PHY_CON2_RESET_VAL     0x00010004
> -#define INIT_DESKEW_EN         (1 << 6)
> -#define RDLVL_GATE_EN          (1 << 24)
> +/* SPLL_CON1 */
> +#define SPLL_CON1_VAL  0x0020f300
>
> -/*ZQ Configurations */
> -#define PHY_CON16_RESET_VAL    0x08000304
> +/* IPLL_CON1 */
> +#define IPLL_CON1_VAL  0x00000080
>
> -#define ZQ_CLK_DIV_EN          (1 << 18)
> -#define ZQ_MANUAL_STR          (1 << 1)
> -#define ZQ_DONE                        (1 << 0)
> +/* KPLL_CON1 */
> +#define KPLL_CON1_VAL  0x200000
>
> -#define CTRL_RDLVL_GATE_ENABLE 1
> -#define CTRL_RDLVL_GATE_DISABLE        1
> +/* CLK_SRC_ISP */
> +#define CLK_SRC_ISP_VAL                0x33366000
> +#define CLK_DIV_ISP0_VAL       0x13131300
> +#define CLK_DIV_ISP1_VAL       0xbb110202
>
> -/* Direct Command */
> -#define DIRECT_CMD_NOP                 0x07000000
> -#define DIRECT_CMD_PALL                        0x01000000
> -#define DIRECT_CMD_ZQINIT              0x0a000000
> -#define DIRECT_CMD_CHANNEL_SHIFT       28
> -#define DIRECT_CMD_CHIP_SHIFT          20
>
> -/* DMC PHY Control0 register */
> -#define PHY_CONTROL0_RESET_VAL 0x0
> -#define MEM_TERM_EN    (1 << 31)       /* Termination enable for memory */
> -#define PHY_TERM_EN    (1 << 30)       /* Termination enable for PHY */
> -#define DMC_CTRL_SHGATE        (1 << 29)       /* Duration of DQS gating
> signal */
> -#define FP_RSYNC       (1 << 3)        /* Force DLL resyncronization */
> +/* CLK_FSYS */
> +#define CLK_SRC_FSYS0_VAL              0x33033300
> +#define CLK_DIV_FSYS0_VAL             0x0
> +#define CLK_DIV_FSYS1_VAL             0x04f13c4f
> +#define CLK_DIV_FSYS2_VAL             0x041d0000
> +
> +/* CLK_SRC_CPU */
> +/* 0 = MOUTAPLL,  1 = SCLKMPLL */
> +#define MUX_HPM_SEL             1
> +#define MUX_CPU_SEL             0
> +#define MUX_APLL_SEL            1
>
> -/* Driver strength for CK, CKE, CS & CA */
> -#define IMP_OUTPUT_DRV_40_OHM  0x5
> -#define IMP_OUTPUT_DRV_30_OHM  0x7
> -#define CA_CK_DRVR_DS_OFFSET   9
> -#define CA_CKE_DRVR_DS_OFFSET  6
> -#define CA_CS_DRVR_DS_OFFSET   3
> -#define CA_ADR_DRVR_DS_OFFSET  0
> +#define CLK_SRC_CPU_VAL                ((MUX_HPM_SEL << 20)    \
> +                               | (MUX_CPU_SEL << 16)  \
> +                               | (MUX_APLL_SEL))
>
> -#define PHY_CON42_CTRL_BSTLEN_SHIFT    8
> -#define PHY_CON42_CTRL_RDLAT_SHIFT     0
> +/* CLK_SRC_CDREX */
> +#define CLK_SRC_CDREX_VAL       0x00000011
> +
> +/* CLK_DIV_CDREX */
> +#define CLK_DIV_CDREX0_VAL     0x30010100
> +#define CLK_DIV_CDREX1_VAL     0x300
> +
> +#define CLK_DIV_CDREX_VAL       0x17010100
> +
> +/* CLK_DIV_CPU0_VAL */
> +#define CLK_DIV_CPU0_VAL       0x01440020
> +
> +/* CLK_SRC_TOP */
> +#define CLK_SRC_TOP0_VAL       0x12221222
> +#define CLK_SRC_TOP1_VAL       0x00100200
> +#define CLK_SRC_TOP2_VAL       0x11101000
> +#define CLK_SRC_TOP3_VAL       0x11111111
> +#define CLK_SRC_TOP4_VAL       0x11110111
> +#define CLK_SRC_TOP5_VAL       0x11111100
> +#define CLK_SRC_TOP6_VAL       0x11110111
> +#define CLK_SRC_TOP7_VAL       0x00022200
> +
> +/* CLK_DIV_TOP */
> +#define CLK_DIV_TOP0_VAL       0x23712311
> +#define CLK_DIV_TOP1_VAL       0x13100B00
> +#define CLK_DIV_TOP2_VAL       0x11101100
> +
> +/* PLL Lock Value Factor */
> +#define PLL_LOCK_FACTOR                200
> +#define PLL_X_LOCK_FACTOR      3000
> +
> +/* CLK_SRC_PERIC0 */
> +#define SPDIF_SEL      1
> +#define PWM_SEL                3
> +#define UART4_SEL      3
> +#define UART3_SEL      3
> +#define UART2_SEL      3
> +#define UART1_SEL      3
> +#define UART0_SEL      3
> +/* SRC_CLOCK = SCLK_RPLL */
> +#define CLK_SRC_PERIC0_VAL     ((SPDIF_SEL << 28)      \
> +                               | (PWM_SEL << 24)       \
> +                               | (UART4_SEL << 20)     \
> +                               | (UART3_SEL << 16)     \
> +                               | (UART2_SEL << 12)     \
> +                               | (UART1_SEL << 8)      \
> +                               | (UART0_SEL << 4))
> +
> +/* CLK_SRC_PERIC1 */
> +/* SRC_CLOCK = SCLK_EPLL */
> +#define SPI0_SEL               6
> +#define SPI1_SEL               6
> +#define SPI2_SEL               6
> +#define AUDIO0_SEL             6
> +#define AUDIO1_SEL             6
> +#define AUDIO2_SEL             6
> +#define CLK_SRC_PERIC1_VAL     ((SPI2_SEL << 28)       \
> +                               | (SPI1_SEL << 24)      \
> +                               | (SPI0_SEL << 20)      \
> +                               | (AUDIO2_SEL << 16)    \
> +                               | (AUDIO2_SEL << 12)    \
> +                               | (AUDIO2_SEL << 8))
> +
> +/* CLK_DIV_PERIC0 */
> +#define PWM_RATIO      8
> +#define UART4_RATIO    9
> +#define UART3_RATIO    9
> +#define UART2_RATIO    9
> +#define UART1_RATIO    9
> +#define UART0_RATIO    9
> +
> +#define CLK_DIV_PERIC0_VAL     ((PWM_RATIO << 28)      \
> +                               | (UART4_RATIO << 24)   \
> +                               | (UART3_RATIO << 20)    \
> +                               | (UART2_RATIO << 16)    \
> +                               | (UART1_RATIO << 12)    \
> +                               | (UART0_RATIO << 8))
> +/* CLK_DIV_PERIC1 */
> +#define SPI2_RATIO             0x1
> +#define SPI1_RATIO             0x1
> +#define SPI0_RATIO             0x1
> +#define CLK_DIV_PERIC1_VAL     ((SPI2_RATIO << 28)     \
> +                               | (SPI1_RATIO << 24)    \
> +                               | (SPI0_RATIO << 20))
> +
> +/* CLK_DIV_PERIC2 */
> +#define PCM2_RATIO             0x3
> +#define PCM1_RATIO             0x3
> +#define CLK_DIV_PERIC2_VAL     ((PCM2_RATIO << 24) \
> +                               | (PCM1_RATIO << 16))
> +
> +/* CLK_DIV_PERIC3 */
> +#define AUDIO2_RATIO           0x5
> +#define AUDIO1_RATIO           0x5
> +#define AUDIO0_RATIO           0x5
> +#define CLK_DIV_PERIC3_VAL     ((AUDIO2_RATIO << 28)   \
> +                               | (AUDIO1_RATIO << 24)  \
> +                               | (AUDIO0_RATIO << 20))
> +
> +/* CLK_DIV_PERIC4 */
> +#define SPI2_PRE_RATIO         0x2
> +#define SPI1_PRE_RATIO         0x2
> +#define SPI0_PRE_RATIO         0x2
> +#define CLK_DIV_PERIC4_VAL     ((SPI2_PRE_RATIO << 24) \
> +                               | (SPI1_PRE_RATIO << 16) \
> +                               | (SPI0_PRE_RATIO << 8))
> +
> +/* CLK_SRC_DISP1_0 */
> +#define CLK_SRC_DISP1_0_VAL    0x10666600
> +#define CLK_DIV_DISP1_0_VAL    0x01050211
> +
> +#define APLL_FOUT              (1 << 0)
> +#define KPLL_FOUT              (1 << 0)
> +
> +#define CLK_DIV_CPERI1_VAL     0x3f3f0000
> +#endif
>
>  struct mem_timings;
>
> @@ -490,7 +889,7 @@ enum {
>  };
>
>  /*
> - * Memory variant specific initialization code
> + * Memory variant specific initialization code for DDR3
>   *
>   * @param mem          Memory timings for this memory type.
>   * @param mem_iv_size  Memory interleaving size is a configurable
> parameter
> @@ -503,6 +902,9 @@ enum {
>  int ddr3_mem_ctrl_init(struct mem_timings *mem, unsigned long mem_iv_size,
>                         int reset);
>
> +/* Memory variant specific initialization code for LPDDR3 */
> +void lpddr3_mem_ctrl_init(void);
> +
>  /*
>   * Configure ZQ I/O interface
>   *
> @@ -532,14 +934,6 @@ void dmc_config_mrs(struct mem_timings *mem, struct
> exynos5_dmc *dmc);
>  void dmc_config_prech(struct mem_timings *mem, struct exynos5_dmc *dmc);
>
>  /*
> - * Configure the memconfig and membaseconfig registers
> - *
> - * @param mem          Memory timings for this memory type.
> - * @param exynos5_dmc  Pointer to struct of DMC registers
> - */
> -void dmc_config_memory(struct mem_timings *mem, struct exynos5_dmc *dmc);
> -
> -/*
>   * Reset the DLL. This function is common between DDR3 and LPDDR2.
>   * However, the reset value is different. So we are passing a flag
>   * ddr_mode to distinguish between LPDDR2 and DDR3.
> diff --git a/arch/arm/include/asm/arch-exynos/clk.h
> b/arch/arm/include/asm/arch-exynos/clk.h
> index 1d6fa93..cdeef32 100644
> --- a/arch/arm/include/asm/arch-exynos/clk.h
> +++ b/arch/arm/include/asm/arch-exynos/clk.h
> @@ -14,6 +14,7 @@
>  #define HPLL   3
>  #define VPLL   4
>  #define BPLL   5
> +#define RPLL   6
>
>  enum pll_src_bit {
>         EXYNOS_SRC_MPLL = 6,
> --
> 1.7.12.4
>
> _______________________________________________
> U-Boot mailing list
> U-Boot at lists.denx.de
> http://lists.denx.de/mailman/listinfo/u-boot
>



-- 
from. prom.
www.promsoft.net

  reply	other threads:[~2013-11-13  2:45 UTC|newest]

Thread overview: 37+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-10-29  7:23 [U-Boot] [PATCH 00/10 V6] EXYNOS5420: Add SMDK5420 board support Rajeshwari S Shinde
2013-10-29  7:23 ` [U-Boot] [PATCH 01/10 V6] EXYNOS5: Create a common board file Rajeshwari S Shinde
2013-11-08  8:13   ` Przemyslaw Marczak
2013-11-08  8:37     ` Rajeshwari Birje
2013-11-08  9:03       ` Przemyslaw Marczak
2013-11-08  9:27         ` Rajeshwari Birje
2013-11-08  9:46           ` Przemyslaw Marczak
2013-11-08  9:52             ` Rajeshwari Birje
2013-10-29  7:23 ` [U-Boot] [PATCH 02/10 V6] Exynos5420: Add base addresses for 5420 Rajeshwari S Shinde
2013-11-13  3:20   ` Minkyu Kang
2013-10-29  7:23 ` [U-Boot] [PATCH 03/10 V6] Exynos5420: Add clock initialization " Rajeshwari S Shinde
2013-11-13  2:45   ` Minkyu Kang [this message]
2013-11-13 11:17     ` Rajeshwari Birje
2013-11-14  1:56       ` Minkyu Kang
2013-10-29  7:23 ` [U-Boot] [PATCH 04/10 V6] Exynos5420: Add DDR3 " Rajeshwari S Shinde
2013-11-13  3:24   ` Minkyu Kang
2013-10-29  7:23 ` [U-Boot] [PATCH 05/10 V6] Exynos5420: Add support for 5420 in pinmux and gpio Rajeshwari S Shinde
2013-11-13  3:01   ` Minkyu Kang
2013-11-13  6:04     ` Rajeshwari Birje
2013-11-13  6:08       ` Rajeshwari Birje
2013-11-14  2:46       ` Minkyu Kang
2013-10-29  7:23 ` [U-Boot] [PATCH 06/10 V6] Exynos5420: Add base patch for SMDK5420 Rajeshwari S Shinde
2013-11-13  3:09   ` Minkyu Kang
2013-10-29  7:23 ` [U-Boot] [PATCH 07/10 V6] DTS: Add dts support " Rajeshwari S Shinde
2013-11-13  3:17   ` Minkyu Kang
2013-11-13  4:26     ` Rajeshwari Birje
2013-11-14  2:01       ` Minkyu Kang
2013-11-15  2:32         ` Rajeshwari Birje
2013-10-29  7:23 ` [U-Boot] [PATCH 08/10 V6] Config: Add initial config " Rajeshwari S Shinde
2013-11-13  3:31   ` Minkyu Kang
2013-10-29  7:23 ` [U-Boot] [PATCH 09/10 V6] SPL: EXYNOS: Prepare for variable size SPL support Rajeshwari S Shinde
2013-10-29  7:23 ` [U-Boot] [PATCH 10/10 V6] DWMMC: SMDK5420: Disable SMU for eMMC Rajeshwari S Shinde
2013-10-29 10:24   ` Jaehoon Chung
2013-10-31  7:50   ` Pantelis Antoniou
2013-10-31  8:42 ` [U-Boot] [PATCH 00/10 V6] EXYNOS5420: Add SMDK5420 board support Rajeshwari Birje
2013-11-06 11:42   ` Rajeshwari Birje
2013-11-07  1:32     ` Minkyu Kang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CALrBrZ1OQjes=Z4UCTVfycu_F3fKWnNcjZFYk43BOhjU8OsHRQ@mail.gmail.com' \
    --to=promsoft@gmail.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.