From: Matthew Auld <matthew.william.auld@gmail.com> To: "Thomas Hellström" <thomas.hellstrom@linux.intel.com> Cc: Intel Graphics Development <intel-gfx@lists.freedesktop.org>, Matthew Auld <matthew.auld@intel.com>, ML dri-devel <dri-devel@lists.freedesktop.org> Subject: Re: [Intel-gfx] [PATCH 3/9] drm/i915: Introduce a ww transaction helper Date: Tue, 8 Jun 2021 18:17:12 +0100 [thread overview] Message-ID: <CAM0jSHOyOtORECkqjYuiCncj=rFrgUeoXP4DNvxBxkF2nBmFpg@mail.gmail.com> (raw) In-Reply-To: <20210608092846.64198-4-thomas.hellstrom@linux.intel.com> On Tue, 8 Jun 2021 at 10:29, Thomas Hellström <thomas.hellstrom@linux.intel.com> wrote: > > Introduce a for_i915_gem_ww(){} utility to help make the code > around a ww transaction more readable. > > Signed-off-by: Thomas Hellström <thomas.hellstrom@linux.intel.com> > --- > drivers/gpu/drm/i915/i915_gem_ww.h | 31 +++++++++++++++++++++++++++++- > 1 file changed, 30 insertions(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/i915/i915_gem_ww.h b/drivers/gpu/drm/i915/i915_gem_ww.h > index f2d8769e4118..f6b1a796667b 100644 > --- a/drivers/gpu/drm/i915/i915_gem_ww.h > +++ b/drivers/gpu/drm/i915/i915_gem_ww.h > @@ -11,11 +11,40 @@ struct i915_gem_ww_ctx { > struct ww_acquire_ctx ctx; > struct list_head obj_list; > struct drm_i915_gem_object *contended; > - bool intr; > + unsigned short intr; > + unsigned short loop; Why are these now unsigned short? Reviewed-by: Matthew Auld <matthew.auld@intel.com> > }; > > void i915_gem_ww_ctx_init(struct i915_gem_ww_ctx *ctx, bool intr); > void i915_gem_ww_ctx_fini(struct i915_gem_ww_ctx *ctx); > int __must_check i915_gem_ww_ctx_backoff(struct i915_gem_ww_ctx *ctx); > void i915_gem_ww_unlock_single(struct drm_i915_gem_object *obj); > + > +/* Internal functions used by the inlines! Don't use. */ > +static inline int __i915_gem_ww_fini(struct i915_gem_ww_ctx *ww, int err) > +{ > + ww->loop = 0; > + if (err == -EDEADLK) { > + err = i915_gem_ww_ctx_backoff(ww); > + if (!err) > + ww->loop = 1; > + } > + > + if (!ww->loop) > + i915_gem_ww_ctx_fini(ww); > + > + return err; > +} > + > +static inline void > +__i915_gem_ww_init(struct i915_gem_ww_ctx *ww, bool intr) > +{ > + i915_gem_ww_ctx_init(ww, intr); > + ww->loop = 1; > +} > + > +#define for_i915_gem_ww(_ww, _err, _intr) \ > + for (__i915_gem_ww_init(_ww, _intr); (_ww)->loop; \ > + _err = __i915_gem_ww_fini(_ww, _err)) > + > #endif > -- > 2.31.1 > > _______________________________________________ > Intel-gfx mailing list > Intel-gfx@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/intel-gfx
WARNING: multiple messages have this Message-ID (diff)
From: Matthew Auld <matthew.william.auld@gmail.com> To: "Thomas Hellström" <thomas.hellstrom@linux.intel.com> Cc: Intel Graphics Development <intel-gfx@lists.freedesktop.org>, Matthew Auld <matthew.auld@intel.com>, ML dri-devel <dri-devel@lists.freedesktop.org> Subject: Re: [Intel-gfx] [PATCH 3/9] drm/i915: Introduce a ww transaction helper Date: Tue, 8 Jun 2021 18:17:12 +0100 [thread overview] Message-ID: <CAM0jSHOyOtORECkqjYuiCncj=rFrgUeoXP4DNvxBxkF2nBmFpg@mail.gmail.com> (raw) In-Reply-To: <20210608092846.64198-4-thomas.hellstrom@linux.intel.com> On Tue, 8 Jun 2021 at 10:29, Thomas Hellström <thomas.hellstrom@linux.intel.com> wrote: > > Introduce a for_i915_gem_ww(){} utility to help make the code > around a ww transaction more readable. > > Signed-off-by: Thomas Hellström <thomas.hellstrom@linux.intel.com> > --- > drivers/gpu/drm/i915/i915_gem_ww.h | 31 +++++++++++++++++++++++++++++- > 1 file changed, 30 insertions(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/i915/i915_gem_ww.h b/drivers/gpu/drm/i915/i915_gem_ww.h > index f2d8769e4118..f6b1a796667b 100644 > --- a/drivers/gpu/drm/i915/i915_gem_ww.h > +++ b/drivers/gpu/drm/i915/i915_gem_ww.h > @@ -11,11 +11,40 @@ struct i915_gem_ww_ctx { > struct ww_acquire_ctx ctx; > struct list_head obj_list; > struct drm_i915_gem_object *contended; > - bool intr; > + unsigned short intr; > + unsigned short loop; Why are these now unsigned short? Reviewed-by: Matthew Auld <matthew.auld@intel.com> > }; > > void i915_gem_ww_ctx_init(struct i915_gem_ww_ctx *ctx, bool intr); > void i915_gem_ww_ctx_fini(struct i915_gem_ww_ctx *ctx); > int __must_check i915_gem_ww_ctx_backoff(struct i915_gem_ww_ctx *ctx); > void i915_gem_ww_unlock_single(struct drm_i915_gem_object *obj); > + > +/* Internal functions used by the inlines! Don't use. */ > +static inline int __i915_gem_ww_fini(struct i915_gem_ww_ctx *ww, int err) > +{ > + ww->loop = 0; > + if (err == -EDEADLK) { > + err = i915_gem_ww_ctx_backoff(ww); > + if (!err) > + ww->loop = 1; > + } > + > + if (!ww->loop) > + i915_gem_ww_ctx_fini(ww); > + > + return err; > +} > + > +static inline void > +__i915_gem_ww_init(struct i915_gem_ww_ctx *ww, bool intr) > +{ > + i915_gem_ww_ctx_init(ww, intr); > + ww->loop = 1; > +} > + > +#define for_i915_gem_ww(_ww, _err, _intr) \ > + for (__i915_gem_ww_init(_ww, _intr); (_ww)->loop; \ > + _err = __i915_gem_ww_fini(_ww, _err)) > + > #endif > -- > 2.31.1 > > _______________________________________________ > Intel-gfx mailing list > Intel-gfx@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/intel-gfx _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2021-06-08 17:17 UTC|newest] Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-06-08 9:28 [PATCH 0/9] Prereqs for TTM accelerated migration Thomas Hellström 2021-06-08 9:28 ` [Intel-gfx] " Thomas Hellström 2021-06-08 9:28 ` [PATCH 1/9] drm/i915: Reference objects on the ww object list Thomas Hellström 2021-06-08 9:28 ` [Intel-gfx] " Thomas Hellström 2021-06-08 17:05 ` Matthew Auld 2021-06-08 17:05 ` [Intel-gfx] " Matthew Auld 2021-06-08 9:28 ` [PATCH 2/9] drm/i915: Break out dma_resv ww locking utilities to separate files Thomas Hellström 2021-06-08 9:28 ` [Intel-gfx] " Thomas Hellström 2021-06-08 17:10 ` Matthew Auld 2021-06-08 17:10 ` [Intel-gfx] " Matthew Auld 2021-06-08 9:28 ` [PATCH 3/9] drm/i915: Introduce a ww transaction helper Thomas Hellström 2021-06-08 9:28 ` [Intel-gfx] " Thomas Hellström 2021-06-08 17:17 ` Matthew Auld [this message] 2021-06-08 17:17 ` Matthew Auld 2021-06-08 19:00 ` Thomas Hellström 2021-06-08 19:00 ` Thomas Hellström 2021-06-08 9:28 ` [PATCH 4/9] drm/i915/gt: Add an insert_entry for gen8_ppgtt Thomas Hellström 2021-06-08 9:28 ` [Intel-gfx] " Thomas Hellström 2021-06-08 9:28 ` [PATCH 5/9] drm/i915/gt: Add a routine to iterate over the pagetables of a GTT Thomas Hellström 2021-06-08 9:28 ` [Intel-gfx] " Thomas Hellström 2021-06-08 9:28 ` [PATCH 6/9] drm/i915/gt: Export the pinned context constructor Thomas Hellström 2021-06-08 9:28 ` [Intel-gfx] " Thomas Hellström 2021-06-08 9:28 ` [PATCH 7/9] drm/i915/gt: Pipelined page migration Thomas Hellström 2021-06-08 9:28 ` [Intel-gfx] " Thomas Hellström 2021-06-08 16:18 ` Matthew Auld 2021-06-08 16:18 ` Matthew Auld 2021-06-08 19:05 ` Thomas Hellström 2021-06-08 19:05 ` Thomas Hellström 2021-06-08 19:09 ` Thomas Hellström 2021-06-08 19:09 ` [Intel-gfx] " Thomas Hellström 2021-06-08 9:28 ` [PATCH 8/9] drm/i915/gt: Pipelined clear Thomas Hellström 2021-06-08 9:28 ` [Intel-gfx] " Thomas Hellström 2021-06-08 9:28 ` [PATCH 9/9] drm/i915/gt: Setup a default migration context on the GT Thomas Hellström 2021-06-08 9:28 ` [Intel-gfx] " Thomas Hellström 2021-06-08 12:02 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for Prereqs for TTM accelerated migration Patchwork 2021-06-08 12:32 ` [Intel-gfx] ✗ Fi.CI.BAT: failure " Patchwork 2021-06-08 12:32 ` [Intel-gfx] ✗ Fi.CI.BUILD: warning " Patchwork
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to='CAM0jSHOyOtORECkqjYuiCncj=rFrgUeoXP4DNvxBxkF2nBmFpg@mail.gmail.com' \ --to=matthew.william.auld@gmail.com \ --cc=dri-devel@lists.freedesktop.org \ --cc=intel-gfx@lists.freedesktop.org \ --cc=matthew.auld@intel.com \ --cc=thomas.hellstrom@linux.intel.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.