[PATCH] perf metricgroup: remove unneeded semicolon

[PATCH] perf metricgroup: remove unneeded semicolon

[Yang Li]

Eliminate the following coccicheck warning:
./tools/perf/util/metricgroup.c:382:3-4: Unneeded semicolon

Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
---
 tools/perf/util/metricgroup.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/perf/util/metricgroup.c b/tools/perf/util/metricgroup.c
index e6d3452..26c990e 100644
--- a/tools/perf/util/metricgroup.c
+++ b/tools/perf/util/metricgroup.c
@@ -379,7 +379,7 @@ static int metricgroup__setup_events(struct list_head *groups,
 				metric_refs[i].metric_expr = ref->metric_expr;
 				i++;
 			}
-		};
+		}
 
 		expr->metric_refs = metric_refs;
 		expr->metric_expr = m->metric_expr;
-- 
1.8.3.1

Re: [PATCH] perf metricgroup: remove unneeded semicolon

[Namhyung Kim]

Hello,

On Mon, Feb 1, 2021 at 4:41 PM Yang Li <yang.lee@linux.alibaba.com> wrote:
>
> Eliminate the following coccicheck warning:
> ./tools/perf/util/metricgroup.c:382:3-4: Unneeded semicolon
>
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>

Acked-by: Namhyung Kim <namhyung@kernel.org>

Thanks,
Namhyung

> ---
>  tools/perf/util/metricgroup.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/perf/util/metricgroup.c b/tools/perf/util/metricgroup.c
> index e6d3452..26c990e 100644
> --- a/tools/perf/util/metricgroup.c
> +++ b/tools/perf/util/metricgroup.c
> @@ -379,7 +379,7 @@ static int metricgroup__setup_events(struct list_head *groups,
>                                 metric_refs[i].metric_expr = ref->metric_expr;
>                                 i++;
>                         }
> -               };
> +               }
>
>                 expr->metric_refs = metric_refs;
>                 expr->metric_expr = m->metric_expr;
> --
> 1.8.3.1
>

Re: [PATCH] perf metricgroup: remove unneeded semicolon

[Arnaldo Carvalho de Melo]

Em Tue, Feb 16, 2021 at 04:34:25PM +0900, Namhyung Kim escreveu:
> Hello,
> 
> On Mon, Feb 1, 2021 at 4:41 PM Yang Li <yang.lee@linux.alibaba.com> wrote:
> >
> > Eliminate the following coccicheck warning:
> > ./tools/perf/util/metricgroup.c:382:3-4: Unneeded semicolon
> >
> > Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> > Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
> 
> Acked-by: Namhyung Kim <namhyung@kernel.org>

Thanks, applied.

- Arnaldo

 
> Thanks,
> Namhyung
> 
> > ---
> >  tools/perf/util/metricgroup.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/tools/perf/util/metricgroup.c b/tools/perf/util/metricgroup.c
> > index e6d3452..26c990e 100644
> > --- a/tools/perf/util/metricgroup.c
> > +++ b/tools/perf/util/metricgroup.c
> > @@ -379,7 +379,7 @@ static int metricgroup__setup_events(struct list_head *groups,
> >                                 metric_refs[i].metric_expr = ref->metric_expr;
> >                                 i++;
> >                         }
> > -               };
> > +               }
> >
> >                 expr->metric_refs = metric_refs;
> >                 expr->metric_expr = m->metric_expr;
> > --
> > 1.8.3.1
> >

-- 

- Arnaldo