[PATCH v2] cryptodev: bump 1 commit past 1.11 to fix 5.9-rc1+

[PATCH v2] cryptodev: bump 1 commit past 1.11 to fix 5.9-rc1+

[Denys Dmytriyenko]

From: Denys Dmytriyenko <denys@ti.com>

There's one commit on top of 1.11 release that fixes builds against kernel 5.9-rc1+.

Signed-off-by: Denys Dmytriyenko <denys@ti.com>
---
v2 - append SRCPV to PV

 meta/recipes-kernel/cryptodev/cryptodev.inc | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/meta/recipes-kernel/cryptodev/cryptodev.inc b/meta/recipes-kernel/cryptodev/cryptodev.inc
index 906f4fc..027d636 100644
--- a/meta/recipes-kernel/cryptodev/cryptodev.inc
+++ b/meta/recipes-kernel/cryptodev/cryptodev.inc
@@ -5,7 +5,8 @@ LIC_FILES_CHKSUM = "file://COPYING;md5=b234ee4d69f5fce4486a80fdaf4a4263"
 
 SRC_URI = "git://github.com/cryptodev-linux/cryptodev-linux \
            "
-SRCREV = "2299d39475e91392abd050ea09f2d20feecb4adf"
+SRCREV = "fabe5989a3dc9fba0cd0a40b612247cdde351c01"
+PV .= "+git${SRCPV}"
 
 S = "${WORKDIR}/git"
 
-- 
2.7.4

Re: [OE-core] [PATCH v2] cryptodev: bump 1 commit past 1.11 to fix 5.9-rc1+

[Khem Raj]

On Wed, Sep 9, 2020 at 6:16 PM Denys Dmytriyenko <denis@denix.org> wrote:
>
> From: Denys Dmytriyenko <denys@ti.com>
>
> There's one commit on top of 1.11 release that fixes builds against kernel 5.9-rc1+.
>
> Signed-off-by: Denys Dmytriyenko <denys@ti.com>
> ---
> v2 - append SRCPV to PV
>
>  meta/recipes-kernel/cryptodev/cryptodev.inc | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/meta/recipes-kernel/cryptodev/cryptodev.inc b/meta/recipes-kernel/cryptodev/cryptodev.inc
> index 906f4fc..027d636 100644
> --- a/meta/recipes-kernel/cryptodev/cryptodev.inc
> +++ b/meta/recipes-kernel/cryptodev/cryptodev.inc
> @@ -5,7 +5,8 @@ LIC_FILES_CHKSUM = "file://COPYING;md5=b234ee4d69f5fce4486a80fdaf4a4263"
>
>  SRC_URI = "git://github.com/cryptodev-linux/cryptodev-linux \
>             "
> -SRCREV = "2299d39475e91392abd050ea09f2d20feecb4adf"
> +SRCREV = "fabe5989a3dc9fba0cd0a40b612247cdde351c01"
> +PV .= "+git${SRCPV}"

I just saw that this change does not go well with some of
meta-freescale changes which uses the inc file paired with PV, so
perhaps keeping the version at same PV
or creating a single patch is better.

now ends up with.

ERROR: ParseError at
/mnt/b/yoe/master/sources/meta-freescale/recipes-kernel/cryptodev/cryptodev-qoriq-tests_1.11.bb:2:
Could not include required file cryptodev-qoriq-1.11+git${SRCPV}.inc


>
>  S = "${WORKDIR}/git"
>
> --
> 2.7.4
>
> 

Re: [OE-core] [PATCH v2] cryptodev: bump 1 commit past 1.11 to fix 5.9-rc1+

[Denys Dmytriyenko]

On Thu, Sep 10, 2020 at 08:46:36AM -0700, Khem Raj wrote:
> On Wed, Sep 9, 2020 at 6:16 PM Denys Dmytriyenko <denis@denix.org> wrote:
> >
> > From: Denys Dmytriyenko <denys@ti.com>
> >
> > There's one commit on top of 1.11 release that fixes builds against kernel 5.9-rc1+.
> >
> > Signed-off-by: Denys Dmytriyenko <denys@ti.com>
> > ---
> > v2 - append SRCPV to PV
> >
> >  meta/recipes-kernel/cryptodev/cryptodev.inc | 3 ++-
> >  1 file changed, 2 insertions(+), 1 deletion(-)
> >
> > diff --git a/meta/recipes-kernel/cryptodev/cryptodev.inc b/meta/recipes-kernel/cryptodev/cryptodev.inc
> > index 906f4fc..027d636 100644
> > --- a/meta/recipes-kernel/cryptodev/cryptodev.inc
> > +++ b/meta/recipes-kernel/cryptodev/cryptodev.inc
> > @@ -5,7 +5,8 @@ LIC_FILES_CHKSUM = "file://COPYING;md5=b234ee4d69f5fce4486a80fdaf4a4263"
> >
> >  SRC_URI = "git://github.com/cryptodev-linux/cryptodev-linux \
> >             "
> > -SRCREV = "2299d39475e91392abd050ea09f2d20feecb4adf"
> > +SRCREV = "fabe5989a3dc9fba0cd0a40b612247cdde351c01"
> > +PV .= "+git${SRCPV}"
> 
> I just saw that this change does not go well with some of
> meta-freescale changes which uses the inc file paired with PV, so
> perhaps keeping the version at same PV
> or creating a single patch is better.

Well, it's unfortunate that it affects some downstream layers, but that never 
stopped changes in OE-Core before - as a maintainer of few downstream layers 
myself, I had to adapt to such changes in the past many-many times...

Anyway, alternative would be to use v1 of the patch.


> now ends up with.
> 
> ERROR: ParseError at
> /mnt/b/yoe/master/sources/meta-freescale/recipes-kernel/cryptodev/cryptodev-qoriq-tests_1.11.bb:2:
> Could not include required file cryptodev-qoriq-1.11+git${SRCPV}.inc
> 
> 
> >
> >  S = "${WORKDIR}/git"
> >
> > --
> > 2.7.4
> >
> > 
> 

Re: [OE-core] [PATCH v2] cryptodev: bump 1 commit past 1.11 to fix 5.9-rc1+

[Khem Raj]

On 9/10/20 12:55 PM, Denys Dmytriyenko wrote:
> On Thu, Sep 10, 2020 at 08:46:36AM -0700, Khem Raj wrote:
>> On Wed, Sep 9, 2020 at 6:16 PM Denys Dmytriyenko <denis@denix.org> wrote:
>>>
>>> From: Denys Dmytriyenko <denys@ti.com>
>>>
>>> There's one commit on top of 1.11 release that fixes builds against kernel 5.9-rc1+.
>>>
>>> Signed-off-by: Denys Dmytriyenko <denys@ti.com>
>>> ---
>>> v2 - append SRCPV to PV
>>>
>>>   meta/recipes-kernel/cryptodev/cryptodev.inc | 3 ++-
>>>   1 file changed, 2 insertions(+), 1 deletion(-)
>>>
>>> diff --git a/meta/recipes-kernel/cryptodev/cryptodev.inc b/meta/recipes-kernel/cryptodev/cryptodev.inc
>>> index 906f4fc..027d636 100644
>>> --- a/meta/recipes-kernel/cryptodev/cryptodev.inc
>>> +++ b/meta/recipes-kernel/cryptodev/cryptodev.inc
>>> @@ -5,7 +5,8 @@ LIC_FILES_CHKSUM = "file://COPYING;md5=b234ee4d69f5fce4486a80fdaf4a4263"
>>>
>>>   SRC_URI = "git://github.com/cryptodev-linux/cryptodev-linux \
>>>              "
>>> -SRCREV = "2299d39475e91392abd050ea09f2d20feecb4adf"
>>> +SRCREV = "fabe5989a3dc9fba0cd0a40b612247cdde351c01"
>>> +PV .= "+git${SRCPV}"
>>
>> I just saw that this change does not go well with some of
>> meta-freescale changes which uses the inc file paired with PV, so
>> perhaps keeping the version at same PV
>> or creating a single patch is better.
> 
> Well, it's unfortunate that it affects some downstream layers, but that never
> stopped changes in OE-Core before - as a maintainer of few downstream layers
> myself, I had to adapt to such changes in the past many-many times...
> 
> Anyway, alternative would be to use v1 of the patch.

Richard

yeah lets go with v1

> 
> 
>> now ends up with.
>>
>> ERROR: ParseError at
>> /mnt/b/yoe/master/sources/meta-freescale/recipes-kernel/cryptodev/cryptodev-qoriq-tests_1.11.bb:2:
>> Could not include required file cryptodev-qoriq-1.11+git${SRCPV}.inc
>>
>>
>>>
>>>   S = "${WORKDIR}/git"
>>>
>>> --
>>> 2.7.4
>>>
>>> 
>>