[PATCH] glibc: fix ldconfig packaging issue

[PATCH] glibc: fix ldconfig packaging issue

[liu.ming50]

From: Ming Liu <liu.ming50@gmail.com>

ldconfig should be prior to glibc-utils in PACKAGES variable, or else
ldconfig binary would not be split to its own package, hence will lead
to runtime issues for the packages that depending on ldconfig, like
systemd.

Signed-off-by: Ming Liu <liu.ming50@gmail.com>
---
 meta/recipes-core/glibc/glibc-package.inc | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/meta/recipes-core/glibc/glibc-package.inc b/meta/recipes-core/glibc/glibc-package.inc
index 9dd5a0d..ede9e9b 100644
--- a/meta/recipes-core/glibc/glibc-package.inc
+++ b/meta/recipes-core/glibc/glibc-package.inc
@@ -1,6 +1,6 @@
 INHIBIT_SYSROOT_STRIP = "1"
 
-PACKAGES = "${PN}-dbg catchsegv sln nscd ldd tzcode glibc-thread-db ${PN}-pic libcidn libmemusage libnss-db libsegfault ${PN}-pcprofile libsotruss ${PN} ${PN}-utils glibc-extra-nss ${PN}-dev ${PN}-staticdev ${PN}-doc ldconfig"
+PACKAGES = "${PN}-dbg catchsegv sln nscd ldconfig ldd tzcode glibc-thread-db ${PN}-pic libcidn libmemusage libnss-db libsegfault ${PN}-pcprofile libsotruss ${PN} ${PN}-utils glibc-extra-nss ${PN}-dev ${PN}-staticdev ${PN}-doc"
 
 # The ld.so in this glibc supports the GNU_HASH
 RPROVIDES_${PN} = "eglibc rtld(GNU_HASH)"
-- 
2.7.4

Re: [PATCH] glibc: fix ldconfig packaging issue

[Khem Raj]

On Tue, Dec 3, 2019 at 10:45 AM <liu.ming50@gmail.com> wrote:
>
> From: Ming Liu <liu.ming50@gmail.com>
>
> ldconfig should be prior to glibc-utils in PACKAGES variable, or else
> ldconfig binary would not be split to its own package, hence will lead
> to runtime issues for the packages that depending on ldconfig, like
> systemd.

hmmm perhaps FILES_ldconfig =+ would help ?

>
> Signed-off-by: Ming Liu <liu.ming50@gmail.com>
> ---
>  meta/recipes-core/glibc/glibc-package.inc | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/meta/recipes-core/glibc/glibc-package.inc b/meta/recipes-core/glibc/glibc-package.inc
> index 9dd5a0d..ede9e9b 100644
> --- a/meta/recipes-core/glibc/glibc-package.inc
> +++ b/meta/recipes-core/glibc/glibc-package.inc
> @@ -1,6 +1,6 @@
>  INHIBIT_SYSROOT_STRIP = "1"
>
> -PACKAGES = "${PN}-dbg catchsegv sln nscd ldd tzcode glibc-thread-db ${PN}-pic libcidn libmemusage libnss-db libsegfault ${PN}-pcprofile libsotruss ${PN} ${PN}-utils glibc-extra-nss ${PN}-dev ${PN}-staticdev ${PN}-doc ldconfig"
> +PACKAGES = "${PN}-dbg catchsegv sln nscd ldconfig ldd tzcode glibc-thread-db ${PN}-pic libcidn libmemusage libnss-db libsegfault ${PN}-pcprofile libsotruss ${PN} ${PN}-utils glibc-extra-nss ${PN}-dev ${PN}-staticdev ${PN}-doc"
>
>  # The ld.so in this glibc supports the GNU_HASH
>  RPROVIDES_${PN} = "eglibc rtld(GNU_HASH)"
> --
> 2.7.4
>
> --
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core

Re: [PATCH] glibc: fix ldconfig packaging issue

[Ming Liu]

[-- Attachment #1: Type: text/plain, Size: 2187 bytes --]

Hi, Khem:

I don't think so, the problem is the package names in PACKAGES are being
handled in package task in order, if ldconfig is after glibc-utils, and
they both contains /sbin (or /usr/sbin for usermerge) path, then
/sbin/ldconfig (or /usr/sbin/usermerge) would be split into glibc-utils.

It could be reproduced by enabling usermerge distro feature.

//Ming Liu

Khem Raj <raj.khem@gmail.com> 於 2019年12月3日 週二 下午9:16寫道：

> On Tue, Dec 3, 2019 at 10:45 AM <liu.ming50@gmail.com> wrote:
> >
> > From: Ming Liu <liu.ming50@gmail.com>
> >
> > ldconfig should be prior to glibc-utils in PACKAGES variable, or else
> > ldconfig binary would not be split to its own package, hence will lead
> > to runtime issues for the packages that depending on ldconfig, like
> > systemd.
>
> hmmm perhaps FILES_ldconfig =+ would help ?
>
> >
> > Signed-off-by: Ming Liu <liu.ming50@gmail.com>
> > ---
> >  meta/recipes-core/glibc/glibc-package.inc | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/meta/recipes-core/glibc/glibc-package.inc
> b/meta/recipes-core/glibc/glibc-package.inc
> > index 9dd5a0d..ede9e9b 100644
> > --- a/meta/recipes-core/glibc/glibc-package.inc
> > +++ b/meta/recipes-core/glibc/glibc-package.inc
> > @@ -1,6 +1,6 @@
> >  INHIBIT_SYSROOT_STRIP = "1"
> >
> > -PACKAGES = "${PN}-dbg catchsegv sln nscd ldd tzcode glibc-thread-db
> ${PN}-pic libcidn libmemusage libnss-db libsegfault ${PN}-pcprofile
> libsotruss ${PN} ${PN}-utils glibc-extra-nss ${PN}-dev ${PN}-staticdev
> ${PN}-doc ldconfig"
> > +PACKAGES = "${PN}-dbg catchsegv sln nscd ldconfig ldd tzcode
> glibc-thread-db ${PN}-pic libcidn libmemusage libnss-db libsegfault
> ${PN}-pcprofile libsotruss ${PN} ${PN}-utils glibc-extra-nss ${PN}-dev
> ${PN}-staticdev ${PN}-doc"
> >
> >  # The ld.so in this glibc supports the GNU_HASH
> >  RPROVIDES_${PN} = "eglibc rtld(GNU_HASH)"
> > --
> > 2.7.4
> >
> > --
> > _______________________________________________
> > Openembedded-core mailing list
> > Openembedded-core@lists.openembedded.org
> > http://lists.openembedded.org/mailman/listinfo/openembedded-core
>

[-- Attachment #2: Type: text/html, Size: 3108 bytes --]

Re: [PATCH] glibc: fix ldconfig packaging issue

[Khem Raj]

[-- Attachment #1: Type: text/plain, Size: 2424 bytes --]

On Tue, Dec 3, 2019 at 1:53 PM Ming Liu <liu.ming50@gmail.com> wrote:

> Hi, Khem:
>
> I don't think so, the problem is the package names in PACKAGES are being
> handled in package task in order, if ldconfig is after glibc-utils, and
> they both contains /sbin (or /usr/sbin for usermerge) path, then
> /sbin/ldconfig (or /usr/sbin/usermerge) would be split into glibc-utils.
>
> It could be reproduced by enabling usermerge distro feature.
>

Yes no worries I see that we are defining PACKAGES variable there so this
change is ok


> //Ming Liu
>
> Khem Raj <raj.khem@gmail.com> 於 2019年12月3日 週二 下午9:16寫道：
>
>> On Tue, Dec 3, 2019 at 10:45 AM <liu.ming50@gmail.com> wrote:
>> >
>> > From: Ming Liu <liu.ming50@gmail.com>
>> >
>> > ldconfig should be prior to glibc-utils in PACKAGES variable, or else
>> > ldconfig binary would not be split to its own package, hence will lead
>> > to runtime issues for the packages that depending on ldconfig, like
>> > systemd.
>>
>> hmmm perhaps FILES_ldconfig =+ would help ?
>>
>> >
>> > Signed-off-by: Ming Liu <liu.ming50@gmail.com>
>> > ---
>> >  meta/recipes-core/glibc/glibc-package.inc | 2 +-
>> >  1 file changed, 1 insertion(+), 1 deletion(-)
>> >
>> > diff --git a/meta/recipes-core/glibc/glibc-package.inc
>> b/meta/recipes-core/glibc/glibc-package.inc
>> > index 9dd5a0d..ede9e9b 100644
>> > --- a/meta/recipes-core/glibc/glibc-package.inc
>> > +++ b/meta/recipes-core/glibc/glibc-package.inc
>> > @@ -1,6 +1,6 @@
>> >  INHIBIT_SYSROOT_STRIP = "1"
>> >
>> > -PACKAGES = "${PN}-dbg catchsegv sln nscd ldd tzcode glibc-thread-db
>> ${PN}-pic libcidn libmemusage libnss-db libsegfault ${PN}-pcprofile
>> libsotruss ${PN} ${PN}-utils glibc-extra-nss ${PN}-dev ${PN}-staticdev
>> ${PN}-doc ldconfig"
>> > +PACKAGES = "${PN}-dbg catchsegv sln nscd ldconfig ldd tzcode
>> glibc-thread-db ${PN}-pic libcidn libmemusage libnss-db libsegfault
>> ${PN}-pcprofile libsotruss ${PN} ${PN}-utils glibc-extra-nss ${PN}-dev
>> ${PN}-staticdev ${PN}-doc"
>> >
>> >  # The ld.so in this glibc supports the GNU_HASH
>> >  RPROVIDES_${PN} = "eglibc rtld(GNU_HASH)"
>> > --
>> > 2.7.4
>> >
>> > --
>> > _______________________________________________
>> > Openembedded-core mailing list
>> > Openembedded-core@lists.openembedded.org
>> > http://lists.openembedded.org/mailman/listinfo/openembedded-core
>>
>

[-- Attachment #2: Type: text/html, Size: 3803 bytes --]