From: "Shilimkar, Santosh" <santosh.shilimkar@ti.com> To: Tony Lindgren <tony@atomide.com> Cc: Kevin Hilman <khilman@ti.com>, linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux@arm.linux.org.uk, rnayak@ti.com, Richard Woodruff <r-woodruff2@ti.com> Subject: Re: [PATCH 02/25] OMAP4: Redefine mandatory barriers for OMAP to include interconnect barriers. Date: Fri, 16 Sep 2011 17:31:53 +0530 [thread overview] Message-ID: <CAMQu2gxhDyQqLqt3C+97s0vy_r0P2umcrygN5ZaN=A8p0TV3xQ@mail.gmail.com> (raw) In-Reply-To: <CAMQu2gwv5y6PY_ooBjYuM497D=QuU54yWB+i6DRdn1YuuocY6Q@mail.gmail.com> On Fri, Sep 16, 2011 at 1:30 AM, Shilimkar, Santosh <santosh.shilimkar@ti.com> wrote: > On Fri, Sep 16, 2011 at 1:13 AM, Tony Lindgren <tony@atomide.com> wrote: >> * Shilimkar, Santosh <santosh.shilimkar@ti.com> [110915 10:49]: >>> On Thu, Sep 15, 2011 at 11:23 PM, Tony Lindgren <tony@atomide.com> wrote: >>> > >>> > Please also include the errata in the description and set it up with >>> > a Kconfig entry with something like ARM_ERRATA_XXXXXX or TI_ERRATA_XXXXXX. >>> > >>> Sure. >>> It's a TI ERRATA. >> >> OK >> >>> > Also it would be best to apply this fix at the end of the PM series so >>> > it is easier to verify the bug and potentially remove the hack if >>> > a better fix is ever available. >>> > >>> As such order doesn't matter much because it can be removed either way >>> even if it is in the beginning of the series with KCONFIG entry. >>> >>> But I can change the order if you prefer that way. >> >> Well it seems that it's the omap4_finish_suspend in this series that >> can be used to trigger the bug, although the bug has been around for >> few years. So then instead of mentioning random hangups you can have >> a better description with something like "Patch xyz added PM idle >> support for omap4, however bug 123 causes so and so. Fix the issue >> with blah blah". >> > Sounds good . > >> Also, if you have some easy way to reproduce the bug maybe mention >> that too? That would make it easy to verify if issue has been fixed. >> Just for record, Below are the errata details. ERRATA: i688: Async Bridge Corruption If a data is stalled inside asynchronous bridge because of backpressure, it may be accepted multiple times, creating pointer misalignment that will corrupt next transfers on that data path until next reset of the system (No recovery procedure once the issue is hit, the path remains consistently broken). Async bridge can be found on path between MPU to EMIF, MPU to L3 interconnect and Cortex M3 to Emif . This situation can happen only when the idle is initiated by a Master Request Disconnection (which is trigged by software whenexecuting WFI) WORKAROUND All the initiators connected through Async Bridge must ensure that data path is properly drained before issuing WFI. This condition will be met if one Strongly ordered access is performed to the target right before executing the WFI. > There are some multimedia usecases where the bug was discovered > but on mainline obviously we don't have that support. > > I will check with IP folks if any other simple test-case is possible > to reproduce the issue and If I find one, will mention that. > We have a GFX usecase which demonstrate this issue but can't be tested on mainline sicne no GFX support. But the same patch is already in the product line which has fixed the GFX usecase issue. Regards Santosh -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: santosh.shilimkar@ti.com (Shilimkar, Santosh) To: linux-arm-kernel@lists.infradead.org Subject: [PATCH 02/25] OMAP4: Redefine mandatory barriers for OMAP to include interconnect barriers. Date: Fri, 16 Sep 2011 17:31:53 +0530 [thread overview] Message-ID: <CAMQu2gxhDyQqLqt3C+97s0vy_r0P2umcrygN5ZaN=A8p0TV3xQ@mail.gmail.com> (raw) In-Reply-To: <CAMQu2gwv5y6PY_ooBjYuM497D=QuU54yWB+i6DRdn1YuuocY6Q@mail.gmail.com> On Fri, Sep 16, 2011 at 1:30 AM, Shilimkar, Santosh <santosh.shilimkar@ti.com> wrote: > On Fri, Sep 16, 2011 at 1:13 AM, Tony Lindgren <tony@atomide.com> wrote: >> * Shilimkar, Santosh <santosh.shilimkar@ti.com> [110915 10:49]: >>> On Thu, Sep 15, 2011 at 11:23 PM, Tony Lindgren <tony@atomide.com> wrote: >>> > >>> > Please also include the errata in the description and set it up with >>> > a Kconfig entry with something like ARM_ERRATA_XXXXXX or TI_ERRATA_XXXXXX. >>> > >>> Sure. >>> It's a ?TI ERRATA. >> >> OK >> >>> > Also it would be best to apply this fix at the end of the PM series so >>> > it is easier to verify the bug and potentially remove the hack if >>> > a better fix is ever available. >>> > >>> As such order doesn't matter much because it can be removed either way >>> even if it is in the beginning of the series with KCONFIG entry. >>> >>> But I can change the order if you prefer that way. >> >> Well it seems that it's the omap4_finish_suspend in this series that >> can be used to trigger the bug, although the bug has been around for >> few years. So then instead of mentioning random hangups you can have >> a better description with something like "Patch xyz added PM idle >> support for omap4, however bug 123 causes so and so. Fix the issue >> with blah blah". >> > Sounds good . > >> Also, if you have some easy way to reproduce the bug maybe mention >> that too? That would make it easy to verify if issue has been fixed. >> Just for record, Below are the errata details. ERRATA: i688: Async Bridge Corruption If a data is stalled inside asynchronous bridge because of backpressure, it may be accepted multiple times, creating pointer misalignment that will corrupt next transfers on that data path until next reset of the system (No recovery procedure once the issue is hit, the path remains consistently broken). Async bridge can be found on path between MPU to EMIF, MPU to L3 interconnect and Cortex M3 to Emif . This situation can happen only when the idle is initiated by a Master Request Disconnection (which is trigged by software whenexecuting WFI) WORKAROUND All the initiators connected through Async Bridge must ensure that data path is properly drained before issuing WFI. This condition will be met if one Strongly ordered access is performed to the target right before executing the WFI. > There are some multimedia usecases where the bug was discovered > but on mainline obviously we don't have that support. > > I will check with IP folks if any other simple test-case is possible > to reproduce the issue and If I find one, will mention that. > We have a GFX usecase which demonstrate this issue but can't be tested on mainline sicne no GFX support. But the same patch is already in the product line which has fixed the GFX usecase issue. Regards Santosh
next prev parent reply other threads:[~2011-09-16 12:02 UTC|newest] Thread overview: 238+ messages / expand[flat|nested] mbox.gz Atom feed top 2011-09-04 13:54 [PATCH 00/25] OMAP4: PM: suspend, CPU-hotplug and CPUilde support Santosh Shilimkar 2011-09-04 13:54 ` Santosh Shilimkar 2011-09-04 13:54 ` [PATCH 01/25] ARM: mm: Add strongly ordered descriptor support Santosh Shilimkar 2011-09-04 13:54 ` Santosh Shilimkar 2011-09-13 20:23 ` Tony Lindgren 2011-09-13 20:23 ` Tony Lindgren 2011-09-14 5:36 ` Shilimkar, Santosh 2011-09-14 5:36 ` Shilimkar, Santosh 2011-09-04 13:54 ` [PATCH 02/25] OMAP4: Redefine mandatory barriers for OMAP to include interconnect barriers Santosh Shilimkar 2011-09-04 13:54 ` Santosh Shilimkar 2011-09-13 20:27 ` Tony Lindgren 2011-09-13 20:27 ` Tony Lindgren 2011-09-14 5:39 ` Shilimkar, Santosh 2011-09-14 5:39 ` Shilimkar, Santosh 2011-09-14 10:24 ` Santosh 2011-09-14 10:24 ` Santosh 2011-09-15 17:17 ` Kevin Hilman 2011-09-15 17:17 ` Kevin Hilman 2011-09-15 17:24 ` Shilimkar, Santosh 2011-09-15 17:24 ` Shilimkar, Santosh 2011-09-15 17:53 ` Tony Lindgren 2011-09-15 17:53 ` Tony Lindgren 2011-09-15 18:22 ` Shilimkar, Santosh 2011-09-15 18:22 ` Shilimkar, Santosh 2011-09-15 19:43 ` Tony Lindgren 2011-09-15 19:43 ` Tony Lindgren 2011-09-15 20:00 ` Shilimkar, Santosh 2011-09-15 20:00 ` Shilimkar, Santosh 2011-09-16 12:01 ` Shilimkar, Santosh [this message] 2011-09-16 12:01 ` Shilimkar, Santosh 2011-09-04 13:54 ` [PATCH 03/25] OMAP4: PM: Use custom omap_do_wfi() for suspend and default idle Santosh Shilimkar 2011-09-04 13:54 ` Santosh Shilimkar 2011-09-04 13:54 ` [PATCH 04/25] OMAP4: Remove un-used do_wfi() macro Santosh Shilimkar 2011-09-04 13:54 ` Santosh Shilimkar 2011-09-04 13:54 ` [PATCH 05/25] OMAP4: Use WARN_ON() instead of BUG_ON() with graceful exit Santosh Shilimkar 2011-09-04 13:54 ` Santosh Shilimkar 2011-09-05 10:11 ` Sergei Shtylyov 2011-09-05 10:11 ` Sergei Shtylyov 2011-09-05 10:42 ` Santosh 2011-09-05 10:42 ` Santosh 2011-09-05 10:47 ` Russell King - ARM Linux 2011-09-05 10:47 ` Russell King - ARM Linux 2011-09-05 10:51 ` Santosh 2011-09-05 10:51 ` Santosh 2011-09-08 18:51 ` Jean Pihet 2011-09-08 18:51 ` Jean Pihet 2011-09-04 13:54 ` [PATCH 06/25] OMAP4: Export omap4_get_base*() rather than global address pointers Santosh Shilimkar 2011-09-04 13:54 ` Santosh Shilimkar 2011-09-04 13:54 ` [PATCH 07/25] OMAP4: PM: Add SAR RAM support Santosh Shilimkar 2011-09-04 13:54 ` Santosh Shilimkar 2011-09-04 13:54 ` [PATCH 08/25] OMAP4: PM: Keep static dep between MPUSS-EMIF and MPUSS-L3 and DUCATI-L3 Santosh Shilimkar 2011-09-04 13:54 ` Santosh Shilimkar 2011-09-08 18:06 ` Kevin Hilman 2011-09-08 18:06 ` Kevin Hilman 2011-09-09 4:21 ` Santosh 2011-09-09 4:21 ` Santosh 2011-09-04 13:54 ` [PATCH 09/25] OMAP4: PM: Avoid omap4_pm_init() on OMAP4430 ES1.0 Santosh Shilimkar 2011-09-04 13:54 ` Santosh Shilimkar 2011-09-04 13:54 ` [PATCH 10/25] OMAP4: PM: Initialise all the clockdomains to supported states Santosh Shilimkar 2011-09-04 13:54 ` Santosh Shilimkar 2011-09-04 13:54 ` [PATCH 11/25] OMAP: Add Secure HAL and monitor mode API infrastructure Santosh Shilimkar 2011-09-04 13:54 ` Santosh Shilimkar 2011-09-08 18:58 ` Jean Pihet 2011-09-08 18:58 ` Jean Pihet 2011-09-09 4:22 ` Santosh 2011-09-09 4:22 ` Santosh 2011-09-04 13:54 ` [PATCH 12/25] OMAP: Add support to allocate the memory for secure RAM Santosh Shilimkar 2011-09-04 13:54 ` Santosh Shilimkar 2011-09-08 19:19 ` Jean Pihet 2011-09-08 19:19 ` Jean Pihet 2011-09-09 9:43 ` Santosh 2011-09-09 9:43 ` Santosh 2011-09-09 12:54 ` Jean Pihet 2011-09-09 12:54 ` Jean Pihet 2011-09-09 14:09 ` Shilimkar, Santosh 2011-09-09 14:09 ` Shilimkar, Santosh 2011-09-04 13:54 ` [PATCH 13/25] OMAP4: PM: Add WakeupGen module as OMAP gic_arch_extn Santosh Shilimkar 2011-09-04 13:54 ` Santosh Shilimkar 2011-09-08 18:27 ` Kevin Hilman 2011-09-08 18:27 ` Kevin Hilman 2011-09-09 4:29 ` Santosh 2011-09-09 4:29 ` Santosh 2011-09-09 7:19 ` Thomas Gleixner 2011-09-09 7:19 ` Thomas Gleixner 2011-09-09 8:07 ` Santosh 2011-09-09 8:07 ` Santosh 2011-09-09 8:18 ` Thomas Gleixner 2011-09-09 8:18 ` Thomas Gleixner 2011-09-09 9:05 ` Santosh 2011-09-09 9:05 ` Santosh 2011-09-12 7:56 ` Thomas Gleixner 2011-09-12 7:56 ` Thomas Gleixner 2011-09-12 8:44 ` Santosh 2011-09-12 8:44 ` Santosh 2011-09-08 19:16 ` Jean Pihet 2011-09-08 19:16 ` Jean Pihet 2011-09-09 4:23 ` Santosh 2011-09-09 4:23 ` Santosh 2011-09-13 20:36 ` Tony Lindgren 2011-09-13 20:36 ` Tony Lindgren 2011-09-14 5:34 ` Shilimkar, Santosh 2011-09-14 5:34 ` Shilimkar, Santosh 2011-09-14 15:21 ` Tony Lindgren 2011-09-14 15:21 ` Tony Lindgren 2011-09-14 16:49 ` Santosh 2011-09-14 16:49 ` Santosh 2011-09-14 17:08 ` Tony Lindgren 2011-09-14 17:08 ` Tony Lindgren 2011-09-14 17:13 ` Santosh 2011-09-14 17:13 ` Santosh 2011-09-14 17:18 ` Tony Lindgren 2011-09-14 17:18 ` Tony Lindgren 2011-09-14 17:21 ` Santosh 2011-09-14 17:21 ` Santosh 2011-09-14 17:22 ` Santosh 2011-09-14 17:22 ` Santosh 2011-09-14 19:04 ` Tony Lindgren 2011-09-14 19:04 ` Tony Lindgren 2011-09-15 2:57 ` Santosh 2011-09-15 2:57 ` Santosh 2011-09-15 9:36 ` Cousson, Benoit 2011-09-15 9:36 ` Cousson, Benoit 2011-09-15 12:02 ` Shilimkar, Santosh 2011-09-15 12:02 ` Shilimkar, Santosh 2011-09-15 13:29 ` Woodruff, Richard 2011-09-15 13:29 ` Woodruff, Richard 2011-09-04 13:54 ` [PATCH 14/25] OMAP4: PM: Add CPUX OFF mode support Santosh Shilimkar 2011-09-04 13:54 ` Santosh Shilimkar 2011-09-08 19:39 ` Jean Pihet 2011-09-08 19:39 ` Jean Pihet 2011-09-09 9:59 ` Santosh 2011-09-09 9:59 ` Santosh 2011-09-09 8:04 ` Shawn Guo 2011-09-09 8:04 ` Shawn Guo 2011-09-09 8:09 ` Santosh 2011-09-09 8:09 ` Santosh 2011-09-09 14:13 ` Shawn Guo 2011-09-09 14:13 ` Shawn Guo 2011-09-09 14:11 ` Shilimkar, Santosh 2011-09-09 14:11 ` Shilimkar, Santosh 2011-09-09 15:27 ` Shawn Guo 2011-09-09 15:27 ` Shawn Guo 2011-09-09 16:59 ` Santosh 2011-09-09 16:59 ` Santosh 2011-09-09 18:34 ` Kevin Hilman 2011-09-09 18:34 ` Kevin Hilman 2011-09-10 3:39 ` Shilimkar, Santosh 2011-09-10 3:39 ` Shilimkar, Santosh 2011-09-09 23:34 ` Shawn Guo 2011-09-09 23:34 ` Shawn Guo 2011-09-10 3:38 ` Shilimkar, Santosh 2011-09-10 3:38 ` Shilimkar, Santosh 2011-09-10 4:54 ` Shawn Guo 2011-09-10 4:54 ` Shawn Guo 2011-09-10 5:51 ` Santosh 2011-09-10 5:51 ` Santosh 2011-09-12 21:06 ` Kevin Hilman 2011-09-12 21:06 ` Kevin Hilman 2011-09-13 5:39 ` Santosh 2011-09-13 5:39 ` Santosh 2011-09-13 17:33 ` Kevin Hilman 2011-09-13 17:33 ` Kevin Hilman 2011-09-14 5:26 ` Shilimkar, Santosh 2011-09-14 5:26 ` Shilimkar, Santosh 2011-09-04 13:54 ` [PATCH 15/25] OMAP4: Remove __INIT from omap_secondary_startup() to re-use it for hotplug Santosh Shilimkar 2011-09-04 13:54 ` Santosh Shilimkar 2011-09-04 13:54 ` [PATCH 16/25] OMAP4: PM: Program CPU1 to hit OFF when off-lined Santosh Shilimkar 2011-09-04 13:54 ` Santosh Shilimkar 2011-09-12 21:12 ` Kevin Hilman 2011-09-12 21:12 ` Kevin Hilman 2011-09-13 5:35 ` Santosh 2011-09-13 5:35 ` Santosh 2011-09-04 13:54 ` [PATCH 17/25] OMAP4: PM: CPU1 wakeup workaround from Low power modes Santosh Shilimkar 2011-09-04 13:54 ` Santosh Shilimkar 2011-09-04 13:54 ` [PATCH 18/25] OMAP4: suspend: Add MPUSS power domain RETENTION support Santosh Shilimkar 2011-09-04 13:54 ` Santosh Shilimkar 2011-09-15 0:27 ` Kevin Hilman 2011-09-15 0:27 ` Kevin Hilman 2011-09-15 3:19 ` Santosh 2011-09-15 3:19 ` Santosh 2011-09-04 13:54 ` [PATCH 19/25] OMAP4: PM: Add WakeupGen and secure GIC low power support Santosh Shilimkar 2011-09-04 13:54 ` Santosh Shilimkar 2011-09-04 13:54 ` [PATCH 20/25] OMAP4: PM: Add L2X0 cache lowpower support Santosh Shilimkar 2011-09-04 13:54 ` Santosh Shilimkar 2011-09-05 14:01 ` Lorenzo Pieralisi 2011-09-05 14:01 ` Lorenzo Pieralisi 2011-09-05 14:13 ` Santosh 2011-09-05 14:13 ` Santosh 2011-09-16 17:23 ` Kevin Hilman 2011-09-16 17:23 ` Kevin Hilman 2011-09-18 8:46 ` Santosh 2011-09-18 8:46 ` Santosh 2011-09-04 13:54 ` [PATCH 21/25] OMAP4: PM: Add MPUSS power domain OSWR support Santosh Shilimkar 2011-09-04 13:54 ` Santosh Shilimkar 2011-09-12 18:52 ` Kevin Hilman 2011-09-12 18:52 ` Kevin Hilman 2011-09-13 5:37 ` Santosh 2011-09-13 5:37 ` Santosh 2011-09-13 7:39 ` Jean Pihet 2011-09-13 7:39 ` Jean Pihet 2011-09-13 8:25 ` Santosh 2011-09-13 8:25 ` Santosh 2011-09-04 13:54 ` [PATCH 22/25] OMAP4: PM: Add power domain statistics support Santosh Shilimkar 2011-09-04 13:54 ` Santosh Shilimkar 2011-09-05 10:08 ` Sergei Shtylyov 2011-09-05 10:08 ` Sergei Shtylyov 2011-09-05 10:43 ` Santosh 2011-09-05 10:43 ` Santosh 2011-09-04 13:54 ` [PATCH 23/25] OMAP4: PM: Add CPUidle support Santosh Shilimkar 2011-09-04 13:54 ` Santosh Shilimkar 2011-09-16 17:45 ` Kevin Hilman 2011-09-16 17:45 ` Kevin Hilman 2011-09-18 8:47 ` Santosh 2011-09-18 8:47 ` Santosh 2011-09-04 13:54 ` [PATCH 24/25] OMAP4: cpuidle: Switch to gptimer from twd in deeper C-states Santosh Shilimkar 2011-09-04 13:54 ` Santosh Shilimkar 2011-09-16 17:51 ` Kevin Hilman 2011-09-16 17:51 ` Kevin Hilman 2011-09-18 8:48 ` Santosh 2011-09-18 8:48 ` Santosh 2011-09-04 13:54 ` [PATCH 25/25] OMAP3: CPUidle: Make use of CPU PM notifiers Santosh Shilimkar 2011-09-04 13:54 ` Santosh Shilimkar 2011-09-08 17:57 ` Kevin Hilman 2011-09-08 17:57 ` Kevin Hilman 2011-09-09 4:20 ` Santosh 2011-09-09 4:20 ` Santosh 2011-09-09 7:17 ` Santosh 2011-09-09 7:17 ` Santosh 2011-09-08 20:15 ` [PATCH 00/25] OMAP4: PM: suspend, CPU-hotplug and CPUilde support Jean Pihet 2011-09-08 20:15 ` Jean Pihet 2011-09-09 4:25 ` Santosh 2011-09-09 4:25 ` Santosh 2011-09-20 11:24 ` Vishwanath Sripathy 2011-09-20 11:24 ` Vishwanath Sripathy 2011-09-20 11:37 ` Santosh 2011-09-20 11:37 ` Santosh 2011-09-20 11:57 ` Santosh 2011-09-20 11:57 ` Santosh
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to='CAMQu2gxhDyQqLqt3C+97s0vy_r0P2umcrygN5ZaN=A8p0TV3xQ@mail.gmail.com' \ --to=santosh.shilimkar@ti.com \ --cc=khilman@ti.com \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-omap@vger.kernel.org \ --cc=linux@arm.linux.org.uk \ --cc=r-woodruff2@ti.com \ --cc=rnayak@ti.com \ --cc=tony@atomide.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.