Re: [PATCH v2 2/2] hwmon: ltc4282: add support for the LTC4282 chip

From: Bartosz Golaszewski <brgl@bgdev.pl>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: "Nuno Sá" <noname.nuno@gmail.com>,
	"Guenter Roeck" <linux@roeck-us.net>,
	"Andy Shevchenko" <andy@kernel.org>,
	nuno.sa@analog.com, linux-hwmon@vger.kernel.org,
	devicetree@vger.kernel.org, linux-doc@vger.kernel.org,
	"Jean Delvare" <jdelvare@suse.com>,
	"Rob Herring" <robh+dt@kernel.org>,
	"Krzysztof Kozlowski" <krzysztof.kozlowski+dt@linaro.org>,
	"Conor Dooley" <conor+dt@kernel.org>,
	"Jonathan Corbet" <corbet@lwn.net>
Subject: Re: [PATCH v2 2/2] hwmon: ltc4282: add support for the LTC4282 chip
Date: Mon, 4 Dec 2023 09:20:37 +0100	[thread overview]
Message-ID: <CAMRc=Mc9dbyNEdg2W9WdptjnuG_bFsBFXuimyU9gccqUVsqTxA@mail.gmail.com> (raw)
In-Reply-To: <CACRpkdYfe68aVNcnvfmLz8y3QOfsyA9vFHsaTL6Y9mZJ31wKRg@mail.gmail.com>

On Mon, Dec 4, 2023 at 12:09 AM Linus Walleij <linus.walleij@linaro.org> wrote:
>
> On Sat, Dec 2, 2023 at 10:42 AM Nuno Sá <noname.nuno@gmail.com> wrote:
>
>  Hopefully, I'll get into the gpio stuff later on. From a brief look,
> the auxiliary
> > bus might feet and easier than mfd.
>
> You can also just spawn a random platform_device from the HWMON driver
> and let that probe a driver down in drivers/gpio/*.
>

Please don't. A "random platform_device" even reads like a bad idea.
Conceptually the GPIO part is not a child but one of the modules. It
should be an MFD device IMO.

Bart

> static struct platform_device my_gpio_device = {
>         .name = "my-gpio",
>         .id = -1,
> };
>
> my_gpio_device.dev.platform_data = ... ;
> my_gpio_device.dev.parent = dev;
> return platform_device_register(&my_gpio_device);
>
> You can then pass any accessors as platform data. This in a way is what
> the MFD or aux buses do just more organized.
>
> Yours
> Linus Walleij