Re: [PATCH v2 1/2] dt-bindings: hwmon: Add LTC4282 bindings

From: "Nuno Sá" <noname.nuno@gmail.com>
To: Rob Herring <robh@kernel.org>, Nuno Sa <nuno.sa@analog.com>
Cc: linux-hwmon@vger.kernel.org, devicetree@vger.kernel.org,
	 linux-doc@vger.kernel.org, Jean Delvare <jdelvare@suse.com>,
	Guenter Roeck <linux@roeck-us.net>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	 Conor Dooley <conor+dt@kernel.org>,
	Jonathan Corbet <corbet@lwn.net>,
	Bartosz Golaszewski <brgl@bgdev.pl>,
	 Linus Walleij <linus.walleij@linaro.org>,
	Andy Shevchenko <andy@kernel.org>
Subject: Re: [PATCH v2 1/2] dt-bindings: hwmon: Add LTC4282 bindings
Date: Tue, 28 Nov 2023 16:49:43 +0100	[thread overview]
Message-ID: <e4147e797ee2a35092f4dbf9e8687fb63f7a8c5a.camel@gmail.com> (raw)
In-Reply-To: <20231128153733.GA3313427-robh@kernel.org>

On Tue, 2023-11-28 at 09:37 -0600, Rob Herring wrote:
> On Fri, Nov 24, 2023 at 03:18:16PM +0100, Nuno Sa wrote:
> > Add bindings for the LTC4282 High Current Hot Swap Controller with I2C
> > Compatible Monitoring.
> > 
> > Signed-off-by: Nuno Sa <nuno.sa@analog.com>
> > ---
> >  .../devicetree/bindings/hwmon/adi,ltc4282.yaml     | 206
> > +++++++++++++++++++++
> >  MAINTAINERS                                        |   6 +
> >  2 files changed, 212 insertions(+)
> > 
> > diff --git a/Documentation/devicetree/bindings/hwmon/adi,ltc4282.yaml
> > b/Documentation/devicetree/bindings/hwmon/adi,ltc4282.yaml
> > new file mode 100644
> > index 000000000000..6c979f70687e
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/hwmon/adi,ltc4282.yaml
> > @@ -0,0 +1,206 @@
> > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> > +%YAML 1.2
> > +---
> > +$id: http://devicetree.org/schemas/hwmon/adi,ltc4282.yaml#
> > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > +
> > +title: Analog Devices LTC4282 I2C High Current Hot Swap Controller over I2C
> > +
> > +maintainers:
> > +  - Nuno Sa <nuno.sa@analog.com>
> > +
> > +description: |
> > +  Analog Devices LTC4282 I2C High Current Hot Swap Controller over I2C.
> > +
> > + 
> > https://www.analog.com/media/en/technical-documentation/data-sheets/ltc4282.pdf
> > +
> > +properties:
> > +  compatible:
> > +    enum:
> > +      - adi,ltc4282
> > +
> > +  reg:
> > +    maxItems: 1
> > +
> > +  vdd-supply: true
> > +
> > +  clocks:
> > +    maxItems: 1
> > +
> > +  '#clock-cells':
> > +    const: 0
> > +
> > +  adi,rsense-nano-ohms:
> > +    description: Value of the sense resistor.
> > +
> > +  adi,vin-mode-microvolt:
> > +    description:
> > +      Selects operating range for the Undervoltage, Overvoltage and
> > Foldback
> > +      pins. Also for the ADC. Should be set to the nominal input voltage.
> > +    enum: [3300000, 5000000, 12000000, 24000000]
> > +    default: 12000000
> > +
> > +  adi,fet-bad-timeout-ms:
> > +    description:
> > +      From the moment a FET bad conditions is present, this property
> > selects the
> > +      wait time/timeout for a FET-bad fault to be signaled. Setting this to
> > 0,
> > +      disables FET bad faults to be reported.
> > +    default: 255
> > +    maximum: 255
> > +
> > +  adi,overvoltage-dividers:
> > +    description: |
> > +      Select which dividers to use for VDD Overvoltage detection. Note that
> > +      when the internal dividers are used the threshold is referenced to
> > VDD.
> > +      The percentages in the datasheet are misleading since the actual
> > values
> > +      to look for are in the "Absolute Maximum Ratings" table in the
> > +      "Comparator Inputs" section. In there there's a line for each of the
> > 5%,
> > +      10% and 15% settings with the actual min, typical and max tolerances.
> > +    $ref: /schemas/types.yaml#/definitions/string
> > +    enum: [external, vdd_5_percent, vdd_10_percent, vdd_15_percent]
> > +    default: 0
> 
> Default is an integer yet the type is a string?

Argh, another leftover from v1. Thanks for catching it... Will change it in v3.

- Nuno Sá
> 