All of lore.kernel.org
 help / color / mirror / Atom feed
From: Loic Poulain <loic.poulain@linaro.org>
To: Andy Gross <agross@kernel.org>,
	Bjorn Andersson <bjorn.andersson@linaro.org>,
	Ard Biesheuvel <ardb@kernel.org>
Cc: linux-arm-kernel@lists.infradead.org,
	Thara Gopinath <thara.gopinath@linaro.org>,
	linux-arm-msm@vger.kernel.org
Subject: Re: [PATCH] cpufreq: qcom-cpufreq-hw: Avoid stack buffer for IRQ name
Date: Mon, 20 Dec 2021 11:12:32 +0100	[thread overview]
Message-ID: <CAMZdPi9m_JJogxwT7k_0bzC9+gPxq9NHkuDF3T0HEj8EU-vd7w@mail.gmail.com> (raw)
In-Reply-To: <5bdf0bb1-150b-6b60-6f9d-86542b4d7695@linaro.org>

> On 9/1/21 4:47 AM, Ard Biesheuvel wrote:
> > Registering an IRQ requires the string buffer containing the name to
> > remain allocated, as the name is not copied into another buffer.
> >
> > So let's add a irq_name field to the data struct instead, which is
> > guaranteed to have the appropriate lifetime.
> >
> > Cc: Thara Gopinath <thara.gopinath@linaro.org>
> > Cc: Bjorn Andersson <bjorn.andersson@linaro.org>
> > Cc: Andy Gross <agross@kernel.org>
> > Cc: linux-arm-msm@vger.kernel.org
> > Signed-off-by: Ard Biesheuvel <ardb@kernel.org>
>
> Thanks for the fix.
>
> Reviewed-by: Thara Gopinath <thara.gopinath@linaro.org>

Seems this patch has been overlooked. Would it be possible to resubmit
it with a 'Fixes' tag?

Regards,
Loic

WARNING: multiple messages have this Message-ID (diff)
From: Loic Poulain <loic.poulain@linaro.org>
To: Andy Gross <agross@kernel.org>,
	Bjorn Andersson <bjorn.andersson@linaro.org>,
	 Ard Biesheuvel <ardb@kernel.org>
Cc: linux-arm-kernel@lists.infradead.org,
	 Thara Gopinath <thara.gopinath@linaro.org>,
	linux-arm-msm@vger.kernel.org
Subject: Re: [PATCH] cpufreq: qcom-cpufreq-hw: Avoid stack buffer for IRQ name
Date: Mon, 20 Dec 2021 11:12:32 +0100	[thread overview]
Message-ID: <CAMZdPi9m_JJogxwT7k_0bzC9+gPxq9NHkuDF3T0HEj8EU-vd7w@mail.gmail.com> (raw)
In-Reply-To: <5bdf0bb1-150b-6b60-6f9d-86542b4d7695@linaro.org>

> On 9/1/21 4:47 AM, Ard Biesheuvel wrote:
> > Registering an IRQ requires the string buffer containing the name to
> > remain allocated, as the name is not copied into another buffer.
> >
> > So let's add a irq_name field to the data struct instead, which is
> > guaranteed to have the appropriate lifetime.
> >
> > Cc: Thara Gopinath <thara.gopinath@linaro.org>
> > Cc: Bjorn Andersson <bjorn.andersson@linaro.org>
> > Cc: Andy Gross <agross@kernel.org>
> > Cc: linux-arm-msm@vger.kernel.org
> > Signed-off-by: Ard Biesheuvel <ardb@kernel.org>
>
> Thanks for the fix.
>
> Reviewed-by: Thara Gopinath <thara.gopinath@linaro.org>

Seems this patch has been overlooked. Would it be possible to resubmit
it with a 'Fixes' tag?

Regards,
Loic

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2021-12-20 10:01 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-01  8:47 [PATCH] cpufreq: qcom-cpufreq-hw: Avoid stack buffer for IRQ name Ard Biesheuvel
2021-09-01  8:47 ` Ard Biesheuvel
2021-09-01 10:59 ` Steev Klimaszewski
2021-09-01 10:59   ` Steev Klimaszewski
2021-09-01 19:22 ` Thara Gopinath
2021-09-01 19:22   ` Thara Gopinath
2021-12-20 10:12   ` Loic Poulain [this message]
2021-12-20 10:12     ` Loic Poulain
2021-12-20 23:43     ` Bjorn Andersson
2021-12-20 23:43       ` Bjorn Andersson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAMZdPi9m_JJogxwT7k_0bzC9+gPxq9NHkuDF3T0HEj8EU-vd7w@mail.gmail.com \
    --to=loic.poulain@linaro.org \
    --cc=agross@kernel.org \
    --cc=ardb@kernel.org \
    --cc=bjorn.andersson@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=thara.gopinath@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.