All of lore.kernel.org
 help / color / mirror / Atom feed
From: Muchun Song <songmuchun@bytedance.com>
To: Suren Baghdasaryan <surenb@google.com>
Cc: Tejun Heo <tj@kernel.org>, Johannes Weiner <hannes@cmpxchg.org>,
	Michal Hocko <mhocko@kernel.org>,
	Vladimir Davydov <vdavydov.dev@gmail.com>,
	Andrew Morton <akpm@linux-foundation.org>,
	Shakeel Butt <shakeelb@google.com>, Roman Gushchin <guro@fb.com>,
	Yang Shi <shy828301@gmail.com>, Alex Shi <alexs@kernel.org>,
	Wei Yang <richard.weiyang@gmail.com>,
	Vlastimil Babka <vbabka@suse.cz>, Jens Axboe <axboe@kernel.dk>,
	Joonsoo Kim <iamjoonsoo.kim@lge.com>,
	David Hildenbrand <david@redhat.com>,
	Matthew Wilcox <willy@infradead.org>,
	apopple@nvidia.com, Minchan Kim <minchan@kernel.org>,
	Miaohe Lin <linmiaohe@huawei.com>,
	LKML <linux-kernel@vger.kernel.org>,
	Cgroups <cgroups@vger.kernel.org>,
	Linux Memory Management List <linux-mm@kvack.org>,
	kernel-team@android.com
Subject: Re: [External] [PATCH v3 1/3] mm, memcg: add mem_cgroup_disabled checks in vmpressure and swap-related functions
Date: Sat, 10 Jul 2021 18:54:20 +0800	[thread overview]
Message-ID: <CAMZfGtWXKJ6_UxqA6su=1ZVc8geqEYoLzxP7xtoHDm_Qp5pQzA@mail.gmail.com> (raw)
In-Reply-To: <20210710003626.3549282-1-surenb@google.com>

On Sat, Jul 10, 2021 at 8:36 AM Suren Baghdasaryan <surenb@google.com> wrote:
>
> Add mem_cgroup_disabled check in vmpressure, mem_cgroup_uncharge_swap and
> cgroup_throttle_swaprate functions. This minimizes the memcg overhead in
> the pagefault and exit_mmap paths when memcgs are disabled using
> cgroup_disable=memory command-line option.
> This change results in ~2.1% overhead reduction when running PFT test
> comparing {CONFIG_MEMCG=n, CONFIG_MEMCG_SWAP=n} against {CONFIG_MEMCG=y,
> CONFIG_MEMCG_SWAP=y, cgroup_disable=memory} configuration on an 8-core
> ARM64 Android device.
>
> Signed-off-by: Suren Baghdasaryan <surenb@google.com>
> Reviewed-by: Shakeel Butt <shakeelb@google.com>
> Acked-by: Johannes Weiner <hannes@cmpxchg.org>

The changes are straightforward. LGTM.
Reviewed-by: Muchun Song <songmuchun@bytedance.com>

WARNING: multiple messages have this Message-ID (diff)
From: Muchun Song <songmuchun@bytedance.com>
To: Suren Baghdasaryan <surenb@google.com>
Cc: Tejun Heo <tj@kernel.org>, Johannes Weiner <hannes@cmpxchg.org>,
	Michal Hocko <mhocko@kernel.org>,
	Vladimir Davydov <vdavydov.dev@gmail.com>,
	Andrew Morton <akpm@linux-foundation.org>,
	Shakeel Butt <shakeelb@google.com>, Roman Gushchin <guro@fb.com>,
	Yang Shi <shy828301@gmail.com>, Alex Shi <alexs@kernel.org>,
	Wei Yang <richard.weiyang@gmail.com>,
	Vlastimil Babka <vbabka@suse.cz>, Jens Axboe <axboe@kernel.dk>,
	Joonsoo Kim <iamjoonsoo.kim@lge.com>,
	David Hildenbrand <david@redhat.com>,
	Matthew Wilcox <willy@infradead.org>,
	apopple@nvidia.com, Minchan Kim <minchan@kernel.org>,
	Miaohe Lin <linmiaohe@huawei.com>,
	LKML <linux-kernel@vger.kernel.org>,
	Cgroups <cgroups@vger.kernel.org>,
	Linux Memory Management List <linux-mm@kvack.org>,
	kernel-team@android.
Subject: Re: [External] [PATCH v3 1/3] mm, memcg: add mem_cgroup_disabled checks in vmpressure and swap-related functions
Date: Sat, 10 Jul 2021 18:54:20 +0800	[thread overview]
Message-ID: <CAMZfGtWXKJ6_UxqA6su=1ZVc8geqEYoLzxP7xtoHDm_Qp5pQzA@mail.gmail.com> (raw)
In-Reply-To: <20210710003626.3549282-1-surenb@google.com>

On Sat, Jul 10, 2021 at 8:36 AM Suren Baghdasaryan <surenb@google.com> wrote:
>
> Add mem_cgroup_disabled check in vmpressure, mem_cgroup_uncharge_swap and
> cgroup_throttle_swaprate functions. This minimizes the memcg overhead in
> the pagefault and exit_mmap paths when memcgs are disabled using
> cgroup_disable=memory command-line option.
> This change results in ~2.1% overhead reduction when running PFT test
> comparing {CONFIG_MEMCG=n, CONFIG_MEMCG_SWAP=n} against {CONFIG_MEMCG=y,
> CONFIG_MEMCG_SWAP=y, cgroup_disable=memory} configuration on an 8-core
> ARM64 Android device.
>
> Signed-off-by: Suren Baghdasaryan <surenb@google.com>
> Reviewed-by: Shakeel Butt <shakeelb@google.com>
> Acked-by: Johannes Weiner <hannes@cmpxchg.org>

The changes are straightforward. LGTM.
Reviewed-by: Muchun Song <songmuchun@bytedance.com>

  parent reply	other threads:[~2021-07-10 11:01 UTC|newest]

Thread overview: 50+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-10  0:36 [PATCH v3 1/3] mm, memcg: add mem_cgroup_disabled checks in vmpressure and swap-related functions Suren Baghdasaryan
2021-07-10  0:36 ` Suren Baghdasaryan
2021-07-10  0:36 ` Suren Baghdasaryan
2021-07-10  0:36 ` [PATCH v3 2/3] mm, memcg: inline mem_cgroup_{charge/uncharge} to improve disabled memcg config Suren Baghdasaryan
2021-07-10  0:36   ` Suren Baghdasaryan
2021-07-10 11:08   ` [External] " Muchun Song
2021-07-10 11:08     ` Muchun Song
2021-07-10 11:08     ` Muchun Song
2021-07-13  1:12     ` Suren Baghdasaryan
2021-07-13  1:12       ` Suren Baghdasaryan
2021-07-13  1:12       ` Suren Baghdasaryan
2021-07-12  7:15   ` Michal Hocko
2021-07-12  7:15     ` Michal Hocko
2021-07-12 15:55     ` Suren Baghdasaryan
2021-07-12 15:55       ` Suren Baghdasaryan
2021-07-12 15:55       ` Suren Baghdasaryan
2021-07-18 16:55   ` Matthew Wilcox
2021-07-18 16:55     ` Matthew Wilcox
2021-07-18 21:25     ` Suren Baghdasaryan
2021-07-18 21:25       ` Suren Baghdasaryan
2021-07-18 21:25       ` Suren Baghdasaryan
2021-07-18 21:29       ` Matthew Wilcox
2021-07-18 21:29         ` Matthew Wilcox
2021-07-18 21:32         ` Suren Baghdasaryan
2021-07-18 21:32           ` Suren Baghdasaryan
2021-07-18 21:32           ` Suren Baghdasaryan
2021-07-10  0:36 ` [PATCH v3 3/3] mm, memcg: inline swap-related functions " Suren Baghdasaryan
2021-07-10  0:36   ` Suren Baghdasaryan
2021-07-10  0:36   ` Suren Baghdasaryan
2021-07-10 11:19   ` [External] " Muchun Song
2021-07-10 11:19     ` Muchun Song
2021-07-10 11:19     ` Muchun Song
2021-07-12  7:17   ` Michal Hocko
2021-07-12  7:17     ` Michal Hocko
2021-07-12 15:57     ` Suren Baghdasaryan
2021-07-12 15:57       ` Suren Baghdasaryan
2021-07-10  1:52 ` [PATCH v3 1/3] mm, memcg: add mem_cgroup_disabled checks in vmpressure and swap-related functions Miaohe Lin
2021-07-10  1:52   ` Miaohe Lin
2021-07-10  2:40   ` Suren Baghdasaryan
2021-07-10  2:40     ` Suren Baghdasaryan
2021-07-10  3:37     ` Miaohe Lin
2021-07-10  3:37       ` Miaohe Lin
2021-07-10 10:54 ` Muchun Song [this message]
2021-07-10 10:54   ` [External] " Muchun Song
2021-07-10 10:54   ` Muchun Song
2021-07-12  7:11 ` Michal Hocko
2021-07-12  7:11   ` Michal Hocko
2021-07-12 15:55   ` Suren Baghdasaryan
2021-07-12 15:55     ` Suren Baghdasaryan
2021-07-12 15:55     ` Suren Baghdasaryan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAMZfGtWXKJ6_UxqA6su=1ZVc8geqEYoLzxP7xtoHDm_Qp5pQzA@mail.gmail.com' \
    --to=songmuchun@bytedance.com \
    --cc=akpm@linux-foundation.org \
    --cc=alexs@kernel.org \
    --cc=apopple@nvidia.com \
    --cc=axboe@kernel.dk \
    --cc=cgroups@vger.kernel.org \
    --cc=david@redhat.com \
    --cc=guro@fb.com \
    --cc=hannes@cmpxchg.org \
    --cc=iamjoonsoo.kim@lge.com \
    --cc=kernel-team@android.com \
    --cc=linmiaohe@huawei.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=mhocko@kernel.org \
    --cc=minchan@kernel.org \
    --cc=richard.weiyang@gmail.com \
    --cc=shakeelb@google.com \
    --cc=shy828301@gmail.com \
    --cc=surenb@google.com \
    --cc=tj@kernel.org \
    --cc=vbabka@suse.cz \
    --cc=vdavydov.dev@gmail.com \
    --cc=willy@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.