From: Matthew Wilcox <willy@infradead.org>
To: Suren Baghdasaryan <surenb@google.com>
Cc: tj@kernel.org, hannes@cmpxchg.org, mhocko@kernel.org,
vdavydov.dev@gmail.com, akpm@linux-foundation.org,
shakeelb@google.com, guro@fb.com, songmuchun@bytedance.com,
shy828301@gmail.com, alexs@kernel.org, richard.weiyang@gmail.com,
vbabka@suse.cz, axboe@kernel.dk, iamjoonsoo.kim@lge.com,
david@redhat.com, apopple@nvidia.com, minchan@kernel.org,
linmiaohe@huawei.com, linux-kernel@vger.kernel.org,
cgroups@vger.kernel.org, linux-mm@kvack.org,
kernel-team@android.com
Subject: Re: [PATCH v3 2/3] mm, memcg: inline mem_cgroup_{charge/uncharge} to improve disabled memcg config
Date: Sun, 18 Jul 2021 17:55:59 +0100 [thread overview]
Message-ID: <YPRdH56+dOFs/Ypu@casper.infradead.org> (raw)
In-Reply-To: <20210710003626.3549282-2-surenb@google.com>
On Fri, Jul 09, 2021 at 05:36:25PM -0700, Suren Baghdasaryan wrote:
> @@ -6723,7 +6722,7 @@ static int __mem_cgroup_charge(struct page *page, struct mem_cgroup *memcg,
> }
>
> /**
> - * mem_cgroup_charge - charge a newly allocated page to a cgroup
> + * __mem_cgroup_charge - charge a newly allocated page to a cgroup
> * @page: page to charge
> * @mm: mm context of the victim
> * @gfp_mask: reclaim mode
This patch conflicts with the folio work, so I'm just rebasing the
folio patches on top of this, and I think this part of the patch is a
mistake. We don't want to document the __mem_cgroup_charge() function.
That's an implementation detail. This patch should instead have moved the
kernel-doc to memcontrol.h and continued to document mem_cgroup_charge().
WARNING: multiple messages have this Message-ID (diff)
From: Matthew Wilcox <willy-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org>
To: Suren Baghdasaryan <surenb-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>
Cc: tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org,
hannes-druUgvl0LCNAfugRpC6u6w@public.gmane.org,
mhocko-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org,
vdavydov.dev-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org,
akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org,
shakeelb-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org,
guro-b10kYP2dOMg@public.gmane.org,
songmuchun-EC8Uxl6Npydl57MIdRCFDg@public.gmane.org,
shy828301-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org,
alexs-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org,
richard.weiyang-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org,
vbabka-AlSwsSmVLrQ@public.gmane.org,
axboe-tSWWG44O7X1aa/9Udqfwiw@public.gmane.org,
iamjoonsoo.kim-Hm3cg6mZ9cc@public.gmane.org,
david-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org,
apopple-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org,
minchan-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org,
linmiaohe-hv44wF8Li93QT0dZR+AlfA@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-mm-Bw31MaZKKs3YtjvyW6yDsg@public.gmane.org,
kernel-team-z5hGa2qSFaRBDgjK7y7TUQ@public.gmane.org
Subject: Re: [PATCH v3 2/3] mm, memcg: inline mem_cgroup_{charge/uncharge} to improve disabled memcg config
Date: Sun, 18 Jul 2021 17:55:59 +0100 [thread overview]
Message-ID: <YPRdH56+dOFs/Ypu@casper.infradead.org> (raw)
In-Reply-To: <20210710003626.3549282-2-surenb-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>
On Fri, Jul 09, 2021 at 05:36:25PM -0700, Suren Baghdasaryan wrote:
> @@ -6723,7 +6722,7 @@ static int __mem_cgroup_charge(struct page *page, struct mem_cgroup *memcg,
> }
>
> /**
> - * mem_cgroup_charge - charge a newly allocated page to a cgroup
> + * __mem_cgroup_charge - charge a newly allocated page to a cgroup
> * @page: page to charge
> * @mm: mm context of the victim
> * @gfp_mask: reclaim mode
This patch conflicts with the folio work, so I'm just rebasing the
folio patches on top of this, and I think this part of the patch is a
mistake. We don't want to document the __mem_cgroup_charge() function.
That's an implementation detail. This patch should instead have moved the
kernel-doc to memcontrol.h and continued to document mem_cgroup_charge().
next prev parent reply other threads:[~2021-07-18 16:57 UTC|newest]
Thread overview: 50+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-10 0:36 [PATCH v3 1/3] mm, memcg: add mem_cgroup_disabled checks in vmpressure and swap-related functions Suren Baghdasaryan
2021-07-10 0:36 ` Suren Baghdasaryan
2021-07-10 0:36 ` Suren Baghdasaryan
2021-07-10 0:36 ` [PATCH v3 2/3] mm, memcg: inline mem_cgroup_{charge/uncharge} to improve disabled memcg config Suren Baghdasaryan
2021-07-10 0:36 ` Suren Baghdasaryan
2021-07-10 11:08 ` [External] " Muchun Song
2021-07-10 11:08 ` Muchun Song
2021-07-10 11:08 ` Muchun Song
2021-07-13 1:12 ` Suren Baghdasaryan
2021-07-13 1:12 ` Suren Baghdasaryan
2021-07-13 1:12 ` Suren Baghdasaryan
2021-07-12 7:15 ` Michal Hocko
2021-07-12 7:15 ` Michal Hocko
2021-07-12 15:55 ` Suren Baghdasaryan
2021-07-12 15:55 ` Suren Baghdasaryan
2021-07-12 15:55 ` Suren Baghdasaryan
2021-07-18 16:55 ` Matthew Wilcox [this message]
2021-07-18 16:55 ` Matthew Wilcox
2021-07-18 21:25 ` Suren Baghdasaryan
2021-07-18 21:25 ` Suren Baghdasaryan
2021-07-18 21:25 ` Suren Baghdasaryan
2021-07-18 21:29 ` Matthew Wilcox
2021-07-18 21:29 ` Matthew Wilcox
2021-07-18 21:32 ` Suren Baghdasaryan
2021-07-18 21:32 ` Suren Baghdasaryan
2021-07-18 21:32 ` Suren Baghdasaryan
2021-07-10 0:36 ` [PATCH v3 3/3] mm, memcg: inline swap-related functions " Suren Baghdasaryan
2021-07-10 0:36 ` Suren Baghdasaryan
2021-07-10 0:36 ` Suren Baghdasaryan
2021-07-10 11:19 ` [External] " Muchun Song
2021-07-10 11:19 ` Muchun Song
2021-07-10 11:19 ` Muchun Song
2021-07-12 7:17 ` Michal Hocko
2021-07-12 7:17 ` Michal Hocko
2021-07-12 15:57 ` Suren Baghdasaryan
2021-07-12 15:57 ` Suren Baghdasaryan
2021-07-10 1:52 ` [PATCH v3 1/3] mm, memcg: add mem_cgroup_disabled checks in vmpressure and swap-related functions Miaohe Lin
2021-07-10 1:52 ` Miaohe Lin
2021-07-10 2:40 ` Suren Baghdasaryan
2021-07-10 2:40 ` Suren Baghdasaryan
2021-07-10 3:37 ` Miaohe Lin
2021-07-10 3:37 ` Miaohe Lin
2021-07-10 10:54 ` [External] " Muchun Song
2021-07-10 10:54 ` Muchun Song
2021-07-10 10:54 ` Muchun Song
2021-07-12 7:11 ` Michal Hocko
2021-07-12 7:11 ` Michal Hocko
2021-07-12 15:55 ` Suren Baghdasaryan
2021-07-12 15:55 ` Suren Baghdasaryan
2021-07-12 15:55 ` Suren Baghdasaryan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YPRdH56+dOFs/Ypu@casper.infradead.org \
--to=willy@infradead.org \
--cc=akpm@linux-foundation.org \
--cc=alexs@kernel.org \
--cc=apopple@nvidia.com \
--cc=axboe@kernel.dk \
--cc=cgroups@vger.kernel.org \
--cc=david@redhat.com \
--cc=guro@fb.com \
--cc=hannes@cmpxchg.org \
--cc=iamjoonsoo.kim@lge.com \
--cc=kernel-team@android.com \
--cc=linmiaohe@huawei.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@kernel.org \
--cc=minchan@kernel.org \
--cc=richard.weiyang@gmail.com \
--cc=shakeelb@google.com \
--cc=shy828301@gmail.com \
--cc=songmuchun@bytedance.com \
--cc=surenb@google.com \
--cc=tj@kernel.org \
--cc=vbabka@suse.cz \
--cc=vdavydov.dev@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.