* [PATCH] net: bridge: br_set_ageing_time takes a clock_t
@ 2016-07-21 16:42 Vivien Didelot
2016-07-21 16:58 ` Cong Wang
2016-07-25 17:31 ` David Miller
0 siblings, 2 replies; 5+ messages in thread
From: Vivien Didelot @ 2016-07-21 16:42 UTC (permalink / raw)
To: netdev
Cc: linux-kernel, kernel, David S. Miller, Stephen Hemminger, Vivien Didelot
Change the ageing_time type in br_set_ageing_time() from u32 to what it
is expected to be, i.e. a clock_t.
Signed-off-by: Vivien Didelot <vivien.didelot@savoirfairelinux.com>
---
net/bridge/br_private.h | 2 +-
net/bridge/br_stp.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/net/bridge/br_private.h b/net/bridge/br_private.h
index 52edecf..b12447e 100644
--- a/net/bridge/br_private.h
+++ b/net/bridge/br_private.h
@@ -942,7 +942,7 @@ void __br_set_forward_delay(struct net_bridge *br, unsigned long t);
int br_set_forward_delay(struct net_bridge *br, unsigned long x);
int br_set_hello_time(struct net_bridge *br, unsigned long x);
int br_set_max_age(struct net_bridge *br, unsigned long x);
-int br_set_ageing_time(struct net_bridge *br, u32 ageing_time);
+int br_set_ageing_time(struct net_bridge *br, clock_t ageing_time);
/* br_stp_if.c */
diff --git a/net/bridge/br_stp.c b/net/bridge/br_stp.c
index 9cb7044..9258b8e 100644
--- a/net/bridge/br_stp.c
+++ b/net/bridge/br_stp.c
@@ -570,7 +570,7 @@ int br_set_max_age(struct net_bridge *br, unsigned long val)
*
* Offloaded switch entries maybe more restrictive
*/
-int br_set_ageing_time(struct net_bridge *br, u32 ageing_time)
+int br_set_ageing_time(struct net_bridge *br, clock_t ageing_time)
{
struct switchdev_attr attr = {
.orig_dev = br->dev,
--
2.9.0
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] net: bridge: br_set_ageing_time takes a clock_t
2016-07-21 16:42 [PATCH] net: bridge: br_set_ageing_time takes a clock_t Vivien Didelot
@ 2016-07-21 16:58 ` Cong Wang
2016-07-21 18:18 ` Vivien Didelot
2016-07-25 17:31 ` David Miller
1 sibling, 1 reply; 5+ messages in thread
From: Cong Wang @ 2016-07-21 16:58 UTC (permalink / raw)
To: Vivien Didelot
Cc: Linux Kernel Network Developers, LKML, kernel, David S. Miller,
Stephen Hemminger
On Thu, Jul 21, 2016 at 9:42 AM, Vivien Didelot
<vivien.didelot@savoirfairelinux.com> wrote:
> Change the ageing_time type in br_set_ageing_time() from u32 to what it
> is expected to be, i.e. a clock_t.
You also need to change struct switchdev_attr:
struct switchdev_attr {
struct net_device *orig_dev;
enum switchdev_attr_id id;
u32 flags;
void *complete_priv;
void (*complete)(struct net_device *dev, int err, void *priv);
union {
struct netdev_phys_item_id ppid; /* PORT_PARENT_ID */
u8 stp_state; /* PORT_STP_STATE */
unsigned long brport_flags; /* PORT_BRIDGE_FLAGS */
u32 ageing_time; /* BRIDGE_AGEING_TIME */
bool vlan_filtering; /*
BRIDGE_VLAN_FILTERING */
} u;
};
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] net: bridge: br_set_ageing_time takes a clock_t
2016-07-21 16:58 ` Cong Wang
@ 2016-07-21 18:18 ` Vivien Didelot
2016-07-21 18:27 ` Cong Wang
0 siblings, 1 reply; 5+ messages in thread
From: Vivien Didelot @ 2016-07-21 18:18 UTC (permalink / raw)
To: Cong Wang
Cc: Linux Kernel Network Developers, LKML, kernel, David S. Miller,
Stephen Hemminger
Hi Cong,
Cong Wang <xiyou.wangcong@gmail.com> writes:
> On Thu, Jul 21, 2016 at 9:42 AM, Vivien Didelot
> <vivien.didelot@savoirfairelinux.com> wrote:
>> Change the ageing_time type in br_set_ageing_time() from u32 to what it
>> is expected to be, i.e. a clock_t.
>
> You also need to change struct switchdev_attr:
>
> struct switchdev_attr {
> struct net_device *orig_dev;
> enum switchdev_attr_id id;
> u32 flags;
> void *complete_priv;
> void (*complete)(struct net_device *dev, int err, void *priv);
> union {
> struct netdev_phys_item_id ppid; /* PORT_PARENT_ID */
> u8 stp_state; /* PORT_STP_STATE */
> unsigned long brport_flags; /* PORT_BRIDGE_FLAGS */
> u32 ageing_time; /* BRIDGE_AGEING_TIME */
> bool vlan_filtering; /*
> BRIDGE_VLAN_FILTERING */
> } u;
> };
Already changed in net/master as of eabfdda93477
("net: switchdev: change ageing_time type to clock_t").
Thanks,
Vivien
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] net: bridge: br_set_ageing_time takes a clock_t
2016-07-21 18:18 ` Vivien Didelot
@ 2016-07-21 18:27 ` Cong Wang
0 siblings, 0 replies; 5+ messages in thread
From: Cong Wang @ 2016-07-21 18:27 UTC (permalink / raw)
To: Vivien Didelot
Cc: Linux Kernel Network Developers, LKML, kernel, David S. Miller,
Stephen Hemminger
On Thu, Jul 21, 2016 at 11:18 AM, Vivien Didelot
<vivien.didelot@savoirfairelinux.com> wrote:
> Hi Cong,
>
> Cong Wang <xiyou.wangcong@gmail.com> writes:
>
>> On Thu, Jul 21, 2016 at 9:42 AM, Vivien Didelot
>> <vivien.didelot@savoirfairelinux.com> wrote:
>>> Change the ageing_time type in br_set_ageing_time() from u32 to what it
>>> is expected to be, i.e. a clock_t.
>>
>> You also need to change struct switchdev_attr:
>>
>> struct switchdev_attr {
>> struct net_device *orig_dev;
>> enum switchdev_attr_id id;
>> u32 flags;
>> void *complete_priv;
>> void (*complete)(struct net_device *dev, int err, void *priv);
>> union {
>> struct netdev_phys_item_id ppid; /* PORT_PARENT_ID */
>> u8 stp_state; /* PORT_STP_STATE */
>> unsigned long brport_flags; /* PORT_BRIDGE_FLAGS */
>> u32 ageing_time; /* BRIDGE_AGEING_TIME */
>> bool vlan_filtering; /*
>> BRIDGE_VLAN_FILTERING */
>> } u;
>> };
>
> Already changed in net/master as of eabfdda93477
> ("net: switchdev: change ageing_time type to clock_t").
Oh, your are right, sorry I was on net-next.
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] net: bridge: br_set_ageing_time takes a clock_t
2016-07-21 16:42 [PATCH] net: bridge: br_set_ageing_time takes a clock_t Vivien Didelot
2016-07-21 16:58 ` Cong Wang
@ 2016-07-25 17:31 ` David Miller
1 sibling, 0 replies; 5+ messages in thread
From: David Miller @ 2016-07-25 17:31 UTC (permalink / raw)
To: vivien.didelot; +Cc: netdev, linux-kernel, kernel, stephen
From: Vivien Didelot <vivien.didelot@savoirfairelinux.com>
Date: Thu, 21 Jul 2016 12:42:19 -0400
> Change the ageing_time type in br_set_ageing_time() from u32 to what it
> is expected to be, i.e. a clock_t.
>
> Signed-off-by: Vivien Didelot <vivien.didelot@savoirfairelinux.com>
Applied.
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2016-07-25 17:31 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-07-21 16:42 [PATCH] net: bridge: br_set_ageing_time takes a clock_t Vivien Didelot
2016-07-21 16:58 ` Cong Wang
2016-07-21 18:18 ` Vivien Didelot
2016-07-21 18:27 ` Cong Wang
2016-07-25 17:31 ` David Miller
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.