From: Ard Biesheuvel <ardb@kernel.org> To: Rob Herring <robh+dt@kernel.org> Cc: Alexandre TORGUE <alexandre.torgue@foss.st.com>, Quentin Perret <qperret@google.com>, Greg Kroah-Hartman <gregkh@linuxfoundation.org>, Sasha Levin <sashal@kernel.org>, stable <stable@vger.kernel.org>, Arnd Bergmann <arnd@arndb.de>, "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" <devicetree@vger.kernel.org>, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>, Nicolas Boichat <drinkcat@chromium.org>, Stephen Boyd <swboyd@chromium.org>, Florian Fainelli <f.fainelli@gmail.com>, KarimAllah Ahmed <karahmed@amazon.de>, Android Kernel Team <kernel-team@android.com>, Architecture Mailman List <boot-architecture@lists.linaro.org>, Frank Rowand <frowand.list@gmail.com>, linux-arm-kernel <linux-arm-kernel@lists.infradead.org> Subject: Re: [v5.4 stable] arm: stm32: Regression observed on "no-map" reserved memory region Date: Tue, 20 Apr 2021 18:10:27 +0200 [thread overview] Message-ID: <CAMj1kXE2Mgr9CsAMnKXff+96xhDaE5OLeNhypHvpN815vZGZhQ@mail.gmail.com> (raw) In-Reply-To: <CAL_Jsq+LUPZFhXd+j-xM67rZB=pvEvZM+1sfckip0Lqq02PkZQ@mail.gmail.com> On Tue, 20 Apr 2021 at 17:54, Rob Herring <robh+dt@kernel.org> wrote: > > On Tue, Apr 20, 2021 at 10:12 AM Alexandre TORGUE > <alexandre.torgue@foss.st.com> wrote: > > > > > > > > On 4/20/21 4:45 PM, Rob Herring wrote: > > > On Tue, Apr 20, 2021 at 9:03 AM Alexandre TORGUE > > > <alexandre.torgue@foss.st.com> wrote: > > >> > > >> Hi, > > > > > > Greg or Sasha won't know what to do with this. Not sure who follows > > > the stable list either. Quentin sent the patch, but is not the author. > > > Given the patch in question is about consistency between EFI memory > > > map boot and DT memory map boot, copying EFI knowledgeable folks would > > > help (Ard B for starters). > > > > Ok thanks for the tips. I add Ard in the loop. > > Sigh. If it was only Ard I was suggesting I would have done that > myself. Now everyone on the patch in question and relevant lists are > Cc'ed. > Thanks for the cc. > > > > Ard, let me know if other people have to be directly added or if I have > > to resend to another mailing list. > > > > thanks > > alex > > > > > > > >> > > >> Since v5.4.102 I observe a regression on stm32mp1 platform: "no-map" > > >> reserved-memory regions are no more "reserved" and make part of the > > >> kernel System RAM. This causes allocation failure for devices which try > > >> to take a reserved-memory region. > > >> > > >> It has been introduced by the following path: > > >> > > >> "fdt: Properly handle "no-map" field in the memory region > > >> [ Upstream commit 86588296acbfb1591e92ba60221e95677ecadb43 ]" > > >> which replace memblock_remove by memblock_mark_nomap in no-map case. > > >> Why was this backported? It doesn't look like a bugfix to me. > > >> Reverting this patch it's fine. > > >> > > >> I add part of my DT (something is maybe wrong inside): > > >> > > >> memory@c0000000 { > > >> reg = <0xc0000000 0x20000000>; > > >> }; > > >> > > >> reserved-memory { > > >> #address-cells = <1>; > > >> #size-cells = <1>; > > >> ranges; > > >> > > >> gpu_reserved: gpu@d4000000 { > > >> reg = <0xd4000000 0x4000000>; > > >> no-map; > > >> }; > > >> }; > > >> > > >> Sorry if this issue has already been raised and discussed. > > >> Could you explain why it fails? The region is clearly part of system memory, and tagged as no-map, so the patch in itself is not unreasonable. However, we obviously have code that relies on how the region is represented in /proc/iomem, so it would be helpful to get some insight into why this is the case. In any case, the mere fact that this causes a regression should be sufficient justification to revert/withdraw it from v5.4, as I don't see a reason why it was merged there in the first place. (It has no fixes tag or cc:stable)
WARNING: multiple messages have this Message-ID (diff)
From: Ard Biesheuvel <ardb@kernel.org> To: Rob Herring <robh+dt@kernel.org> Cc: Alexandre TORGUE <alexandre.torgue@foss.st.com>, Quentin Perret <qperret@google.com>, Greg Kroah-Hartman <gregkh@linuxfoundation.org>, Sasha Levin <sashal@kernel.org>, stable <stable@vger.kernel.org>, Arnd Bergmann <arnd@arndb.de>, "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" <devicetree@vger.kernel.org>, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>, Nicolas Boichat <drinkcat@chromium.org>, Stephen Boyd <swboyd@chromium.org>, Florian Fainelli <f.fainelli@gmail.com>, KarimAllah Ahmed <karahmed@amazon.de>, Android Kernel Team <kernel-team@android.com>, Architecture Mailman List <boot-architecture@lists.linaro.org>, Frank Rowand <frowand.list@gmail.com>, linux-arm-kernel <linux-arm-kernel@lists.infradead.org> Subject: Re: [v5.4 stable] arm: stm32: Regression observed on "no-map" reserved memory region Date: Tue, 20 Apr 2021 18:10:27 +0200 [thread overview] Message-ID: <CAMj1kXE2Mgr9CsAMnKXff+96xhDaE5OLeNhypHvpN815vZGZhQ@mail.gmail.com> (raw) In-Reply-To: <CAL_Jsq+LUPZFhXd+j-xM67rZB=pvEvZM+1sfckip0Lqq02PkZQ@mail.gmail.com> On Tue, 20 Apr 2021 at 17:54, Rob Herring <robh+dt@kernel.org> wrote: > > On Tue, Apr 20, 2021 at 10:12 AM Alexandre TORGUE > <alexandre.torgue@foss.st.com> wrote: > > > > > > > > On 4/20/21 4:45 PM, Rob Herring wrote: > > > On Tue, Apr 20, 2021 at 9:03 AM Alexandre TORGUE > > > <alexandre.torgue@foss.st.com> wrote: > > >> > > >> Hi, > > > > > > Greg or Sasha won't know what to do with this. Not sure who follows > > > the stable list either. Quentin sent the patch, but is not the author. > > > Given the patch in question is about consistency between EFI memory > > > map boot and DT memory map boot, copying EFI knowledgeable folks would > > > help (Ard B for starters). > > > > Ok thanks for the tips. I add Ard in the loop. > > Sigh. If it was only Ard I was suggesting I would have done that > myself. Now everyone on the patch in question and relevant lists are > Cc'ed. > Thanks for the cc. > > > > Ard, let me know if other people have to be directly added or if I have > > to resend to another mailing list. > > > > thanks > > alex > > > > > > > >> > > >> Since v5.4.102 I observe a regression on stm32mp1 platform: "no-map" > > >> reserved-memory regions are no more "reserved" and make part of the > > >> kernel System RAM. This causes allocation failure for devices which try > > >> to take a reserved-memory region. > > >> > > >> It has been introduced by the following path: > > >> > > >> "fdt: Properly handle "no-map" field in the memory region > > >> [ Upstream commit 86588296acbfb1591e92ba60221e95677ecadb43 ]" > > >> which replace memblock_remove by memblock_mark_nomap in no-map case. > > >> Why was this backported? It doesn't look like a bugfix to me. > > >> Reverting this patch it's fine. > > >> > > >> I add part of my DT (something is maybe wrong inside): > > >> > > >> memory@c0000000 { > > >> reg = <0xc0000000 0x20000000>; > > >> }; > > >> > > >> reserved-memory { > > >> #address-cells = <1>; > > >> #size-cells = <1>; > > >> ranges; > > >> > > >> gpu_reserved: gpu@d4000000 { > > >> reg = <0xd4000000 0x4000000>; > > >> no-map; > > >> }; > > >> }; > > >> > > >> Sorry if this issue has already been raised and discussed. > > >> Could you explain why it fails? The region is clearly part of system memory, and tagged as no-map, so the patch in itself is not unreasonable. However, we obviously have code that relies on how the region is represented in /proc/iomem, so it would be helpful to get some insight into why this is the case. In any case, the mere fact that this causes a regression should be sufficient justification to revert/withdraw it from v5.4, as I don't see a reason why it was merged there in the first place. (It has no fixes tag or cc:stable) _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-04-20 16:10 UTC|newest] Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-04-20 14:02 [v5.4 stable] arm: stm32: Regression observed on "no-map" reserved memory region Alexandre TORGUE 2021-04-20 14:45 ` Rob Herring 2021-04-20 15:12 ` Alexandre TORGUE 2021-04-20 15:54 ` Rob Herring 2021-04-20 15:54 ` Rob Herring 2021-04-20 16:10 ` Ard Biesheuvel [this message] 2021-04-20 16:10 ` Ard Biesheuvel 2021-04-20 16:33 ` Florian Fainelli 2021-04-20 16:33 ` Florian Fainelli 2021-04-21 8:31 ` Quentin Perret 2021-04-21 8:31 ` Quentin Perret 2021-04-21 8:45 ` Quentin Perret 2021-04-21 8:45 ` Quentin Perret 2021-04-21 14:33 ` Florian Fainelli 2021-04-21 14:33 ` Florian Fainelli 2021-04-21 15:17 ` Florian Fainelli 2021-04-21 15:17 ` Florian Fainelli 2021-04-22 13:03 ` Quentin Perret 2021-04-22 13:03 ` Quentin Perret 2021-04-22 12:59 ` Quentin Perret 2021-04-22 12:59 ` Quentin Perret 2021-05-07 15:15 ` Alexandre TORGUE 2021-05-07 15:15 ` Alexandre TORGUE 2021-05-10 10:09 ` Quentin Perret 2021-05-10 10:09 ` Quentin Perret 2021-05-12 10:55 ` Alexandre TORGUE 2021-05-12 10:55 ` Alexandre TORGUE 2021-05-12 12:34 ` Quentin Perret 2021-05-12 12:34 ` Quentin Perret 2021-05-12 12:44 ` Alexandre TORGUE 2021-05-12 12:44 ` Alexandre TORGUE 2021-04-20 21:05 ` Rob Herring 2021-04-20 21:05 ` Rob Herring
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=CAMj1kXE2Mgr9CsAMnKXff+96xhDaE5OLeNhypHvpN815vZGZhQ@mail.gmail.com \ --to=ardb@kernel.org \ --cc=alexandre.torgue@foss.st.com \ --cc=arnd@arndb.de \ --cc=boot-architecture@lists.linaro.org \ --cc=devicetree@vger.kernel.org \ --cc=drinkcat@chromium.org \ --cc=f.fainelli@gmail.com \ --cc=frowand.list@gmail.com \ --cc=gregkh@linuxfoundation.org \ --cc=karahmed@amazon.de \ --cc=kernel-team@android.com \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=qperret@google.com \ --cc=robh+dt@kernel.org \ --cc=sashal@kernel.org \ --cc=stable@vger.kernel.org \ --cc=swboyd@chromium.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.