Re: [PATCH] target/arm: Fix decode of {LD,ST}RA[AB] instructions

[Peter Collingbourne <pcc@google.com>]

On Mon, Aug 3, 2020 at 3:27 PM Peter Collingbourne <pcc@google.com> wrote:
>
> These instructions use zero as the discriminator, not SP.

Oh, there is no such thing as STRAA/STRAB. I must have been confused
by the name of the function, disas_ldst_pac. I will send a v2 with a
fixed commit message, and another patch to rename the function to
disas_ld_pac.

Peter

>
> Signed-off-by: Peter Collingbourne <pcc@google.com>
> ---
>  target/arm/translate-a64.c | 6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/target/arm/translate-a64.c b/target/arm/translate-a64.c
> index 8c0764957c..c996ca1393 100644
> --- a/target/arm/translate-a64.c
> +++ b/target/arm/translate-a64.c
> @@ -3429,9 +3429,11 @@ static void disas_ldst_pac(DisasContext *s, uint32_t insn,
>
>      if (s->pauth_active) {
>          if (use_key_a) {
> -            gen_helper_autda(dirty_addr, cpu_env, dirty_addr, cpu_X[31]);
> +            gen_helper_autda(dirty_addr, cpu_env, dirty_addr,
> +                             new_tmp_a64_zero(s));
>          } else {
> -            gen_helper_autdb(dirty_addr, cpu_env, dirty_addr, cpu_X[31]);
> +            gen_helper_autdb(dirty_addr, cpu_env, dirty_addr,
> +                             new_tmp_a64_zero(s));
>          }
>      }
>
> --
> 2.28.0.163.g6104cc2f0b6-goog
>