All of lore.kernel.org
 help / color / mirror / Atom feed
From: Bartosz Golaszewski <bgolaszewski@baylibre.com>
To: Sekhar Nori <nsekhar@ti.com>
Cc: David Lechner <david@lechnology.com>,
	Kevin Hilman <khilman@baylibre.com>,
	Michael Turquette <mturquette@baylibre.com>,
	Patrick Titiano <ptitiano@baylibre.com>,
	Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
	Russell King <linux@armlinux.org.uk>,
	arm-soc <linux-arm-kernel@lists.infradead.org>,
	LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v3 6/6] ARM: davinci: add enable GPIOs for vpif capture to pdata-quirks
Date: Tue, 28 Feb 2017 10:42:45 +0100	[thread overview]
Message-ID: <CAMpxmJWdzBL5yEw4crS+vKnB393mj3uA4qgc=tjo9gTo770E=Q@mail.gmail.com> (raw)
In-Reply-To: <2a617e15-5eab-6a24-9c21-e3ab9ecf3899@ti.com>

2017-02-28 9:49 GMT+01:00 Sekhar Nori <nsekhar@ti.com>:
> On Wednesday 22 February 2017 07:43 PM, Bartosz Golaszewski wrote:
>> On the da850-evm board we need to select the UI expander video capture
>> function to make vpif capture work. Add the relevant GPIOs to the
>> pdata-quirks.
>>
>> Signed-off-by: Bartosz Golaszewski <bgolaszewski@baylibre.com>
>
> Hmm, why do we need this despite enable-gpios in DT ?
>

I didn't look at the exact code path, but if we're using pdata-quirks,
the of_node in struct device passed to vpif_probe is NULL (one of the
reasons why we're not mixing DT and pdata for vpif subdevices
configuration etc.). So it seems that as long as we don't switch over
to DT entirely we need to have the GPIOs here as well.

Thanks,
Bartosz

WARNING: multiple messages have this Message-ID (diff)
From: bgolaszewski@baylibre.com (Bartosz Golaszewski)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v3 6/6] ARM: davinci: add enable GPIOs for vpif capture to pdata-quirks
Date: Tue, 28 Feb 2017 10:42:45 +0100	[thread overview]
Message-ID: <CAMpxmJWdzBL5yEw4crS+vKnB393mj3uA4qgc=tjo9gTo770E=Q@mail.gmail.com> (raw)
In-Reply-To: <2a617e15-5eab-6a24-9c21-e3ab9ecf3899@ti.com>

2017-02-28 9:49 GMT+01:00 Sekhar Nori <nsekhar@ti.com>:
> On Wednesday 22 February 2017 07:43 PM, Bartosz Golaszewski wrote:
>> On the da850-evm board we need to select the UI expander video capture
>> function to make vpif capture work. Add the relevant GPIOs to the
>> pdata-quirks.
>>
>> Signed-off-by: Bartosz Golaszewski <bgolaszewski@baylibre.com>
>
> Hmm, why do we need this despite enable-gpios in DT ?
>

I didn't look at the exact code path, but if we're using pdata-quirks,
the of_node in struct device passed to vpif_probe is NULL (one of the
reasons why we're not mixing DT and pdata for vpif subdevices
configuration etc.). So it seems that as long as we don't switch over
to DT entirely we need to have the GPIOs here as well.

Thanks,
Bartosz

  reply	other threads:[~2017-02-28  9:52 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-02-22 14:13 [PATCH v3 0/6] ARM: davinci: vpif capture & display support Bartosz Golaszewski
2017-02-22 14:13 ` Bartosz Golaszewski
2017-02-22 14:13 ` [PATCH v3 1/6] ARM: davinci: da8xx: allow having multiple pdata-quirks Bartosz Golaszewski
2017-02-22 14:13   ` Bartosz Golaszewski
2017-02-28 18:00   ` Kevin Hilman
2017-02-28 18:00     ` Kevin Hilman
2017-02-22 14:13 ` [PATCH v3 2/6] ARM: davinci: board-da850-evm: add I2C ID for VPIF Bartosz Golaszewski
2017-02-22 14:13   ` Bartosz Golaszewski
2017-02-22 14:13 ` [PATCH v3 3/6] ARM: davinci: da8xx: add pdata-quirks for VPIF capture Bartosz Golaszewski
2017-02-22 14:13   ` Bartosz Golaszewski
2017-02-28  8:57   ` Sekhar Nori
2017-02-28  8:57     ` Sekhar Nori
2017-02-22 14:13 ` [PATCH v3 4/6] ARM: da850-evm: add a fixed regulator for the UI board IO expander Bartosz Golaszewski
2017-02-22 14:13   ` Bartosz Golaszewski
2017-02-22 14:13 ` [PATCH v3 5/6] ARM: davinci: add pdata-quirks for da850-evm vpif display Bartosz Golaszewski
2017-02-22 14:13   ` Bartosz Golaszewski
2017-02-22 14:13 ` [PATCH v3 6/6] ARM: davinci: add enable GPIOs for vpif capture to pdata-quirks Bartosz Golaszewski
2017-02-22 14:13   ` Bartosz Golaszewski
2017-02-28  8:49   ` Sekhar Nori
2017-02-28  8:49     ` Sekhar Nori
2017-02-28  9:42     ` Bartosz Golaszewski [this message]
2017-02-28  9:42       ` Bartosz Golaszewski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAMpxmJWdzBL5yEw4crS+vKnB393mj3uA4qgc=tjo9gTo770E=Q@mail.gmail.com' \
    --to=bgolaszewski@baylibre.com \
    --cc=david@lechnology.com \
    --cc=khilman@baylibre.com \
    --cc=laurent.pinchart@ideasonboard.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@armlinux.org.uk \
    --cc=mturquette@baylibre.com \
    --cc=nsekhar@ti.com \
    --cc=ptitiano@baylibre.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.