From: Bartosz Golaszewski <bgolaszewski@baylibre.com>
To: Peter Ujfalusi <peter.ujfalusi@ti.com>
Cc: Kevin Hilman <khilman@baylibre.com>,
Michael Turquette <mturquette@baylibre.com>,
Sekhar Nori <nsekhar@ti.com>, Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Russell King <linux@armlinux.org.uk>,
LKML <linux-kernel@vger.kernel.org>,
arm-soc <linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH 6/6] ARM: da850: adjust memory settings for tilcdc
Date: Fri, 30 Sep 2016 17:06:12 +0200 [thread overview]
Message-ID: <CAMpxmJXafyT5G8ZyD8RBAtzD6R9HmvyS0NBpz5i2fJ0SwOhXBA@mail.gmail.com> (raw)
In-Reply-To: <4e089d20-d00f-ff54-7c54-85aa061e23c2@ti.com>
2016-09-30 14:59 GMT+02:00 Peter Ujfalusi <peter.ujfalusi@ti.com>:
> On 09/29/16 19:31, Bartosz Golaszewski wrote:
>> Default memory settings of da850 do not meet the throughput/latency
>> requirements of tilcdc. This results in the image displayed being
>> incorrect and the following warning being displayed by the LCDC
>> drm driver:
>>
>> tilcdc da8xx_lcdc.0: tilcdc_crtc_irq(0x00000020): FIFO underfow
>>
>> Reconfigure the LCDC priority to the highest. This is a workaround
>> for the da850-lcdk board which has the LCD controller enabled in
>> the device tree, but a long-term, system-wide fix is needed for
>> all davinci boards.
>>
>> This patch has been modified for mainline linux. It comes from a
>> downstream TI release for da850[1].
>>
>> Original author: Vishwanathrao Badarkhe, Manish <manishv.b@ti.com>
>>
[snip]
>
> Is this safe to do for all da850 boards (to change PR_OLD_COUNT from 0xff to
> 0x20)? Most probably it is, but this setting has nothing to do with LCDC.
>
> The whole priority configuration has nothing to do with the LCDC, it is a
> system level priority.
>
> Now you have lowered the eDMA3_0-TPTC0/1 priority. Audio is serviced by
> eDMA3_0-TPTC1. So are we going to see issues in audio if LCDC is taking the
> highest priority?
>
Just ran a quick test with speaker-test -c2 -twav. Besides the fact
that the left and right channels are inverted (I'm looking into that),
I didn't notice any problems. Even at 1024x768 resolution, playing
audio at the same time seems to work fine.
Best regards,
Bartosz Golaszewski
WARNING: multiple messages have this Message-ID (diff)
From: bgolaszewski@baylibre.com (Bartosz Golaszewski)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 6/6] ARM: da850: adjust memory settings for tilcdc
Date: Fri, 30 Sep 2016 17:06:12 +0200 [thread overview]
Message-ID: <CAMpxmJXafyT5G8ZyD8RBAtzD6R9HmvyS0NBpz5i2fJ0SwOhXBA@mail.gmail.com> (raw)
In-Reply-To: <4e089d20-d00f-ff54-7c54-85aa061e23c2@ti.com>
2016-09-30 14:59 GMT+02:00 Peter Ujfalusi <peter.ujfalusi@ti.com>:
> On 09/29/16 19:31, Bartosz Golaszewski wrote:
>> Default memory settings of da850 do not meet the throughput/latency
>> requirements of tilcdc. This results in the image displayed being
>> incorrect and the following warning being displayed by the LCDC
>> drm driver:
>>
>> tilcdc da8xx_lcdc.0: tilcdc_crtc_irq(0x00000020): FIFO underfow
>>
>> Reconfigure the LCDC priority to the highest. This is a workaround
>> for the da850-lcdk board which has the LCD controller enabled in
>> the device tree, but a long-term, system-wide fix is needed for
>> all davinci boards.
>>
>> This patch has been modified for mainline linux. It comes from a
>> downstream TI release for da850[1].
>>
>> Original author: Vishwanathrao Badarkhe, Manish <manishv.b@ti.com>
>>
[snip]
>
> Is this safe to do for all da850 boards (to change PR_OLD_COUNT from 0xff to
> 0x20)? Most probably it is, but this setting has nothing to do with LCDC.
>
> The whole priority configuration has nothing to do with the LCDC, it is a
> system level priority.
>
> Now you have lowered the eDMA3_0-TPTC0/1 priority. Audio is serviced by
> eDMA3_0-TPTC1. So are we going to see issues in audio if LCDC is taking the
> highest priority?
>
Just ran a quick test with speaker-test -c2 -twav. Besides the fact
that the left and right channels are inverted (I'm looking into that),
I didn't notice any problems. Even at 1024x768 resolution, playing
audio at the same time seems to work fine.
Best regards,
Bartosz Golaszewski
next prev parent reply other threads:[~2016-09-30 15:06 UTC|newest]
Thread overview: 66+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-29 16:31 [PATCH 0/6] ARM: davinci: da850-lcdk: add support for tilcdc Bartosz Golaszewski
2016-09-29 16:31 ` Bartosz Golaszewski
2016-09-29 16:31 ` [PATCH 1/6] ARM: davinci: da8xx-dt: add OF_DEV_AUXDATA entry for lcdc Bartosz Golaszewski
2016-09-29 16:31 ` Bartosz Golaszewski
2016-09-29 16:31 ` [PATCH 2/6] ARM: dts: da850: add a node for the LCD controller Bartosz Golaszewski
2016-09-29 16:31 ` Bartosz Golaszewski
2016-09-30 9:34 ` Sekhar Nori
2016-09-30 9:34 ` Sekhar Nori
2016-09-30 13:03 ` Bartosz Golaszewski
2016-09-30 13:03 ` Bartosz Golaszewski
2016-09-29 16:31 ` [PATCH 3/6] ARM: dts: da850-lcdk: enable " Bartosz Golaszewski
2016-09-29 16:31 ` Bartosz Golaszewski
2016-09-29 18:40 ` Karl Beldan
2016-09-29 18:40 ` Karl Beldan
2016-09-30 9:42 ` Bartosz Golaszewski
2016-09-30 9:42 ` Bartosz Golaszewski
2016-09-30 13:15 ` Karl Beldan
2016-09-30 13:15 ` Karl Beldan
2016-09-30 14:21 ` Sekhar Nori
2016-09-30 14:21 ` Sekhar Nori
2016-09-29 16:31 ` [PATCH 4/6] ARM: dts: da850-lcdk: add support for 1024x768 resolution Bartosz Golaszewski
2016-09-29 16:31 ` Bartosz Golaszewski
2016-09-29 18:58 ` Karl Beldan
2016-09-29 18:58 ` Karl Beldan
2016-09-30 9:37 ` Bartosz Golaszewski
2016-09-30 9:37 ` Bartosz Golaszewski
2016-09-30 11:47 ` Sekhar Nori
2016-09-30 11:47 ` Sekhar Nori
2016-09-30 12:49 ` Karl Beldan
2016-09-30 12:49 ` Karl Beldan
2016-09-30 13:48 ` Bartosz Golaszewski
2016-09-30 13:48 ` Bartosz Golaszewski
2016-10-01 9:35 ` Sekhar Nori
2016-10-01 9:35 ` Sekhar Nori
2016-09-29 16:31 ` [PATCH 5/6] ARM: davinci: enable the LCDC DRM driver in defconfig Bartosz Golaszewski
2016-09-29 16:31 ` Bartosz Golaszewski
2016-10-01 12:39 ` Sekhar Nori
2016-10-01 12:39 ` Sekhar Nori
2016-09-29 16:31 ` [PATCH 6/6] ARM: da850: adjust memory settings for tilcdc Bartosz Golaszewski
2016-09-29 16:31 ` Bartosz Golaszewski
2016-09-29 19:07 ` Karl Beldan
2016-09-29 19:07 ` Karl Beldan
2016-09-30 9:31 ` Bartosz Golaszewski
2016-09-30 9:31 ` Bartosz Golaszewski
2016-09-30 9:39 ` Karl Beldan
2016-09-30 9:39 ` Karl Beldan
2016-09-30 12:59 ` Peter Ujfalusi
2016-09-30 12:59 ` Peter Ujfalusi
2016-09-30 15:06 ` Bartosz Golaszewski [this message]
2016-09-30 15:06 ` Bartosz Golaszewski
2016-09-30 19:19 ` Peter Ujfalusi
2016-09-30 19:19 ` Peter Ujfalusi
2016-10-01 9:24 ` Sekhar Nori
2016-10-01 9:24 ` Sekhar Nori
2016-10-03 7:13 ` Peter Ujfalusi
2016-10-03 7:13 ` Peter Ujfalusi
2016-10-04 13:02 ` Kevin Hilman
2016-10-04 13:02 ` Kevin Hilman
2016-10-05 8:22 ` Peter Ujfalusi
2016-10-05 8:22 ` Peter Ujfalusi
2016-10-06 17:57 ` Sekhar Nori
2016-10-06 17:57 ` Sekhar Nori
2016-10-04 9:20 ` Bartosz Golaszewski
2016-10-04 9:20 ` Bartosz Golaszewski
2016-10-05 8:02 ` Peter Ujfalusi
2016-10-05 8:02 ` Peter Ujfalusi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAMpxmJXafyT5G8ZyD8RBAtzD6R9HmvyS0NBpz5i2fJ0SwOhXBA@mail.gmail.com \
--to=bgolaszewski@baylibre.com \
--cc=khilman@baylibre.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=mark.rutland@arm.com \
--cc=mturquette@baylibre.com \
--cc=nsekhar@ti.com \
--cc=peter.ujfalusi@ti.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.