From: Jagan Teki <jagan@amarulasolutions.com>
To: Paul Kocialkowski <paul.kocialkowski@bootlin.com>
Cc: Andrzej Hajda <a.hajda@samsung.com>,
Laurent Pinchart <Laurent.pinchart@ideasonboard.com>,
Chen-Yu Tsai <wens@csie.org>,
Maxime Ripard <maxime.ripard@bootlin.com>,
David Airlie <airlied@linux.ie>, Daniel Vetter <daniel@ffwll.ch>,
Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Michael Trimarchi <michael@amarulasolutions.com>,
dri-devel <dri-devel@lists.freedesktop.org>,
linux-kernel <linux-kernel@vger.kernel.org>,
devicetree <devicetree@vger.kernel.org>,
linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
linux-sunxi <linux-sunxi@googlegroups.com>,
linux-amarula@amarulasolutions.com
Subject: Re: [linux-sunxi] [PATCH 1/6] drm/bridge: Export drm_bridge_detach
Date: Mon, 18 Mar 2019 22:18:11 +0530 [thread overview]
Message-ID: <CAMty3ZBOTOR4hHfPE4Ufhb2+VoNJfFQwiii1kti263fi7DEEaQ@mail.gmail.com> (raw)
In-Reply-To: <c52be751ac1bc7b1ee21e3e2a30d5b494bf95faa.camel@bootlin.com>
Hi Paul,
On Fri, Mar 15, 2019 at 6:58 PM Paul Kocialkowski
<paul.kocialkowski@bootlin.com> wrote:
>
> Hi Jakan,
>
> On Fri, 2019-03-15 at 18:38 +0530, Jagan Teki wrote:
> > Export drm_bridge_detach from drm bridge core so-that it
> > can use on respective interface or bridge driver while
> > detaching the bridge.
>
> I don't see why this change is required based on the commit log. The
> DRM bridge code clearly indicates that drm_bridge_attach should *not*
> be balanced with a drm_bridge_detach call in the driver, so this seems
> quite wrong.
>
> The DRM core itself should handle detaching the bridge, not the driver.
> Is there any reason why you need to do things differently for DSI?
Yes, you are correct the detach of bridge is being taking care via
drm_encoder_cleanup. This patch exported explicitly, since we need to
taken care bridge detach during unbind even exynos_drm_dsi in other
patch seems using detach by explicitly pointing. so I think the better
approach is to use drm_encoder_cleanup in unbind, what do you say?
Jagan.
WARNING: multiple messages have this Message-ID (diff)
From: Jagan Teki <jagan@amarulasolutions.com>
To: Paul Kocialkowski <paul.kocialkowski@bootlin.com>
Cc: Mark Rutland <mark.rutland@arm.com>,
devicetree <devicetree@vger.kernel.org>,
Maxime Ripard <maxime.ripard@bootlin.com>,
David Airlie <airlied@linux.ie>,
linux-sunxi <linux-sunxi@googlegroups.com>,
linux-kernel <linux-kernel@vger.kernel.org>,
dri-devel <dri-devel@lists.freedesktop.org>,
Andrzej Hajda <a.hajda@samsung.com>, Chen-Yu Tsai <wens@csie.org>,
Rob Herring <robh+dt@kernel.org>,
Laurent Pinchart <Laurent.pinchart@ideasonboard.com>,
Daniel Vetter <daniel@ffwll.ch>,
Michael Trimarchi <michael@amarulasolutions.com>,
linux-amarula@amarulasolutions.com,
linux-arm-kernel <linux-arm-kernel@lists.infradead.org>
Subject: Re: [linux-sunxi] [PATCH 1/6] drm/bridge: Export drm_bridge_detach
Date: Mon, 18 Mar 2019 22:18:11 +0530 [thread overview]
Message-ID: <CAMty3ZBOTOR4hHfPE4Ufhb2+VoNJfFQwiii1kti263fi7DEEaQ@mail.gmail.com> (raw)
In-Reply-To: <c52be751ac1bc7b1ee21e3e2a30d5b494bf95faa.camel@bootlin.com>
Hi Paul,
On Fri, Mar 15, 2019 at 6:58 PM Paul Kocialkowski
<paul.kocialkowski@bootlin.com> wrote:
>
> Hi Jakan,
>
> On Fri, 2019-03-15 at 18:38 +0530, Jagan Teki wrote:
> > Export drm_bridge_detach from drm bridge core so-that it
> > can use on respective interface or bridge driver while
> > detaching the bridge.
>
> I don't see why this change is required based on the commit log. The
> DRM bridge code clearly indicates that drm_bridge_attach should *not*
> be balanced with a drm_bridge_detach call in the driver, so this seems
> quite wrong.
>
> The DRM core itself should handle detaching the bridge, not the driver.
> Is there any reason why you need to do things differently for DSI?
Yes, you are correct the detach of bridge is being taking care via
drm_encoder_cleanup. This patch exported explicitly, since we need to
taken care bridge detach during unbind even exynos_drm_dsi in other
patch seems using detach by explicitly pointing. so I think the better
approach is to use drm_encoder_cleanup in unbind, what do you say?
Jagan.
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-03-18 16:48 UTC|newest]
Thread overview: 69+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-15 13:08 [PATCH 0/6] drm/bridge: Add ICN6211 MIPI-DSI/RGB bridge Jagan Teki
2019-03-15 13:08 ` Jagan Teki
2019-03-15 13:08 ` Jagan Teki
2019-03-15 13:08 ` [PATCH 1/6] drm/bridge: Export drm_bridge_detach Jagan Teki
2019-03-15 13:08 ` Jagan Teki
2019-03-15 13:08 ` Jagan Teki
2019-03-15 13:27 ` [linux-sunxi] " Paul Kocialkowski
2019-03-15 13:27 ` Paul Kocialkowski
2019-03-15 13:27 ` Paul Kocialkowski
2019-03-18 16:48 ` Jagan Teki [this message]
2019-03-18 16:48 ` [linux-sunxi] " Jagan Teki
2019-03-18 16:57 ` Paul Kocialkowski
2019-03-18 16:57 ` Paul Kocialkowski
2019-03-18 17:07 ` Jagan Teki
2019-03-18 17:07 ` Jagan Teki
2019-03-18 17:07 ` Jagan Teki
2019-03-15 13:08 ` [PATCH 2/6] drm/exynos: dsi: Use drm_bridge_detach Jagan Teki
2019-03-15 13:08 ` Jagan Teki
2019-03-15 13:08 ` Jagan Teki
2019-03-19 3:59 ` Inki Dae
2019-03-19 3:59 ` Inki Dae
2019-03-15 13:08 ` [PATCH 3/6] drm/sun4i: dsi: Add bridge support Jagan Teki
2019-03-15 13:08 ` Jagan Teki
2019-03-15 13:08 ` Jagan Teki
2019-03-15 13:32 ` [linux-sunxi] " Paul Kocialkowski
2019-03-15 13:32 ` Paul Kocialkowski
2019-03-15 13:32 ` Paul Kocialkowski
2019-03-15 13:45 ` [linux-sunxi] " Maxime Ripard
2019-03-15 13:45 ` Maxime Ripard
2019-03-15 13:45 ` Maxime Ripard
2019-03-15 13:48 ` [linux-sunxi] " Paul Kocialkowski
2019-03-15 13:48 ` Paul Kocialkowski
2019-03-15 13:48 ` Paul Kocialkowski
2019-03-15 15:20 ` [linux-sunxi] " Sergey Suloev
2019-05-22 12:01 ` Jagan Teki
2019-05-22 12:01 ` Jagan Teki
2019-03-15 13:08 ` [PATCH 4/6] dt-bindings: display: bridge: Add ICN6211 MIPI-DSI to RGB convertor bridge Jagan Teki
2019-03-15 13:08 ` Jagan Teki
2019-03-15 13:34 ` Maxime Ripard
2019-03-15 13:34 ` Maxime Ripard
2019-03-15 13:34 ` Maxime Ripard
2019-03-18 16:58 ` Jagan Teki
2019-03-18 16:58 ` Jagan Teki
2019-03-19 2:59 ` [linux-sunxi] " Chen-Yu Tsai
2019-03-19 2:59 ` Chen-Yu Tsai
2019-03-19 7:48 ` Jagan Teki
2019-03-19 7:48 ` Jagan Teki
2019-03-19 7:48 ` Jagan Teki
2019-03-19 8:35 ` Maxime Ripard
2019-03-19 8:35 ` Maxime Ripard
2019-03-15 13:08 ` [PATCH 5/6] drm/bridge: Add Chipone ICN6211 MIPI-DSI/RGB " Jagan Teki
2019-03-15 13:08 ` Jagan Teki
2019-03-15 13:08 ` Jagan Teki
2019-03-15 13:33 ` Maxime Ripard
2019-03-15 13:33 ` Maxime Ripard
2019-03-15 13:33 ` Maxime Ripard
2019-03-17 16:30 ` Laurent Pinchart
2019-03-17 16:30 ` Laurent Pinchart
2019-03-17 16:30 ` Laurent Pinchart
2019-03-18 17:59 ` Jagan Teki
2019-03-18 17:59 ` Jagan Teki
2019-03-19 3:05 ` [linux-sunxi] " Chen-Yu Tsai
2019-03-19 3:05 ` Chen-Yu Tsai
2019-03-19 3:05 ` Chen-Yu Tsai
2019-03-15 13:08 ` [PATCH 6/6] arm64: dts: allwinner: bananapi-m64: Enable S070WV20-CT16 DSI panel Jagan Teki
2019-03-15 13:08 ` Jagan Teki
2019-03-15 13:25 ` Maxime Ripard
2019-03-15 13:25 ` Maxime Ripard
2019-03-15 13:25 ` Maxime Ripard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAMty3ZBOTOR4hHfPE4Ufhb2+VoNJfFQwiii1kti263fi7DEEaQ@mail.gmail.com \
--to=jagan@amarulasolutions.com \
--cc=Laurent.pinchart@ideasonboard.com \
--cc=a.hajda@samsung.com \
--cc=airlied@linux.ie \
--cc=daniel@ffwll.ch \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-amarula@amarulasolutions.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sunxi@googlegroups.com \
--cc=mark.rutland@arm.com \
--cc=maxime.ripard@bootlin.com \
--cc=michael@amarulasolutions.com \
--cc=paul.kocialkowski@bootlin.com \
--cc=robh+dt@kernel.org \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.