From: Jagan Teki <jagan@amarulasolutions.com> To: Maxime Ripard <maxime.ripard@bootlin.com> Cc: Andrzej Hajda <a.hajda@samsung.com>, Laurent Pinchart <Laurent.pinchart@ideasonboard.com>, Chen-Yu Tsai <wens@csie.org>, David Airlie <airlied@linux.ie>, Daniel Vetter <daniel@ffwll.ch>, Rob Herring <robh+dt@kernel.org>, Mark Rutland <mark.rutland@arm.com>, Michael Trimarchi <michael@amarulasolutions.com>, dri-devel <dri-devel@lists.freedesktop.org>, linux-kernel <linux-kernel@vger.kernel.org>, devicetree <devicetree@vger.kernel.org>, linux-arm-kernel <linux-arm-kernel@lists.infradead.org>, linux-sunxi <linux-sunxi@googlegroups.com>, linux-amarula@amarulasolutions.com Subject: Re: [PATCH 4/6] dt-bindings: display: bridge: Add ICN6211 MIPI-DSI to RGB convertor bridge Date: Mon, 18 Mar 2019 22:28:10 +0530 [thread overview] Message-ID: <CAMty3ZBn=MjB-VxwadkEDaM_==hGu1pzTv2A47cKitv0Vb5VXw@mail.gmail.com> (raw) In-Reply-To: <20190315133414.5zwc5qtrivrbrzow@flea> On Fri, Mar 15, 2019 at 7:04 PM Maxime Ripard <maxime.ripard@bootlin.com> wrote: > > On Fri, Mar 15, 2019 at 06:38:23PM +0530, Jagan Teki wrote: > > ICN6211 is MIPI-DSI/RGB converter bridge from chipone. > > It has a flexible configuration of MIPI DSI signal input > > and produce RGB565, RGB666, RGB888 output format. > > > > Add dt-bingings for it. > > > > Signed-off-by: Jagan Teki <jagan@amarulasolutions.com> > > --- > > .../display/bridge/chipone,icn6211.txt | 36 +++++++++++++++++++ > > 1 file changed, 36 insertions(+) > > create mode 100644 Documentation/devicetree/bindings/display/bridge/chipone,icn6211.txt > > > > diff --git a/Documentation/devicetree/bindings/display/bridge/chipone,icn6211.txt b/Documentation/devicetree/bindings/display/bridge/chipone,icn6211.txt > > new file mode 100644 > > index 000000000000..7f13efd7ee7f > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/display/bridge/chipone,icn6211.txt > > @@ -0,0 +1,36 @@ > > +Chipone ICN6211 MIPI-DSI to RGB Convertor Bridge > > + > > +ICN6211 is MIPI-DSI/RGB converter bridge from chipone. > > +It has a flexible configuration of MIPI DSI signal input > > +and produce RGB565, RGB666, RGB888 output format. > > + > > +Required properties for RGB: > > +- compatible: must be "chipone,icn6211" and one of: > > + * "bananapi,icn6211" > > Why is that compatible needed? chipone,icn6211 - generic compatible bridge controller IC bananapi,icn6211 - compatible for icn6211 bridge using on bananapi panel I hope this would be proper bindings in terms of controller IC with associate device, anything wrong? Infact I used similar reference from Ilitek Bananapi panel from here Documentation/devicetree/bindings/display/panel/ilitek,ili9881c.txt This is what I understood based on dt-binding, correct if I'm wrong. ilitek,ili9881c - generic ilitek,ili9881c compatable bananapi,lhr050h41 - compatible for bananapi panel associated with this ilitek IC > > > +- reg: the virtual channel number of a DSI peripheral > > +- reset-gpios: a GPIO phandle for the reset pin > > + > > +The device node can contain following 'port' child nodes, > > +according to the OF graph bindings defined in [1]: > > + 0: DSI Input, not required, if the bridge is DSI controlled > > + 1: RGB Output, mandatory > > Your example doesn't have that input port Yes, I intentionally did this by referring existing bridge binding. Documentation/devicetree/bindings/display/bridge/toshiba,tc35876*.txt Do we really need? since the input port can be part of panel binding.
WARNING: multiple messages have this Message-ID (diff)
From: Jagan Teki <jagan@amarulasolutions.com> To: Maxime Ripard <maxime.ripard@bootlin.com> Cc: Mark Rutland <mark.rutland@arm.com>, devicetree <devicetree@vger.kernel.org>, David Airlie <airlied@linux.ie>, linux-sunxi <linux-sunxi@googlegroups.com>, linux-kernel <linux-kernel@vger.kernel.org>, dri-devel <dri-devel@lists.freedesktop.org>, Andrzej Hajda <a.hajda@samsung.com>, Chen-Yu Tsai <wens@csie.org>, Rob Herring <robh+dt@kernel.org>, Laurent Pinchart <Laurent.pinchart@ideasonboard.com>, Daniel Vetter <daniel@ffwll.ch>, Michael Trimarchi <michael@amarulasolutions.com>, linux-amarula@amarulasolutions.com, linux-arm-kernel <linux-arm-kernel@lists.infradead.org> Subject: Re: [PATCH 4/6] dt-bindings: display: bridge: Add ICN6211 MIPI-DSI to RGB convertor bridge Date: Mon, 18 Mar 2019 22:28:10 +0530 [thread overview] Message-ID: <CAMty3ZBn=MjB-VxwadkEDaM_==hGu1pzTv2A47cKitv0Vb5VXw@mail.gmail.com> (raw) In-Reply-To: <20190315133414.5zwc5qtrivrbrzow@flea> On Fri, Mar 15, 2019 at 7:04 PM Maxime Ripard <maxime.ripard@bootlin.com> wrote: > > On Fri, Mar 15, 2019 at 06:38:23PM +0530, Jagan Teki wrote: > > ICN6211 is MIPI-DSI/RGB converter bridge from chipone. > > It has a flexible configuration of MIPI DSI signal input > > and produce RGB565, RGB666, RGB888 output format. > > > > Add dt-bingings for it. > > > > Signed-off-by: Jagan Teki <jagan@amarulasolutions.com> > > --- > > .../display/bridge/chipone,icn6211.txt | 36 +++++++++++++++++++ > > 1 file changed, 36 insertions(+) > > create mode 100644 Documentation/devicetree/bindings/display/bridge/chipone,icn6211.txt > > > > diff --git a/Documentation/devicetree/bindings/display/bridge/chipone,icn6211.txt b/Documentation/devicetree/bindings/display/bridge/chipone,icn6211.txt > > new file mode 100644 > > index 000000000000..7f13efd7ee7f > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/display/bridge/chipone,icn6211.txt > > @@ -0,0 +1,36 @@ > > +Chipone ICN6211 MIPI-DSI to RGB Convertor Bridge > > + > > +ICN6211 is MIPI-DSI/RGB converter bridge from chipone. > > +It has a flexible configuration of MIPI DSI signal input > > +and produce RGB565, RGB666, RGB888 output format. > > + > > +Required properties for RGB: > > +- compatible: must be "chipone,icn6211" and one of: > > + * "bananapi,icn6211" > > Why is that compatible needed? chipone,icn6211 - generic compatible bridge controller IC bananapi,icn6211 - compatible for icn6211 bridge using on bananapi panel I hope this would be proper bindings in terms of controller IC with associate device, anything wrong? Infact I used similar reference from Ilitek Bananapi panel from here Documentation/devicetree/bindings/display/panel/ilitek,ili9881c.txt This is what I understood based on dt-binding, correct if I'm wrong. ilitek,ili9881c - generic ilitek,ili9881c compatable bananapi,lhr050h41 - compatible for bananapi panel associated with this ilitek IC > > > +- reg: the virtual channel number of a DSI peripheral > > +- reset-gpios: a GPIO phandle for the reset pin > > + > > +The device node can contain following 'port' child nodes, > > +according to the OF graph bindings defined in [1]: > > + 0: DSI Input, not required, if the bridge is DSI controlled > > + 1: RGB Output, mandatory > > Your example doesn't have that input port Yes, I intentionally did this by referring existing bridge binding. Documentation/devicetree/bindings/display/bridge/toshiba,tc35876*.txt Do we really need? since the input port can be part of panel binding. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-03-18 16:58 UTC|newest] Thread overview: 69+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-03-15 13:08 [PATCH 0/6] drm/bridge: Add ICN6211 MIPI-DSI/RGB bridge Jagan Teki 2019-03-15 13:08 ` Jagan Teki 2019-03-15 13:08 ` Jagan Teki 2019-03-15 13:08 ` [PATCH 1/6] drm/bridge: Export drm_bridge_detach Jagan Teki 2019-03-15 13:08 ` Jagan Teki 2019-03-15 13:08 ` Jagan Teki 2019-03-15 13:27 ` [linux-sunxi] " Paul Kocialkowski 2019-03-15 13:27 ` Paul Kocialkowski 2019-03-15 13:27 ` Paul Kocialkowski 2019-03-18 16:48 ` [linux-sunxi] " Jagan Teki 2019-03-18 16:48 ` Jagan Teki 2019-03-18 16:57 ` Paul Kocialkowski 2019-03-18 16:57 ` Paul Kocialkowski 2019-03-18 17:07 ` Jagan Teki 2019-03-18 17:07 ` Jagan Teki 2019-03-18 17:07 ` Jagan Teki 2019-03-15 13:08 ` [PATCH 2/6] drm/exynos: dsi: Use drm_bridge_detach Jagan Teki 2019-03-15 13:08 ` Jagan Teki 2019-03-15 13:08 ` Jagan Teki 2019-03-19 3:59 ` Inki Dae 2019-03-19 3:59 ` Inki Dae 2019-03-15 13:08 ` [PATCH 3/6] drm/sun4i: dsi: Add bridge support Jagan Teki 2019-03-15 13:08 ` Jagan Teki 2019-03-15 13:08 ` Jagan Teki 2019-03-15 13:32 ` [linux-sunxi] " Paul Kocialkowski 2019-03-15 13:32 ` Paul Kocialkowski 2019-03-15 13:32 ` Paul Kocialkowski 2019-03-15 13:45 ` [linux-sunxi] " Maxime Ripard 2019-03-15 13:45 ` Maxime Ripard 2019-03-15 13:45 ` Maxime Ripard 2019-03-15 13:48 ` [linux-sunxi] " Paul Kocialkowski 2019-03-15 13:48 ` Paul Kocialkowski 2019-03-15 13:48 ` Paul Kocialkowski 2019-03-15 15:20 ` [linux-sunxi] " Sergey Suloev 2019-05-22 12:01 ` Jagan Teki 2019-05-22 12:01 ` Jagan Teki 2019-03-15 13:08 ` [PATCH 4/6] dt-bindings: display: bridge: Add ICN6211 MIPI-DSI to RGB convertor bridge Jagan Teki 2019-03-15 13:08 ` Jagan Teki 2019-03-15 13:34 ` Maxime Ripard 2019-03-15 13:34 ` Maxime Ripard 2019-03-15 13:34 ` Maxime Ripard 2019-03-18 16:58 ` Jagan Teki [this message] 2019-03-18 16:58 ` Jagan Teki 2019-03-19 2:59 ` [linux-sunxi] " Chen-Yu Tsai 2019-03-19 2:59 ` Chen-Yu Tsai 2019-03-19 7:48 ` Jagan Teki 2019-03-19 7:48 ` Jagan Teki 2019-03-19 7:48 ` Jagan Teki 2019-03-19 8:35 ` Maxime Ripard 2019-03-19 8:35 ` Maxime Ripard 2019-03-15 13:08 ` [PATCH 5/6] drm/bridge: Add Chipone ICN6211 MIPI-DSI/RGB " Jagan Teki 2019-03-15 13:08 ` Jagan Teki 2019-03-15 13:08 ` Jagan Teki 2019-03-15 13:33 ` Maxime Ripard 2019-03-15 13:33 ` Maxime Ripard 2019-03-15 13:33 ` Maxime Ripard 2019-03-17 16:30 ` Laurent Pinchart 2019-03-17 16:30 ` Laurent Pinchart 2019-03-17 16:30 ` Laurent Pinchart 2019-03-18 17:59 ` Jagan Teki 2019-03-18 17:59 ` Jagan Teki 2019-03-19 3:05 ` [linux-sunxi] " Chen-Yu Tsai 2019-03-19 3:05 ` Chen-Yu Tsai 2019-03-19 3:05 ` Chen-Yu Tsai 2019-03-15 13:08 ` [PATCH 6/6] arm64: dts: allwinner: bananapi-m64: Enable S070WV20-CT16 DSI panel Jagan Teki 2019-03-15 13:08 ` Jagan Teki 2019-03-15 13:25 ` Maxime Ripard 2019-03-15 13:25 ` Maxime Ripard 2019-03-15 13:25 ` Maxime Ripard
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to='CAMty3ZBn=MjB-VxwadkEDaM_==hGu1pzTv2A47cKitv0Vb5VXw@mail.gmail.com' \ --to=jagan@amarulasolutions.com \ --cc=Laurent.pinchart@ideasonboard.com \ --cc=a.hajda@samsung.com \ --cc=airlied@linux.ie \ --cc=daniel@ffwll.ch \ --cc=devicetree@vger.kernel.org \ --cc=dri-devel@lists.freedesktop.org \ --cc=linux-amarula@amarulasolutions.com \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-sunxi@googlegroups.com \ --cc=mark.rutland@arm.com \ --cc=maxime.ripard@bootlin.com \ --cc=michael@amarulasolutions.com \ --cc=robh+dt@kernel.org \ --cc=wens@csie.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.