All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jagan Teki <jagan@amarulasolutions.com>
To: Roman Bacik <roman.bacik@broadcom.com>
Cc: U-Boot Mailing List <u-boot@lists.denx.de>,
	 Rayagonda Kokatanur <rayagonda.kokatanur@broadcom.com>,
	Bharat Gooty <bharat.gooty@broadcom.com>,
	Vignesh R <vigneshr@ti.com>
Subject: Re: [PATCH v4] driver: spi: add bcm iproc qspi support.
Date: Mon, 1 Nov 2021 12:42:14 +0530	[thread overview]
Message-ID: <CAMty3ZDS45VuFQVpiba19z6Pdq+1f-AhPx-p0dU_xu8HEhNPWA@mail.gmail.com> (raw)
In-Reply-To: <20211025123639.v4.1.Ibcd6b4db038dac555a5071d1406a0c2f757c9570@changeid>

On Tue, Oct 26, 2021 at 1:07 AM Roman Bacik <roman.bacik@broadcom.com> wrote:
>
> From: Rayagonda Kokatanur <rayagonda.kokatanur@broadcom.com>
>
> IPROC qspi driver supports both BSPI and MSPI modes.
>
> Signed-off-by: Rayagonda Kokatanur <rayagonda.kokatanur@broadcom.com>
> Signed-off-by: Bharat Gooty <bharat.gooty@broadcom.com>
> Acked-by: Rayagonda Kokatanur <rayagonda.kokatanur@broadcom.com>
>
> Signed-off-by: Roman Bacik <roman.bacik@broadcom.com>
> ---
>
> Changes in v4:
> - move iproc_qspi.c from spi to mtd/spi
> - remove iproc_qspi.h
> - rename IPROC_QSPI to SPI_FLASH_IPROC
>
> Changes in v3:
> - fix warning by including linux/delay.h
> - change ofdata_to_platdata to of_to_plat
> - change priv_auto_alloc_size to priv_auto
>
> Changes in v2:
> - remove include spi-nor.h
> - define and use named BITs for writing register values
> - remove bspi_set_4byte_mode() method
>
>  drivers/mtd/spi/Kconfig      |   6 +
>  drivers/mtd/spi/Makefile     |   1 +
>  drivers/mtd/spi/iproc_qspi.c | 718 +++++++++++++++++++++++++++++++++++
>  3 files changed, 725 insertions(+)
>  create mode 100644 drivers/mtd/spi/iproc_qspi.c

Look like you confused what I've mentioned before, your driver is
flash specific so add a driver in UCLASS_SPI_FLASH. drivers with
UCLASS_SPI to be in drivers/spi/

Jagan.

  reply	other threads:[~2021-11-01  7:12 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-10-25 19:36 [PATCH v4] driver: spi: add bcm iproc qspi support Roman Bacik
2021-11-01  7:12 ` Jagan Teki [this message]
2021-11-01 23:27   ` Roman Bacik
2021-11-02  5:06     ` Jagan Teki
2021-11-02 16:43       ` Roman Bacik

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAMty3ZDS45VuFQVpiba19z6Pdq+1f-AhPx-p0dU_xu8HEhNPWA@mail.gmail.com \
    --to=jagan@amarulasolutions.com \
    --cc=bharat.gooty@broadcom.com \
    --cc=rayagonda.kokatanur@broadcom.com \
    --cc=roman.bacik@broadcom.com \
    --cc=u-boot@lists.denx.de \
    --cc=vigneshr@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.