From: Geert Uytterhoeven <geert@linux-m68k.org> To: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com> Cc: Simon <horms@verge.net.au>, Zhang Rui <rui.zhang@intel.com>, Eduardo Valentin <edubezval@gmail.com>, Magnus <magnus.damm@gmail.com>, Linux-sh list <linux-sh@vger.kernel.org>, Linux PM list <linux-pm@vger.kernel.org>, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>, "devicetree@vger.kernel.org" <devicetree@vger.kernel.org> Subject: Re: [PATCH 2/4] thermal: rcar: enable to use thermal-zone on DT Date: Fri, 04 Dec 2015 08:32:36 +0000 [thread overview] Message-ID: <CAMuHMdUcQFcQuEmQZ4yMGwm=ouH+aQQhG3V95p=Pb56qWberQA@mail.gmail.com> (raw) In-Reply-To: <87y4dagb0i.wl%kuninori.morimoto.gx@renesas.com> Hi Morimoto-san, CC devicetree On Fri, Dec 4, 2015 at 4:17 AM, Kuninori Morimoto <kuninori.morimoto.gx@renesas.com> wrote: > From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com> > > This patch enables to use thermal-zone on DT if it was call as > "renesas,rcar-thermal-gen2". > Previous style is still supported by "renesas,rcar-thermal". > > Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com> > --- > .../devicetree/bindings/thermal/rcar-thermal.txt | 37 +++++++++++++++++- > drivers/thermal/rcar_thermal.c | 45 +++++++++++++++++++--- > 2 files changed, 74 insertions(+), 8 deletions(-) > > diff --git a/Documentation/devicetree/bindings/thermal/rcar-thermal.txt b/Documentation/devicetree/bindings/thermal/rcar-thermal.txt > index 332e625..904f204 100644 > --- a/Documentation/devicetree/bindings/thermal/rcar-thermal.txt > +++ b/Documentation/devicetree/bindings/thermal/rcar-thermal.txt > @@ -1,8 +1,9 @@ > * Renesas R-Car Thermal > > Required properties: > -- compatible : "renesas,thermal-<soctype>", "renesas,rcar-thermal" > - as fallback. > +- compatible : "renesas,thermal-<soctype>", > + "renesas,rcar-thermal-gen2" (with thermal-zone) or Ugh, another different scheme "<manuf>,<family>-<device>-<familyversion>"... What about "renesas,rcar-gen2-thermal"? > + "renesas,rcar-thermal" (without thermal-zone) as fallback. > Examples with soctypes are: > - "renesas,thermal-r8a73a4" (R-Mobile APE6) > - "renesas,thermal-r8a7779" (R-Car H1) > @@ -36,3 +37,35 @@ thermal@e61f0000 { > 0xe61f0300 0x38>; > interrupts = <0 69 IRQ_TYPE_LEVEL_HIGH>; > }; > + > +Example (with thermal-zone): > + > +thermal-zones { > + cpu_thermal: cpu-thermal { > + polling-delay-passive = <1000>; > + polling-delay = <5000>; > + > + thermal-sensors = <&thermal>; > + > + trips { > + cpu-crit { > + temperature = <1150000>; > + hysteresis = <0>; > + type = "critical"; > + }; > + }; > + cooling-maps { > + }; > + }; > +}; > + > +thermal: thermal@e61f0000 { > + compatible = "renesas,thermal-r8a7790", > + "renesas,rcar-thermal-gen2", > + "renesas,rcar-thermal"; > + reg = <0 0xe61f0000 0 0x14>, <0 0xe61f0100 0 0x38>; > + interrupts = <0 69 IRQ_TYPE_LEVEL_HIGH>; > + clocks = <&mstp5_clks R8A7790_CLK_THERMAL>; > + power-domains = <&cpg_clocks>; > + #thermal-sensor-cells = <0>; > +}; How are the two nodes above linked? Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
WARNING: multiple messages have this Message-ID (diff)
From: Geert Uytterhoeven <geert@linux-m68k.org> To: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com> Cc: Simon <horms@verge.net.au>, Zhang Rui <rui.zhang@intel.com>, Eduardo Valentin <edubezval@gmail.com>, Magnus <magnus.damm@gmail.com>, Linux-sh list <linux-sh@vger.kernel.org>, Linux PM list <linux-pm@vger.kernel.org>, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>, "devicetree@vger.kernel.org" <devicetree@vger.kernel.org> Subject: Re: [PATCH 2/4] thermal: rcar: enable to use thermal-zone on DT Date: Fri, 4 Dec 2015 09:32:36 +0100 [thread overview] Message-ID: <CAMuHMdUcQFcQuEmQZ4yMGwm=ouH+aQQhG3V95p=Pb56qWberQA@mail.gmail.com> (raw) In-Reply-To: <87y4dagb0i.wl%kuninori.morimoto.gx@renesas.com> Hi Morimoto-san, CC devicetree On Fri, Dec 4, 2015 at 4:17 AM, Kuninori Morimoto <kuninori.morimoto.gx@renesas.com> wrote: > From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com> > > This patch enables to use thermal-zone on DT if it was call as > "renesas,rcar-thermal-gen2". > Previous style is still supported by "renesas,rcar-thermal". > > Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com> > --- > .../devicetree/bindings/thermal/rcar-thermal.txt | 37 +++++++++++++++++- > drivers/thermal/rcar_thermal.c | 45 +++++++++++++++++++--- > 2 files changed, 74 insertions(+), 8 deletions(-) > > diff --git a/Documentation/devicetree/bindings/thermal/rcar-thermal.txt b/Documentation/devicetree/bindings/thermal/rcar-thermal.txt > index 332e625..904f204 100644 > --- a/Documentation/devicetree/bindings/thermal/rcar-thermal.txt > +++ b/Documentation/devicetree/bindings/thermal/rcar-thermal.txt > @@ -1,8 +1,9 @@ > * Renesas R-Car Thermal > > Required properties: > -- compatible : "renesas,thermal-<soctype>", "renesas,rcar-thermal" > - as fallback. > +- compatible : "renesas,thermal-<soctype>", > + "renesas,rcar-thermal-gen2" (with thermal-zone) or Ugh, another different scheme "<manuf>,<family>-<device>-<familyversion>"... What about "renesas,rcar-gen2-thermal"? > + "renesas,rcar-thermal" (without thermal-zone) as fallback. > Examples with soctypes are: > - "renesas,thermal-r8a73a4" (R-Mobile APE6) > - "renesas,thermal-r8a7779" (R-Car H1) > @@ -36,3 +37,35 @@ thermal@e61f0000 { > 0xe61f0300 0x38>; > interrupts = <0 69 IRQ_TYPE_LEVEL_HIGH>; > }; > + > +Example (with thermal-zone): > + > +thermal-zones { > + cpu_thermal: cpu-thermal { > + polling-delay-passive = <1000>; > + polling-delay = <5000>; > + > + thermal-sensors = <&thermal>; > + > + trips { > + cpu-crit { > + temperature = <1150000>; > + hysteresis = <0>; > + type = "critical"; > + }; > + }; > + cooling-maps { > + }; > + }; > +}; > + > +thermal: thermal@e61f0000 { > + compatible = "renesas,thermal-r8a7790", > + "renesas,rcar-thermal-gen2", > + "renesas,rcar-thermal"; > + reg = <0 0xe61f0000 0 0x14>, <0 0xe61f0100 0 0x38>; > + interrupts = <0 69 IRQ_TYPE_LEVEL_HIGH>; > + clocks = <&mstp5_clks R8A7790_CLK_THERMAL>; > + power-domains = <&cpg_clocks>; > + #thermal-sensor-cells = <0>; > +}; How are the two nodes above linked? Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
next prev parent reply other threads:[~2015-12-04 8:32 UTC|newest] Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top 2015-12-04 3:16 [PATCH 0/4] enable to use thermal-zone on r8a7790/1 Kuninori Morimoto 2015-12-04 3:16 ` Kuninori Morimoto 2015-12-04 3:16 ` Kuninori Morimoto 2015-12-04 3:17 ` [PATCH 1/4] thermal: rcar: move rcar_thermal_dt_ids to upside Kuninori Morimoto 2015-12-04 3:17 ` Kuninori Morimoto 2015-12-04 3:17 ` Kuninori Morimoto 2015-12-04 3:17 ` [PATCH 2/4] thermal: rcar: enable to use thermal-zone on DT Kuninori Morimoto 2015-12-04 3:17 ` Kuninori Morimoto 2015-12-04 3:17 ` Kuninori Morimoto 2015-12-04 6:21 ` Manish Badarkhe 2015-12-04 6:33 ` Manish Badarkhe 2015-12-04 7:07 ` Kuninori Morimoto 2015-12-04 7:07 ` Kuninori Morimoto 2015-12-04 7:07 ` Kuninori Morimoto 2015-12-04 8:32 ` Geert Uytterhoeven [this message] 2015-12-04 8:32 ` Geert Uytterhoeven [not found] ` <CAMuHMdUcQFcQuEmQZ4yMGwm=ouH+aQQhG3V95p=Pb56qWberQA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org> 2015-12-04 8:34 ` Geert Uytterhoeven 2015-12-04 8:34 ` Geert Uytterhoeven 2015-12-04 8:34 ` Geert Uytterhoeven 2015-12-04 3:18 ` [PATCH 3/4] ARM: shmobile: r8a7790: enable to use thermal-zone Kuninori Morimoto 2015-12-04 3:18 ` Kuninori Morimoto 2015-12-04 3:18 ` Kuninori Morimoto 2015-12-07 6:34 ` Simon Horman 2015-12-07 6:34 ` Simon Horman 2015-12-04 3:18 ` [PATCH 4/4] ARM: shmobile: r8a7791: " Kuninori Morimoto 2015-12-04 3:18 ` Kuninori Morimoto 2015-12-04 3:18 ` Kuninori Morimoto
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to='CAMuHMdUcQFcQuEmQZ4yMGwm=ouH+aQQhG3V95p=Pb56qWberQA@mail.gmail.com' \ --to=geert@linux-m68k.org \ --cc=devicetree@vger.kernel.org \ --cc=edubezval@gmail.com \ --cc=horms@verge.net.au \ --cc=kuninori.morimoto.gx@renesas.com \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-pm@vger.kernel.org \ --cc=linux-sh@vger.kernel.org \ --cc=magnus.damm@gmail.com \ --cc=rui.zhang@intel.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.