All of lore.kernel.org
 help / color / mirror / Atom feed
From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
To: Manish Badarkhe <badarkhe.manish@gmail.com>
Cc: Simon <horms@verge.net.au>, Zhang Rui <rui.zhang@intel.com>,
	Eduardo Valentin <edubezval@gmail.com>,
	Magnus <magnus.damm@gmail.com>,
	linux-sh@vger.kernel.org, linux-pm@vger.kernel.org,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 2/4] thermal: rcar: enable to use thermal-zone on DT
Date: Fri, 04 Dec 2015 07:07:54 +0000	[thread overview]
Message-ID: <87k2oug0cy.wl%kuninori.morimoto.gx@renesas.com> (raw)
In-Reply-To: <CAKDJKT47kHx9vNO_L_h085cJs3ACndiA9sQL7e2K5PtYySWJxA@mail.gmail.com>


Hi Manish

> > +static int rcar_thermal_of_get_temp(void *data, int *temp)
> > +{
> > +       struct rcar_thermal_priv *priv = data;
> > +
> > +       *temp = rcar_thermal_get_current_temp(priv);
> > +
> > +       return 0;
> > +}
> > +
> > +static int rcar_thermal_get_temp(struct thermal_zone_device *zone, int *temp)
> > +{
> > +       struct rcar_thermal_priv *priv = rcar_zone_to_priv(zone);
> > +
> > +       *temp = rcar_thermal_get_current_temp(priv);
> > +
> >         return 0;
> >  }
> >
> 
> Above two function, always returns 0. Can it possible to handle error
> and log some messages.

Thanks. Will try in v2


WARNING: multiple messages have this Message-ID (diff)
From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
To: Manish Badarkhe <badarkhe.manish@gmail.com>
Cc: Simon <horms@verge.net.au>, Zhang Rui <rui.zhang@intel.com>,
	Eduardo Valentin <edubezval@gmail.com>,
	Magnus <magnus.damm@gmail.com>, <linux-sh@vger.kernel.org>,
	<linux-pm@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 2/4] thermal: rcar: enable to use thermal-zone on DT
Date: Fri, 4 Dec 2015 07:07:54 +0000	[thread overview]
Message-ID: <87k2oug0cy.wl%kuninori.morimoto.gx@renesas.com> (raw)
In-Reply-To: <CAKDJKT47kHx9vNO_L_h085cJs3ACndiA9sQL7e2K5PtYySWJxA@mail.gmail.com>


Hi Manish

> > +static int rcar_thermal_of_get_temp(void *data, int *temp)
> > +{
> > +       struct rcar_thermal_priv *priv = data;
> > +
> > +       *temp = rcar_thermal_get_current_temp(priv);
> > +
> > +       return 0;
> > +}
> > +
> > +static int rcar_thermal_get_temp(struct thermal_zone_device *zone, int *temp)
> > +{
> > +       struct rcar_thermal_priv *priv = rcar_zone_to_priv(zone);
> > +
> > +       *temp = rcar_thermal_get_current_temp(priv);
> > +
> >         return 0;
> >  }
> >
> 
> Above two function, always returns 0. Can it possible to handle error
> and log some messages.

Thanks. Will try in v2


WARNING: multiple messages have this Message-ID (diff)
From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
To: Manish Badarkhe <badarkhe.manish@gmail.com>
Cc: Simon <horms@verge.net.au>, Zhang Rui <rui.zhang@intel.com>,
	Eduardo Valentin <edubezval@gmail.com>,
	Magnus <magnus.damm@gmail.com>,
	linux-sh@vger.kernel.org, linux-pm@vger.kernel.org,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 2/4] thermal: rcar: enable to use thermal-zone on DT
Date: Fri, 4 Dec 2015 07:07:54 +0000	[thread overview]
Message-ID: <87k2oug0cy.wl%kuninori.morimoto.gx@renesas.com> (raw)
In-Reply-To: <CAKDJKT47kHx9vNO_L_h085cJs3ACndiA9sQL7e2K5PtYySWJxA@mail.gmail.com>


Hi Manish

> > +static int rcar_thermal_of_get_temp(void *data, int *temp)
> > +{
> > +       struct rcar_thermal_priv *priv = data;
> > +
> > +       *temp = rcar_thermal_get_current_temp(priv);
> > +
> > +       return 0;
> > +}
> > +
> > +static int rcar_thermal_get_temp(struct thermal_zone_device *zone, int *temp)
> > +{
> > +       struct rcar_thermal_priv *priv = rcar_zone_to_priv(zone);
> > +
> > +       *temp = rcar_thermal_get_current_temp(priv);
> > +
> >         return 0;
> >  }
> >
> 
> Above two function, always returns 0. Can it possible to handle error
> and log some messages.

Thanks. Will try in v2

  reply	other threads:[~2015-12-04  7:07 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-12-04  3:16 [PATCH 0/4] enable to use thermal-zone on r8a7790/1 Kuninori Morimoto
2015-12-04  3:16 ` Kuninori Morimoto
2015-12-04  3:16 ` Kuninori Morimoto
2015-12-04  3:17 ` [PATCH 1/4] thermal: rcar: move rcar_thermal_dt_ids to upside Kuninori Morimoto
2015-12-04  3:17   ` Kuninori Morimoto
2015-12-04  3:17   ` Kuninori Morimoto
2015-12-04  3:17 ` [PATCH 2/4] thermal: rcar: enable to use thermal-zone on DT Kuninori Morimoto
2015-12-04  3:17   ` Kuninori Morimoto
2015-12-04  3:17   ` Kuninori Morimoto
2015-12-04  6:21   ` Manish Badarkhe
2015-12-04  6:33     ` Manish Badarkhe
2015-12-04  7:07     ` Kuninori Morimoto [this message]
2015-12-04  7:07       ` Kuninori Morimoto
2015-12-04  7:07       ` Kuninori Morimoto
2015-12-04  8:32   ` Geert Uytterhoeven
2015-12-04  8:32     ` Geert Uytterhoeven
     [not found]     ` <CAMuHMdUcQFcQuEmQZ4yMGwm=ouH+aQQhG3V95p=Pb56qWberQA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2015-12-04  8:34       ` Geert Uytterhoeven
2015-12-04  8:34         ` Geert Uytterhoeven
2015-12-04  8:34         ` Geert Uytterhoeven
2015-12-04  3:18 ` [PATCH 3/4] ARM: shmobile: r8a7790: enable to use thermal-zone Kuninori Morimoto
2015-12-04  3:18   ` Kuninori Morimoto
2015-12-04  3:18   ` Kuninori Morimoto
2015-12-07  6:34   ` Simon Horman
2015-12-07  6:34     ` Simon Horman
2015-12-04  3:18 ` [PATCH 4/4] ARM: shmobile: r8a7791: " Kuninori Morimoto
2015-12-04  3:18   ` Kuninori Morimoto
2015-12-04  3:18   ` Kuninori Morimoto

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87k2oug0cy.wl%kuninori.morimoto.gx@renesas.com \
    --to=kuninori.morimoto.gx@renesas.com \
    --cc=badarkhe.manish@gmail.com \
    --cc=edubezval@gmail.com \
    --cc=horms@verge.net.au \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=linux-sh@vger.kernel.org \
    --cc=magnus.damm@gmail.com \
    --cc=rui.zhang@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.