From: Geert Uytterhoeven <geert@linux-m68k.org> To: Laurent Pinchart <laurent.pinchart+renesas-ryLnwIuWjnjg/C1BVhZhaw@public.gmane.org> Cc: iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org, Ben Dooks <ben.dooks-4yDnlxn2s6sWdaTGBSpHTA@public.gmane.org>, Linux-sh list <linux-sh-u79uwXL29TY76Z2rM5mHXA@public.gmane.org> Subject: Re: [PATCH 1/2] iommu: Add driver for Renesas VMSA-compatible IPMMU Date: Fri, 28 Feb 2014 17:48:22 +0000 [thread overview] Message-ID: <CAMuHMdUcrANSqUmS6QJkcms_bU=aYLBXjBUL5ep=k0eQxYzw6g@mail.gmail.com> (raw) In-Reply-To: <1393601099-4413-2-git-send-email-laurent.pinchart+renesas-ryLnwIuWjnjg/C1BVhZhaw@public.gmane.org> On Fri, Feb 28, 2014 at 4:24 PM, Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com> wrote: > +/* > + * VMSA that states in section B3.6.3 "Control of Secure or Non-secure memory VMSA states > + * access, Long-descriptor format" that the NStable bit being set in a table > + * descriptor will result in the NStable and NS bits of all child entries being > + * ignored and considered as being set. The IPMMU seems not to comply with this, > + * as it generates a secure access page fault if any of the NStable and NS bits > + * isn't set when running in non-secure mode. > + */ > + /* > + * TTBCR > + * We use long descriptor, with inner-shareable WBWA tables and allocate descriptors > + * the whole 32-bit VA space to TTBR0. > + */ > + /* > + * Clear the error status flags. Unlike traditionnal interrupt flag traditional Sorry, only comments on the comments ;-) Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
WARNING: multiple messages have this Message-ID (diff)
From: Geert Uytterhoeven <geert-Td1EMuHUCqxL1ZNQvxDV9g@public.gmane.org> To: Laurent Pinchart <laurent.pinchart+renesas-ryLnwIuWjnjg/C1BVhZhaw@public.gmane.org> Cc: iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org, Ben Dooks <ben.dooks-4yDnlxn2s6sWdaTGBSpHTA@public.gmane.org>, Linux-sh list <linux-sh-u79uwXL29TY76Z2rM5mHXA@public.gmane.org> Subject: Re: [PATCH 1/2] iommu: Add driver for Renesas VMSA-compatible IPMMU Date: Fri, 28 Feb 2014 18:48:22 +0100 [thread overview] Message-ID: <CAMuHMdUcrANSqUmS6QJkcms_bU=aYLBXjBUL5ep=k0eQxYzw6g@mail.gmail.com> (raw) In-Reply-To: <1393601099-4413-2-git-send-email-laurent.pinchart+renesas-ryLnwIuWjnjg/C1BVhZhaw@public.gmane.org> On Fri, Feb 28, 2014 at 4:24 PM, Laurent Pinchart <laurent.pinchart+renesas-ryLnwIuWjnjg/C1BVhZhaw@public.gmane.org> wrote: > +/* > + * VMSA that states in section B3.6.3 "Control of Secure or Non-secure memory VMSA states > + * access, Long-descriptor format" that the NStable bit being set in a table > + * descriptor will result in the NStable and NS bits of all child entries being > + * ignored and considered as being set. The IPMMU seems not to comply with this, > + * as it generates a secure access page fault if any of the NStable and NS bits > + * isn't set when running in non-secure mode. > + */ > + /* > + * TTBCR > + * We use long descriptor, with inner-shareable WBWA tables and allocate descriptors > + * the whole 32-bit VA space to TTBR0. > + */ > + /* > + * Clear the error status flags. Unlike traditionnal interrupt flag traditional Sorry, only comments on the comments ;-) Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert-Td1EMuHUCqxL1ZNQvxDV9g@public.gmane.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
next prev parent reply other threads:[~2014-02-28 17:48 UTC|newest] Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top 2014-02-28 15:24 [PATCH 0/2] Renesas VMSA-compatible IPMMU driver Laurent Pinchart 2014-02-28 15:24 ` Laurent Pinchart [not found] ` <1393601099-4413-1-git-send-email-laurent.pinchart+renesas-ryLnwIuWjnjg/C1BVhZhaw@public.gmane.org> 2014-02-28 15:24 ` [PATCH 1/2] iommu: Add driver for Renesas VMSA-compatible IPMMU Laurent Pinchart 2014-02-28 15:24 ` Laurent Pinchart 2014-02-28 15:37 ` Ben Dooks 2014-02-28 15:48 ` Laurent Pinchart 2014-02-28 15:48 ` Laurent Pinchart [not found] ` <1393601099-4413-2-git-send-email-laurent.pinchart+renesas-ryLnwIuWjnjg/C1BVhZhaw@public.gmane.org> 2014-02-28 17:48 ` Geert Uytterhoeven [this message] 2014-02-28 17:48 ` Geert Uytterhoeven 2014-03-02 20:59 ` Laurent Pinchart 2014-03-02 21:00 ` Laurent Pinchart 2014-02-28 15:24 ` [PATCH 2/2] [TEST] ARM: shmobile: koelsch-reference: Instantiate IPMMU-MX Laurent Pinchart 2014-02-28 15:24 ` Laurent Pinchart
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to='CAMuHMdUcrANSqUmS6QJkcms_bU=aYLBXjBUL5ep=k0eQxYzw6g@mail.gmail.com' \ --to=geert@linux-m68k.org \ --cc=ben.dooks-4yDnlxn2s6sWdaTGBSpHTA@public.gmane.org \ --cc=iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org \ --cc=laurent.pinchart+renesas-ryLnwIuWjnjg/C1BVhZhaw@public.gmane.org \ --cc=linux-sh-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.