All of lore.kernel.org
 help / color / mirror / Atom feed
From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>,
	iommu@lists.linux-foundation.org,
	Linux-sh list <linux-sh@vger.kernel.org>,
	Ben Dooks <ben.dooks@codethink.co.uk>
Subject: Re: [PATCH 1/2] iommu: Add driver for Renesas VMSA-compatible IPMMU
Date: Sun, 02 Mar 2014 20:59:11 +0000	[thread overview]
Message-ID: <9614296.npf9XYVJ8Q@avalon> (raw)
In-Reply-To: <CAMuHMdUcrANSqUmS6QJkcms_bU=aYLBXjBUL5ep=k0eQxYzw6g@mail.gmail.com>

Hi Geert,

Thank you for the review.

On Friday 28 February 2014 18:48:22 Geert Uytterhoeven wrote:
> On Fri, Feb 28, 2014 at 4:24 PM, Laurent Pinchart wrote:
> > +/*
> > + * VMSA that states in section B3.6.3 "Control of Secure or Non-secure
> > memory
>
> VMSA states
> 
> > + * access, Long-descriptor format" that the NStable bit being set in a
> > table + * descriptor will result in the NStable and NS bits of all child
> > entries being + * ignored and considered as being set. The IPMMU seems
> > not to comply with this, + * as it generates a secure access page fault
> > if any of the NStable and NS bits + * isn't set when running in
> > non-secure mode.
> > + */
> > 
> > +       /*
> > +        * TTBCR
> > +        * We use long descriptor, with inner-shareable WBWA tables and
> > allocate
>
> descriptors
> 
> > +        * the whole 32-bit VA space to TTBR0.
> > +        */
> > 
> > +       /*
> > +        * Clear the error status flags. Unlike traditionnal interrupt
> > flag
> 
> traditional
> 
> Sorry, only comments on the comments ;-)

I'll of course assume this means that the driver is perfect ;-)

I'll fix all this in v2.

-- 
Regards,

Laurent Pinchart


WARNING: multiple messages have this Message-ID (diff)
From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>,
	iommu@lists.linux-foundation.org,
	Linux-sh list <linux-sh@vger.kernel.org>,
	Ben Dooks <ben.dooks@codethink.co.uk>
Subject: Re: [PATCH 1/2] iommu: Add driver for Renesas VMSA-compatible IPMMU
Date: Sun, 02 Mar 2014 22:00:33 +0100	[thread overview]
Message-ID: <9614296.npf9XYVJ8Q@avalon> (raw)
In-Reply-To: <CAMuHMdUcrANSqUmS6QJkcms_bU=aYLBXjBUL5ep=k0eQxYzw6g@mail.gmail.com>

Hi Geert,

Thank you for the review.

On Friday 28 February 2014 18:48:22 Geert Uytterhoeven wrote:
> On Fri, Feb 28, 2014 at 4:24 PM, Laurent Pinchart wrote:
> > +/*
> > + * VMSA that states in section B3.6.3 "Control of Secure or Non-secure
> > memory
>
> VMSA states
> 
> > + * access, Long-descriptor format" that the NStable bit being set in a
> > table + * descriptor will result in the NStable and NS bits of all child
> > entries being + * ignored and considered as being set. The IPMMU seems
> > not to comply with this, + * as it generates a secure access page fault
> > if any of the NStable and NS bits + * isn't set when running in
> > non-secure mode.
> > + */
> > 
> > +       /*
> > +        * TTBCR
> > +        * We use long descriptor, with inner-shareable WBWA tables and
> > allocate
>
> descriptors
> 
> > +        * the whole 32-bit VA space to TTBR0.
> > +        */
> > 
> > +       /*
> > +        * Clear the error status flags. Unlike traditionnal interrupt
> > flag
> 
> traditional
> 
> Sorry, only comments on the comments ;-)

I'll of course assume this means that the driver is perfect ;-)

I'll fix all this in v2.

-- 
Regards,

Laurent Pinchart


  reply	other threads:[~2014-03-02 20:59 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-02-28 15:24 [PATCH 0/2] Renesas VMSA-compatible IPMMU driver Laurent Pinchart
2014-02-28 15:24 ` Laurent Pinchart
     [not found] ` <1393601099-4413-1-git-send-email-laurent.pinchart+renesas-ryLnwIuWjnjg/C1BVhZhaw@public.gmane.org>
2014-02-28 15:24   ` [PATCH 1/2] iommu: Add driver for Renesas VMSA-compatible IPMMU Laurent Pinchart
2014-02-28 15:24     ` Laurent Pinchart
2014-02-28 15:37     ` Ben Dooks
2014-02-28 15:48       ` Laurent Pinchart
2014-02-28 15:48         ` Laurent Pinchart
     [not found]     ` <1393601099-4413-2-git-send-email-laurent.pinchart+renesas-ryLnwIuWjnjg/C1BVhZhaw@public.gmane.org>
2014-02-28 17:48       ` Geert Uytterhoeven
2014-02-28 17:48         ` Geert Uytterhoeven
2014-03-02 20:59         ` Laurent Pinchart [this message]
2014-03-02 21:00           ` Laurent Pinchart
2014-02-28 15:24 ` [PATCH 2/2] [TEST] ARM: shmobile: koelsch-reference: Instantiate IPMMU-MX Laurent Pinchart
2014-02-28 15:24   ` Laurent Pinchart

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=9614296.npf9XYVJ8Q@avalon \
    --to=laurent.pinchart@ideasonboard.com \
    --cc=ben.dooks@codethink.co.uk \
    --cc=geert@linux-m68k.org \
    --cc=iommu@lists.linux-foundation.org \
    --cc=laurent.pinchart+renesas@ideasonboard.com \
    --cc=linux-sh@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.