From: Geert Uytterhoeven <geert@linux-m68k.org> To: Laurent Pinchart <laurent.pinchart@ideasonboard.com> Cc: Geert Uytterhoeven <geert+renesas@glider.be>, Simon Horman <horms@verge.net.au>, Magnus Damm <magnus.damm@gmail.com>, Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>, Philipp Zabel <p.zabel@pengutronix.de>, Michael Turquette <mturquette@baylibre.com>, Stephen Boyd <sboyd@codeaurora.org>, Dirk Behme <dirk.behme@de.bosch.com>, linux-renesas-soc@vger.kernel.org, "linux-arm-kernel@lists.infradead.org" <linux-arm-kernel@lists.infradead.org>, "devicetree@vger.kernel.org" <devicetree@vger.kernel.org> Subject: Re: [PATCH/RFC v3 01/22] reset: Add renesas,rst DT bindings Date: Fri, 10 Jun 2016 09:52:07 +0200 [thread overview] Message-ID: <CAMuHMdVVCwhVBzPTRVzU6MFbP_sfQPu_dGx1Ef2urNMD+Eda_g@mail.gmail.com> (raw) In-Reply-To: <10393056.BKo7UTPXFi@avalon> Hi Laurent, On Thu, Jun 2, 2016 at 11:47 PM, Laurent Pinchart <laurent.pinchart@ideasonboard.com> wrote: >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/reset/renesas,rst.txt >> @@ -0,0 +1,35 @@ >> +DT bindings for the Renesas R-Car Reset Controller >> + >> +The R-Car Reset Controller provides reset control, and implements the >> following >> +functions: >> + - Latching of the levels on mode pins when PRESET# is negated, >> + - Mode monitoring register, >> + - Reset control of peripheral devices (on R-Car Gen1), >> + - Watchdog timer (on R-Car Gen1). >> + - Register-based reset control and boot address registers for the various >> CPU >> + cores (on R-Car Gen2/Gen3), >> + >> + >> +Required properties: >> + - compatible: Should be >> + - "renesas,<soctype>-reset-wdt" for R-Car Gen1, >> + - "renesas,<soctype>-rst" for R-Car Gen2/Gen3. >> + Examples with soctypes are: >> + - "renesas,r8a7778-reset-wdt" (R-Car M1A) >> + - "renesas,r8a7779-reset-wdt" (R-Car H1) >> + - "renesas,r8a7790-rst" (R-Car H2) >> + - "renesas,r8a7791-rst" (R-Car M2-W) >> + - "renesas,r8a7792-rst" (R-Car V2H >> + - "renesas,r8a7793-rst" (R-Car M2-N) >> + - "renesas,r8a7794-rst" (R-Car E2) >> + - "renesas,r8a7795-rst" (R-Car H3) >> + - "renesas,r8a7796-rst" (R-Car M3-W) > > Any specific reason for such a large indentation ? (I know this is really > nitpicking) To align the two paragraphs and lists. > Apart from that, it's just a bit of a shame we can't have generic compatible > strings, but that would require additional DT properties to describe the reset > controller features, and I assume that's not a path we want to take. The reset controller is one of the few blocks that really differs between members of the same family, due to the relationship with the various CPU cores. > Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> Thanks! Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
WARNING: multiple messages have this Message-ID (diff)
From: geert@linux-m68k.org (Geert Uytterhoeven) To: linux-arm-kernel@lists.infradead.org Subject: [PATCH/RFC v3 01/22] reset: Add renesas,rst DT bindings Date: Fri, 10 Jun 2016 09:52:07 +0200 [thread overview] Message-ID: <CAMuHMdVVCwhVBzPTRVzU6MFbP_sfQPu_dGx1Ef2urNMD+Eda_g@mail.gmail.com> (raw) In-Reply-To: <10393056.BKo7UTPXFi@avalon> Hi Laurent, On Thu, Jun 2, 2016 at 11:47 PM, Laurent Pinchart <laurent.pinchart@ideasonboard.com> wrote: >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/reset/renesas,rst.txt >> @@ -0,0 +1,35 @@ >> +DT bindings for the Renesas R-Car Reset Controller >> + >> +The R-Car Reset Controller provides reset control, and implements the >> following >> +functions: >> + - Latching of the levels on mode pins when PRESET# is negated, >> + - Mode monitoring register, >> + - Reset control of peripheral devices (on R-Car Gen1), >> + - Watchdog timer (on R-Car Gen1). >> + - Register-based reset control and boot address registers for the various >> CPU >> + cores (on R-Car Gen2/Gen3), >> + >> + >> +Required properties: >> + - compatible: Should be >> + - "renesas,<soctype>-reset-wdt" for R-Car Gen1, >> + - "renesas,<soctype>-rst" for R-Car Gen2/Gen3. >> + Examples with soctypes are: >> + - "renesas,r8a7778-reset-wdt" (R-Car M1A) >> + - "renesas,r8a7779-reset-wdt" (R-Car H1) >> + - "renesas,r8a7790-rst" (R-Car H2) >> + - "renesas,r8a7791-rst" (R-Car M2-W) >> + - "renesas,r8a7792-rst" (R-Car V2H >> + - "renesas,r8a7793-rst" (R-Car M2-N) >> + - "renesas,r8a7794-rst" (R-Car E2) >> + - "renesas,r8a7795-rst" (R-Car H3) >> + - "renesas,r8a7796-rst" (R-Car M3-W) > > Any specific reason for such a large indentation ? (I know this is really > nitpicking) To align the two paragraphs and lists. > Apart from that, it's just a bit of a shame we can't have generic compatible > strings, but that would require additional DT properties to describe the reset > controller features, and I assume that's not a path we want to take. The reset controller is one of the few blocks that really differs between members of the same family, due to the relationship with the various CPU cores. > Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> Thanks! Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert at linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
next prev parent reply other threads:[~2016-06-10 7:52 UTC|newest] Thread overview: 74+ messages / expand[flat|nested] mbox.gz Atom feed top 2016-06-01 19:20 [PATCH/RFC v3 00/22] soc: renesas: Add R-Car RST driver for obtaining mode pin state Geert Uytterhoeven 2016-06-01 19:20 ` [PATCH/RFC v3 01/22] reset: Add renesas,rst DT bindings Geert Uytterhoeven 2016-06-02 5:40 ` Dirk Behme 2016-06-02 5:40 ` Dirk Behme 2016-06-02 5:40 ` Dirk Behme 2016-06-02 21:47 ` Laurent Pinchart 2016-06-02 21:47 ` Laurent Pinchart 2016-06-10 7:52 ` Geert Uytterhoeven [this message] 2016-06-10 7:52 ` Geert Uytterhoeven 2016-06-01 19:21 ` [PATCH/RFC v3 02/22] soc: renesas: Add R-Car RST driver Geert Uytterhoeven 2016-06-02 5:42 ` Dirk Behme 2016-06-02 5:42 ` Dirk Behme 2016-06-02 5:42 ` Dirk Behme 2016-06-10 7:58 ` Geert Uytterhoeven 2016-06-10 7:58 ` Geert Uytterhoeven 2016-06-10 8:38 ` Dirk Behme 2016-06-10 8:38 ` Dirk Behme 2016-06-10 8:38 ` Dirk Behme 2016-06-10 13:08 ` Laurent Pinchart 2016-06-10 13:08 ` Laurent Pinchart 2016-06-02 21:58 ` Laurent Pinchart 2016-06-02 21:58 ` Laurent Pinchart 2016-06-10 7:54 ` Geert Uytterhoeven 2016-06-10 7:54 ` Geert Uytterhoeven 2016-06-10 7:54 ` Geert Uytterhoeven 2016-06-01 19:21 ` [PATCH/RFC v3 05/22] ARM: dts: r8a7790: Add device node for RST module Geert Uytterhoeven 2016-06-01 19:21 ` [PATCH/RFC v3 06/22] ARM: dts: r8a7791: " Geert Uytterhoeven 2016-06-01 19:21 ` [PATCH/RFC v3 07/22] ARM: dts: r8a7793: " Geert Uytterhoeven 2016-06-01 19:21 ` [PATCH/RFC v3 08/22] ARM: dts: r8a7794: " Geert Uytterhoeven 2016-06-01 19:21 ` [PATCH/RFC v3 09/22] arm64: renesas: r8a7795 dtsi: " Geert Uytterhoeven 2016-06-01 19:21 ` [PATCH/RFC v3 10/22] arm64: renesas: r8a7796 " Geert Uytterhoeven 2016-06-01 19:21 ` [PATCH/RFC v3 13/22] clk: renesas: rcar-gen2: Obtain mode pin values using RST driver Geert Uytterhoeven 2016-06-01 19:21 ` [PATCH/RFC v3 14/22] clk: renesas: r8a7795: Obtain mode pin values from R-Car " Geert Uytterhoeven 2016-06-02 22:01 ` Laurent Pinchart 2016-06-02 22:01 ` Laurent Pinchart 2016-06-01 19:21 ` [PATCH/RFC v3 15/22] clk: renesas: r8a7796: " Geert Uytterhoeven 2016-06-02 22:02 ` Laurent Pinchart 2016-06-02 22:02 ` Laurent Pinchart 2016-06-01 19:21 ` [PATCH/RFC v3 17/22] ARM: shmobile: r8a7778: Stop passing mode pins state to clock driver Geert Uytterhoeven 2016-06-01 19:21 ` [PATCH/RFC v3 18/22] ARM: shmobile: r8a7779: " Geert Uytterhoeven 2016-06-01 19:21 ` [PATCH/RFC v3 19/22] ARM: shmobile: rcar-gen2: " Geert Uytterhoeven 2016-06-01 19:21 ` [PATCH/RFC v3 20/22] clk: renesas: r8a7778: Remove obsolete r8a7778_clocks_init() Geert Uytterhoeven 2016-06-02 5:54 ` Dirk Behme 2016-06-02 5:54 ` Dirk Behme 2016-06-02 5:54 ` Dirk Behme 2016-06-02 7:13 ` Geert Uytterhoeven 2016-06-02 7:13 ` Geert Uytterhoeven [not found] ` <1464808880-343-1-git-send-email-geert+renesas-gXvu3+zWzMSzQB+pC5nmwQ@public.gmane.org> 2016-06-01 19:21 ` [PATCH/RFC v3 03/22] ARM: dts: r8a7778: Add device node for RESET/WDT module Geert Uytterhoeven 2016-06-01 19:21 ` Geert Uytterhoeven 2016-06-01 19:21 ` [PATCH/RFC v3 04/22] ARM: dts: r8a7779: " Geert Uytterhoeven 2016-06-01 19:21 ` Geert Uytterhoeven 2016-06-01 19:21 ` [PATCH/RFC v3 11/22] clk: renesas: r8a7778: Obtain mode pin values using R-Car RST driver Geert Uytterhoeven 2016-06-01 19:21 ` Geert Uytterhoeven 2016-06-01 19:21 ` [PATCH/RFC v3 12/22] clk: renesas: r8a7779: Obtain mode pin values from " Geert Uytterhoeven 2016-06-01 19:21 ` Geert Uytterhoeven 2016-06-01 19:21 ` [PATCH/RFC v3 16/22] clk: renesas: rcar-gen3-cpg: Remove obsolete rcar_gen3_read_mode_pins() Geert Uytterhoeven 2016-06-01 19:21 ` Geert Uytterhoeven [not found] ` <1464808880-343-17-git-send-email-geert+renesas-gXvu3+zWzMSzQB+pC5nmwQ@public.gmane.org> 2016-06-02 22:02 ` Laurent Pinchart 2016-06-02 22:02 ` Laurent Pinchart 2016-06-02 22:02 ` Laurent Pinchart 2016-06-01 19:21 ` [PATCH/RFC v3 21/22] clk: renesas: r8a7779: Remove obsolete r8a7779_clocks_init() Geert Uytterhoeven 2016-06-01 19:21 ` Geert Uytterhoeven 2016-06-01 19:21 ` [PATCH/RFC v3 22/22] clk: renesas: rcar-gen2: Remove obsolete rcar_gen2_clocks_init() Geert Uytterhoeven 2016-06-02 5:57 ` [PATCH/RFC v3 00/22] soc: renesas: Add R-Car RST driver for obtaining mode pin state Dirk Behme 2016-06-02 5:57 ` Dirk Behme 2016-06-02 5:57 ` Dirk Behme 2016-06-30 20:14 ` Stephen Boyd 2016-06-30 20:14 ` Stephen Boyd 2016-09-01 11:46 ` Geert Uytterhoeven 2016-09-01 11:46 ` Geert Uytterhoeven 2016-09-12 22:16 ` Stephen Boyd 2016-09-12 22:16 ` Stephen Boyd 2016-09-13 6:48 ` Geert Uytterhoeven 2016-09-13 6:48 ` Geert Uytterhoeven
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=CAMuHMdVVCwhVBzPTRVzU6MFbP_sfQPu_dGx1Ef2urNMD+Eda_g@mail.gmail.com \ --to=geert@linux-m68k.org \ --cc=devicetree@vger.kernel.org \ --cc=dirk.behme@de.bosch.com \ --cc=geert+renesas@glider.be \ --cc=horms@verge.net.au \ --cc=laurent.pinchart+renesas@ideasonboard.com \ --cc=laurent.pinchart@ideasonboard.com \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-renesas-soc@vger.kernel.org \ --cc=magnus.damm@gmail.com \ --cc=mturquette@baylibre.com \ --cc=p.zabel@pengutronix.de \ --cc=sboyd@codeaurora.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.