From: Geert Uytterhoeven <geert@linux-m68k.org> To: Randy Dunlap <rdunlap@infradead.org> Cc: linux-kernel@vger.kernel.org, Liam Girdwood <lgirdwood@gmail.com>, Mark Brown <broonie@kernel.org>, alsa-devel@alsa-project.org, Codrin Ciubotariu <codrin.ciubotariu@microchip.com> Subject: Re: [PATCH] ASoC: atmel: add COMPILE_TEST for SND_ATMEL_SOC_PDC Date: Mon, 4 Oct 2021 09:14:32 +0200 [thread overview] Message-ID: <CAMuHMdVuObZvVCkQbXfmruB_RnprkghAv6b14Pz5nC+7M4YtzQ@mail.gmail.com> (raw) In-Reply-To: <20211003030357.32456-1-rdunlap@infradead.org> Hi Randy, On Sun, Oct 3, 2021 at 5:04 AM Randy Dunlap <rdunlap@infradead.org> wrote: > Geert pointed out that since sound/soc has the soc_dummy_driver for > NO_DMA platforms, it is possible (desirable) to have drivers that > depend on HAS_DMA to alternately depend on COMPILE_TEST. Actually I had never heard about the soc_dummy_driver before ;-) I did know about the dummies in include/linux/dma-mapping.h. > This means that SND_ATMEL_SOC_PDC can depend on HAS_DMA || COMPIE_TEST. COMPILE_TEST > Fixes: 6c5c659dfe3f ("ASoC: atmel: ATMEL drivers don't need HAS_DMA") > Signed-off-by: Randy Dunlap <rdunlap@infradead.org> > Suggested-by: Geert Uytterhoeven <geert@linux-m68k.org> > Cc: Liam Girdwood <lgirdwood@gmail.com> > Cc: Mark Brown <broonie@kernel.org> > Cc: alsa-devel@alsa-project.org > Cc: Codrin Ciubotariu <codrin.ciubotariu@microchip.com> > --- > sound/soc/atmel/Kconfig | 1 + > 1 file changed, 1 insertion(+) > > --- linux-next-20211001.orig/sound/soc/atmel/Kconfig > +++ linux-next-20211001/sound/soc/atmel/Kconfig > @@ -11,6 +11,7 @@ if SND_ATMEL_SOC > > config SND_ATMEL_SOC_PDC > bool > + depends on HAS_DMA || COMPILE_TEST > > config SND_ATMEL_SOC_DMA > bool The actual change LGTM, so Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be> Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
WARNING: multiple messages have this Message-ID (diff)
From: Geert Uytterhoeven <geert@linux-m68k.org> To: Randy Dunlap <rdunlap@infradead.org> Cc: Codrin Ciubotariu <codrin.ciubotariu@microchip.com>, alsa-devel@alsa-project.org, Mark Brown <broonie@kernel.org>, linux-kernel@vger.kernel.org, Liam Girdwood <lgirdwood@gmail.com> Subject: Re: [PATCH] ASoC: atmel: add COMPILE_TEST for SND_ATMEL_SOC_PDC Date: Mon, 4 Oct 2021 09:14:32 +0200 [thread overview] Message-ID: <CAMuHMdVuObZvVCkQbXfmruB_RnprkghAv6b14Pz5nC+7M4YtzQ@mail.gmail.com> (raw) In-Reply-To: <20211003030357.32456-1-rdunlap@infradead.org> Hi Randy, On Sun, Oct 3, 2021 at 5:04 AM Randy Dunlap <rdunlap@infradead.org> wrote: > Geert pointed out that since sound/soc has the soc_dummy_driver for > NO_DMA platforms, it is possible (desirable) to have drivers that > depend on HAS_DMA to alternately depend on COMPILE_TEST. Actually I had never heard about the soc_dummy_driver before ;-) I did know about the dummies in include/linux/dma-mapping.h. > This means that SND_ATMEL_SOC_PDC can depend on HAS_DMA || COMPIE_TEST. COMPILE_TEST > Fixes: 6c5c659dfe3f ("ASoC: atmel: ATMEL drivers don't need HAS_DMA") > Signed-off-by: Randy Dunlap <rdunlap@infradead.org> > Suggested-by: Geert Uytterhoeven <geert@linux-m68k.org> > Cc: Liam Girdwood <lgirdwood@gmail.com> > Cc: Mark Brown <broonie@kernel.org> > Cc: alsa-devel@alsa-project.org > Cc: Codrin Ciubotariu <codrin.ciubotariu@microchip.com> > --- > sound/soc/atmel/Kconfig | 1 + > 1 file changed, 1 insertion(+) > > --- linux-next-20211001.orig/sound/soc/atmel/Kconfig > +++ linux-next-20211001/sound/soc/atmel/Kconfig > @@ -11,6 +11,7 @@ if SND_ATMEL_SOC > > config SND_ATMEL_SOC_PDC > bool > + depends on HAS_DMA || COMPILE_TEST > > config SND_ATMEL_SOC_DMA > bool The actual change LGTM, so Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be> Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
next prev parent reply other threads:[~2021-10-04 7:15 UTC|newest] Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-10-03 3:03 [PATCH] ASoC: atmel: add COMPILE_TEST for SND_ATMEL_SOC_PDC Randy Dunlap 2021-10-03 3:03 ` Randy Dunlap 2021-10-04 7:14 ` Geert Uytterhoeven [this message] 2021-10-04 7:14 ` Geert Uytterhoeven 2021-10-13 8:15 ` Codrin.Ciubotariu 2021-10-13 8:15 ` Codrin.Ciubotariu 2021-10-13 8:40 ` Geert Uytterhoeven 2021-10-13 8:40 ` Geert Uytterhoeven 2021-10-13 9:33 ` Codrin.Ciubotariu 2021-10-13 9:33 ` Codrin.Ciubotariu
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=CAMuHMdVuObZvVCkQbXfmruB_RnprkghAv6b14Pz5nC+7M4YtzQ@mail.gmail.com \ --to=geert@linux-m68k.org \ --cc=alsa-devel@alsa-project.org \ --cc=broonie@kernel.org \ --cc=codrin.ciubotariu@microchip.com \ --cc=lgirdwood@gmail.com \ --cc=linux-kernel@vger.kernel.org \ --cc=rdunlap@infradead.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.