* [PATCH] ASoC: atmel: add COMPILE_TEST for SND_ATMEL_SOC_PDC
@ 2021-10-03 3:03 ` Randy Dunlap
0 siblings, 0 replies; 10+ messages in thread
From: Randy Dunlap @ 2021-10-03 3:03 UTC (permalink / raw)
To: linux-kernel
Cc: Randy Dunlap, Geert Uytterhoeven, Liam Girdwood, Mark Brown,
alsa-devel, Codrin Ciubotariu
Geert pointed out that since sound/soc has the soc_dummy_driver for
NO_DMA platforms, it is possible (desirable) to have drivers that
depend on HAS_DMA to alternately depend on COMPILE_TEST.
This means that SND_ATMEL_SOC_PDC can depend on HAS_DMA || COMPIE_TEST.
Fixes: 6c5c659dfe3f ("ASoC: atmel: ATMEL drivers don't need HAS_DMA")
Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
Suggested-by: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Liam Girdwood <lgirdwood@gmail.com>
Cc: Mark Brown <broonie@kernel.org>
Cc: alsa-devel@alsa-project.org
Cc: Codrin Ciubotariu <codrin.ciubotariu@microchip.com>
---
sound/soc/atmel/Kconfig | 1 +
1 file changed, 1 insertion(+)
--- linux-next-20211001.orig/sound/soc/atmel/Kconfig
+++ linux-next-20211001/sound/soc/atmel/Kconfig
@@ -11,6 +11,7 @@ if SND_ATMEL_SOC
config SND_ATMEL_SOC_PDC
bool
+ depends on HAS_DMA || COMPILE_TEST
config SND_ATMEL_SOC_DMA
bool
^ permalink raw reply [flat|nested] 10+ messages in thread* [PATCH] ASoC: atmel: add COMPILE_TEST for SND_ATMEL_SOC_PDC
@ 2021-10-03 3:03 ` Randy Dunlap
0 siblings, 0 replies; 10+ messages in thread
From: Randy Dunlap @ 2021-10-03 3:03 UTC (permalink / raw)
To: linux-kernel
Cc: alsa-devel, Randy Dunlap, Liam Girdwood, Mark Brown,
Geert Uytterhoeven, Codrin Ciubotariu
Geert pointed out that since sound/soc has the soc_dummy_driver for
NO_DMA platforms, it is possible (desirable) to have drivers that
depend on HAS_DMA to alternately depend on COMPILE_TEST.
This means that SND_ATMEL_SOC_PDC can depend on HAS_DMA || COMPIE_TEST.
Fixes: 6c5c659dfe3f ("ASoC: atmel: ATMEL drivers don't need HAS_DMA")
Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
Suggested-by: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Liam Girdwood <lgirdwood@gmail.com>
Cc: Mark Brown <broonie@kernel.org>
Cc: alsa-devel@alsa-project.org
Cc: Codrin Ciubotariu <codrin.ciubotariu@microchip.com>
---
sound/soc/atmel/Kconfig | 1 +
1 file changed, 1 insertion(+)
--- linux-next-20211001.orig/sound/soc/atmel/Kconfig
+++ linux-next-20211001/sound/soc/atmel/Kconfig
@@ -11,6 +11,7 @@ if SND_ATMEL_SOC
config SND_ATMEL_SOC_PDC
bool
+ depends on HAS_DMA || COMPILE_TEST
config SND_ATMEL_SOC_DMA
bool
^ permalink raw reply [flat|nested] 10+ messages in thread* Re: [PATCH] ASoC: atmel: add COMPILE_TEST for SND_ATMEL_SOC_PDC
2021-10-03 3:03 ` Randy Dunlap
@ 2021-10-04 7:14 ` Geert Uytterhoeven
-1 siblings, 0 replies; 10+ messages in thread
From: Geert Uytterhoeven @ 2021-10-04 7:14 UTC (permalink / raw)
To: Randy Dunlap
Cc: linux-kernel, Liam Girdwood, Mark Brown, alsa-devel, Codrin Ciubotariu
Hi Randy,
On Sun, Oct 3, 2021 at 5:04 AM Randy Dunlap <rdunlap@infradead.org> wrote:
> Geert pointed out that since sound/soc has the soc_dummy_driver for
> NO_DMA platforms, it is possible (desirable) to have drivers that
> depend on HAS_DMA to alternately depend on COMPILE_TEST.
Actually I had never heard about the soc_dummy_driver before ;-)
I did know about the dummies in include/linux/dma-mapping.h.
> This means that SND_ATMEL_SOC_PDC can depend on HAS_DMA || COMPIE_TEST.
COMPILE_TEST
> Fixes: 6c5c659dfe3f ("ASoC: atmel: ATMEL drivers don't need HAS_DMA")
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> Suggested-by: Geert Uytterhoeven <geert@linux-m68k.org>
> Cc: Liam Girdwood <lgirdwood@gmail.com>
> Cc: Mark Brown <broonie@kernel.org>
> Cc: alsa-devel@alsa-project.org
> Cc: Codrin Ciubotariu <codrin.ciubotariu@microchip.com>
> ---
> sound/soc/atmel/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> --- linux-next-20211001.orig/sound/soc/atmel/Kconfig
> +++ linux-next-20211001/sound/soc/atmel/Kconfig
> @@ -11,6 +11,7 @@ if SND_ATMEL_SOC
>
> config SND_ATMEL_SOC_PDC
> bool
> + depends on HAS_DMA || COMPILE_TEST
>
> config SND_ATMEL_SOC_DMA
> bool
The actual change LGTM, so
Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
^ permalink raw reply [flat|nested] 10+ messages in thread* Re: [PATCH] ASoC: atmel: add COMPILE_TEST for SND_ATMEL_SOC_PDC
@ 2021-10-04 7:14 ` Geert Uytterhoeven
0 siblings, 0 replies; 10+ messages in thread
From: Geert Uytterhoeven @ 2021-10-04 7:14 UTC (permalink / raw)
To: Randy Dunlap
Cc: Codrin Ciubotariu, alsa-devel, Mark Brown, linux-kernel, Liam Girdwood
Hi Randy,
On Sun, Oct 3, 2021 at 5:04 AM Randy Dunlap <rdunlap@infradead.org> wrote:
> Geert pointed out that since sound/soc has the soc_dummy_driver for
> NO_DMA platforms, it is possible (desirable) to have drivers that
> depend on HAS_DMA to alternately depend on COMPILE_TEST.
Actually I had never heard about the soc_dummy_driver before ;-)
I did know about the dummies in include/linux/dma-mapping.h.
> This means that SND_ATMEL_SOC_PDC can depend on HAS_DMA || COMPIE_TEST.
COMPILE_TEST
> Fixes: 6c5c659dfe3f ("ASoC: atmel: ATMEL drivers don't need HAS_DMA")
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> Suggested-by: Geert Uytterhoeven <geert@linux-m68k.org>
> Cc: Liam Girdwood <lgirdwood@gmail.com>
> Cc: Mark Brown <broonie@kernel.org>
> Cc: alsa-devel@alsa-project.org
> Cc: Codrin Ciubotariu <codrin.ciubotariu@microchip.com>
> ---
> sound/soc/atmel/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> --- linux-next-20211001.orig/sound/soc/atmel/Kconfig
> +++ linux-next-20211001/sound/soc/atmel/Kconfig
> @@ -11,6 +11,7 @@ if SND_ATMEL_SOC
>
> config SND_ATMEL_SOC_PDC
> bool
> + depends on HAS_DMA || COMPILE_TEST
>
> config SND_ATMEL_SOC_DMA
> bool
The actual change LGTM, so
Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] ASoC: atmel: add COMPILE_TEST for SND_ATMEL_SOC_PDC
2021-10-03 3:03 ` Randy Dunlap
@ 2021-10-13 8:15 ` Codrin.Ciubotariu
-1 siblings, 0 replies; 10+ messages in thread
From: Codrin.Ciubotariu @ 2021-10-13 8:15 UTC (permalink / raw)
To: rdunlap, linux-kernel; +Cc: geert, lgirdwood, broonie, alsa-devel
On 03.10.2021 06:03, Randy Dunlap wrote:
> Geert pointed out that since sound/soc has the soc_dummy_driver for
> NO_DMA platforms, it is possible (desirable) to have drivers that
> depend on HAS_DMA to alternately depend on COMPILE_TEST.
>
> This means that SND_ATMEL_SOC_PDC can depend on HAS_DMA || COMPIE_TEST.
>
> Fixes: 6c5c659dfe3f ("ASoC: atmel: ATMEL drivers don't need HAS_DMA")
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> Suggested-by: Geert Uytterhoeven <geert@linux-m68k.org>
> Cc: Liam Girdwood <lgirdwood@gmail.com>
> Cc: Mark Brown <broonie@kernel.org>
> Cc: alsa-devel@alsa-project.org
> Cc: Codrin Ciubotariu <codrin.ciubotariu@microchip.com>
> ---
> sound/soc/atmel/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> --- linux-next-20211001.orig/sound/soc/atmel/Kconfig
> +++ linux-next-20211001/sound/soc/atmel/Kconfig
> @@ -11,6 +11,7 @@ if SND_ATMEL_SOC
>
> config SND_ATMEL_SOC_PDC
> bool
> + depends on HAS_DMA || COMPILE_TEST
SND_ATMEL_SOC_PDC compiles fine without HAS_DMA, so I don't understand
the need for this...
^ permalink raw reply [flat|nested] 10+ messages in thread* Re: [PATCH] ASoC: atmel: add COMPILE_TEST for SND_ATMEL_SOC_PDC
@ 2021-10-13 8:15 ` Codrin.Ciubotariu
0 siblings, 0 replies; 10+ messages in thread
From: Codrin.Ciubotariu @ 2021-10-13 8:15 UTC (permalink / raw)
To: rdunlap, linux-kernel; +Cc: alsa-devel, broonie, geert, lgirdwood
On 03.10.2021 06:03, Randy Dunlap wrote:
> Geert pointed out that since sound/soc has the soc_dummy_driver for
> NO_DMA platforms, it is possible (desirable) to have drivers that
> depend on HAS_DMA to alternately depend on COMPILE_TEST.
>
> This means that SND_ATMEL_SOC_PDC can depend on HAS_DMA || COMPIE_TEST.
>
> Fixes: 6c5c659dfe3f ("ASoC: atmel: ATMEL drivers don't need HAS_DMA")
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> Suggested-by: Geert Uytterhoeven <geert@linux-m68k.org>
> Cc: Liam Girdwood <lgirdwood@gmail.com>
> Cc: Mark Brown <broonie@kernel.org>
> Cc: alsa-devel@alsa-project.org
> Cc: Codrin Ciubotariu <codrin.ciubotariu@microchip.com>
> ---
> sound/soc/atmel/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> --- linux-next-20211001.orig/sound/soc/atmel/Kconfig
> +++ linux-next-20211001/sound/soc/atmel/Kconfig
> @@ -11,6 +11,7 @@ if SND_ATMEL_SOC
>
> config SND_ATMEL_SOC_PDC
> bool
> + depends on HAS_DMA || COMPILE_TEST
SND_ATMEL_SOC_PDC compiles fine without HAS_DMA, so I don't understand
the need for this...
^ permalink raw reply [flat|nested] 10+ messages in thread* Re: [PATCH] ASoC: atmel: add COMPILE_TEST for SND_ATMEL_SOC_PDC
2021-10-13 8:15 ` Codrin.Ciubotariu
@ 2021-10-13 8:40 ` Geert Uytterhoeven
-1 siblings, 0 replies; 10+ messages in thread
From: Geert Uytterhoeven @ 2021-10-13 8:40 UTC (permalink / raw)
To: Codrin Ciubotariu
Cc: Randy Dunlap, Linux Kernel Mailing List, Liam Girdwood,
Mark Brown, ALSA Development Mailing List
Hi Codrin,
On Wed, Oct 13, 2021 at 10:15 AM <Codrin.Ciubotariu@microchip.com> wrote:
> On 03.10.2021 06:03, Randy Dunlap wrote:
> > Geert pointed out that since sound/soc has the soc_dummy_driver for
> > NO_DMA platforms, it is possible (desirable) to have drivers that
> > depend on HAS_DMA to alternately depend on COMPILE_TEST.
> >
> > This means that SND_ATMEL_SOC_PDC can depend on HAS_DMA || COMPIE_TEST.
> >
> > Fixes: 6c5c659dfe3f ("ASoC: atmel: ATMEL drivers don't need HAS_DMA")
> > Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> > Suggested-by: Geert Uytterhoeven <geert@linux-m68k.org>
> > Cc: Liam Girdwood <lgirdwood@gmail.com>
> > Cc: Mark Brown <broonie@kernel.org>
> > Cc: alsa-devel@alsa-project.org
> > Cc: Codrin Ciubotariu <codrin.ciubotariu@microchip.com>
> > ---
> > sound/soc/atmel/Kconfig | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > --- linux-next-20211001.orig/sound/soc/atmel/Kconfig
> > +++ linux-next-20211001/sound/soc/atmel/Kconfig
> > @@ -11,6 +11,7 @@ if SND_ATMEL_SOC
> >
> > config SND_ATMEL_SOC_PDC
> > bool
> > + depends on HAS_DMA || COMPILE_TEST
>
> SND_ATMEL_SOC_PDC compiles fine without HAS_DMA, so I don't understand
> the need for this...
Does it work without DMA support?
If not, it doesn't make much sense to offer this option to the user, unless
the user is compile-testing.
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
^ permalink raw reply [flat|nested] 10+ messages in thread* Re: [PATCH] ASoC: atmel: add COMPILE_TEST for SND_ATMEL_SOC_PDC
@ 2021-10-13 8:40 ` Geert Uytterhoeven
0 siblings, 0 replies; 10+ messages in thread
From: Geert Uytterhoeven @ 2021-10-13 8:40 UTC (permalink / raw)
To: Codrin Ciubotariu
Cc: Mark Brown, Randy Dunlap, Linux Kernel Mailing List,
ALSA Development Mailing List, Liam Girdwood
Hi Codrin,
On Wed, Oct 13, 2021 at 10:15 AM <Codrin.Ciubotariu@microchip.com> wrote:
> On 03.10.2021 06:03, Randy Dunlap wrote:
> > Geert pointed out that since sound/soc has the soc_dummy_driver for
> > NO_DMA platforms, it is possible (desirable) to have drivers that
> > depend on HAS_DMA to alternately depend on COMPILE_TEST.
> >
> > This means that SND_ATMEL_SOC_PDC can depend on HAS_DMA || COMPIE_TEST.
> >
> > Fixes: 6c5c659dfe3f ("ASoC: atmel: ATMEL drivers don't need HAS_DMA")
> > Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> > Suggested-by: Geert Uytterhoeven <geert@linux-m68k.org>
> > Cc: Liam Girdwood <lgirdwood@gmail.com>
> > Cc: Mark Brown <broonie@kernel.org>
> > Cc: alsa-devel@alsa-project.org
> > Cc: Codrin Ciubotariu <codrin.ciubotariu@microchip.com>
> > ---
> > sound/soc/atmel/Kconfig | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > --- linux-next-20211001.orig/sound/soc/atmel/Kconfig
> > +++ linux-next-20211001/sound/soc/atmel/Kconfig
> > @@ -11,6 +11,7 @@ if SND_ATMEL_SOC
> >
> > config SND_ATMEL_SOC_PDC
> > bool
> > + depends on HAS_DMA || COMPILE_TEST
>
> SND_ATMEL_SOC_PDC compiles fine without HAS_DMA, so I don't understand
> the need for this...
Does it work without DMA support?
If not, it doesn't make much sense to offer this option to the user, unless
the user is compile-testing.
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
^ permalink raw reply [flat|nested] 10+ messages in thread* Re: [PATCH] ASoC: atmel: add COMPILE_TEST for SND_ATMEL_SOC_PDC
2021-10-13 8:40 ` Geert Uytterhoeven
@ 2021-10-13 9:33 ` Codrin.Ciubotariu
-1 siblings, 0 replies; 10+ messages in thread
From: Codrin.Ciubotariu @ 2021-10-13 9:33 UTC (permalink / raw)
To: geert; +Cc: rdunlap, linux-kernel, lgirdwood, broonie, alsa-devel
On 13.10.2021 11:40, Geert Uytterhoeven wrote:
> Hi Codrin,
>
> On Wed, Oct 13, 2021 at 10:15 AM <Codrin.Ciubotariu@microchip.com> wrote:
>> On 03.10.2021 06:03, Randy Dunlap wrote:
>>> Geert pointed out that since sound/soc has the soc_dummy_driver for
>>> NO_DMA platforms, it is possible (desirable) to have drivers that
>>> depend on HAS_DMA to alternately depend on COMPILE_TEST.
>>>
>>> This means that SND_ATMEL_SOC_PDC can depend on HAS_DMA || COMPIE_TEST.
>>>
>>> Fixes: 6c5c659dfe3f ("ASoC: atmel: ATMEL drivers don't need HAS_DMA")
>>> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
>>> Suggested-by: Geert Uytterhoeven <geert@linux-m68k.org>
>>> Cc: Liam Girdwood <lgirdwood@gmail.com>
>>> Cc: Mark Brown <broonie@kernel.org>
>>> Cc: alsa-devel@alsa-project.org
>>> Cc: Codrin Ciubotariu <codrin.ciubotariu@microchip.com>
>>> ---
>>> sound/soc/atmel/Kconfig | 1 +
>>> 1 file changed, 1 insertion(+)
>>>
>>> --- linux-next-20211001.orig/sound/soc/atmel/Kconfig
>>> +++ linux-next-20211001/sound/soc/atmel/Kconfig
>>> @@ -11,6 +11,7 @@ if SND_ATMEL_SOC
>>>
>>> config SND_ATMEL_SOC_PDC
>>> bool
>>> + depends on HAS_DMA || COMPILE_TEST
>>
>> SND_ATMEL_SOC_PDC compiles fine without HAS_DMA, so I don't understand
>> the need for this...
>
> Does it work without DMA support?
> If not, it doesn't make much sense to offer this option to the user, unless
> the user is compile-testing.
it is using a Peripheral DMA controller, that is mapped in SSC's address
space and is not using the DMA engine. I see that HAS_DMA is needed for
the DMA mapping API, which we use, so I guess we do depend on it. That
being said:
Reviewed-by: Codrin Ciubotariu <codrin.ciubotariu@microchip.com>
Thanks!
^ permalink raw reply [flat|nested] 10+ messages in thread* Re: [PATCH] ASoC: atmel: add COMPILE_TEST for SND_ATMEL_SOC_PDC
@ 2021-10-13 9:33 ` Codrin.Ciubotariu
0 siblings, 0 replies; 10+ messages in thread
From: Codrin.Ciubotariu @ 2021-10-13 9:33 UTC (permalink / raw)
To: geert; +Cc: broonie, rdunlap, linux-kernel, alsa-devel, lgirdwood
On 13.10.2021 11:40, Geert Uytterhoeven wrote:
> Hi Codrin,
>
> On Wed, Oct 13, 2021 at 10:15 AM <Codrin.Ciubotariu@microchip.com> wrote:
>> On 03.10.2021 06:03, Randy Dunlap wrote:
>>> Geert pointed out that since sound/soc has the soc_dummy_driver for
>>> NO_DMA platforms, it is possible (desirable) to have drivers that
>>> depend on HAS_DMA to alternately depend on COMPILE_TEST.
>>>
>>> This means that SND_ATMEL_SOC_PDC can depend on HAS_DMA || COMPIE_TEST.
>>>
>>> Fixes: 6c5c659dfe3f ("ASoC: atmel: ATMEL drivers don't need HAS_DMA")
>>> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
>>> Suggested-by: Geert Uytterhoeven <geert@linux-m68k.org>
>>> Cc: Liam Girdwood <lgirdwood@gmail.com>
>>> Cc: Mark Brown <broonie@kernel.org>
>>> Cc: alsa-devel@alsa-project.org
>>> Cc: Codrin Ciubotariu <codrin.ciubotariu@microchip.com>
>>> ---
>>> sound/soc/atmel/Kconfig | 1 +
>>> 1 file changed, 1 insertion(+)
>>>
>>> --- linux-next-20211001.orig/sound/soc/atmel/Kconfig
>>> +++ linux-next-20211001/sound/soc/atmel/Kconfig
>>> @@ -11,6 +11,7 @@ if SND_ATMEL_SOC
>>>
>>> config SND_ATMEL_SOC_PDC
>>> bool
>>> + depends on HAS_DMA || COMPILE_TEST
>>
>> SND_ATMEL_SOC_PDC compiles fine without HAS_DMA, so I don't understand
>> the need for this...
>
> Does it work without DMA support?
> If not, it doesn't make much sense to offer this option to the user, unless
> the user is compile-testing.
it is using a Peripheral DMA controller, that is mapped in SSC's address
space and is not using the DMA engine. I see that HAS_DMA is needed for
the DMA mapping API, which we use, so I guess we do depend on it. That
being said:
Reviewed-by: Codrin Ciubotariu <codrin.ciubotariu@microchip.com>
Thanks!
^ permalink raw reply [flat|nested] 10+ messages in thread
end of thread, other threads:[~2021-10-13 9:34 UTC | newest]
Thread overview: 10+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-10-03 3:03 [PATCH] ASoC: atmel: add COMPILE_TEST for SND_ATMEL_SOC_PDC Randy Dunlap
2021-10-03 3:03 ` Randy Dunlap
2021-10-04 7:14 ` Geert Uytterhoeven
2021-10-04 7:14 ` Geert Uytterhoeven
2021-10-13 8:15 ` Codrin.Ciubotariu
2021-10-13 8:15 ` Codrin.Ciubotariu
2021-10-13 8:40 ` Geert Uytterhoeven
2021-10-13 8:40 ` Geert Uytterhoeven
2021-10-13 9:33 ` Codrin.Ciubotariu
2021-10-13 9:33 ` Codrin.Ciubotariu
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.