* [PATCH RESEND] backlight: pwm_bl: don't use GPIOF_* with gpiod_get_direction
@ 2018-04-10 12:32 ` Wolfram Sang
0 siblings, 0 replies; 21+ messages in thread
From: Wolfram Sang @ 2018-04-10 12:32 UTC (permalink / raw)
To: linux-kernel
Cc: linux-renesas-soc, Wolfram Sang, Thierry Reding, Lee Jones,
Daniel Thompson, Jingoo Han, Bartlomiej Zolnierkiewicz,
linux-pwm, dri-devel, linux-fbdev
The documentation was wrong, gpiod_get_direction() returns 0/1 instead
of the GPIOF_* flags. The docs were fixed with commit 94fc73094abe47
("gpio: correct docs about return value of gpiod_get_direction"). Now,
fix this user (until a better, system-wide solution is in place).
Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
Acked-by: Daniel Thompson <daniel.thompson@linaro.org>
---
Changes since V1:
* rebased to top-of-linus-tree
* added tag from Daniel, thanks!
Through which tree does this need to go?
drivers/video/backlight/pwm_bl.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/video/backlight/pwm_bl.c b/drivers/video/backlight/pwm_bl.c
index 1c2289ddd555..0fa7d2bd0e48 100644
--- a/drivers/video/backlight/pwm_bl.c
+++ b/drivers/video/backlight/pwm_bl.c
@@ -301,14 +301,14 @@ static int pwm_backlight_probe(struct platform_device *pdev)
/*
* If the GPIO is not known to be already configured as output, that
- * is, if gpiod_get_direction returns either GPIOF_DIR_IN or -EINVAL,
- * change the direction to output and set the GPIO as active.
+ * is, if gpiod_get_direction returns either 1 or -EINVAL, change the
+ * direction to output and set the GPIO as active.
* Do not force the GPIO to active when it was already output as it
* could cause backlight flickering or we would enable the backlight too
* early. Leave the decision of the initial backlight state for later.
*/
if (pb->enable_gpio &&
- gpiod_get_direction(pb->enable_gpio) != GPIOF_DIR_OUT)
+ gpiod_get_direction(pb->enable_gpio) != 0)
gpiod_direction_output(pb->enable_gpio, 1);
pb->power_supply = devm_regulator_get(&pdev->dev, "power");
--
2.11.0
^ permalink raw reply related [flat|nested] 21+ messages in thread
* [PATCH RESEND] backlight: pwm_bl: don't use GPIOF_* with gpiod_get_direction
@ 2018-04-10 12:32 ` Wolfram Sang
0 siblings, 0 replies; 21+ messages in thread
From: Wolfram Sang @ 2018-04-10 12:32 UTC (permalink / raw)
To: linux-kernel
Cc: linux-renesas-soc, Wolfram Sang, Thierry Reding, Lee Jones,
Daniel Thompson, Jingoo Han, Bartlomiej Zolnierkiewicz,
linux-pwm, dri-devel, linux-fbdev
The documentation was wrong, gpiod_get_direction() returns 0/1 instead
of the GPIOF_* flags. The docs were fixed with commit 94fc73094abe47
("gpio: correct docs about return value of gpiod_get_direction"). Now,
fix this user (until a better, system-wide solution is in place).
Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
Acked-by: Daniel Thompson <daniel.thompson@linaro.org>
---
Changes since V1:
* rebased to top-of-linus-tree
* added tag from Daniel, thanks!
Through which tree does this need to go?
drivers/video/backlight/pwm_bl.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/video/backlight/pwm_bl.c b/drivers/video/backlight/pwm_bl.c
index 1c2289ddd555..0fa7d2bd0e48 100644
--- a/drivers/video/backlight/pwm_bl.c
+++ b/drivers/video/backlight/pwm_bl.c
@@ -301,14 +301,14 @@ static int pwm_backlight_probe(struct platform_device *pdev)
/*
* If the GPIO is not known to be already configured as output, that
- * is, if gpiod_get_direction returns either GPIOF_DIR_IN or -EINVAL,
- * change the direction to output and set the GPIO as active.
+ * is, if gpiod_get_direction returns either 1 or -EINVAL, change the
+ * direction to output and set the GPIO as active.
* Do not force the GPIO to active when it was already output as it
* could cause backlight flickering or we would enable the backlight too
* early. Leave the decision of the initial backlight state for later.
*/
if (pb->enable_gpio &&
- gpiod_get_direction(pb->enable_gpio) != GPIOF_DIR_OUT)
+ gpiod_get_direction(pb->enable_gpio) != 0)
gpiod_direction_output(pb->enable_gpio, 1);
pb->power_supply = devm_regulator_get(&pdev->dev, "power");
--
2.11.0
^ permalink raw reply related [flat|nested] 21+ messages in thread
* Re: [PATCH RESEND] backlight: pwm_bl: don't use GPIOF_* with gpiod_get_direction
2018-04-10 12:32 ` Wolfram Sang
@ 2018-04-11 7:32 ` Simon Horman
-1 siblings, 0 replies; 21+ messages in thread
From: Simon Horman @ 2018-04-11 7:32 UTC (permalink / raw)
To: Wolfram Sang
Cc: linux-kernel, linux-renesas-soc, Thierry Reding, Lee Jones,
Daniel Thompson, Jingoo Han, Bartlomiej Zolnierkiewicz,
linux-pwm, dri-devel, linux-fbdev
On Tue, Apr 10, 2018 at 02:32:40PM +0200, Wolfram Sang wrote:
> The documentation was wrong, gpiod_get_direction() returns 0/1 instead
> of the GPIOF_* flags. The docs were fixed with commit 94fc73094abe47
> ("gpio: correct docs about return value of gpiod_get_direction"). Now,
> fix this user (until a better, system-wide solution is in place).
>
> Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
> Acked-by: Daniel Thompson <daniel.thompson@linaro.org>
Reviewed-by: Simon Horman <horms+renesas@verge.net.au>
> ---
>
> Changes since V1:
> * rebased to top-of-linus-tree
> * added tag from Daniel, thanks!
>
> Through which tree does this need to go?
>
> drivers/video/backlight/pwm_bl.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/video/backlight/pwm_bl.c b/drivers/video/backlight/pwm_bl.c
> index 1c2289ddd555..0fa7d2bd0e48 100644
> --- a/drivers/video/backlight/pwm_bl.c
> +++ b/drivers/video/backlight/pwm_bl.c
> @@ -301,14 +301,14 @@ static int pwm_backlight_probe(struct platform_device *pdev)
>
> /*
> * If the GPIO is not known to be already configured as output, that
> - * is, if gpiod_get_direction returns either GPIOF_DIR_IN or -EINVAL,
> - * change the direction to output and set the GPIO as active.
> + * is, if gpiod_get_direction returns either 1 or -EINVAL, change the
> + * direction to output and set the GPIO as active.
> * Do not force the GPIO to active when it was already output as it
> * could cause backlight flickering or we would enable the backlight too
> * early. Leave the decision of the initial backlight state for later.
> */
> if (pb->enable_gpio &&
> - gpiod_get_direction(pb->enable_gpio) != GPIOF_DIR_OUT)
> + gpiod_get_direction(pb->enable_gpio) != 0)
> gpiod_direction_output(pb->enable_gpio, 1);
>
> pb->power_supply = devm_regulator_get(&pdev->dev, "power");
> --
> 2.11.0
>
^ permalink raw reply [flat|nested] 21+ messages in thread
* Re: [PATCH RESEND] backlight: pwm_bl: don't use GPIOF_* with gpiod_get_direction
@ 2018-04-11 7:32 ` Simon Horman
0 siblings, 0 replies; 21+ messages in thread
From: Simon Horman @ 2018-04-11 7:32 UTC (permalink / raw)
To: Wolfram Sang
Cc: linux-kernel, linux-renesas-soc, Thierry Reding, Lee Jones,
Daniel Thompson, Jingoo Han, Bartlomiej Zolnierkiewicz,
linux-pwm, dri-devel, linux-fbdev
On Tue, Apr 10, 2018 at 02:32:40PM +0200, Wolfram Sang wrote:
> The documentation was wrong, gpiod_get_direction() returns 0/1 instead
> of the GPIOF_* flags. The docs were fixed with commit 94fc73094abe47
> ("gpio: correct docs about return value of gpiod_get_direction"). Now,
> fix this user (until a better, system-wide solution is in place).
>
> Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
> Acked-by: Daniel Thompson <daniel.thompson@linaro.org>
Reviewed-by: Simon Horman <horms+renesas@verge.net.au>
> ---
>
> Changes since V1:
> * rebased to top-of-linus-tree
> * added tag from Daniel, thanks!
>
> Through which tree does this need to go?
>
> drivers/video/backlight/pwm_bl.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/video/backlight/pwm_bl.c b/drivers/video/backlight/pwm_bl.c
> index 1c2289ddd555..0fa7d2bd0e48 100644
> --- a/drivers/video/backlight/pwm_bl.c
> +++ b/drivers/video/backlight/pwm_bl.c
> @@ -301,14 +301,14 @@ static int pwm_backlight_probe(struct platform_device *pdev)
>
> /*
> * If the GPIO is not known to be already configured as output, that
> - * is, if gpiod_get_direction returns either GPIOF_DIR_IN or -EINVAL,
> - * change the direction to output and set the GPIO as active.
> + * is, if gpiod_get_direction returns either 1 or -EINVAL, change the
> + * direction to output and set the GPIO as active.
> * Do not force the GPIO to active when it was already output as it
> * could cause backlight flickering or we would enable the backlight too
> * early. Leave the decision of the initial backlight state for later.
> */
> if (pb->enable_gpio &&
> - gpiod_get_direction(pb->enable_gpio) != GPIOF_DIR_OUT)
> + gpiod_get_direction(pb->enable_gpio) != 0)
> gpiod_direction_output(pb->enable_gpio, 1);
>
> pb->power_supply = devm_regulator_get(&pdev->dev, "power");
> --
> 2.11.0
>
^ permalink raw reply [flat|nested] 21+ messages in thread
* Re: [PATCH RESEND] backlight: pwm_bl: don't use GPIOF_* with gpiod_get_direction
2018-04-11 7:32 ` Simon Horman
(?)
@ 2018-04-13 16:08 ` Daniel Vetter
-1 siblings, 0 replies; 21+ messages in thread
From: Daniel Vetter @ 2018-04-13 16:08 UTC (permalink / raw)
To: Simon Horman
Cc: Wolfram Sang, linux-pwm, Daniel Thompson,
Bartlomiej Zolnierkiewicz, Jingoo Han, linux-kernel, dri-devel,
linux-renesas-soc, Thierry Reding, linux-fbdev, Lee Jones
On Wed, Apr 11, 2018 at 09:32:16AM +0200, Simon Horman wrote:
> On Tue, Apr 10, 2018 at 02:32:40PM +0200, Wolfram Sang wrote:
> > The documentation was wrong, gpiod_get_direction() returns 0/1 instead
> > of the GPIOF_* flags. The docs were fixed with commit 94fc73094abe47
> > ("gpio: correct docs about return value of gpiod_get_direction"). Now,
> > fix this user (until a better, system-wide solution is in place).
> >
> > Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
> > Acked-by: Daniel Thompson <daniel.thompson@linaro.org>
>
> Reviewed-by: Simon Horman <horms+renesas@verge.net.au>
>
> > ---
> >
> > Changes since V1:
> > * rebased to top-of-linus-tree
> > * added tag from Daniel, thanks!
> >
> > Through which tree does this need to go?
I think Daniel Thompson has one ...
-Daniel
> >
> > drivers/video/backlight/pwm_bl.c | 6 +++---
> > 1 file changed, 3 insertions(+), 3 deletions(-)
> >
> > diff --git a/drivers/video/backlight/pwm_bl.c b/drivers/video/backlight/pwm_bl.c
> > index 1c2289ddd555..0fa7d2bd0e48 100644
> > --- a/drivers/video/backlight/pwm_bl.c
> > +++ b/drivers/video/backlight/pwm_bl.c
> > @@ -301,14 +301,14 @@ static int pwm_backlight_probe(struct platform_device *pdev)
> >
> > /*
> > * If the GPIO is not known to be already configured as output, that
> > - * is, if gpiod_get_direction returns either GPIOF_DIR_IN or -EINVAL,
> > - * change the direction to output and set the GPIO as active.
> > + * is, if gpiod_get_direction returns either 1 or -EINVAL, change the
> > + * direction to output and set the GPIO as active.
> > * Do not force the GPIO to active when it was already output as it
> > * could cause backlight flickering or we would enable the backlight too
> > * early. Leave the decision of the initial backlight state for later.
> > */
> > if (pb->enable_gpio &&
> > - gpiod_get_direction(pb->enable_gpio) != GPIOF_DIR_OUT)
> > + gpiod_get_direction(pb->enable_gpio) != 0)
> > gpiod_direction_output(pb->enable_gpio, 1);
> >
> > pb->power_supply = devm_regulator_get(&pdev->dev, "power");
> > --
> > 2.11.0
> >
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
^ permalink raw reply [flat|nested] 21+ messages in thread
* Re: [PATCH RESEND] backlight: pwm_bl: don't use GPIOF_* with gpiod_get_direction
@ 2018-04-13 16:08 ` Daniel Vetter
0 siblings, 0 replies; 21+ messages in thread
From: Daniel Vetter @ 2018-04-13 16:08 UTC (permalink / raw)
To: Simon Horman
Cc: linux-pwm, Daniel Thompson, Bartlomiej Zolnierkiewicz,
Jingoo Han, linux-kernel, dri-devel, linux-renesas-soc,
Wolfram Sang, Thierry Reding, linux-fbdev, Lee Jones
On Wed, Apr 11, 2018 at 09:32:16AM +0200, Simon Horman wrote:
> On Tue, Apr 10, 2018 at 02:32:40PM +0200, Wolfram Sang wrote:
> > The documentation was wrong, gpiod_get_direction() returns 0/1 instead
> > of the GPIOF_* flags. The docs were fixed with commit 94fc73094abe47
> > ("gpio: correct docs about return value of gpiod_get_direction"). Now,
> > fix this user (until a better, system-wide solution is in place).
> >
> > Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
> > Acked-by: Daniel Thompson <daniel.thompson@linaro.org>
>
> Reviewed-by: Simon Horman <horms+renesas@verge.net.au>
>
> > ---
> >
> > Changes since V1:
> > * rebased to top-of-linus-tree
> > * added tag from Daniel, thanks!
> >
> > Through which tree does this need to go?
I think Daniel Thompson has one ...
-Daniel
> >
> > drivers/video/backlight/pwm_bl.c | 6 +++---
> > 1 file changed, 3 insertions(+), 3 deletions(-)
> >
> > diff --git a/drivers/video/backlight/pwm_bl.c b/drivers/video/backlight/pwm_bl.c
> > index 1c2289ddd555..0fa7d2bd0e48 100644
> > --- a/drivers/video/backlight/pwm_bl.c
> > +++ b/drivers/video/backlight/pwm_bl.c
> > @@ -301,14 +301,14 @@ static int pwm_backlight_probe(struct platform_device *pdev)
> >
> > /*
> > * If the GPIO is not known to be already configured as output, that
> > - * is, if gpiod_get_direction returns either GPIOF_DIR_IN or -EINVAL,
> > - * change the direction to output and set the GPIO as active.
> > + * is, if gpiod_get_direction returns either 1 or -EINVAL, change the
> > + * direction to output and set the GPIO as active.
> > * Do not force the GPIO to active when it was already output as it
> > * could cause backlight flickering or we would enable the backlight too
> > * early. Leave the decision of the initial backlight state for later.
> > */
> > if (pb->enable_gpio &&
> > - gpiod_get_direction(pb->enable_gpio) != GPIOF_DIR_OUT)
> > + gpiod_get_direction(pb->enable_gpio) != 0)
> > gpiod_direction_output(pb->enable_gpio, 1);
> >
> > pb->power_supply = devm_regulator_get(&pdev->dev, "power");
> > --
> > 2.11.0
> >
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 21+ messages in thread
* Re: [PATCH RESEND] backlight: pwm_bl: don't use GPIOF_* with gpiod_get_direction
@ 2018-04-13 16:08 ` Daniel Vetter
0 siblings, 0 replies; 21+ messages in thread
From: Daniel Vetter @ 2018-04-13 16:08 UTC (permalink / raw)
To: Simon Horman
Cc: linux-pwm, Daniel Thompson, Bartlomiej Zolnierkiewicz,
Jingoo Han, linux-kernel, dri-devel, linux-renesas-soc,
Wolfram Sang, Thierry Reding, linux-fbdev, Lee Jones
On Wed, Apr 11, 2018 at 09:32:16AM +0200, Simon Horman wrote:
> On Tue, Apr 10, 2018 at 02:32:40PM +0200, Wolfram Sang wrote:
> > The documentation was wrong, gpiod_get_direction() returns 0/1 instead
> > of the GPIOF_* flags. The docs were fixed with commit 94fc73094abe47
> > ("gpio: correct docs about return value of gpiod_get_direction"). Now,
> > fix this user (until a better, system-wide solution is in place).
> >
> > Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
> > Acked-by: Daniel Thompson <daniel.thompson@linaro.org>
>
> Reviewed-by: Simon Horman <horms+renesas@verge.net.au>
>
> > ---
> >
> > Changes since V1:
> > * rebased to top-of-linus-tree
> > * added tag from Daniel, thanks!
> >
> > Through which tree does this need to go?
I think Daniel Thompson has one ...
-Daniel
> >
> > drivers/video/backlight/pwm_bl.c | 6 +++---
> > 1 file changed, 3 insertions(+), 3 deletions(-)
> >
> > diff --git a/drivers/video/backlight/pwm_bl.c b/drivers/video/backlight/pwm_bl.c
> > index 1c2289ddd555..0fa7d2bd0e48 100644
> > --- a/drivers/video/backlight/pwm_bl.c
> > +++ b/drivers/video/backlight/pwm_bl.c
> > @@ -301,14 +301,14 @@ static int pwm_backlight_probe(struct platform_device *pdev)
> >
> > /*
> > * If the GPIO is not known to be already configured as output, that
> > - * is, if gpiod_get_direction returns either GPIOF_DIR_IN or -EINVAL,
> > - * change the direction to output and set the GPIO as active.
> > + * is, if gpiod_get_direction returns either 1 or -EINVAL, change the
> > + * direction to output and set the GPIO as active.
> > * Do not force the GPIO to active when it was already output as it
> > * could cause backlight flickering or we would enable the backlight too
> > * early. Leave the decision of the initial backlight state for later.
> > */
> > if (pb->enable_gpio &&
> > - gpiod_get_direction(pb->enable_gpio) != GPIOF_DIR_OUT)
> > + gpiod_get_direction(pb->enable_gpio) != 0)
> > gpiod_direction_output(pb->enable_gpio, 1);
> >
> > pb->power_supply = devm_regulator_get(&pdev->dev, "power");
> > --
> > 2.11.0
> >
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
^ permalink raw reply [flat|nested] 21+ messages in thread
* Re: [PATCH RESEND] backlight: pwm_bl: don't use GPIOF_* with gpiod_get_direction
2018-04-13 16:08 ` Daniel Vetter
(?)
@ 2018-04-13 16:26 ` Daniel Thompson
-1 siblings, 0 replies; 21+ messages in thread
From: Daniel Thompson @ 2018-04-13 16:26 UTC (permalink / raw)
To: Simon Horman, Wolfram Sang, linux-pwm, Bartlomiej Zolnierkiewicz,
Jingoo Han, linux-kernel, dri-devel, linux-renesas-soc,
Thierry Reding, linux-fbdev, Lee Jones
On Fri, Apr 13, 2018 at 06:08:24PM +0200, Daniel Vetter wrote:
> On Wed, Apr 11, 2018 at 09:32:16AM +0200, Simon Horman wrote:
> > On Tue, Apr 10, 2018 at 02:32:40PM +0200, Wolfram Sang wrote:
> > > The documentation was wrong, gpiod_get_direction() returns 0/1 instead
> > > of the GPIOF_* flags. The docs were fixed with commit 94fc73094abe47
> > > ("gpio: correct docs about return value of gpiod_get_direction"). Now,
> > > fix this user (until a better, system-wide solution is in place).
> > >
> > > Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
> > > Acked-by: Daniel Thompson <daniel.thompson@linaro.org>
> >
> > Reviewed-by: Simon Horman <horms+renesas@verge.net.au>
> >
> > > ---
> > >
> > > Changes since V1:
> > > * rebased to top-of-linus-tree
> > > * added tag from Daniel, thanks!
> > >
> > > Through which tree does this need to go?
>
> I think Daniel Thompson has one ...
Sorry, I didn't spot the question at the bottom of the change block.
For backlight patches generally go though Lee Jones' tree.
Daniel.
^ permalink raw reply [flat|nested] 21+ messages in thread
* Re: [PATCH RESEND] backlight: pwm_bl: don't use GPIOF_* with gpiod_get_direction
@ 2018-04-13 16:26 ` Daniel Thompson
0 siblings, 0 replies; 21+ messages in thread
From: Daniel Thompson @ 2018-04-13 16:26 UTC (permalink / raw)
To: Simon Horman, Wolfram Sang, linux-pwm, Bartlomiej Zolnierkiewicz,
Jingoo Han, linux-kernel, dri-devel, linux-renesas-soc,
Thierry Reding, linux-fbdev, Lee Jones
On Fri, Apr 13, 2018 at 06:08:24PM +0200, Daniel Vetter wrote:
> On Wed, Apr 11, 2018 at 09:32:16AM +0200, Simon Horman wrote:
> > On Tue, Apr 10, 2018 at 02:32:40PM +0200, Wolfram Sang wrote:
> > > The documentation was wrong, gpiod_get_direction() returns 0/1 instead
> > > of the GPIOF_* flags. The docs were fixed with commit 94fc73094abe47
> > > ("gpio: correct docs about return value of gpiod_get_direction"). Now,
> > > fix this user (until a better, system-wide solution is in place).
> > >
> > > Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
> > > Acked-by: Daniel Thompson <daniel.thompson@linaro.org>
> >
> > Reviewed-by: Simon Horman <horms+renesas@verge.net.au>
> >
> > > ---
> > >
> > > Changes since V1:
> > > * rebased to top-of-linus-tree
> > > * added tag from Daniel, thanks!
> > >
> > > Through which tree does this need to go?
>
> I think Daniel Thompson has one ...
Sorry, I didn't spot the question at the bottom of the change block.
For backlight patches generally go though Lee Jones' tree.
Daniel.
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 21+ messages in thread
* Re: [PATCH RESEND] backlight: pwm_bl: don't use GPIOF_* with gpiod_get_direction
@ 2018-04-13 16:26 ` Daniel Thompson
0 siblings, 0 replies; 21+ messages in thread
From: Daniel Thompson @ 2018-04-13 16:26 UTC (permalink / raw)
To: Simon Horman, Wolfram Sang, linux-pwm, Bartlomiej Zolnierkiewicz,
Jingoo Han, linux-kernel, dri-devel, linux-renesas-soc,
Thierry Reding, linux-fbdev, Lee Jones
On Fri, Apr 13, 2018 at 06:08:24PM +0200, Daniel Vetter wrote:
> On Wed, Apr 11, 2018 at 09:32:16AM +0200, Simon Horman wrote:
> > On Tue, Apr 10, 2018 at 02:32:40PM +0200, Wolfram Sang wrote:
> > > The documentation was wrong, gpiod_get_direction() returns 0/1 instead
> > > of the GPIOF_* flags. The docs were fixed with commit 94fc73094abe47
> > > ("gpio: correct docs about return value of gpiod_get_direction"). Now,
> > > fix this user (until a better, system-wide solution is in place).
> > >
> > > Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
> > > Acked-by: Daniel Thompson <daniel.thompson@linaro.org>
> >
> > Reviewed-by: Simon Horman <horms+renesas@verge.net.au>
> >
> > > ---
> > >
> > > Changes since V1:
> > > * rebased to top-of-linus-tree
> > > * added tag from Daniel, thanks!
> > >
> > > Through which tree does this need to go?
>
> I think Daniel Thompson has one ...
Sorry, I didn't spot the question at the bottom of the change block.
For backlight patches generally go though Lee Jones' tree.
Daniel.
^ permalink raw reply [flat|nested] 21+ messages in thread
* Re: [PATCH RESEND] backlight: pwm_bl: don't use GPIOF_* with gpiod_get_direction
2018-04-11 7:32 ` Simon Horman
(?)
@ 2018-04-16 9:12 ` Lee Jones
-1 siblings, 0 replies; 21+ messages in thread
From: Lee Jones @ 2018-04-16 9:12 UTC (permalink / raw)
To: Simon Horman
Cc: Wolfram Sang, linux-kernel, linux-renesas-soc, Thierry Reding,
Daniel Thompson, Jingoo Han, Bartlomiej Zolnierkiewicz,
linux-pwm, dri-devel, linux-fbdev
On Wed, 11 Apr 2018, Simon Horman wrote:
> On Tue, Apr 10, 2018 at 02:32:40PM +0200, Wolfram Sang wrote:
> > The documentation was wrong, gpiod_get_direction() returns 0/1 instead
> > of the GPIOF_* flags. The docs were fixed with commit 94fc73094abe47
> > ("gpio: correct docs about return value of gpiod_get_direction"). Now,
> > fix this user (until a better, system-wide solution is in place).
> >
> > Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
> > Acked-by: Daniel Thompson <daniel.thompson@linaro.org>
>
> Reviewed-by: Simon Horman <horms+renesas@verge.net.au>
Thanks for the Reviewed-by Simon. I have applied it to the original mail.
Do you know why you mail wasn't sent attached to the original thread?
For some reason I received this mail on it's own i.e. not in reply
to the original.
> > ---
> >
> > Changes since V1:
> > * rebased to top-of-linus-tree
> > * added tag from Daniel, thanks!
> >
> > Through which tree does this need to go?
> >
> > drivers/video/backlight/pwm_bl.c | 6 +++---
> > 1 file changed, 3 insertions(+), 3 deletions(-)
> >
> > diff --git a/drivers/video/backlight/pwm_bl.c b/drivers/video/backlight/pwm_bl.c
> > index 1c2289ddd555..0fa7d2bd0e48 100644
> > --- a/drivers/video/backlight/pwm_bl.c
> > +++ b/drivers/video/backlight/pwm_bl.c
> > @@ -301,14 +301,14 @@ static int pwm_backlight_probe(struct platform_device *pdev)
> >
> > /*
> > * If the GPIO is not known to be already configured as output, that
> > - * is, if gpiod_get_direction returns either GPIOF_DIR_IN or -EINVAL,
> > - * change the direction to output and set the GPIO as active.
> > + * is, if gpiod_get_direction returns either 1 or -EINVAL, change the
> > + * direction to output and set the GPIO as active.
> > * Do not force the GPIO to active when it was already output as it
> > * could cause backlight flickering or we would enable the backlight too
> > * early. Leave the decision of the initial backlight state for later.
> > */
> > if (pb->enable_gpio &&
> > - gpiod_get_direction(pb->enable_gpio) != GPIOF_DIR_OUT)
> > + gpiod_get_direction(pb->enable_gpio) != 0)
> > gpiod_direction_output(pb->enable_gpio, 1);
> >
> > pb->power_supply = devm_regulator_get(&pdev->dev, "power");
--
Lee Jones [李琼斯]
Linaro Services Technical Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
^ permalink raw reply [flat|nested] 21+ messages in thread
* Re: [PATCH RESEND] backlight: pwm_bl: don't use GPIOF_* with gpiod_get_direction
@ 2018-04-16 9:12 ` Lee Jones
0 siblings, 0 replies; 21+ messages in thread
From: Lee Jones @ 2018-04-16 9:12 UTC (permalink / raw)
To: Simon Horman
Cc: linux-pwm, Daniel Thompson, Bartlomiej Zolnierkiewicz,
Jingoo Han, linux-kernel, dri-devel, linux-renesas-soc,
Wolfram Sang, Thierry Reding, linux-fbdev
On Wed, 11 Apr 2018, Simon Horman wrote:
> On Tue, Apr 10, 2018 at 02:32:40PM +0200, Wolfram Sang wrote:
> > The documentation was wrong, gpiod_get_direction() returns 0/1 instead
> > of the GPIOF_* flags. The docs were fixed with commit 94fc73094abe47
> > ("gpio: correct docs about return value of gpiod_get_direction"). Now,
> > fix this user (until a better, system-wide solution is in place).
> >
> > Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
> > Acked-by: Daniel Thompson <daniel.thompson@linaro.org>
>
> Reviewed-by: Simon Horman <horms+renesas@verge.net.au>
Thanks for the Reviewed-by Simon. I have applied it to the original mail.
Do you know why you mail wasn't sent attached to the original thread?
For some reason I received this mail on it's own i.e. not in reply
to the original.
> > ---
> >
> > Changes since V1:
> > * rebased to top-of-linus-tree
> > * added tag from Daniel, thanks!
> >
> > Through which tree does this need to go?
> >
> > drivers/video/backlight/pwm_bl.c | 6 +++---
> > 1 file changed, 3 insertions(+), 3 deletions(-)
> >
> > diff --git a/drivers/video/backlight/pwm_bl.c b/drivers/video/backlight/pwm_bl.c
> > index 1c2289ddd555..0fa7d2bd0e48 100644
> > --- a/drivers/video/backlight/pwm_bl.c
> > +++ b/drivers/video/backlight/pwm_bl.c
> > @@ -301,14 +301,14 @@ static int pwm_backlight_probe(struct platform_device *pdev)
> >
> > /*
> > * If the GPIO is not known to be already configured as output, that
> > - * is, if gpiod_get_direction returns either GPIOF_DIR_IN or -EINVAL,
> > - * change the direction to output and set the GPIO as active.
> > + * is, if gpiod_get_direction returns either 1 or -EINVAL, change the
> > + * direction to output and set the GPIO as active.
> > * Do not force the GPIO to active when it was already output as it
> > * could cause backlight flickering or we would enable the backlight too
> > * early. Leave the decision of the initial backlight state for later.
> > */
> > if (pb->enable_gpio &&
> > - gpiod_get_direction(pb->enable_gpio) != GPIOF_DIR_OUT)
> > + gpiod_get_direction(pb->enable_gpio) != 0)
> > gpiod_direction_output(pb->enable_gpio, 1);
> >
> > pb->power_supply = devm_regulator_get(&pdev->dev, "power");
--
Lee Jones [李琼斯]
Linaro Services Technical Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 21+ messages in thread
* Re: [PATCH RESEND] backlight: pwm_bl: don't use GPIOF_* with gpiod_get_direction
@ 2018-04-16 9:12 ` Lee Jones
0 siblings, 0 replies; 21+ messages in thread
From: Lee Jones @ 2018-04-16 9:12 UTC (permalink / raw)
To: Simon Horman
Cc: linux-pwm, Daniel Thompson, Bartlomiej Zolnierkiewicz,
Jingoo Han, linux-kernel, dri-devel, linux-renesas-soc,
Wolfram Sang, Thierry Reding, linux-fbdev
On Wed, 11 Apr 2018, Simon Horman wrote:
> On Tue, Apr 10, 2018 at 02:32:40PM +0200, Wolfram Sang wrote:
> > The documentation was wrong, gpiod_get_direction() returns 0/1 instead
> > of the GPIOF_* flags. The docs were fixed with commit 94fc73094abe47
> > ("gpio: correct docs about return value of gpiod_get_direction"). Now,
> > fix this user (until a better, system-wide solution is in place).
> >
> > Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
> > Acked-by: Daniel Thompson <daniel.thompson@linaro.org>
>
> Reviewed-by: Simon Horman <horms+renesas@verge.net.au>
Thanks for the Reviewed-by Simon. I have applied it to the original mail.
Do you know why you mail wasn't sent attached to the original thread?
For some reason I received this mail on it's own i.e. not in reply
to the original.
> > ---
> >
> > Changes since V1:
> > * rebased to top-of-linus-tree
> > * added tag from Daniel, thanks!
> >
> > Through which tree does this need to go?
> >
> > drivers/video/backlight/pwm_bl.c | 6 +++---
> > 1 file changed, 3 insertions(+), 3 deletions(-)
> >
> > diff --git a/drivers/video/backlight/pwm_bl.c b/drivers/video/backlight/pwm_bl.c
> > index 1c2289ddd555..0fa7d2bd0e48 100644
> > --- a/drivers/video/backlight/pwm_bl.c
> > +++ b/drivers/video/backlight/pwm_bl.c
> > @@ -301,14 +301,14 @@ static int pwm_backlight_probe(struct platform_device *pdev)
> >
> > /*
> > * If the GPIO is not known to be already configured as output, that
> > - * is, if gpiod_get_direction returns either GPIOF_DIR_IN or -EINVAL,
> > - * change the direction to output and set the GPIO as active.
> > + * is, if gpiod_get_direction returns either 1 or -EINVAL, change the
> > + * direction to output and set the GPIO as active.
> > * Do not force the GPIO to active when it was already output as it
> > * could cause backlight flickering or we would enable the backlight too
> > * early. Leave the decision of the initial backlight state for later.
> > */
> > if (pb->enable_gpio &&
> > - gpiod_get_direction(pb->enable_gpio) != GPIOF_DIR_OUT)
> > + gpiod_get_direction(pb->enable_gpio) != 0)
> > gpiod_direction_output(pb->enable_gpio, 1);
> >
> > pb->power_supply = devm_regulator_get(&pdev->dev, "power");
--
Lee Jones [李琼斯]
Linaro Services Technical Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
^ permalink raw reply [flat|nested] 21+ messages in thread
* Re: [PATCH RESEND] backlight: pwm_bl: don't use GPIOF_* with gpiod_get_direction
2018-04-16 9:12 ` Lee Jones
@ 2018-04-24 8:41 ` Simon Horman
-1 siblings, 0 replies; 21+ messages in thread
From: Simon Horman @ 2018-04-24 8:41 UTC (permalink / raw)
To: Lee Jones
Cc: Wolfram Sang, linux-kernel, linux-renesas-soc, Thierry Reding,
Daniel Thompson, Jingoo Han, Bartlomiej Zolnierkiewicz,
linux-pwm, dri-devel, linux-fbdev
On Mon, Apr 16, 2018 at 10:12:57AM +0100, Lee Jones wrote:
> On Wed, 11 Apr 2018, Simon Horman wrote:
>
> > On Tue, Apr 10, 2018 at 02:32:40PM +0200, Wolfram Sang wrote:
> > > The documentation was wrong, gpiod_get_direction() returns 0/1 instead
> > > of the GPIOF_* flags. The docs were fixed with commit 94fc73094abe47
> > > ("gpio: correct docs about return value of gpiod_get_direction"). Now,
> > > fix this user (until a better, system-wide solution is in place).
> > >
> > > Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
> > > Acked-by: Daniel Thompson <daniel.thompson@linaro.org>
> >
> > Reviewed-by: Simon Horman <horms+renesas@verge.net.au>
>
> Thanks for the Reviewed-by Simon. I have applied it to the original mail.
>
> Do you know why you mail wasn't sent attached to the original thread?
> For some reason I received this mail on it's own i.e. not in reply
> to the original.
No, not off hand. Perhaps I responded to the email in some unusual way
but by now I don't recall. In any case I'll try to be more careful
in future.
^ permalink raw reply [flat|nested] 21+ messages in thread
* Re: [PATCH RESEND] backlight: pwm_bl: don't use GPIOF_* with gpiod_get_direction
@ 2018-04-24 8:41 ` Simon Horman
0 siblings, 0 replies; 21+ messages in thread
From: Simon Horman @ 2018-04-24 8:41 UTC (permalink / raw)
To: Lee Jones
Cc: Wolfram Sang, linux-kernel, linux-renesas-soc, Thierry Reding,
Daniel Thompson, Jingoo Han, Bartlomiej Zolnierkiewicz,
linux-pwm, dri-devel, linux-fbdev
On Mon, Apr 16, 2018 at 10:12:57AM +0100, Lee Jones wrote:
> On Wed, 11 Apr 2018, Simon Horman wrote:
>
> > On Tue, Apr 10, 2018 at 02:32:40PM +0200, Wolfram Sang wrote:
> > > The documentation was wrong, gpiod_get_direction() returns 0/1 instead
> > > of the GPIOF_* flags. The docs were fixed with commit 94fc73094abe47
> > > ("gpio: correct docs about return value of gpiod_get_direction"). Now,
> > > fix this user (until a better, system-wide solution is in place).
> > >
> > > Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
> > > Acked-by: Daniel Thompson <daniel.thompson@linaro.org>
> >
> > Reviewed-by: Simon Horman <horms+renesas@verge.net.au>
>
> Thanks for the Reviewed-by Simon. I have applied it to the original mail.
>
> Do you know why you mail wasn't sent attached to the original thread?
> For some reason I received this mail on it's own i.e. not in reply
> to the original.
No, not off hand. Perhaps I responded to the email in some unusual way
but by now I don't recall. In any case I'll try to be more careful
in future.
^ permalink raw reply [flat|nested] 21+ messages in thread
* Re: [PATCH RESEND] backlight: pwm_bl: don't use GPIOF_* with gpiod_get_direction
2018-04-24 8:41 ` Simon Horman
(?)
@ 2018-04-24 9:12 ` Geert Uytterhoeven
-1 siblings, 0 replies; 21+ messages in thread
From: Geert Uytterhoeven @ 2018-04-24 9:12 UTC (permalink / raw)
To: Simon Horman
Cc: Lee Jones, Wolfram Sang, Linux Kernel Mailing List,
Linux-Renesas, Thierry Reding, Daniel Thompson, Jingoo Han,
Bartlomiej Zolnierkiewicz, Linux PWM List, DRI Development,
Linux Fbdev development list
On Tue, Apr 24, 2018 at 10:41 AM, Simon Horman <horms@verge.net.au> wrote:
> On Mon, Apr 16, 2018 at 10:12:57AM +0100, Lee Jones wrote:
>> On Wed, 11 Apr 2018, Simon Horman wrote:
>> > On Tue, Apr 10, 2018 at 02:32:40PM +0200, Wolfram Sang wrote:
>> > > The documentation was wrong, gpiod_get_direction() returns 0/1 instead
>> > > of the GPIOF_* flags. The docs were fixed with commit 94fc73094abe47
>> > > ("gpio: correct docs about return value of gpiod_get_direction"). Now,
>> > > fix this user (until a better, system-wide solution is in place).
>> > >
>> > > Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
>> > > Acked-by: Daniel Thompson <daniel.thompson@linaro.org>
>> >
>> > Reviewed-by: Simon Horman <horms+renesas@verge.net.au>
>>
>> Thanks for the Reviewed-by Simon. I have applied it to the original mail.
>>
>> Do you know why you mail wasn't sent attached to the original thread?
>> For some reason I received this mail on it's own i.e. not in reply
>> to the original.
>
> No, not off hand. Perhaps I responded to the email in some unusual way
> but by now I don't recall. In any case I'll try to be more careful
> in future.
I see Lee is using gmail for sending, so I assume also for receiving.
While I did receive Simon's reply in-thread, lately I had issues with gmail
not always doing so, and sometimes failing to do deduplication when receiving
email through multiple paths (mailing lists and/or directly).
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
^ permalink raw reply [flat|nested] 21+ messages in thread
* Re: [PATCH RESEND] backlight: pwm_bl: don't use GPIOF_* with gpiod_get_direction
@ 2018-04-24 9:12 ` Geert Uytterhoeven
0 siblings, 0 replies; 21+ messages in thread
From: Geert Uytterhoeven @ 2018-04-24 9:12 UTC (permalink / raw)
To: Simon Horman
Cc: Linux PWM List, Daniel Thompson, Bartlomiej Zolnierkiewicz,
Jingoo Han, Linux Kernel Mailing List, DRI Development,
Linux-Renesas, Wolfram Sang, Thierry Reding,
Linux Fbdev development list, Lee Jones
On Tue, Apr 24, 2018 at 10:41 AM, Simon Horman <horms@verge.net.au> wrote:
> On Mon, Apr 16, 2018 at 10:12:57AM +0100, Lee Jones wrote:
>> On Wed, 11 Apr 2018, Simon Horman wrote:
>> > On Tue, Apr 10, 2018 at 02:32:40PM +0200, Wolfram Sang wrote:
>> > > The documentation was wrong, gpiod_get_direction() returns 0/1 instead
>> > > of the GPIOF_* flags. The docs were fixed with commit 94fc73094abe47
>> > > ("gpio: correct docs about return value of gpiod_get_direction"). Now,
>> > > fix this user (until a better, system-wide solution is in place).
>> > >
>> > > Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
>> > > Acked-by: Daniel Thompson <daniel.thompson@linaro.org>
>> >
>> > Reviewed-by: Simon Horman <horms+renesas@verge.net.au>
>>
>> Thanks for the Reviewed-by Simon. I have applied it to the original mail.
>>
>> Do you know why you mail wasn't sent attached to the original thread?
>> For some reason I received this mail on it's own i.e. not in reply
>> to the original.
>
> No, not off hand. Perhaps I responded to the email in some unusual way
> but by now I don't recall. In any case I'll try to be more careful
> in future.
I see Lee is using gmail for sending, so I assume also for receiving.
While I did receive Simon's reply in-thread, lately I had issues with gmail
not always doing so, and sometimes failing to do deduplication when receiving
email through multiple paths (mailing lists and/or directly).
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 21+ messages in thread
* Re: [PATCH RESEND] backlight: pwm_bl: don't use GPIOF_* with gpiod_get_direction
@ 2018-04-24 9:12 ` Geert Uytterhoeven
0 siblings, 0 replies; 21+ messages in thread
From: Geert Uytterhoeven @ 2018-04-24 9:12 UTC (permalink / raw)
To: Simon Horman
Cc: Linux PWM List, Daniel Thompson, Bartlomiej Zolnierkiewicz,
Jingoo Han, Linux Kernel Mailing List, DRI Development,
Linux-Renesas, Wolfram Sang, Thierry Reding,
Linux Fbdev development list, Lee Jones
On Tue, Apr 24, 2018 at 10:41 AM, Simon Horman <horms@verge.net.au> wrote:
> On Mon, Apr 16, 2018 at 10:12:57AM +0100, Lee Jones wrote:
>> On Wed, 11 Apr 2018, Simon Horman wrote:
>> > On Tue, Apr 10, 2018 at 02:32:40PM +0200, Wolfram Sang wrote:
>> > > The documentation was wrong, gpiod_get_direction() returns 0/1 instead
>> > > of the GPIOF_* flags. The docs were fixed with commit 94fc73094abe47
>> > > ("gpio: correct docs about return value of gpiod_get_direction"). Now,
>> > > fix this user (until a better, system-wide solution is in place).
>> > >
>> > > Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
>> > > Acked-by: Daniel Thompson <daniel.thompson@linaro.org>
>> >
>> > Reviewed-by: Simon Horman <horms+renesas@verge.net.au>
>>
>> Thanks for the Reviewed-by Simon. I have applied it to the original mail.
>>
>> Do you know why you mail wasn't sent attached to the original thread?
>> For some reason I received this mail on it's own i.e. not in reply
>> to the original.
>
> No, not off hand. Perhaps I responded to the email in some unusual way
> but by now I don't recall. In any case I'll try to be more careful
> in future.
I see Lee is using gmail for sending, so I assume also for receiving.
While I did receive Simon's reply in-thread, lately I had issues with gmail
not always doing so, and sometimes failing to do deduplication when receiving
email through multiple paths (mailing lists and/or directly).
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
^ permalink raw reply [flat|nested] 21+ messages in thread
* Re: [PATCH RESEND] backlight: pwm_bl: don't use GPIOF_* with gpiod_get_direction
2018-04-24 9:12 ` Geert Uytterhoeven
(?)
@ 2018-04-24 10:07 ` Lee Jones
-1 siblings, 0 replies; 21+ messages in thread
From: Lee Jones @ 2018-04-24 10:07 UTC (permalink / raw)
To: Geert Uytterhoeven
Cc: Simon Horman, Wolfram Sang, Linux Kernel Mailing List,
Linux-Renesas, Thierry Reding, Daniel Thompson, Jingoo Han,
Bartlomiej Zolnierkiewicz, Linux PWM List, DRI Development,
Linux Fbdev development list
On Tue, 24 Apr 2018, Geert Uytterhoeven wrote:
> On Tue, Apr 24, 2018 at 10:41 AM, Simon Horman <horms@verge.net.au> wrote:
> > On Mon, Apr 16, 2018 at 10:12:57AM +0100, Lee Jones wrote:
> >> On Wed, 11 Apr 2018, Simon Horman wrote:
> >> > On Tue, Apr 10, 2018 at 02:32:40PM +0200, Wolfram Sang wrote:
> >> > > The documentation was wrong, gpiod_get_direction() returns 0/1 instead
> >> > > of the GPIOF_* flags. The docs were fixed with commit 94fc73094abe47
> >> > > ("gpio: correct docs about return value of gpiod_get_direction"). Now,
> >> > > fix this user (until a better, system-wide solution is in place).
> >> > >
> >> > > Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
> >> > > Acked-by: Daniel Thompson <daniel.thompson@linaro.org>
> >> >
> >> > Reviewed-by: Simon Horman <horms+renesas@verge.net.au>
> >>
> >> Thanks for the Reviewed-by Simon. I have applied it to the original mail.
> >>
> >> Do you know why you mail wasn't sent attached to the original thread?
> >> For some reason I received this mail on it's own i.e. not in reply
> >> to the original.
> >
> > No, not off hand. Perhaps I responded to the email in some unusual way
> > but by now I don't recall. In any case I'll try to be more careful
> > in future.
>
> I see Lee is using gmail for sending, so I assume also for receiving.
Well I'm using their servers, but my set-up is IMAP/Mutt.
> While I did receive Simon's reply in-thread, lately I had issues with gmail
> not always doing so, and sometimes failing to do deduplication when receiving
> email through multiple paths (mailing lists and/or directly).
--
Lee Jones [李琼斯]
Linaro Services Technical Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
^ permalink raw reply [flat|nested] 21+ messages in thread
* Re: [PATCH RESEND] backlight: pwm_bl: don't use GPIOF_* with gpiod_get_direction
@ 2018-04-24 10:07 ` Lee Jones
0 siblings, 0 replies; 21+ messages in thread
From: Lee Jones @ 2018-04-24 10:07 UTC (permalink / raw)
To: Geert Uytterhoeven
Cc: Linux PWM List, Daniel Thompson, Bartlomiej Zolnierkiewicz,
Jingoo Han, Linux Kernel Mailing List, DRI Development,
Linux-Renesas, Wolfram Sang, Simon Horman, Thierry Reding,
Linux Fbdev development list
On Tue, 24 Apr 2018, Geert Uytterhoeven wrote:
> On Tue, Apr 24, 2018 at 10:41 AM, Simon Horman <horms@verge.net.au> wrote:
> > On Mon, Apr 16, 2018 at 10:12:57AM +0100, Lee Jones wrote:
> >> On Wed, 11 Apr 2018, Simon Horman wrote:
> >> > On Tue, Apr 10, 2018 at 02:32:40PM +0200, Wolfram Sang wrote:
> >> > > The documentation was wrong, gpiod_get_direction() returns 0/1 instead
> >> > > of the GPIOF_* flags. The docs were fixed with commit 94fc73094abe47
> >> > > ("gpio: correct docs about return value of gpiod_get_direction"). Now,
> >> > > fix this user (until a better, system-wide solution is in place).
> >> > >
> >> > > Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
> >> > > Acked-by: Daniel Thompson <daniel.thompson@linaro.org>
> >> >
> >> > Reviewed-by: Simon Horman <horms+renesas@verge.net.au>
> >>
> >> Thanks for the Reviewed-by Simon. I have applied it to the original mail.
> >>
> >> Do you know why you mail wasn't sent attached to the original thread?
> >> For some reason I received this mail on it's own i.e. not in reply
> >> to the original.
> >
> > No, not off hand. Perhaps I responded to the email in some unusual way
> > but by now I don't recall. In any case I'll try to be more careful
> > in future.
>
> I see Lee is using gmail for sending, so I assume also for receiving.
Well I'm using their servers, but my set-up is IMAP/Mutt.
> While I did receive Simon's reply in-thread, lately I had issues with gmail
> not always doing so, and sometimes failing to do deduplication when receiving
> email through multiple paths (mailing lists and/or directly).
--
Lee Jones [李琼斯]
Linaro Services Technical Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 21+ messages in thread
* Re: [PATCH RESEND] backlight: pwm_bl: don't use GPIOF_* with gpiod_get_direction
@ 2018-04-24 10:07 ` Lee Jones
0 siblings, 0 replies; 21+ messages in thread
From: Lee Jones @ 2018-04-24 10:07 UTC (permalink / raw)
To: Geert Uytterhoeven
Cc: Linux PWM List, Daniel Thompson, Bartlomiej Zolnierkiewicz,
Jingoo Han, Linux Kernel Mailing List, DRI Development,
Linux-Renesas, Wolfram Sang, Simon Horman, Thierry Reding,
Linux Fbdev development list
On Tue, 24 Apr 2018, Geert Uytterhoeven wrote:
> On Tue, Apr 24, 2018 at 10:41 AM, Simon Horman <horms@verge.net.au> wrote:
> > On Mon, Apr 16, 2018 at 10:12:57AM +0100, Lee Jones wrote:
> >> On Wed, 11 Apr 2018, Simon Horman wrote:
> >> > On Tue, Apr 10, 2018 at 02:32:40PM +0200, Wolfram Sang wrote:
> >> > > The documentation was wrong, gpiod_get_direction() returns 0/1 instead
> >> > > of the GPIOF_* flags. The docs were fixed with commit 94fc73094abe47
> >> > > ("gpio: correct docs about return value of gpiod_get_direction"). Now,
> >> > > fix this user (until a better, system-wide solution is in place).
> >> > >
> >> > > Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
> >> > > Acked-by: Daniel Thompson <daniel.thompson@linaro.org>
> >> >
> >> > Reviewed-by: Simon Horman <horms+renesas@verge.net.au>
> >>
> >> Thanks for the Reviewed-by Simon. I have applied it to the original mail.
> >>
> >> Do you know why you mail wasn't sent attached to the original thread?
> >> For some reason I received this mail on it's own i.e. not in reply
> >> to the original.
> >
> > No, not off hand. Perhaps I responded to the email in some unusual way
> > but by now I don't recall. In any case I'll try to be more careful
> > in future.
>
> I see Lee is using gmail for sending, so I assume also for receiving.
Well I'm using their servers, but my set-up is IMAP/Mutt.
> While I did receive Simon's reply in-thread, lately I had issues with gmail
> not always doing so, and sometimes failing to do deduplication when receiving
> email through multiple paths (mailing lists and/or directly).
--
Lee Jones [李琼斯]
Linaro Services Technical Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
^ permalink raw reply [flat|nested] 21+ messages in thread
end of thread, other threads:[~2018-04-24 10:07 UTC | newest]
Thread overview: 21+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-04-10 12:32 [PATCH RESEND] backlight: pwm_bl: don't use GPIOF_* with gpiod_get_direction Wolfram Sang
2018-04-10 12:32 ` Wolfram Sang
2018-04-11 7:32 ` Simon Horman
2018-04-11 7:32 ` Simon Horman
2018-04-13 16:08 ` Daniel Vetter
2018-04-13 16:08 ` Daniel Vetter
2018-04-13 16:08 ` Daniel Vetter
2018-04-13 16:26 ` Daniel Thompson
2018-04-13 16:26 ` Daniel Thompson
2018-04-13 16:26 ` Daniel Thompson
2018-04-16 9:12 ` Lee Jones
2018-04-16 9:12 ` Lee Jones
2018-04-16 9:12 ` Lee Jones
2018-04-24 8:41 ` Simon Horman
2018-04-24 8:41 ` Simon Horman
2018-04-24 9:12 ` Geert Uytterhoeven
2018-04-24 9:12 ` Geert Uytterhoeven
2018-04-24 9:12 ` Geert Uytterhoeven
2018-04-24 10:07 ` Lee Jones
2018-04-24 10:07 ` Lee Jones
2018-04-24 10:07 ` Lee Jones
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.