From: Geert Uytterhoeven <geert@linux-m68k.org> To: John Paul Adrian Glaubitz <glaubitz@physik.fu-berlin.de> Cc: Rich Felker <dalias@libc.org>, Christoph Hellwig <hch@lst.de>, Yoshinori Sato <ysato@users.sourceforge.jp>, Linux-sh list <linux-sh@vger.kernel.org>, Linux Kernel Mailing List <linux-kernel@vger.kernel.org> Subject: Re: ioremap and dma cleanups and fixes for superh (2nd resend) Date: Wed, 15 Jul 2020 08:06:56 +0000 [thread overview] Message-ID: <CAMuHMdWP6h+6uTq--wpP7xtSRRMScqM617a9w=p_bV=w90yVtw@mail.gmail.com> (raw) In-Reply-To: <47673a8f-cda1-4915-df20-068acfc49892@physik.fu-berlin.de> Hi Adrian, On Wed, Jul 15, 2020 at 9:37 AM John Paul Adrian Glaubitz <glaubitz@physik.fu-berlin.de> wrote: > On 7/15/20 9:27 AM, Geert Uytterhoeven wrote: > > On Wed, Jul 15, 2020 at 1:14 AM John Paul Adrian Glaubitz > > <glaubitz@physik.fu-berlin.de> wrote: > >> However, independent of Christoph's series, the kernels throws two backtraces during > >> boot which I think should require a git bisect (unless I missed a configuration option > >> as I trimmed down the kernel a bit to make sure it's not too big). > >> > >> See the traces below and let me know what you think. > > > >> [ 1.560000] sh-sci.1: ttySC1 at MMIO 0xffeb0000 (irq = 44, base_baud = 0) is a scif > >> [ 1.560000] BUG: spinlock bad magic on CPU#0, swapper/1 > >> [ 1.560000] lock: sci_ports+0x1d8/0xb10, .magic: 00000000, .owner: <none>/-1, .owner_cpu: 0 > > > > [PATCH v1] serial: core: Initialise spin lock before use in > > uart_configure_port() > > https://lore.kernel.org/r/20200706140036.75524-1-andriy.shevchenko@linux.intel.com > Yes, this patch fixes this particular problem. > > There is just a typo in the code which causes a build problem but it's fixed by replacing > "uport" with "port": Oops, there's a v2 fixing that: https://lore.kernel.org/linux-serial/20200706143548.63985-1-andriy.shevchenko@linux.intel.com/ > CC kernel/module.o > drivers/tty/serial/serial_core.c: In function ‘uart_configure_port’: > drivers/tty/serial/serial_core.c:2385:33: error: ‘uport’ undeclared (first use in this function); did you mean ‘port’? > 2385 | uart_any_port_spin_lock_init(uport); > | ^~~~~ > | port > drivers/tty/serial/serial_core.c:2385:33: note: each undeclared identifier is reported only once for each function it appears in > make[3]: *** [scripts/Makefile.build:280: drivers/tty/serial/serial_core.o] Error 1 > make[2]: *** [scripts/Makefile.build:497: drivers/tty/serial] Error 2 > make[1]: *** [scripts/Makefile.build:497: drivers/tty] Error 2 > make[1]: *** Waiting for unfinished jobs.... > AR drivers/base/firmware_loader/built-in.a > > Will test the other changes in a minute. > > Can we include the serial fix? Please be patient. I expect this to be fixed soon through the tty tree. Note that linux-next already has an alternative fix (f38278e9b810b06a ("serial: sh-sci: Initialize spinlock for uart console")), which is planned to be reverted once the real fix has been applied. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
WARNING: multiple messages have this Message-ID (diff)
From: Geert Uytterhoeven <geert@linux-m68k.org> To: John Paul Adrian Glaubitz <glaubitz@physik.fu-berlin.de> Cc: Rich Felker <dalias@libc.org>, Christoph Hellwig <hch@lst.de>, Yoshinori Sato <ysato@users.sourceforge.jp>, Linux-sh list <linux-sh@vger.kernel.org>, Linux Kernel Mailing List <linux-kernel@vger.kernel.org> Subject: Re: ioremap and dma cleanups and fixes for superh (2nd resend) Date: Wed, 15 Jul 2020 10:06:56 +0200 [thread overview] Message-ID: <CAMuHMdWP6h+6uTq--wpP7xtSRRMScqM617a9w=p_bV=w90yVtw@mail.gmail.com> (raw) In-Reply-To: <47673a8f-cda1-4915-df20-068acfc49892@physik.fu-berlin.de> Hi Adrian, On Wed, Jul 15, 2020 at 9:37 AM John Paul Adrian Glaubitz <glaubitz@physik.fu-berlin.de> wrote: > On 7/15/20 9:27 AM, Geert Uytterhoeven wrote: > > On Wed, Jul 15, 2020 at 1:14 AM John Paul Adrian Glaubitz > > <glaubitz@physik.fu-berlin.de> wrote: > >> However, independent of Christoph's series, the kernels throws two backtraces during > >> boot which I think should require a git bisect (unless I missed a configuration option > >> as I trimmed down the kernel a bit to make sure it's not too big). > >> > >> See the traces below and let me know what you think. > > > >> [ 1.560000] sh-sci.1: ttySC1 at MMIO 0xffeb0000 (irq = 44, base_baud = 0) is a scif > >> [ 1.560000] BUG: spinlock bad magic on CPU#0, swapper/1 > >> [ 1.560000] lock: sci_ports+0x1d8/0xb10, .magic: 00000000, .owner: <none>/-1, .owner_cpu: 0 > > > > [PATCH v1] serial: core: Initialise spin lock before use in > > uart_configure_port() > > https://lore.kernel.org/r/20200706140036.75524-1-andriy.shevchenko@linux.intel.com > Yes, this patch fixes this particular problem. > > There is just a typo in the code which causes a build problem but it's fixed by replacing > "uport" with "port": Oops, there's a v2 fixing that: https://lore.kernel.org/linux-serial/20200706143548.63985-1-andriy.shevchenko@linux.intel.com/ > CC kernel/module.o > drivers/tty/serial/serial_core.c: In function ‘uart_configure_port’: > drivers/tty/serial/serial_core.c:2385:33: error: ‘uport’ undeclared (first use in this function); did you mean ‘port’? > 2385 | uart_any_port_spin_lock_init(uport); > | ^~~~~ > | port > drivers/tty/serial/serial_core.c:2385:33: note: each undeclared identifier is reported only once for each function it appears in > make[3]: *** [scripts/Makefile.build:280: drivers/tty/serial/serial_core.o] Error 1 > make[2]: *** [scripts/Makefile.build:497: drivers/tty/serial] Error 2 > make[1]: *** [scripts/Makefile.build:497: drivers/tty] Error 2 > make[1]: *** Waiting for unfinished jobs.... > AR drivers/base/firmware_loader/built-in.a > > Will test the other changes in a minute. > > Can we include the serial fix? Please be patient. I expect this to be fixed soon through the tty tree. Note that linux-next already has an alternative fix (f38278e9b810b06a ("serial: sh-sci: Initialize spinlock for uart console")), which is planned to be reverted once the real fix has been applied. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
next prev parent reply other threads:[~2020-07-15 8:06 UTC|newest] Thread overview: 163+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-03-24 16:26 ioremap and dma cleanups and fixes for superh Christoph Hellwig 2020-03-24 16:26 ` Christoph Hellwig 2020-03-24 16:26 ` [PATCH 01/10] sh: remove -Werror from Makefiles Christoph Hellwig 2020-03-24 16:26 ` Christoph Hellwig 2020-03-24 16:26 ` [PATCH 02/10] sh: sort the selects for SUPERH alphabetically Christoph Hellwig 2020-03-24 16:26 ` Christoph Hellwig 2020-03-24 16:26 ` [PATCH 03/10] sh: remove __KERNEL__ ifdefs from non-UAPI headers Christoph Hellwig 2020-03-24 16:26 ` Christoph Hellwig 2020-03-24 16:26 ` [PATCH 04/10] sh: move ioremap_fixed details out of <asm/io.h> Christoph Hellwig 2020-03-24 16:26 ` Christoph Hellwig 2020-03-24 16:26 ` [PATCH 05/10] sh: move the ioremap implementation out of line Christoph Hellwig 2020-03-24 16:26 ` Christoph Hellwig 2020-03-24 16:26 ` [PATCH 06/10] sh: don't include <asm/io_trapped.h> in <asm/io.h> Christoph Hellwig 2020-03-24 16:26 ` Christoph Hellwig 2020-03-24 16:26 ` [PATCH 07/10] sh: unexport register_trapped_io and match_trapped_io_handler Christoph Hellwig 2020-03-24 16:26 ` Christoph Hellwig 2020-03-24 16:26 ` [PATCH 08/10] dma-mapping: consolidate the NO_DMA definition in kernel/dma/Kconfig Christoph Hellwig 2020-03-24 16:26 ` Christoph Hellwig 2020-03-24 16:26 ` [PATCH 09/10] sh: don't allow non-coherent DMA for NOMMU Christoph Hellwig 2020-03-24 16:26 ` Christoph Hellwig 2020-03-24 16:26 ` [PATCH 10/10] sh: use the generic dma coherent remap allocator Christoph Hellwig 2020-03-24 16:26 ` Christoph Hellwig 2020-06-26 8:07 ` ioremap and dma cleanups and fixes for superh (resend) Christoph Hellwig 2020-06-26 8:07 ` Christoph Hellwig 2020-06-26 8:07 ` [PATCH 01/10] sh: remove -Werror from Makefiles Christoph Hellwig 2020-06-26 8:07 ` Christoph Hellwig 2020-06-26 8:07 ` [PATCH 02/10] sh: sort the selects for SUPERH alphabetically Christoph Hellwig 2020-06-26 8:07 ` Christoph Hellwig 2020-06-26 8:07 ` [PATCH 03/10] sh: remove __KERNEL__ ifdefs from non-UAPI headers Christoph Hellwig 2020-06-26 8:07 ` Christoph Hellwig 2020-06-26 8:07 ` [PATCH 04/10] sh: move ioremap_fixed details out of <asm/io.h> Christoph Hellwig 2020-06-26 8:07 ` Christoph Hellwig 2020-06-26 8:07 ` [PATCH 05/10] sh: move the ioremap implementation out of line Christoph Hellwig 2020-06-26 8:07 ` Christoph Hellwig 2020-06-26 8:07 ` [PATCH 06/10] sh: don't include <asm/io_trapped.h> in <asm/io.h> Christoph Hellwig 2020-06-26 8:07 ` Christoph Hellwig 2020-06-26 8:07 ` [PATCH 07/10] sh: unexport register_trapped_io and match_trapped_io_handler Christoph Hellwig 2020-06-26 8:07 ` Christoph Hellwig 2020-06-26 8:07 ` [PATCH 08/10] dma-mapping: consolidate the NO_DMA definition in kernel/dma/Kconfig Christoph Hellwig 2020-06-26 8:07 ` Christoph Hellwig 2020-06-26 8:07 ` [PATCH 09/10] sh: don't allow non-coherent DMA for NOMMU Christoph Hellwig 2020-06-26 8:07 ` Christoph Hellwig 2020-06-28 0:53 ` Rob Landley 2020-06-28 1:01 ` Rob Landley 2020-06-28 7:24 ` Christoph Hellwig 2020-06-28 7:24 ` Christoph Hellwig 2020-06-26 8:07 ` [PATCH 10/10] sh: use the generic dma coherent remap allocator Christoph Hellwig 2020-06-26 8:07 ` Christoph Hellwig 2020-07-14 12:18 ` ioremap and dma cleanups and fixes for superh (2nd resend) Christoph Hellwig 2020-07-14 12:18 ` Christoph Hellwig 2020-07-14 12:18 ` [PATCH 01/10] sh: remove -Werror from Makefiles Christoph Hellwig 2020-07-14 12:18 ` Christoph Hellwig 2020-07-14 12:18 ` [PATCH 02/10] sh: sort the selects for SUPERH alphabetically Christoph Hellwig 2020-07-14 12:18 ` Christoph Hellwig 2020-07-14 12:18 ` [PATCH 03/10] sh: remove __KERNEL__ ifdefs from non-UAPI headers Christoph Hellwig 2020-07-14 12:18 ` Christoph Hellwig 2020-07-14 12:18 ` [PATCH 04/10] sh: move ioremap_fixed details out of <asm/io.h> Christoph Hellwig 2020-07-14 12:18 ` Christoph Hellwig 2020-07-14 12:18 ` [PATCH 05/10] sh: move the ioremap implementation out of line Christoph Hellwig 2020-07-14 12:18 ` Christoph Hellwig 2020-07-14 12:18 ` [PATCH 06/10] sh: don't include <asm/io_trapped.h> in <asm/io.h> Christoph Hellwig 2020-07-14 12:18 ` Christoph Hellwig 2020-07-14 12:18 ` [PATCH 07/10] sh: unexport register_trapped_io and match_trapped_io_handler Christoph Hellwig 2020-07-14 12:18 ` Christoph Hellwig 2020-07-14 12:18 ` [PATCH 08/10] dma-mapping: consolidate the NO_DMA definition in kernel/dma/Kconfig Christoph Hellwig 2020-07-14 12:18 ` Christoph Hellwig 2020-07-21 3:17 ` Rich Felker 2020-07-21 3:17 ` Rich Felker 2020-07-21 5:11 ` Christoph Hellwig 2020-07-21 5:11 ` Christoph Hellwig 2020-07-22 0:43 ` Rich Felker 2020-07-22 0:43 ` Rich Felker 2020-07-14 12:18 ` [PATCH 09/10] sh: don't allow non-coherent DMA for NOMMU Christoph Hellwig 2020-07-14 12:18 ` Christoph Hellwig 2020-08-28 2:00 ` Rich Felker 2020-08-28 2:00 ` Rich Felker 2020-08-28 2:11 ` Rich Felker 2020-08-28 2:11 ` Rich Felker 2020-08-28 4:24 ` Christoph Hellwig 2020-08-28 4:24 ` Christoph Hellwig 2020-08-28 9:26 ` Ulf Hansson 2020-08-28 9:26 ` Ulf Hansson 2020-08-28 15:09 ` Rich Felker 2020-08-28 15:09 ` Rich Felker 2020-08-29 8:31 ` Christoph Hellwig 2020-08-29 8:31 ` Christoph Hellwig 2020-08-31 11:28 ` Ulf Hansson 2020-08-31 11:28 ` Ulf Hansson 2020-07-14 12:18 ` [PATCH 10/10] sh: use the generic dma coherent remap allocator Christoph Hellwig 2020-07-14 12:18 ` Christoph Hellwig 2020-07-14 12:31 ` ioremap and dma cleanups and fixes for superh (2nd resend) John Paul Adrian Glaubitz 2020-07-14 12:31 ` John Paul Adrian Glaubitz 2020-07-14 15:59 ` Rich Felker 2020-07-14 15:59 ` Rich Felker 2020-07-14 16:10 ` John Paul Adrian Glaubitz 2020-07-14 16:10 ` John Paul Adrian Glaubitz 2020-07-14 23:12 ` John Paul Adrian Glaubitz 2020-07-14 23:12 ` John Paul Adrian Glaubitz 2020-07-14 23:14 ` John Paul Adrian Glaubitz 2020-07-14 23:14 ` John Paul Adrian Glaubitz 2020-07-15 3:12 ` Rich Felker 2020-07-15 3:12 ` Rich Felker 2020-07-15 6:39 ` John Paul Adrian Glaubitz 2020-07-15 6:39 ` John Paul Adrian Glaubitz 2020-07-15 7:27 ` Geert Uytterhoeven 2020-07-15 7:27 ` Geert Uytterhoeven 2020-07-15 7:37 ` John Paul Adrian Glaubitz 2020-07-15 7:37 ` John Paul Adrian Glaubitz 2020-07-15 8:06 ` Geert Uytterhoeven [this message] 2020-07-15 8:06 ` Geert Uytterhoeven 2020-07-15 7:46 ` John Paul Adrian Glaubitz 2020-07-15 7:46 ` John Paul Adrian Glaubitz 2020-07-15 7:51 ` John Paul Adrian Glaubitz 2020-07-15 8:11 ` Geert Uytterhoeven 2020-07-15 8:11 ` Geert Uytterhoeven 2020-07-15 8:27 ` John Paul Adrian Glaubitz 2020-07-15 8:27 ` John Paul Adrian Glaubitz 2020-07-15 14:37 ` John Paul Adrian Glaubitz 2020-07-15 14:37 ` John Paul Adrian Glaubitz 2020-07-15 15:39 ` John Paul Adrian Glaubitz 2020-07-15 15:39 ` John Paul Adrian Glaubitz 2020-07-15 16:18 ` John Paul Adrian Glaubitz 2020-07-15 16:18 ` John Paul Adrian Glaubitz 2020-07-15 18:21 ` Geert Uytterhoeven 2020-07-15 18:21 ` Geert Uytterhoeven 2020-07-15 18:27 ` John Paul Adrian Glaubitz 2020-07-15 18:27 ` John Paul Adrian Glaubitz 2020-07-16 9:40 ` Peter Zijlstra 2020-07-16 9:40 ` Peter Zijlstra 2020-07-16 10:05 ` John Paul Adrian Glaubitz 2020-07-16 10:05 ` John Paul Adrian Glaubitz 2020-07-16 10:29 ` peterz 2020-07-16 10:29 ` peterz 2020-07-16 10:54 ` John Paul Adrian Glaubitz 2020-07-16 10:54 ` John Paul Adrian Glaubitz 2020-07-16 11:01 ` peterz 2020-07-16 11:01 ` peterz 2020-07-16 11:03 ` John Paul Adrian Glaubitz 2020-07-16 11:03 ` John Paul Adrian Glaubitz 2020-07-16 11:37 ` peterz 2020-07-16 11:37 ` peterz 2020-07-16 12:04 ` peterz 2020-07-16 12:04 ` peterz 2020-07-16 18:14 ` John Paul Adrian Glaubitz 2020-07-16 18:14 ` John Paul Adrian Glaubitz 2020-07-16 19:28 ` Peter Zijlstra 2020-07-16 19:28 ` Peter Zijlstra 2020-07-16 19:33 ` John Paul Adrian Glaubitz 2020-07-16 19:33 ` John Paul Adrian Glaubitz 2020-07-16 11:30 ` John Paul Adrian Glaubitz 2020-07-16 11:30 ` John Paul Adrian Glaubitz 2020-07-15 8:07 ` Geert Uytterhoeven 2020-07-15 8:07 ` Geert Uytterhoeven 2020-07-16 11:31 ` John Paul Adrian Glaubitz 2020-07-16 11:31 ` John Paul Adrian Glaubitz 2020-07-20 13:38 ` Christoph Hellwig 2020-07-20 13:38 ` Christoph Hellwig 2020-07-20 13:42 ` John Paul Adrian Glaubitz 2020-07-20 13:42 ` John Paul Adrian Glaubitz 2020-07-20 14:53 ` Rich Felker 2020-07-20 14:53 ` Rich Felker 2020-07-21 3:20 ` Rich Felker 2020-07-21 3:20 ` Rich Felker
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to='CAMuHMdWP6h+6uTq--wpP7xtSRRMScqM617a9w=p_bV=w90yVtw@mail.gmail.com' \ --to=geert@linux-m68k.org \ --cc=dalias@libc.org \ --cc=glaubitz@physik.fu-berlin.de \ --cc=hch@lst.de \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-sh@vger.kernel.org \ --cc=ysato@users.sourceforge.jp \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.