* [PATCH v2 0/3 pci/next] PCI: rcar, rcar-gen2: Bindings cleanups @ 2016-12-02 10:36 ` Simon Horman 0 siblings, 0 replies; 15+ messages in thread From: Simon Horman @ 2016-12-02 10:36 UTC (permalink / raw) To: Bjorn Helgaas Cc: Phil Edworthy, Magnus Damm, linux-pci-u79uwXL29TY76Z2rM5mHXA, linux-renesas-soc-u79uwXL29TY76Z2rM5mHXA, Rob Herring, devicetree-u79uwXL29TY76Z2rM5mHXA, Simon Horman Hi, this short series makes some bindings cleanups to the Renesas PCI drivers. Simon Horman (3): PCI: rcar-gen2: Use gen2 fallback compatibility last PCI: rcar: Use gen2 fallback compatibility last PCI: rcar: Add gen3 fallback compatibility string for pcie-rcar Documentation/devicetree/bindings/pci/rcar-pci.txt | 1 + drivers/pci/host/pci-rcar-gen2.c | 2 +- drivers/pci/host/pcie-rcar.c | 6 ++++-- 3 files changed, 6 insertions(+), 3 deletions(-) -- 2.7.0.rc3.207.g0ac5344 -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply [flat|nested] 15+ messages in thread
* [PATCH v2 0/3 pci/next] PCI: rcar, rcar-gen2: Bindings cleanups @ 2016-12-02 10:36 ` Simon Horman 0 siblings, 0 replies; 15+ messages in thread From: Simon Horman @ 2016-12-02 10:36 UTC (permalink / raw) To: Bjorn Helgaas Cc: Phil Edworthy, Magnus Damm, linux-pci, linux-renesas-soc, Rob Herring, devicetree, Simon Horman Hi, this short series makes some bindings cleanups to the Renesas PCI drivers. Simon Horman (3): PCI: rcar-gen2: Use gen2 fallback compatibility last PCI: rcar: Use gen2 fallback compatibility last PCI: rcar: Add gen3 fallback compatibility string for pcie-rcar Documentation/devicetree/bindings/pci/rcar-pci.txt | 1 + drivers/pci/host/pci-rcar-gen2.c | 2 +- drivers/pci/host/pcie-rcar.c | 6 ++++-- 3 files changed, 6 insertions(+), 3 deletions(-) -- 2.7.0.rc3.207.g0ac5344 ^ permalink raw reply [flat|nested] 15+ messages in thread
* [PATCH v2 1/3 pci/next] PCI: rcar-gen2: Use gen2 fallback compatibility last 2016-12-02 10:36 ` Simon Horman (?) @ 2016-12-02 10:36 ` Simon Horman 2016-12-02 11:44 ` Geert Uytterhoeven -1 siblings, 1 reply; 15+ messages in thread From: Simon Horman @ 2016-12-02 10:36 UTC (permalink / raw) To: Bjorn Helgaas Cc: Phil Edworthy, Magnus Damm, linux-pci, linux-renesas-soc, Rob Herring, devicetree, Simon Horman Fallback compatibility strings should be used only if more specific ones are matched and the order of compatibility strings in the corresponding struct of_device_id should implement this. This does not have a run-time effect as current all relevant compatibility strings result in the same initialisation. Signed-off-by: Simon Horman <horms+renesas@verge.net.au> --- v2 * New patch Signed-off-by: Simon Horman <horms+renesas@verge.net.au> --- drivers/pci/host/pci-rcar-gen2.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/pci/host/pci-rcar-gen2.c b/drivers/pci/host/pci-rcar-gen2.c index 1eeefa4df64c..85348590848b 100644 --- a/drivers/pci/host/pci-rcar-gen2.c +++ b/drivers/pci/host/pci-rcar-gen2.c @@ -430,10 +430,10 @@ static int rcar_pci_probe(struct platform_device *pdev) } static struct of_device_id rcar_pci_of_match[] = { - { .compatible = "renesas,pci-rcar-gen2", }, { .compatible = "renesas,pci-r8a7790", }, { .compatible = "renesas,pci-r8a7791", }, { .compatible = "renesas,pci-r8a7794", }, + { .compatible = "renesas,pci-rcar-gen2", }, { }, }; -- 2.7.0.rc3.207.g0ac5344 ^ permalink raw reply related [flat|nested] 15+ messages in thread
* Re: [PATCH v2 1/3 pci/next] PCI: rcar-gen2: Use gen2 fallback compatibility last 2016-12-02 10:36 ` [PATCH v2 1/3 pci/next] PCI: rcar-gen2: Use gen2 fallback compatibility last Simon Horman @ 2016-12-02 11:44 ` Geert Uytterhoeven 0 siblings, 0 replies; 15+ messages in thread From: Geert Uytterhoeven @ 2016-12-02 11:44 UTC (permalink / raw) To: Simon Horman Cc: Bjorn Helgaas, Phil Edworthy, Magnus Damm, linux-pci, Linux-Renesas, Rob Herring, devicetree On Fri, Dec 2, 2016 at 11:36 AM, Simon Horman <horms+renesas@verge.net.au> wrote: > Fallback compatibility strings should be used only if more specific ones > are matched and the order of compatibility strings in the corresponding > struct of_device_id should implement this. > > This does not have a run-time effect as current all relevant compatibility > strings result in the same initialisation. > > Signed-off-by: Simon Horman <horms+renesas@verge.net.au> Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be> Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds ^ permalink raw reply [flat|nested] 15+ messages in thread
[parent not found: <1480675020-26346-1-git-send-email-horms+renesas-/R6kz+dDXgpPR4JQBCEnsQ@public.gmane.org>]
* [PATCH v2 2/3 pci/next] PCI: rcar: Use gen2 fallback compatibility last 2016-12-02 10:36 ` Simon Horman @ 2016-12-02 10:36 ` Simon Horman -1 siblings, 0 replies; 15+ messages in thread From: Simon Horman @ 2016-12-02 10:36 UTC (permalink / raw) To: Bjorn Helgaas Cc: Phil Edworthy, Magnus Damm, linux-pci-u79uwXL29TY76Z2rM5mHXA, linux-renesas-soc-u79uwXL29TY76Z2rM5mHXA, Rob Herring, devicetree-u79uwXL29TY76Z2rM5mHXA, Simon Horman Fallback compatibility strings should be used only if more specific ones are matched and the order of compatibility strings in the corresponding struct of_device_id should implement this. This does not have a run-time effect as current all relevant compatibility strings result in the same initialisation. Signed-off-by: Simon Horman <horms+renesas-/R6kz+dDXgpPR4JQBCEnsQ@public.gmane.org> --- v2 * New patch --- drivers/pci/host/pcie-rcar.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/pci/host/pcie-rcar.c b/drivers/pci/host/pcie-rcar.c index 62700d1896f4..85971bc276c6 100644 --- a/drivers/pci/host/pcie-rcar.c +++ b/drivers/pci/host/pcie-rcar.c @@ -1071,12 +1071,12 @@ static int rcar_pcie_parse_map_dma_ranges(struct rcar_pcie *pcie, static const struct of_device_id rcar_pcie_of_match[] = { { .compatible = "renesas,pcie-r8a7779", .data = rcar_pcie_hw_init_h1 }, - { .compatible = "renesas,pcie-rcar-gen2", - .data = rcar_pcie_hw_init_gen2 }, { .compatible = "renesas,pcie-r8a7790", .data = rcar_pcie_hw_init_gen2 }, { .compatible = "renesas,pcie-r8a7791", .data = rcar_pcie_hw_init_gen2 }, + { .compatible = "renesas,pcie-rcar-gen2", + .data = rcar_pcie_hw_init_gen2 }, { .compatible = "renesas,pcie-r8a7795", .data = rcar_pcie_hw_init }, {}, }; -- 2.7.0.rc3.207.g0ac5344 -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply related [flat|nested] 15+ messages in thread
* [PATCH v2 2/3 pci/next] PCI: rcar: Use gen2 fallback compatibility last @ 2016-12-02 10:36 ` Simon Horman 0 siblings, 0 replies; 15+ messages in thread From: Simon Horman @ 2016-12-02 10:36 UTC (permalink / raw) To: Bjorn Helgaas Cc: Phil Edworthy, Magnus Damm, linux-pci, linux-renesas-soc, Rob Herring, devicetree, Simon Horman Fallback compatibility strings should be used only if more specific ones are matched and the order of compatibility strings in the corresponding struct of_device_id should implement this. This does not have a run-time effect as current all relevant compatibility strings result in the same initialisation. Signed-off-by: Simon Horman <horms+renesas@verge.net.au> --- v2 * New patch --- drivers/pci/host/pcie-rcar.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/pci/host/pcie-rcar.c b/drivers/pci/host/pcie-rcar.c index 62700d1896f4..85971bc276c6 100644 --- a/drivers/pci/host/pcie-rcar.c +++ b/drivers/pci/host/pcie-rcar.c @@ -1071,12 +1071,12 @@ static int rcar_pcie_parse_map_dma_ranges(struct rcar_pcie *pcie, static const struct of_device_id rcar_pcie_of_match[] = { { .compatible = "renesas,pcie-r8a7779", .data = rcar_pcie_hw_init_h1 }, - { .compatible = "renesas,pcie-rcar-gen2", - .data = rcar_pcie_hw_init_gen2 }, { .compatible = "renesas,pcie-r8a7790", .data = rcar_pcie_hw_init_gen2 }, { .compatible = "renesas,pcie-r8a7791", .data = rcar_pcie_hw_init_gen2 }, + { .compatible = "renesas,pcie-rcar-gen2", + .data = rcar_pcie_hw_init_gen2 }, { .compatible = "renesas,pcie-r8a7795", .data = rcar_pcie_hw_init }, {}, }; -- 2.7.0.rc3.207.g0ac5344 ^ permalink raw reply related [flat|nested] 15+ messages in thread
[parent not found: <1480675020-26346-3-git-send-email-horms+renesas-/R6kz+dDXgpPR4JQBCEnsQ@public.gmane.org>]
* Re: [PATCH v2 2/3 pci/next] PCI: rcar: Use gen2 fallback compatibility last 2016-12-02 10:36 ` Simon Horman @ 2016-12-02 14:53 ` Geert Uytterhoeven -1 siblings, 0 replies; 15+ messages in thread From: Geert Uytterhoeven @ 2016-12-02 14:53 UTC (permalink / raw) To: Simon Horman Cc: Bjorn Helgaas, Phil Edworthy, Magnus Damm, linux-pci, Linux-Renesas, Rob Herring, devicetree-u79uwXL29TY76Z2rM5mHXA On Fri, Dec 2, 2016 at 11:36 AM, Simon Horman <horms+renesas-/R6kz+dDXgpPR4JQBCEnsQ@public.gmane.org> wrote: > Fallback compatibility strings should be used only if more specific ones > are matched and the order of compatibility strings in the corresponding > struct of_device_id should implement this. > > This does not have a run-time effect as current all relevant compatibility > strings result in the same initialisation. > > Signed-off-by: Simon Horman <horms+renesas-/R6kz+dDXgpPR4JQBCEnsQ@public.gmane.org> Reviewed-by: Geert Uytterhoeven <geert+renesas-gXvu3+zWzMSzQB+pC5nmwQ@public.gmane.org> Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert-Td1EMuHUCqxL1ZNQvxDV9g@public.gmane.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [PATCH v2 2/3 pci/next] PCI: rcar: Use gen2 fallback compatibility last @ 2016-12-02 14:53 ` Geert Uytterhoeven 0 siblings, 0 replies; 15+ messages in thread From: Geert Uytterhoeven @ 2016-12-02 14:53 UTC (permalink / raw) To: Simon Horman Cc: Bjorn Helgaas, Phil Edworthy, Magnus Damm, linux-pci, Linux-Renesas, Rob Herring, devicetree On Fri, Dec 2, 2016 at 11:36 AM, Simon Horman <horms+renesas@verge.net.au> wrote: > Fallback compatibility strings should be used only if more specific ones > are matched and the order of compatibility strings in the corresponding > struct of_device_id should implement this. > > This does not have a run-time effect as current all relevant compatibility > strings result in the same initialisation. > > Signed-off-by: Simon Horman <horms+renesas@verge.net.au> Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be> Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds ^ permalink raw reply [flat|nested] 15+ messages in thread
* [PATCH v2 3/3 pci/next] PCI: rcar: Add gen3 fallback compatibility string for pcie-rcar 2016-12-02 10:36 ` Simon Horman ` (2 preceding siblings ...) (?) @ 2016-12-02 10:37 ` Simon Horman [not found] ` <1480675020-26346-4-git-send-email-horms+renesas-/R6kz+dDXgpPR4JQBCEnsQ@public.gmane.org> -1 siblings, 1 reply; 15+ messages in thread From: Simon Horman @ 2016-12-02 10:37 UTC (permalink / raw) To: Bjorn Helgaas Cc: Phil Edworthy, Magnus Damm, linux-pci, linux-renesas-soc, Rob Herring, devicetree, Simon Horman Add fallback compatibility string for the R-Car Gen 3 family. This is in keeping with the both the existing fallback compatibility string for the R-Car Gen 2 family and the fallback scheme being adopted wherever appropriate for drivers for Renesas SoCs. Signed-off-by: Simon Horman <horms+renesas@verge.net.au> --- v2 * Move fallback binding to below SoC specific bindings it covers in implementation --- Documentation/devicetree/bindings/pci/rcar-pci.txt | 1 + drivers/pci/host/pcie-rcar.c | 2 ++ 2 files changed, 3 insertions(+) diff --git a/Documentation/devicetree/bindings/pci/rcar-pci.txt b/Documentation/devicetree/bindings/pci/rcar-pci.txt index 6cf99690eef9..eee518db90b9 100644 --- a/Documentation/devicetree/bindings/pci/rcar-pci.txt +++ b/Documentation/devicetree/bindings/pci/rcar-pci.txt @@ -7,6 +7,7 @@ compatible: "renesas,pcie-r8a7779" for the R8A7779 SoC; "renesas,pcie-r8a7793" for the R8A7793 SoC; "renesas,pcie-r8a7795" for the R8A7795 SoC; "renesas,pcie-rcar-gen2" for a generic R-Car Gen2 compatible device. + "renesas,pcie-rcar-gen3" for a generic R-Car Gen3 compatible device. When compatible with the generic version, nodes must list the SoC-specific version corresponding to the platform first diff --git a/drivers/pci/host/pcie-rcar.c b/drivers/pci/host/pcie-rcar.c index 85971bc276c6..72058bc7af5c 100644 --- a/drivers/pci/host/pcie-rcar.c +++ b/drivers/pci/host/pcie-rcar.c @@ -1078,6 +1078,8 @@ static const struct of_device_id rcar_pcie_of_match[] = { { .compatible = "renesas,pcie-rcar-gen2", .data = rcar_pcie_hw_init_gen2 }, { .compatible = "renesas,pcie-r8a7795", .data = rcar_pcie_hw_init }, + { .compatible = "renesas,pcie-rcar-gen3", + .data = rcar_pcie_hw_init_hw_init }, {}, }; -- 2.7.0.rc3.207.g0ac5344 ^ permalink raw reply related [flat|nested] 15+ messages in thread
[parent not found: <1480675020-26346-4-git-send-email-horms+renesas-/R6kz+dDXgpPR4JQBCEnsQ@public.gmane.org>]
* Re: [PATCH v2 3/3 pci/next] PCI: rcar: Add gen3 fallback compatibility string for pcie-rcar 2016-12-02 10:37 ` [PATCH v2 3/3 pci/next] PCI: rcar: Add gen3 fallback compatibility string for pcie-rcar Simon Horman @ 2016-12-02 11:44 ` Geert Uytterhoeven 0 siblings, 0 replies; 15+ messages in thread From: Geert Uytterhoeven @ 2016-12-02 11:44 UTC (permalink / raw) To: Simon Horman Cc: Bjorn Helgaas, Phil Edworthy, Magnus Damm, linux-pci, Linux-Renesas, Rob Herring, devicetree-u79uwXL29TY76Z2rM5mHXA On Fri, Dec 2, 2016 at 11:37 AM, Simon Horman <horms+renesas-/R6kz+dDXgpPR4JQBCEnsQ@public.gmane.org> wrote: > Add fallback compatibility string for the R-Car Gen 3 family. This is in > keeping with the both the existing fallback compatibility string for the > R-Car Gen 2 family and the fallback scheme being adopted wherever > appropriate for drivers for Renesas SoCs. > > Signed-off-by: Simon Horman <horms+renesas-/R6kz+dDXgpPR4JQBCEnsQ@public.gmane.org> Reviewed-by: Geert Uytterhoeven <geert+renesas-gXvu3+zWzMSzQB+pC5nmwQ@public.gmane.org> Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert-Td1EMuHUCqxL1ZNQvxDV9g@public.gmane.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [PATCH v2 3/3 pci/next] PCI: rcar: Add gen3 fallback compatibility string for pcie-rcar @ 2016-12-02 11:44 ` Geert Uytterhoeven 0 siblings, 0 replies; 15+ messages in thread From: Geert Uytterhoeven @ 2016-12-02 11:44 UTC (permalink / raw) To: Simon Horman Cc: Bjorn Helgaas, Phil Edworthy, Magnus Damm, linux-pci, Linux-Renesas, Rob Herring, devicetree On Fri, Dec 2, 2016 at 11:37 AM, Simon Horman <horms+renesas@verge.net.au> wrote: > Add fallback compatibility string for the R-Car Gen 3 family. This is in > keeping with the both the existing fallback compatibility string for the > R-Car Gen 2 family and the fallback scheme being adopted wherever > appropriate for drivers for Renesas SoCs. > > Signed-off-by: Simon Horman <horms+renesas@verge.net.au> Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be> Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds ^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [PATCH v2 3/3 pci/next] PCI: rcar: Add gen3 fallback compatibility string for pcie-rcar 2016-12-02 10:37 ` [PATCH v2 3/3 pci/next] PCI: rcar: Add gen3 fallback compatibility string for pcie-rcar Simon Horman @ 2016-12-02 21:50 ` Simon Horman 0 siblings, 0 replies; 15+ messages in thread From: Simon Horman @ 2016-12-02 21:50 UTC (permalink / raw) To: Bjorn Helgaas Cc: Phil Edworthy, Magnus Damm, linux-pci-u79uwXL29TY76Z2rM5mHXA, linux-renesas-soc-u79uwXL29TY76Z2rM5mHXA, Rob Herring, devicetree-u79uwXL29TY76Z2rM5mHXA On Fri, Dec 02, 2016 at 11:37:00AM +0100, Simon Horman wrote: > Add fallback compatibility string for the R-Car Gen 3 family. This is in > keeping with the both the existing fallback compatibility string for the > R-Car Gen 2 family and the fallback scheme being adopted wherever > appropriate for drivers for Renesas SoCs. > > Signed-off-by: Simon Horman <horms+renesas-/R6kz+dDXgpPR4JQBCEnsQ@public.gmane.org> > --- > v2 > * Move fallback binding to below SoC specific bindings it covers > in implementation > --- > Documentation/devicetree/bindings/pci/rcar-pci.txt | 1 + > drivers/pci/host/pcie-rcar.c | 2 ++ > 2 files changed, 3 insertions(+) > > diff --git a/Documentation/devicetree/bindings/pci/rcar-pci.txt b/Documentation/devicetree/bindings/pci/rcar-pci.txt > index 6cf99690eef9..eee518db90b9 100644 > --- a/Documentation/devicetree/bindings/pci/rcar-pci.txt > +++ b/Documentation/devicetree/bindings/pci/rcar-pci.txt > @@ -7,6 +7,7 @@ compatible: "renesas,pcie-r8a7779" for the R8A7779 SoC; > "renesas,pcie-r8a7793" for the R8A7793 SoC; > "renesas,pcie-r8a7795" for the R8A7795 SoC; > "renesas,pcie-rcar-gen2" for a generic R-Car Gen2 compatible device. > + "renesas,pcie-rcar-gen3" for a generic R-Car Gen3 compatible device. > > When compatible with the generic version, nodes must list the > SoC-specific version corresponding to the platform first > diff --git a/drivers/pci/host/pcie-rcar.c b/drivers/pci/host/pcie-rcar.c > index 85971bc276c6..72058bc7af5c 100644 > --- a/drivers/pci/host/pcie-rcar.c > +++ b/drivers/pci/host/pcie-rcar.c > @@ -1078,6 +1078,8 @@ static const struct of_device_id rcar_pcie_of_match[] = { > { .compatible = "renesas,pcie-rcar-gen2", > .data = rcar_pcie_hw_init_gen2 }, > { .compatible = "renesas,pcie-r8a7795", .data = rcar_pcie_hw_init }, > + { .compatible = "renesas,pcie-rcar-gen3", > + .data = rcar_pcie_hw_init_hw_init }, It looks like I failed to compile-test this. s/rcar_pcie_hw_init_hw_init/rcar_pcie_hw_init/ > {}, > }; > > -- > 2.7.0.rc3.207.g0ac5344 > -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [PATCH v2 3/3 pci/next] PCI: rcar: Add gen3 fallback compatibility string for pcie-rcar @ 2016-12-02 21:50 ` Simon Horman 0 siblings, 0 replies; 15+ messages in thread From: Simon Horman @ 2016-12-02 21:50 UTC (permalink / raw) To: Bjorn Helgaas Cc: Phil Edworthy, Magnus Damm, linux-pci, linux-renesas-soc, Rob Herring, devicetree On Fri, Dec 02, 2016 at 11:37:00AM +0100, Simon Horman wrote: > Add fallback compatibility string for the R-Car Gen 3 family. This is in > keeping with the both the existing fallback compatibility string for the > R-Car Gen 2 family and the fallback scheme being adopted wherever > appropriate for drivers for Renesas SoCs. > > Signed-off-by: Simon Horman <horms+renesas@verge.net.au> > --- > v2 > * Move fallback binding to below SoC specific bindings it covers > in implementation > --- > Documentation/devicetree/bindings/pci/rcar-pci.txt | 1 + > drivers/pci/host/pcie-rcar.c | 2 ++ > 2 files changed, 3 insertions(+) > > diff --git a/Documentation/devicetree/bindings/pci/rcar-pci.txt b/Documentation/devicetree/bindings/pci/rcar-pci.txt > index 6cf99690eef9..eee518db90b9 100644 > --- a/Documentation/devicetree/bindings/pci/rcar-pci.txt > +++ b/Documentation/devicetree/bindings/pci/rcar-pci.txt > @@ -7,6 +7,7 @@ compatible: "renesas,pcie-r8a7779" for the R8A7779 SoC; > "renesas,pcie-r8a7793" for the R8A7793 SoC; > "renesas,pcie-r8a7795" for the R8A7795 SoC; > "renesas,pcie-rcar-gen2" for a generic R-Car Gen2 compatible device. > + "renesas,pcie-rcar-gen3" for a generic R-Car Gen3 compatible device. > > When compatible with the generic version, nodes must list the > SoC-specific version corresponding to the platform first > diff --git a/drivers/pci/host/pcie-rcar.c b/drivers/pci/host/pcie-rcar.c > index 85971bc276c6..72058bc7af5c 100644 > --- a/drivers/pci/host/pcie-rcar.c > +++ b/drivers/pci/host/pcie-rcar.c > @@ -1078,6 +1078,8 @@ static const struct of_device_id rcar_pcie_of_match[] = { > { .compatible = "renesas,pcie-rcar-gen2", > .data = rcar_pcie_hw_init_gen2 }, > { .compatible = "renesas,pcie-r8a7795", .data = rcar_pcie_hw_init }, > + { .compatible = "renesas,pcie-rcar-gen3", > + .data = rcar_pcie_hw_init_hw_init }, It looks like I failed to compile-test this. s/rcar_pcie_hw_init_hw_init/rcar_pcie_hw_init/ > {}, > }; > > -- > 2.7.0.rc3.207.g0ac5344 > ^ permalink raw reply [flat|nested] 15+ messages in thread
[parent not found: <20161202215016.GA21497-/R6kz+dDXgpPR4JQBCEnsQ@public.gmane.org>]
* Re: [PATCH v2 3/3 pci/next] PCI: rcar: Add gen3 fallback compatibility string for pcie-rcar 2016-12-02 21:50 ` Simon Horman @ 2016-12-03 11:19 ` Geert Uytterhoeven -1 siblings, 0 replies; 15+ messages in thread From: Geert Uytterhoeven @ 2016-12-03 11:19 UTC (permalink / raw) To: Simon Horman Cc: Bjorn Helgaas, Phil Edworthy, Magnus Damm, linux-pci, Linux-Renesas, Rob Herring, devicetree-u79uwXL29TY76Z2rM5mHXA On Fri, Dec 2, 2016 at 10:50 PM, Simon Horman <horms-/R6kz+dDXgpPR4JQBCEnsQ@public.gmane.org> wrote: > On Fri, Dec 02, 2016 at 11:37:00AM +0100, Simon Horman wrote: >> --- a/drivers/pci/host/pcie-rcar.c >> +++ b/drivers/pci/host/pcie-rcar.c >> @@ -1078,6 +1078,8 @@ static const struct of_device_id rcar_pcie_of_match[] = { >> { .compatible = "renesas,pcie-rcar-gen2", >> .data = rcar_pcie_hw_init_gen2 }, >> { .compatible = "renesas,pcie-r8a7795", .data = rcar_pcie_hw_init }, >> + { .compatible = "renesas,pcie-rcar-gen3", >> + .data = rcar_pcie_hw_init_hw_init }, > > It looks like I failed to compile-test this. > > s/rcar_pcie_hw_init_hw_init/rcar_pcie_hw_init/ Bummer, and my tired eyes didn't notice... Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert-Td1EMuHUCqxL1ZNQvxDV9g@public.gmane.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [PATCH v2 3/3 pci/next] PCI: rcar: Add gen3 fallback compatibility string for pcie-rcar @ 2016-12-03 11:19 ` Geert Uytterhoeven 0 siblings, 0 replies; 15+ messages in thread From: Geert Uytterhoeven @ 2016-12-03 11:19 UTC (permalink / raw) To: Simon Horman Cc: Bjorn Helgaas, Phil Edworthy, Magnus Damm, linux-pci, Linux-Renesas, Rob Herring, devicetree On Fri, Dec 2, 2016 at 10:50 PM, Simon Horman <horms@verge.net.au> wrote: > On Fri, Dec 02, 2016 at 11:37:00AM +0100, Simon Horman wrote: >> --- a/drivers/pci/host/pcie-rcar.c >> +++ b/drivers/pci/host/pcie-rcar.c >> @@ -1078,6 +1078,8 @@ static const struct of_device_id rcar_pcie_of_match[] = { >> { .compatible = "renesas,pcie-rcar-gen2", >> .data = rcar_pcie_hw_init_gen2 }, >> { .compatible = "renesas,pcie-r8a7795", .data = rcar_pcie_hw_init }, >> + { .compatible = "renesas,pcie-rcar-gen3", >> + .data = rcar_pcie_hw_init_hw_init }, > > It looks like I failed to compile-test this. > > s/rcar_pcie_hw_init_hw_init/rcar_pcie_hw_init/ Bummer, and my tired eyes didn't notice... Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds ^ permalink raw reply [flat|nested] 15+ messages in thread
end of thread, other threads:[~2016-12-03 11:20 UTC | newest] Thread overview: 15+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2016-12-02 10:36 [PATCH v2 0/3 pci/next] PCI: rcar, rcar-gen2: Bindings cleanups Simon Horman 2016-12-02 10:36 ` Simon Horman 2016-12-02 10:36 ` [PATCH v2 1/3 pci/next] PCI: rcar-gen2: Use gen2 fallback compatibility last Simon Horman 2016-12-02 11:44 ` Geert Uytterhoeven [not found] ` <1480675020-26346-1-git-send-email-horms+renesas-/R6kz+dDXgpPR4JQBCEnsQ@public.gmane.org> 2016-12-02 10:36 ` [PATCH v2 2/3 pci/next] PCI: rcar: " Simon Horman 2016-12-02 10:36 ` Simon Horman [not found] ` <1480675020-26346-3-git-send-email-horms+renesas-/R6kz+dDXgpPR4JQBCEnsQ@public.gmane.org> 2016-12-02 14:53 ` Geert Uytterhoeven 2016-12-02 14:53 ` Geert Uytterhoeven 2016-12-02 10:37 ` [PATCH v2 3/3 pci/next] PCI: rcar: Add gen3 fallback compatibility string for pcie-rcar Simon Horman [not found] ` <1480675020-26346-4-git-send-email-horms+renesas-/R6kz+dDXgpPR4JQBCEnsQ@public.gmane.org> 2016-12-02 11:44 ` Geert Uytterhoeven 2016-12-02 11:44 ` Geert Uytterhoeven 2016-12-02 21:50 ` Simon Horman 2016-12-02 21:50 ` Simon Horman [not found] ` <20161202215016.GA21497-/R6kz+dDXgpPR4JQBCEnsQ@public.gmane.org> 2016-12-03 11:19 ` Geert Uytterhoeven 2016-12-03 11:19 ` Geert Uytterhoeven
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.