From: Geert Uytterhoeven <geert-Td1EMuHUCqxL1ZNQvxDV9g@public.gmane.org> To: Vladimir Barinov <vladimir.barinov-M4DtvfQ/ZS1MRgGoP+s0PdBPR1lH4CV8@public.gmane.org> Cc: Simon Horman <horms-/R6kz+dDXgpPR4JQBCEnsQ@public.gmane.org>, Magnus Damm <magnus.damm-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>, Rob Herring <robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>, Mark Rutland <mark.rutland-5wv7dgnIgG8@public.gmane.org>, "devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" <devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>, Linux-Renesas <linux-renesas-soc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org> Subject: Re: [PATCH v3 06/12] arm64: dts: h3ulcb: enable SDHI0 Date: Thu, 1 Sep 2016 10:11:45 +0200 [thread overview] Message-ID: <CAMuHMdWakZuEu-gTo5=3VWxRdSc8V9gpL28yhjrVhHh1oZVu+Q@mail.gmail.com> (raw) In-Reply-To: <1472637799-14819-1-git-send-email-vladimir.barinov-M4DtvfQ/ZS1MRgGoP+s0PdBPR1lH4CV8@public.gmane.org> Hi Vladimir, On Wed, Aug 31, 2016 at 12:03 PM, Vladimir Barinov <vladimir.barinov-M4DtvfQ/ZS1MRgGoP+s0PdBPR1lH4CV8@public.gmane.org> wrote: > This supports SDHI0 on H3ULCB board SD card slot > > Signed-off-by: Vladimir Barinov <vladimir.barinov-M4DtvfQ/ZS1MRgGoP+s0PdBPR1lH4CV8@public.gmane.org> Thanks for your patch! > --- a/arch/arm64/boot/dts/renesas/r8a7795-h3ulcb.dts > +++ b/arch/arm64/boot/dts/renesas/r8a7795-h3ulcb.dts > @@ -82,6 +118,18 @@ > status = "okay"; > }; > > +&sdhi0 { > + pinctrl-0 = <&sdhi0_pins_3v3>; > + pinctrl-1 = <&sdhi0_pins_1v8>; > + pinctrl-names = "default", "state_uhs"; > + > + vmmc-supply = <&vcc_sdhi0>; > + vqmmc-supply = <&vccq_sdhi0>; > + cd-gpios = <&gpio3 12 GPIO_ACTIVE_LOW>; > + bus-width = <4>; > + status = "okay"; > +}; According to the schematics, SD0_WP is wired, so I think you want to add wp-gpios = <&gpio3 13 GPIO_ACTIVE_HIGH>; As you add UHS pins, I think you want to add sd-uhs-sdr50 too. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert-Td1EMuHUCqxL1ZNQvxDV9g@public.gmane.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: Geert Uytterhoeven <geert@linux-m68k.org> To: Vladimir Barinov <vladimir.barinov@cogentembedded.com> Cc: Simon Horman <horms@verge.net.au>, Magnus Damm <magnus.damm@gmail.com>, Rob Herring <robh+dt@kernel.org>, Mark Rutland <mark.rutland@arm.com>, "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>, Linux-Renesas <linux-renesas-soc@vger.kernel.org> Subject: Re: [PATCH v3 06/12] arm64: dts: h3ulcb: enable SDHI0 Date: Thu, 1 Sep 2016 10:11:45 +0200 [thread overview] Message-ID: <CAMuHMdWakZuEu-gTo5=3VWxRdSc8V9gpL28yhjrVhHh1oZVu+Q@mail.gmail.com> (raw) In-Reply-To: <1472637799-14819-1-git-send-email-vladimir.barinov@cogentembedded.com> Hi Vladimir, On Wed, Aug 31, 2016 at 12:03 PM, Vladimir Barinov <vladimir.barinov@cogentembedded.com> wrote: > This supports SDHI0 on H3ULCB board SD card slot > > Signed-off-by: Vladimir Barinov <vladimir.barinov@cogentembedded.com> Thanks for your patch! > --- a/arch/arm64/boot/dts/renesas/r8a7795-h3ulcb.dts > +++ b/arch/arm64/boot/dts/renesas/r8a7795-h3ulcb.dts > @@ -82,6 +118,18 @@ > status = "okay"; > }; > > +&sdhi0 { > + pinctrl-0 = <&sdhi0_pins_3v3>; > + pinctrl-1 = <&sdhi0_pins_1v8>; > + pinctrl-names = "default", "state_uhs"; > + > + vmmc-supply = <&vcc_sdhi0>; > + vqmmc-supply = <&vccq_sdhi0>; > + cd-gpios = <&gpio3 12 GPIO_ACTIVE_LOW>; > + bus-width = <4>; > + status = "okay"; > +}; According to the schematics, SD0_WP is wired, so I think you want to add wp-gpios = <&gpio3 13 GPIO_ACTIVE_HIGH>; As you add UHS pins, I think you want to add sd-uhs-sdr50 too. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
next prev parent reply other threads:[~2016-09-01 8:11 UTC|newest] Thread overview: 55+ messages / expand[flat|nested] mbox.gz Atom feed top 2016-08-31 10:01 [PATCH v3 0/12] arm64: renesas: add H3ULCB board Vladimir Barinov 2016-08-31 10:01 ` Vladimir Barinov 2016-08-31 10:02 ` [PATCH v3 01/12] dt: arm: shmobile: add H3ULCB board DT bindings Vladimir Barinov 2016-10-25 12:48 ` Geert Uytterhoeven 2016-10-25 15:06 ` Vladimir Barinov 2016-10-26 10:27 ` Vladimir Barinov 2016-10-26 11:33 ` Geert Uytterhoeven [not found] ` <1472637712-14583-1-git-send-email-vladimir.barinov-M4DtvfQ/ZS1MRgGoP+s0PdBPR1lH4CV8@public.gmane.org> 2016-08-31 10:02 ` [PATCH v3 02/12] arm64: dts: h3ulcb: initial device tree Vladimir Barinov 2016-08-31 10:02 ` Vladimir Barinov [not found] ` <1472637759-14663-1-git-send-email-vladimir.barinov-M4DtvfQ/ZS1MRgGoP+s0PdBPR1lH4CV8@public.gmane.org> 2016-09-01 7:38 ` Geert Uytterhoeven 2016-09-01 7:38 ` Geert Uytterhoeven 2016-08-31 10:03 ` [PATCH v3 05/12] arm64: dts: h3ulcb: enable GPIO leds Vladimir Barinov 2016-08-31 10:03 ` Vladimir Barinov [not found] ` <1472637789-14780-1-git-send-email-vladimir.barinov-M4DtvfQ/ZS1MRgGoP+s0PdBPR1lH4CV8@public.gmane.org> 2016-09-01 7:52 ` Geert Uytterhoeven 2016-09-01 7:52 ` Geert Uytterhoeven [not found] ` <CAMuHMdUpcajev3CsdhtpaD4PrqAOPsAcnv+65TFv-we6FPmDVw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org> 2016-09-01 10:24 ` Vladimir Barinov 2016-09-01 10:24 ` Vladimir Barinov 2016-08-31 10:04 ` [PATCH v3 12/12] arm64: dts: h3ulcb: Sound SSI support Vladimir Barinov 2016-08-31 10:04 ` Vladimir Barinov 2016-09-02 1:19 ` Kuninori Morimoto 2016-09-02 1:19 ` Kuninori Morimoto [not found] ` <87d1knumv9.wl%kuninori.morimoto.gx-zM6kxYcvzFBBDgjK7y7TUQ@public.gmane.org> 2016-09-02 8:19 ` Simon Horman 2016-09-02 8:19 ` Simon Horman 2016-08-31 10:02 ` [PATCH v3 03/12] arm64: dts: h3ulcb: enable SCIF clk and pins Vladimir Barinov [not found] ` <1472637769-14702-1-git-send-email-vladimir.barinov-M4DtvfQ/ZS1MRgGoP+s0PdBPR1lH4CV8@public.gmane.org> 2016-09-01 7:39 ` Geert Uytterhoeven 2016-09-01 7:39 ` Geert Uytterhoeven 2016-08-31 10:02 ` [PATCH v3 04/12] arm64: dts: h3ulcb: enable EthernetAVB Vladimir Barinov [not found] ` <1472637779-14741-1-git-send-email-vladimir.barinov-M4DtvfQ/ZS1MRgGoP+s0PdBPR1lH4CV8@public.gmane.org> 2016-09-01 7:48 ` Geert Uytterhoeven 2016-09-01 7:48 ` Geert Uytterhoeven 2016-09-01 10:11 ` Sergei Shtylyov 2016-08-31 10:03 ` [PATCH v3 06/12] arm64: dts: h3ulcb: enable SDHI0 Vladimir Barinov [not found] ` <1472637799-14819-1-git-send-email-vladimir.barinov-M4DtvfQ/ZS1MRgGoP+s0PdBPR1lH4CV8@public.gmane.org> 2016-09-01 8:11 ` Geert Uytterhoeven [this message] 2016-09-01 8:11 ` Geert Uytterhoeven 2016-09-01 10:41 ` Vladimir Barinov 2016-09-01 11:15 ` Geert Uytterhoeven 2016-08-31 10:03 ` [PATCH v3 07/12] arm64: dts: h3ulcb: enable I2C2 Vladimir Barinov [not found] ` <1472637809-14858-1-git-send-email-vladimir.barinov-M4DtvfQ/ZS1MRgGoP+s0PdBPR1lH4CV8@public.gmane.org> 2016-09-01 8:21 ` Geert Uytterhoeven 2016-09-01 8:21 ` Geert Uytterhoeven 2016-08-31 10:03 ` [PATCH v3 08/12] arm64: dts: h3ulcb: enable EXTALR clk Vladimir Barinov [not found] ` <1472637816-14897-1-git-send-email-vladimir.barinov-M4DtvfQ/ZS1MRgGoP+s0PdBPR1lH4CV8@public.gmane.org> 2016-09-01 8:21 ` Geert Uytterhoeven 2016-09-01 8:21 ` Geert Uytterhoeven 2016-08-31 10:03 ` [PATCH v3 09/12] arm64: dts: h3ulcb: enable WDT Vladimir Barinov [not found] ` <1472637828-14936-1-git-send-email-vladimir.barinov-M4DtvfQ/ZS1MRgGoP+s0PdBPR1lH4CV8@public.gmane.org> 2016-09-01 8:22 ` Geert Uytterhoeven 2016-09-01 8:22 ` Geert Uytterhoeven 2016-08-31 10:03 ` [PATCH v3 10/12] arm64: dts: h3ulcb: enable USB2 PHY of channel 1 Vladimir Barinov 2016-09-01 8:25 ` Geert Uytterhoeven 2016-08-31 10:04 ` [PATCH v3 11/12] arm64: dts: h3ulcb: enable USB2.0 Host " Vladimir Barinov [not found] ` <1472637843-15014-1-git-send-email-vladimir.barinov-M4DtvfQ/ZS1MRgGoP+s0PdBPR1lH4CV8@public.gmane.org> 2016-09-01 8:32 ` Geert Uytterhoeven 2016-09-01 8:32 ` Geert Uytterhoeven 2016-09-01 8:39 ` [PATCH v3 0/12] arm64: renesas: add H3ULCB board Geert Uytterhoeven 2016-09-01 10:43 ` Vladimir Barinov 2016-09-01 14:17 ` Simon Horman 2016-09-01 14:27 ` Simon Horman 2016-09-01 19:25 ` Geert Uytterhoeven 2016-09-02 7:59 ` Simon Horman
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to='CAMuHMdWakZuEu-gTo5=3VWxRdSc8V9gpL28yhjrVhHh1oZVu+Q@mail.gmail.com' \ --to=geert-td1emuhucqxl1znqvxdv9g@public.gmane.org \ --cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \ --cc=horms-/R6kz+dDXgpPR4JQBCEnsQ@public.gmane.org \ --cc=linux-renesas-soc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \ --cc=magnus.damm-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \ --cc=mark.rutland-5wv7dgnIgG8@public.gmane.org \ --cc=robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \ --cc=vladimir.barinov-M4DtvfQ/ZS1MRgGoP+s0PdBPR1lH4CV8@public.gmane.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.