From: Geert Uytterhoeven <geert@linux-m68k.org> To: Hans Verkuil <hverkuil-cisco@xs4all.nl> Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com>, Tomi Valkeinen <tomi.valkeinen+renesas@ideasonboard.com>, linux-renesas-soc@vger.kernel.org, linux-media@vger.kernel.org, dri-devel@lists.freedesktop.org, Kieran Bingham <kieran.bingham@ideasonboard.com>, Nicolas Dufresne <nicolas@ndufresne.ca>, Sakari Ailus <sakari.ailus@iki.fi> Subject: Re: [PATCH v2 7/7] drm: rcar-du: Add new formats (2-10-10-10 ARGB, Y210) Date: Tue, 20 Dec 2022 10:09:46 +0100 [thread overview] Message-ID: <CAMuHMdXd7Q1WWdo-rwfad1-BwuuH5vxt9Kx2Zv2Ok2rQLvh_wA@mail.gmail.com> (raw) In-Reply-To: <2f252958-1bb1-006a-b450-1315be8a3c9f@xs4all.nl> Hi Hans, On Tue, Dec 20, 2022 at 10:01 AM Hans Verkuil <hverkuil-cisco@xs4all.nl> wrote: > On 19/12/2022 22:47, Laurent Pinchart wrote: > > (CC'ing Sakari and Hans) > > > > Thank you for the patch. > > > > On Mon, Dec 19, 2022 at 04:01:39PM +0200, Tomi Valkeinen wrote: > >> Add new pixel formats: RGBX1010102, RGBA1010102, ARGB2101010 and Y210. > >> > >> Signed-off-by: Tomi Valkeinen <tomi.valkeinen+renesas@ideasonboard.com> > >> --- > >> drivers/gpu/drm/rcar-du/rcar_du_kms.c | 24 +++++++++++++ > >> drivers/gpu/drm/rcar-du/rcar_du_vsp.c | 49 +++++++++++++++++++++++++-- > >> 2 files changed, 71 insertions(+), 2 deletions(-) > >> > >> diff --git a/drivers/gpu/drm/rcar-du/rcar_du_kms.c b/drivers/gpu/drm/rcar-du/rcar_du_kms.c > >> index 8c2719efda2a..8ccabf5a30c4 100644 > >> --- a/drivers/gpu/drm/rcar-du/rcar_du_kms.c > >> +++ b/drivers/gpu/drm/rcar-du/rcar_du_kms.c > >> @@ -259,6 +259,24 @@ static const struct rcar_du_format_info rcar_du_format_infos[] = { > >> .bpp = 32, > >> .planes = 1, > >> .hsub = 1, > >> + }, { > >> + .fourcc = DRM_FORMAT_RGBX1010102, > > > > Ah, here the format makes sense. > > > >> + .v4l2 = V4L2_PIX_FMT_XBGR2101010, > > > > But this is horrible :-( Could we use the same names as DRM for new > > formats, when there is no conflict with existing V4L2 formats ? > > > > Sakari, Hans, what do you think ? Please see patch 1/7 in the series for > > the format definitions. > > V4L2 describes pixel formats based on how they appear in memory from the > lowest to highest memory address. So that means big endian? > If I am not mistaken, DRM uses the CPU order. So that explains the difference > in naming. I don't think we should hide that difference. And V4L2 has been > quite consistent in following memory ordering in the naming (except possibly > for some of the really old pixelformats). DRM uses little endian. > Departing from that would be more of a hindrance than a help, IMHO. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
WARNING: multiple messages have this Message-ID (diff)
From: Geert Uytterhoeven <geert@linux-m68k.org> To: Hans Verkuil <hverkuil-cisco@xs4all.nl> Cc: Kieran Bingham <kieran.bingham@ideasonboard.com>, dri-devel@lists.freedesktop.org, Nicolas Dufresne <nicolas@ndufresne.ca>, linux-renesas-soc@vger.kernel.org, Sakari Ailus <sakari.ailus@iki.fi>, Laurent Pinchart <laurent.pinchart@ideasonboard.com>, Tomi Valkeinen <tomi.valkeinen+renesas@ideasonboard.com>, linux-media@vger.kernel.org Subject: Re: [PATCH v2 7/7] drm: rcar-du: Add new formats (2-10-10-10 ARGB, Y210) Date: Tue, 20 Dec 2022 10:09:46 +0100 [thread overview] Message-ID: <CAMuHMdXd7Q1WWdo-rwfad1-BwuuH5vxt9Kx2Zv2Ok2rQLvh_wA@mail.gmail.com> (raw) In-Reply-To: <2f252958-1bb1-006a-b450-1315be8a3c9f@xs4all.nl> Hi Hans, On Tue, Dec 20, 2022 at 10:01 AM Hans Verkuil <hverkuil-cisco@xs4all.nl> wrote: > On 19/12/2022 22:47, Laurent Pinchart wrote: > > (CC'ing Sakari and Hans) > > > > Thank you for the patch. > > > > On Mon, Dec 19, 2022 at 04:01:39PM +0200, Tomi Valkeinen wrote: > >> Add new pixel formats: RGBX1010102, RGBA1010102, ARGB2101010 and Y210. > >> > >> Signed-off-by: Tomi Valkeinen <tomi.valkeinen+renesas@ideasonboard.com> > >> --- > >> drivers/gpu/drm/rcar-du/rcar_du_kms.c | 24 +++++++++++++ > >> drivers/gpu/drm/rcar-du/rcar_du_vsp.c | 49 +++++++++++++++++++++++++-- > >> 2 files changed, 71 insertions(+), 2 deletions(-) > >> > >> diff --git a/drivers/gpu/drm/rcar-du/rcar_du_kms.c b/drivers/gpu/drm/rcar-du/rcar_du_kms.c > >> index 8c2719efda2a..8ccabf5a30c4 100644 > >> --- a/drivers/gpu/drm/rcar-du/rcar_du_kms.c > >> +++ b/drivers/gpu/drm/rcar-du/rcar_du_kms.c > >> @@ -259,6 +259,24 @@ static const struct rcar_du_format_info rcar_du_format_infos[] = { > >> .bpp = 32, > >> .planes = 1, > >> .hsub = 1, > >> + }, { > >> + .fourcc = DRM_FORMAT_RGBX1010102, > > > > Ah, here the format makes sense. > > > >> + .v4l2 = V4L2_PIX_FMT_XBGR2101010, > > > > But this is horrible :-( Could we use the same names as DRM for new > > formats, when there is no conflict with existing V4L2 formats ? > > > > Sakari, Hans, what do you think ? Please see patch 1/7 in the series for > > the format definitions. > > V4L2 describes pixel formats based on how they appear in memory from the > lowest to highest memory address. So that means big endian? > If I am not mistaken, DRM uses the CPU order. So that explains the difference > in naming. I don't think we should hide that difference. And V4L2 has been > quite consistent in following memory ordering in the naming (except possibly > for some of the really old pixelformats). DRM uses little endian. > Departing from that would be more of a hindrance than a help, IMHO. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
next prev parent reply other threads:[~2022-12-20 9:10 UTC|newest] Thread overview: 51+ messages / expand[flat|nested] mbox.gz Atom feed top 2022-12-19 14:01 [PATCH v2 0/7] media/drm: renesas: Add new pixel formats Tomi Valkeinen 2022-12-19 14:01 ` [PATCH v2 1/7] media: Add 2-10-10-10 RGB formats Tomi Valkeinen 2022-12-19 19:10 ` Laurent Pinchart 2022-12-19 19:10 ` Laurent Pinchart 2022-12-20 14:12 ` Tomi Valkeinen 2022-12-20 14:12 ` Tomi Valkeinen 2022-12-20 14:24 ` Laurent Pinchart 2022-12-20 14:24 ` Laurent Pinchart 2022-12-20 14:35 ` Tomi Valkeinen 2022-12-20 14:35 ` Tomi Valkeinen 2022-12-19 14:01 ` [PATCH v2 2/7] media: Add Y210, Y212 and Y216 formats Tomi Valkeinen 2022-12-19 20:54 ` Laurent Pinchart 2022-12-19 20:54 ` Laurent Pinchart 2022-12-19 14:01 ` [PATCH v2 3/7] media: renesas: vsp1: Change V3U to be gen4 Tomi Valkeinen 2022-12-19 21:01 ` Laurent Pinchart 2022-12-19 21:01 ` Laurent Pinchart 2022-12-21 7:48 ` Tomi Valkeinen 2022-12-21 7:48 ` Tomi Valkeinen 2022-12-21 10:21 ` Laurent Pinchart 2022-12-21 10:21 ` Laurent Pinchart 2022-12-19 14:01 ` [PATCH v2 4/7] media: renesas: vsp1: Add V4H SoC version Tomi Valkeinen 2022-12-19 21:06 ` Laurent Pinchart 2022-12-19 21:06 ` Laurent Pinchart 2022-12-19 14:01 ` [PATCH v2 5/7] media: renesas: vsp1: Add new formats (2-10-10-10 ARGB, Y210) Tomi Valkeinen 2022-12-19 21:37 ` Laurent Pinchart 2022-12-19 21:37 ` Laurent Pinchart 2022-12-19 14:01 ` [PATCH v2 6/7] drm: rcar-du: Bump V3U to gen 4 Tomi Valkeinen 2022-12-19 15:04 ` Kieran Bingham 2022-12-19 21:38 ` Laurent Pinchart 2022-12-19 21:38 ` Laurent Pinchart 2022-12-19 14:01 ` [PATCH v2 7/7] drm: rcar-du: Add new formats (2-10-10-10 ARGB, Y210) Tomi Valkeinen 2022-12-19 21:47 ` Laurent Pinchart 2022-12-19 21:47 ` Laurent Pinchart 2022-12-20 9:01 ` Hans Verkuil 2022-12-20 9:01 ` Hans Verkuil 2022-12-20 9:09 ` Geert Uytterhoeven [this message] 2022-12-20 9:09 ` Geert Uytterhoeven 2022-12-20 9:20 ` Hans Verkuil 2022-12-20 9:20 ` Hans Verkuil 2022-12-20 9:33 ` Geert Uytterhoeven 2022-12-20 9:33 ` Geert Uytterhoeven 2022-12-20 9:18 ` Laurent Pinchart 2022-12-20 9:18 ` Laurent Pinchart 2022-12-20 9:26 ` Hans Verkuil 2022-12-20 9:26 ` Hans Verkuil 2022-12-20 10:38 ` Laurent Pinchart 2022-12-20 10:38 ` Laurent Pinchart 2022-12-20 9:36 ` Sakari Ailus 2022-12-20 9:36 ` Sakari Ailus 2022-12-20 10:42 ` Laurent Pinchart 2022-12-20 10:42 ` Laurent Pinchart
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=CAMuHMdXd7Q1WWdo-rwfad1-BwuuH5vxt9Kx2Zv2Ok2rQLvh_wA@mail.gmail.com \ --to=geert@linux-m68k.org \ --cc=dri-devel@lists.freedesktop.org \ --cc=hverkuil-cisco@xs4all.nl \ --cc=kieran.bingham@ideasonboard.com \ --cc=laurent.pinchart@ideasonboard.com \ --cc=linux-media@vger.kernel.org \ --cc=linux-renesas-soc@vger.kernel.org \ --cc=nicolas@ndufresne.ca \ --cc=sakari.ailus@iki.fi \ --cc=tomi.valkeinen+renesas@ideasonboard.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.