[PATCH] dmaengine: use phys_addr_t for slave configuration

[PATCH] dmaengine: use phys_addr_t for slave configuration

[Linus Walleij]

The documentation already says these are physical addresses, and
we have concluded that any translation into the DMA address space
needs to reside in the dmaengine driver, so change the type of
the passed arguments.

Cc: Arnd Bergmann <arnd@arndb.de>
Cc: Lee Jones <lee.jones@linaro.org>
Cc: Vinod Koul <vinod.koul@intel.com>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
---
 include/linux/dmaengine.h | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/include/linux/dmaengine.h b/include/linux/dmaengine.h
index 91ac8da..681df5f9 100644
--- a/include/linux/dmaengine.h
+++ b/include/linux/dmaengine.h
@@ -361,8 +361,8 @@ enum dma_slave_buswidth {
  */
 struct dma_slave_config {
 	enum dma_transfer_direction direction;
-	dma_addr_t src_addr;
-	dma_addr_t dst_addr;
+	phys_addr_t src_addr;
+	phys_addr_t dst_addr;
 	enum dma_slave_buswidth src_addr_width;
 	enum dma_slave_buswidth dst_addr_width;
 	u32 src_maxburst;
-- 
1.8.1.4

Re: [PATCH] dmaengine: use phys_addr_t for slave configuration

[Lee Jones]

On Fri, 26 Apr 2013, Linus Walleij wrote:

> The documentation already says these are physical addresses, and
> we have concluded that any translation into the DMA address space
> needs to reside in the dmaengine driver, so change the type of
> the passed arguments.
> 
> Cc: Arnd Bergmann <arnd@arndb.de>
> Cc: Lee Jones <lee.jones@linaro.org>
> Cc: Vinod Koul <vinod.koul@intel.com>
> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
> ---
>  include/linux/dmaengine.h | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/include/linux/dmaengine.h b/include/linux/dmaengine.h
> index 91ac8da..681df5f9 100644
> --- a/include/linux/dmaengine.h
> +++ b/include/linux/dmaengine.h
> @@ -361,8 +361,8 @@ enum dma_slave_buswidth {
>   */
>  struct dma_slave_config {
>  	enum dma_transfer_direction direction;
> -	dma_addr_t src_addr;
> -	dma_addr_t dst_addr;
> +	phys_addr_t src_addr;
> +	phys_addr_t dst_addr;
>  	enum dma_slave_buswidth src_addr_width;
>  	enum dma_slave_buswidth dst_addr_width;
>  	u32 src_maxburst;

Makes a lot more sense.

Acked-by: Lee Jones <lee.jones@linaro.org>

-- 
Lee Jones
Linaro ST-Ericsson Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog

Re: [PATCH] dmaengine: use phys_addr_t for slave configuration

[Arnd Bergmann]

On Friday 26 April 2013 11:06:54 Linus Walleij wrote:
> The documentation already says these are physical addresses, and
> we have concluded that any translation into the DMA address space
> needs to reside in the dmaengine driver, so change the type of
> the passed arguments.
> 
> Cc: Arnd Bergmann <arnd@arndb.de>
> Cc: Lee Jones <lee.jones@linaro.org>
> Cc: Vinod Koul <vinod.koul@intel.com>
> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>

Acked-by: Arnd Bergmann <arnd@arndb.de>

Re: [PATCH] dmaengine: use phys_addr_t for slave configuration

[Geert Uytterhoeven]

On Fri, Apr 26, 2013 at 11:06 AM, Linus Walleij
<linus.walleij@linaro.org> wrote:
> The documentation already says these are physical addresses, and
> we have concluded that any translation into the DMA address space
> needs to reside in the dmaengine driver, so change the type of
> the passed arguments.
>
> Cc: Arnd Bergmann <arnd@arndb.de>
> Cc: Lee Jones <lee.jones@linaro.org>
> Cc: Vinod Koul <vinod.koul@intel.com>
> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>

What's the status of this one, which has been acked by Lee and Arnd?

Thanks!

> ---
>  include/linux/dmaengine.h | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/include/linux/dmaengine.h b/include/linux/dmaengine.h
> index 91ac8da..681df5f9 100644
> --- a/include/linux/dmaengine.h
> +++ b/include/linux/dmaengine.h
> @@ -361,8 +361,8 @@ enum dma_slave_buswidth {
>   */
>  struct dma_slave_config {
>         enum dma_transfer_direction direction;
> -       dma_addr_t src_addr;
> -       dma_addr_t dst_addr;
> +       phys_addr_t src_addr;
> +       phys_addr_t dst_addr;
>         enum dma_slave_buswidth src_addr_width;
>         enum dma_slave_buswidth dst_addr_width;
>         u32 src_maxburst;
> --
> 1.8.1.4

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

Re: [PATCH] dmaengine: use phys_addr_t for slave configuration

[Geert Uytterhoeven]

On Fri, Apr 26, 2013 at 11:06 AM, Linus Walleij
<linus.walleij@linaro.org> wrote:
> The documentation already says these are physical addresses, and
> we have concluded that any translation into the DMA address space
> needs to reside in the dmaengine driver, so change the type of
> the passed arguments.
>
> Cc: Arnd Bergmann <arnd@arndb.de>
> Cc: Lee Jones <lee.jones@linaro.org>
> Cc: Vinod Koul <vinod.koul@intel.com>
> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>

What's the status of this one, which has been acked by Lee and Arnd?

Thanks!

> ---
>  include/linux/dmaengine.h | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/include/linux/dmaengine.h b/include/linux/dmaengine.h
> index 91ac8da..681df5f9 100644
> --- a/include/linux/dmaengine.h
> +++ b/include/linux/dmaengine.h
> @@ -361,8 +361,8 @@ enum dma_slave_buswidth {
>   */
>  struct dma_slave_config {
>         enum dma_transfer_direction direction;
> -       dma_addr_t src_addr;
> -       dma_addr_t dst_addr;
> +       phys_addr_t src_addr;
> +       phys_addr_t dst_addr;
>         enum dma_slave_buswidth src_addr_width;
>         enum dma_slave_buswidth dst_addr_width;
>         u32 src_maxburst;
> --
> 1.8.1.4

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

Re: [PATCH] dmaengine: use phys_addr_t for slave configuration

[Vinod Koul]

On Wed, Jul 08, 2015 at 12:12:52PM +0200, Geert Uytterhoeven wrote:
> On Fri, Apr 26, 2013 at 11:06 AM, Linus Walleij
> <linus.walleij@linaro.org> wrote:
> > The documentation already says these are physical addresses, and
> > we have concluded that any translation into the DMA address space
> > needs to reside in the dmaengine driver, so change the type of
> > the passed arguments.
> >
> > Cc: Arnd Bergmann <arnd@arndb.de>
> > Cc: Lee Jones <lee.jones@linaro.org>
> > Cc: Vinod Koul <vinod.koul@intel.com>
> > Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
> 
> What's the status of this one, which has been acked by Lee and Arnd?
Looks to have slipped thru. I will redo it

-- 
~Vinod

> 
> Thanks!
> 
> > ---
> >  include/linux/dmaengine.h | 4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/include/linux/dmaengine.h b/include/linux/dmaengine.h
> > index 91ac8da..681df5f9 100644
> > --- a/include/linux/dmaengine.h
> > +++ b/include/linux/dmaengine.h
> > @@ -361,8 +361,8 @@ enum dma_slave_buswidth {
> >   */
> >  struct dma_slave_config {
> >         enum dma_transfer_direction direction;
> > -       dma_addr_t src_addr;
> > -       dma_addr_t dst_addr;
> > +       phys_addr_t src_addr;
> > +       phys_addr_t dst_addr;
> >         enum dma_slave_buswidth src_addr_width;
> >         enum dma_slave_buswidth dst_addr_width;
> >         u32 src_maxburst;
> > --
> > 1.8.1.4
> 
> Gr{oetje,eeting}s,
> 
>                         Geert
> 
> --
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
> 
> In personal conversations with technical people, I call myself a hacker. But
> when I'm talking to journalists I just say "programmer" or something like that.
>                                 -- Linus Torvalds

-- 

Re: [PATCH] dmaengine: use phys_addr_t for slave configuration

[Vinod Koul]

On Wed, Jul 08, 2015 at 12:12:52PM +0200, Geert Uytterhoeven wrote:
> On Fri, Apr 26, 2013 at 11:06 AM, Linus Walleij
> <linus.walleij@linaro.org> wrote:
> > The documentation already says these are physical addresses, and
> > we have concluded that any translation into the DMA address space
> > needs to reside in the dmaengine driver, so change the type of
> > the passed arguments.
> >
> > Cc: Arnd Bergmann <arnd@arndb.de>
> > Cc: Lee Jones <lee.jones@linaro.org>
> > Cc: Vinod Koul <vinod.koul@intel.com>
> > Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
> 
> What's the status of this one, which has been acked by Lee and Arnd?
Looks to have slipped thru. I will redo it

-- 
~Vinod

> 
> Thanks!
> 
> > ---
> >  include/linux/dmaengine.h | 4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/include/linux/dmaengine.h b/include/linux/dmaengine.h
> > index 91ac8da..681df5f9 100644
> > --- a/include/linux/dmaengine.h
> > +++ b/include/linux/dmaengine.h
> > @@ -361,8 +361,8 @@ enum dma_slave_buswidth {
> >   */
> >  struct dma_slave_config {
> >         enum dma_transfer_direction direction;
> > -       dma_addr_t src_addr;
> > -       dma_addr_t dst_addr;
> > +       phys_addr_t src_addr;
> > +       phys_addr_t dst_addr;
> >         enum dma_slave_buswidth src_addr_width;
> >         enum dma_slave_buswidth dst_addr_width;
> >         u32 src_maxburst;
> > --
> > 1.8.1.4
> 
> Gr{oetje,eeting}s,
> 
>                         Geert
> 
> --
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
> 
> In personal conversations with technical people, I call myself a hacker. But
> when I'm talking to journalists I just say "programmer" or something like that.
>                                 -- Linus Torvalds

-- 

Re: [PATCH] dmaengine: use phys_addr_t for slave configuration

[Linus Walleij]

On Wed, Jul 8, 2015 at 12:12 PM, Geert Uytterhoeven
<geert@linux-m68k.org> wrote:
> On Fri, Apr 26, 2013 at 11:06 AM, Linus Walleij
> <linus.walleij@linaro.org> wrote:
>> The documentation already says these are physical addresses, and
>> we have concluded that any translation into the DMA address space
>> needs to reside in the dmaengine driver, so change the type of
>> the passed arguments.
>>
>> Cc: Arnd Bergmann <arnd@arndb.de>
>> Cc: Lee Jones <lee.jones@linaro.org>
>> Cc: Vinod Koul <vinod.koul@intel.com>
>> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
>
> What's the status of this one, which has been acked by Lee and Arnd?

I don't even remember writing this patch anymore, haha :D

Yours,
Linus Walleij

Re: [PATCH] dmaengine: use phys_addr_t for slave configuration

[Linus Walleij]

On Wed, Jul 8, 2015 at 12:12 PM, Geert Uytterhoeven
<geert@linux-m68k.org> wrote:
> On Fri, Apr 26, 2013 at 11:06 AM, Linus Walleij
> <linus.walleij@linaro.org> wrote:
>> The documentation already says these are physical addresses, and
>> we have concluded that any translation into the DMA address space
>> needs to reside in the dmaengine driver, so change the type of
>> the passed arguments.
>>
>> Cc: Arnd Bergmann <arnd@arndb.de>
>> Cc: Lee Jones <lee.jones@linaro.org>
>> Cc: Vinod Koul <vinod.koul@intel.com>
>> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
>
> What's the status of this one, which has been acked by Lee and Arnd?

I don't even remember writing this patch anymore, haha :D

Yours,
Linus Walleij

Re: [PATCH] dmaengine: use phys_addr_t for slave configuration

[Geert Uytterhoeven]

Hi Vinod,

On Fri, Jul 10, 2015 at 10:14 AM, Vinod Koul <vinod.koul@intel.com> wrote:
> On Wed, Jul 08, 2015 at 12:12:52PM +0200, Geert Uytterhoeven wrote:
>> On Fri, Apr 26, 2013 at 11:06 AM, Linus Walleij
>> <linus.walleij@linaro.org> wrote:
>> > The documentation already says these are physical addresses, and
>> > we have concluded that any translation into the DMA address space
>> > needs to reside in the dmaengine driver, so change the type of
>> > the passed arguments.
>> >
>> > Cc: Arnd Bergmann <arnd@arndb.de>
>> > Cc: Lee Jones <lee.jones@linaro.org>
>> > Cc: Vinod Koul <vinod.koul@intel.com>
>> > Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
>>
>> What's the status of this one, which has been acked by Lee and Arnd?
> Looks to have slipped thru. I will redo it

Ping?

> --
> ~Vinod
>
>>
>> Thanks!
>>
>> > ---
>> >  include/linux/dmaengine.h | 4 ++--
>> >  1 file changed, 2 insertions(+), 2 deletions(-)
>> >
>> > diff --git a/include/linux/dmaengine.h b/include/linux/dmaengine.h
>> > index 91ac8da..681df5f9 100644
>> > --- a/include/linux/dmaengine.h
>> > +++ b/include/linux/dmaengine.h
>> > @@ -361,8 +361,8 @@ enum dma_slave_buswidth {
>> >   */
>> >  struct dma_slave_config {
>> >         enum dma_transfer_direction direction;
>> > -       dma_addr_t src_addr;
>> > -       dma_addr_t dst_addr;
>> > +       phys_addr_t src_addr;
>> > +       phys_addr_t dst_addr;
>> >         enum dma_slave_buswidth src_addr_width;
>> >         enum dma_slave_buswidth dst_addr_width;
>> >         u32 src_maxburst;
>> > --
>> > 1.8.1.4

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

Re: [PATCH] dmaengine: use phys_addr_t for slave configuration

[Geert Uytterhoeven]

Hi Vinod,

On Fri, Jul 10, 2015 at 10:14 AM, Vinod Koul <vinod.koul@intel.com> wrote:
> On Wed, Jul 08, 2015 at 12:12:52PM +0200, Geert Uytterhoeven wrote:
>> On Fri, Apr 26, 2013 at 11:06 AM, Linus Walleij
>> <linus.walleij@linaro.org> wrote:
>> > The documentation already says these are physical addresses, and
>> > we have concluded that any translation into the DMA address space
>> > needs to reside in the dmaengine driver, so change the type of
>> > the passed arguments.
>> >
>> > Cc: Arnd Bergmann <arnd@arndb.de>
>> > Cc: Lee Jones <lee.jones@linaro.org>
>> > Cc: Vinod Koul <vinod.koul@intel.com>
>> > Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
>>
>> What's the status of this one, which has been acked by Lee and Arnd?
> Looks to have slipped thru. I will redo it

Ping?

> --
> ~Vinod
>
>>
>> Thanks!
>>
>> > ---
>> >  include/linux/dmaengine.h | 4 ++--
>> >  1 file changed, 2 insertions(+), 2 deletions(-)
>> >
>> > diff --git a/include/linux/dmaengine.h b/include/linux/dmaengine.h
>> > index 91ac8da..681df5f9 100644
>> > --- a/include/linux/dmaengine.h
>> > +++ b/include/linux/dmaengine.h
>> > @@ -361,8 +361,8 @@ enum dma_slave_buswidth {
>> >   */
>> >  struct dma_slave_config {
>> >         enum dma_transfer_direction direction;
>> > -       dma_addr_t src_addr;
>> > -       dma_addr_t dst_addr;
>> > +       phys_addr_t src_addr;
>> > +       phys_addr_t dst_addr;
>> >         enum dma_slave_buswidth src_addr_width;
>> >         enum dma_slave_buswidth dst_addr_width;
>> >         u32 src_maxburst;
>> > --
>> > 1.8.1.4

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

Re: [PATCH] dmaengine: use phys_addr_t for slave configuration

[Vinod Koul]

On Tue, Dec 15, 2015 at 11:48:24AM +0100, Geert Uytterhoeven wrote:
> Hi Vinod,
> 
> On Fri, Jul 10, 2015 at 10:14 AM, Vinod Koul <vinod.koul@intel.com> wrote:
> > On Wed, Jul 08, 2015 at 12:12:52PM +0200, Geert Uytterhoeven wrote:
> >> On Fri, Apr 26, 2013 at 11:06 AM, Linus Walleij
> >> <linus.walleij@linaro.org> wrote:
> >> > The documentation already says these are physical addresses, and
> >> > we have concluded that any translation into the DMA address space
> >> > needs to reside in the dmaengine driver, so change the type of
> >> > the passed arguments.
> >> >
> >> > Cc: Arnd Bergmann <arnd@arndb.de>
> >> > Cc: Lee Jones <lee.jones@linaro.org>
> >> > Cc: Vinod Koul <vinod.koul@intel.com>
> >> > Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
> >>
> >> What's the status of this one, which has been acked by Lee and Arnd?
> > Looks to have slipped thru. I will redo it
> 
> Ping?

I should be able to do this in next few days...

> 
> > --
> > ~Vinod
> >
> >>
> >> Thanks!
> >>
> >> > ---
> >> >  include/linux/dmaengine.h | 4 ++--
> >> >  1 file changed, 2 insertions(+), 2 deletions(-)
> >> >
> >> > diff --git a/include/linux/dmaengine.h b/include/linux/dmaengine.h
> >> > index 91ac8da..681df5f9 100644
> >> > --- a/include/linux/dmaengine.h
> >> > +++ b/include/linux/dmaengine.h
> >> > @@ -361,8 +361,8 @@ enum dma_slave_buswidth {
> >> >   */
> >> >  struct dma_slave_config {
> >> >         enum dma_transfer_direction direction;
> >> > -       dma_addr_t src_addr;
> >> > -       dma_addr_t dst_addr;
> >> > +       phys_addr_t src_addr;
> >> > +       phys_addr_t dst_addr;
> >> >         enum dma_slave_buswidth src_addr_width;
> >> >         enum dma_slave_buswidth dst_addr_width;
> >> >         u32 src_maxburst;
> >> > --
> >> > 1.8.1.4
> 
> Gr{oetje,eeting}s,
> 
>                         Geert
> 
> --
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
> 
> In personal conversations with technical people, I call myself a hacker. But
> when I'm talking to journalists I just say "programmer" or something like that.
>                                 -- Linus Torvalds

-- 
~Vinod

Re: [PATCH] dmaengine: use phys_addr_t for slave configuration

[Vinod Koul]

On Tue, Dec 15, 2015 at 11:48:24AM +0100, Geert Uytterhoeven wrote:
> Hi Vinod,
> 
> On Fri, Jul 10, 2015 at 10:14 AM, Vinod Koul <vinod.koul@intel.com> wrote:
> > On Wed, Jul 08, 2015 at 12:12:52PM +0200, Geert Uytterhoeven wrote:
> >> On Fri, Apr 26, 2013 at 11:06 AM, Linus Walleij
> >> <linus.walleij@linaro.org> wrote:
> >> > The documentation already says these are physical addresses, and
> >> > we have concluded that any translation into the DMA address space
> >> > needs to reside in the dmaengine driver, so change the type of
> >> > the passed arguments.
> >> >
> >> > Cc: Arnd Bergmann <arnd@arndb.de>
> >> > Cc: Lee Jones <lee.jones@linaro.org>
> >> > Cc: Vinod Koul <vinod.koul@intel.com>
> >> > Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
> >>
> >> What's the status of this one, which has been acked by Lee and Arnd?
> > Looks to have slipped thru. I will redo it
> 
> Ping?

I should be able to do this in next few days...

> 
> > --
> > ~Vinod
> >
> >>
> >> Thanks!
> >>
> >> > ---
> >> >  include/linux/dmaengine.h | 4 ++--
> >> >  1 file changed, 2 insertions(+), 2 deletions(-)
> >> >
> >> > diff --git a/include/linux/dmaengine.h b/include/linux/dmaengine.h
> >> > index 91ac8da..681df5f9 100644
> >> > --- a/include/linux/dmaengine.h
> >> > +++ b/include/linux/dmaengine.h
> >> > @@ -361,8 +361,8 @@ enum dma_slave_buswidth {
> >> >   */
> >> >  struct dma_slave_config {
> >> >         enum dma_transfer_direction direction;
> >> > -       dma_addr_t src_addr;
> >> > -       dma_addr_t dst_addr;
> >> > +       phys_addr_t src_addr;
> >> > +       phys_addr_t dst_addr;
> >> >         enum dma_slave_buswidth src_addr_width;
> >> >         enum dma_slave_buswidth dst_addr_width;
> >> >         u32 src_maxburst;
> >> > --
> >> > 1.8.1.4
> 
> Gr{oetje,eeting}s,
> 
>                         Geert
> 
> --
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
> 
> In personal conversations with technical people, I call myself a hacker. But
> when I'm talking to journalists I just say "programmer" or something like that.
>                                 -- Linus Torvalds

-- 
~Vinod

Re: [PATCH] dmaengine: use phys_addr_t for slave configuration

[Geert Uytterhoeven]

Hi Vinod,

On Tue, Dec 15, 2015 at 6:26 PM, Vinod Koul <vinod.koul@intel.com> wrote:
> On Tue, Dec 15, 2015 at 11:48:24AM +0100, Geert Uytterhoeven wrote:
>> On Fri, Jul 10, 2015 at 10:14 AM, Vinod Koul <vinod.koul@intel.com> wrote:
>> > On Wed, Jul 08, 2015 at 12:12:52PM +0200, Geert Uytterhoeven wrote:
>> >> On Fri, Apr 26, 2013 at 11:06 AM, Linus Walleij

(yes, 2013)

>> >> <linus.walleij@linaro.org> wrote:
>> >> > The documentation already says these are physical addresses, and
>> >> > we have concluded that any translation into the DMA address space
>> >> > needs to reside in the dmaengine driver, so change the type of
>> >> > the passed arguments.
>> >> >
>> >> > Cc: Arnd Bergmann <arnd@arndb.de>
>> >> > Cc: Lee Jones <lee.jones@linaro.org>
>> >> > Cc: Vinod Koul <vinod.koul@intel.com>
>> >> > Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
>> >>
>> >> What's the status of this one, which has been acked by Lee and Arnd?
>> > Looks to have slipped thru. I will redo it
>>
>> Ping?
>
> I should be able to do this in next few days...

Ping?

This is a dependency for adding iommu support to the rcar-dmac driver, cfr.
"[PATCH v2 0/5] dmaengine: rcar-dmac: add iommu support for slave transfers".
http://www.spinics.net/lists/linux-renesas-soc/msg00066.html
https://www.mail-archive.com/linux-renesas-soc@vger.kernel.org/msg00108.html

Thank you for applying!

>> >> > ---
>> >> >  include/linux/dmaengine.h | 4 ++--
>> >> >  1 file changed, 2 insertions(+), 2 deletions(-)
>> >> >
>> >> > diff --git a/include/linux/dmaengine.h b/include/linux/dmaengine.h
>> >> > index 91ac8da..681df5f9 100644
>> >> > --- a/include/linux/dmaengine.h
>> >> > +++ b/include/linux/dmaengine.h
>> >> > @@ -361,8 +361,8 @@ enum dma_slave_buswidth {
>> >> >   */
>> >> >  struct dma_slave_config {
>> >> >         enum dma_transfer_direction direction;
>> >> > -       dma_addr_t src_addr;
>> >> > -       dma_addr_t dst_addr;
>> >> > +       phys_addr_t src_addr;
>> >> > +       phys_addr_t dst_addr;
>> >> >         enum dma_slave_buswidth src_addr_width;
>> >> >         enum dma_slave_buswidth dst_addr_width;
>> >> >         u32 src_maxburst;

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

[PATCH] dmaengine: use phys_addr_t for slave configuration

[Geert Uytterhoeven]

Hi Vinod,

On Tue, Dec 15, 2015 at 6:26 PM, Vinod Koul <vinod.koul@intel.com> wrote:
> On Tue, Dec 15, 2015 at 11:48:24AM +0100, Geert Uytterhoeven wrote:
>> On Fri, Jul 10, 2015 at 10:14 AM, Vinod Koul <vinod.koul@intel.com> wrote:
>> > On Wed, Jul 08, 2015 at 12:12:52PM +0200, Geert Uytterhoeven wrote:
>> >> On Fri, Apr 26, 2013 at 11:06 AM, Linus Walleij

(yes, 2013)

>> >> <linus.walleij@linaro.org> wrote:
>> >> > The documentation already says these are physical addresses, and
>> >> > we have concluded that any translation into the DMA address space
>> >> > needs to reside in the dmaengine driver, so change the type of
>> >> > the passed arguments.
>> >> >
>> >> > Cc: Arnd Bergmann <arnd@arndb.de>
>> >> > Cc: Lee Jones <lee.jones@linaro.org>
>> >> > Cc: Vinod Koul <vinod.koul@intel.com>
>> >> > Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
>> >>
>> >> What's the status of this one, which has been acked by Lee and Arnd?
>> > Looks to have slipped thru. I will redo it
>>
>> Ping?
>
> I should be able to do this in next few days...

Ping?

This is a dependency for adding iommu support to the rcar-dmac driver, cfr.
"[PATCH v2 0/5] dmaengine: rcar-dmac: add iommu support for slave transfers".
http://www.spinics.net/lists/linux-renesas-soc/msg00066.html
https://www.mail-archive.com/linux-renesas-soc at vger.kernel.org/msg00108.html

Thank you for applying!

>> >> > ---
>> >> >  include/linux/dmaengine.h | 4 ++--
>> >> >  1 file changed, 2 insertions(+), 2 deletions(-)
>> >> >
>> >> > diff --git a/include/linux/dmaengine.h b/include/linux/dmaengine.h
>> >> > index 91ac8da..681df5f9 100644
>> >> > --- a/include/linux/dmaengine.h
>> >> > +++ b/include/linux/dmaengine.h
>> >> > @@ -361,8 +361,8 @@ enum dma_slave_buswidth {
>> >> >   */
>> >> >  struct dma_slave_config {
>> >> >         enum dma_transfer_direction direction;
>> >> > -       dma_addr_t src_addr;
>> >> > -       dma_addr_t dst_addr;
>> >> > +       phys_addr_t src_addr;
>> >> > +       phys_addr_t dst_addr;
>> >> >         enum dma_slave_buswidth src_addr_width;
>> >> >         enum dma_slave_buswidth dst_addr_width;
>> >> >         u32 src_maxburst;

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert at linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

Re: [PATCH] dmaengine: use phys_addr_t for slave configuration

[Wolfram Sang]

[-- Attachment #1: Type: text/plain, Size: 394 bytes --]


> This is a dependency for adding iommu support to the rcar-dmac driver, cfr.
> "[PATCH v2 0/5] dmaengine: rcar-dmac: add iommu support for slave transfers".
> http://www.spinics.net/lists/linux-renesas-soc/msg00066.html
> https://www.mail-archive.com/linux-renesas-soc@vger.kernel.org/msg00108.html
> 
> Thank you for applying!

Yup, we really need it. Anything we can do to help?


[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

[PATCH] dmaengine: use phys_addr_t for slave configuration

[Wolfram Sang]

> This is a dependency for adding iommu support to the rcar-dmac driver, cfr.
> "[PATCH v2 0/5] dmaengine: rcar-dmac: add iommu support for slave transfers".
> http://www.spinics.net/lists/linux-renesas-soc/msg00066.html
> https://www.mail-archive.com/linux-renesas-soc at vger.kernel.org/msg00108.html
> 
> Thank you for applying!

Yup, we really need it. Anything we can do to help?

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20160209/1375b676/attachment.sig>

Re: [PATCH] dmaengine: use phys_addr_t for slave configuration

[Vinod Koul]

[-- Attachment #1: Type: text/plain, Size: 595 bytes --]

On Tue, Feb 09, 2016 at 11:57:24PM +0100, Wolfram Sang wrote:
> 
> > This is a dependency for adding iommu support to the rcar-dmac driver, cfr.
> > "[PATCH v2 0/5] dmaengine: rcar-dmac: add iommu support for slave transfers".
> > http://www.spinics.net/lists/linux-renesas-soc/msg00066.html
> > https://www.mail-archive.com/linux-renesas-soc@vger.kernel.org/msg00108.html
> > 
> > Thank you for applying!
> 
> Yup, we really need it. Anything we can do to help?

I have done this change and discussing wider changes
I will send CFT hopefully before EOW, pls test :)

-- 
~Vinod

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

[PATCH] dmaengine: use phys_addr_t for slave configuration

[Vinod Koul]

On Tue, Feb 09, 2016 at 11:57:24PM +0100, Wolfram Sang wrote:
> 
> > This is a dependency for adding iommu support to the rcar-dmac driver, cfr.
> > "[PATCH v2 0/5] dmaengine: rcar-dmac: add iommu support for slave transfers".
> > http://www.spinics.net/lists/linux-renesas-soc/msg00066.html
> > https://www.mail-archive.com/linux-renesas-soc at vger.kernel.org/msg00108.html
> > 
> > Thank you for applying!
> 
> Yup, we really need it. Anything we can do to help?

I have done this change and discussing wider changes
I will send CFT hopefully before EOW, pls test :)

-- 
~Vinod
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20160215/f4513e05/attachment.sig>

Re: [PATCH] dmaengine: use phys_addr_t for slave configuration

[Wolfram Sang]

[-- Attachment #1: Type: text/plain, Size: 648 bytes --]


> > > This is a dependency for adding iommu support to the rcar-dmac driver, cfr.
> > > "[PATCH v2 0/5] dmaengine: rcar-dmac: add iommu support for slave transfers".
> > > http://www.spinics.net/lists/linux-renesas-soc/msg00066.html
> > > https://www.mail-archive.com/linux-renesas-soc@vger.kernel.org/msg00108.html
> > > 
> > > Thank you for applying!
> > 
> > Yup, we really need it. Anything we can do to help?
> 
> I have done this change and discussing wider changes
> I will send CFT hopefully before EOW, pls test :)

\o/ Thank you, Vinod!

If you cc linux-renesas-soc@vger.kernel.org, you'll surely have some
testers :)


[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

[PATCH] dmaengine: use phys_addr_t for slave configuration

[Wolfram Sang]

> > > This is a dependency for adding iommu support to the rcar-dmac driver, cfr.
> > > "[PATCH v2 0/5] dmaengine: rcar-dmac: add iommu support for slave transfers".
> > > http://www.spinics.net/lists/linux-renesas-soc/msg00066.html
> > > https://www.mail-archive.com/linux-renesas-soc at vger.kernel.org/msg00108.html
> > > 
> > > Thank you for applying!
> > 
> > Yup, we really need it. Anything we can do to help?
> 
> I have done this change and discussing wider changes
> I will send CFT hopefully before EOW, pls test :)

\o/ Thank you, Vinod!

If you cc linux-renesas-soc at vger.kernel.org, you'll surely have some
testers :)

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20160215/8db026bf/attachment.sig>

Re: [PATCH] dmaengine: use phys_addr_t for slave configuration

[Niklas Söderlund]

On 2016-02-15 23:00:53 +0530, Vinod Koul wrote:
> On Tue, Feb 09, 2016 at 11:57:24PM +0100, Wolfram Sang wrote:
> >
> > > This is a dependency for adding iommu support to the rcar-dmac driver, cfr.
> > > "[PATCH v2 0/5] dmaengine: rcar-dmac: add iommu support for slave transfers".
> > > http://www.spinics.net/lists/linux-renesas-soc/msg00066.html
> > > https://www.mail-archive.com/linux-renesas-soc@vger.kernel.org/msg00108.html
> > >
> > > Thank you for applying!
> >
> > Yup, we really need it. Anything we can do to help?
>
> I have done this change and discussing wider changes
> I will send CFT hopefully before EOW, pls test :)

Thanks Vinod for looking at this!

[PATCH] dmaengine: use phys_addr_t for slave configuration

[Niklas Söderlund]

On 2016-02-15 23:00:53 +0530, Vinod Koul wrote:
> On Tue, Feb 09, 2016 at 11:57:24PM +0100, Wolfram Sang wrote:
> >
> > > This is a dependency for adding iommu support to the rcar-dmac driver, cfr.
> > > "[PATCH v2 0/5] dmaengine: rcar-dmac: add iommu support for slave transfers".
> > > http://www.spinics.net/lists/linux-renesas-soc/msg00066.html
> > > https://www.mail-archive.com/linux-renesas-soc at vger.kernel.org/msg00108.html
> > >
> > > Thank you for applying!
> >
> > Yup, we really need it. Anything we can do to help?
>
> I have done this change and discussing wider changes
> I will send CFT hopefully before EOW, pls test :)

Thanks Vinod for looking at this!