All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] dmaengine: use phys_addr_t for slave configuration
@ 2013-04-26  9:06 Linus Walleij
  2013-04-26  9:14 ` Lee Jones
                   ` (2 more replies)
  0 siblings, 3 replies; 23+ messages in thread
From: Linus Walleij @ 2013-04-26  9:06 UTC (permalink / raw)
  To: linux-kernel; +Cc: Arnd Bergmann, Lee Jones, Vinod Koul, Linus Walleij

The documentation already says these are physical addresses, and
we have concluded that any translation into the DMA address space
needs to reside in the dmaengine driver, so change the type of
the passed arguments.

Cc: Arnd Bergmann <arnd@arndb.de>
Cc: Lee Jones <lee.jones@linaro.org>
Cc: Vinod Koul <vinod.koul@intel.com>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
---
 include/linux/dmaengine.h | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/include/linux/dmaengine.h b/include/linux/dmaengine.h
index 91ac8da..681df5f9 100644
--- a/include/linux/dmaengine.h
+++ b/include/linux/dmaengine.h
@@ -361,8 +361,8 @@ enum dma_slave_buswidth {
  */
 struct dma_slave_config {
 	enum dma_transfer_direction direction;
-	dma_addr_t src_addr;
-	dma_addr_t dst_addr;
+	phys_addr_t src_addr;
+	phys_addr_t dst_addr;
 	enum dma_slave_buswidth src_addr_width;
 	enum dma_slave_buswidth dst_addr_width;
 	u32 src_maxburst;
-- 
1.8.1.4


^ permalink raw reply	[flat|nested] 23+ messages in thread

* Re: [PATCH] dmaengine: use phys_addr_t for slave configuration
  2013-04-26  9:06 [PATCH] dmaengine: use phys_addr_t for slave configuration Linus Walleij
@ 2013-04-26  9:14 ` Lee Jones
  2013-04-26  9:40 ` Arnd Bergmann
  2015-07-08 10:12   ` Geert Uytterhoeven
  2 siblings, 0 replies; 23+ messages in thread
From: Lee Jones @ 2013-04-26  9:14 UTC (permalink / raw)
  To: Linus Walleij; +Cc: linux-kernel, Arnd Bergmann, Vinod Koul

On Fri, 26 Apr 2013, Linus Walleij wrote:

> The documentation already says these are physical addresses, and
> we have concluded that any translation into the DMA address space
> needs to reside in the dmaengine driver, so change the type of
> the passed arguments.
> 
> Cc: Arnd Bergmann <arnd@arndb.de>
> Cc: Lee Jones <lee.jones@linaro.org>
> Cc: Vinod Koul <vinod.koul@intel.com>
> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
> ---
>  include/linux/dmaengine.h | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/include/linux/dmaengine.h b/include/linux/dmaengine.h
> index 91ac8da..681df5f9 100644
> --- a/include/linux/dmaengine.h
> +++ b/include/linux/dmaengine.h
> @@ -361,8 +361,8 @@ enum dma_slave_buswidth {
>   */
>  struct dma_slave_config {
>  	enum dma_transfer_direction direction;
> -	dma_addr_t src_addr;
> -	dma_addr_t dst_addr;
> +	phys_addr_t src_addr;
> +	phys_addr_t dst_addr;
>  	enum dma_slave_buswidth src_addr_width;
>  	enum dma_slave_buswidth dst_addr_width;
>  	u32 src_maxburst;

Makes a lot more sense.

Acked-by: Lee Jones <lee.jones@linaro.org>

-- 
Lee Jones
Linaro ST-Ericsson Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog

^ permalink raw reply	[flat|nested] 23+ messages in thread

* Re: [PATCH] dmaengine: use phys_addr_t for slave configuration
  2013-04-26  9:06 [PATCH] dmaengine: use phys_addr_t for slave configuration Linus Walleij
  2013-04-26  9:14 ` Lee Jones
@ 2013-04-26  9:40 ` Arnd Bergmann
  2015-07-08 10:12   ` Geert Uytterhoeven
  2 siblings, 0 replies; 23+ messages in thread
From: Arnd Bergmann @ 2013-04-26  9:40 UTC (permalink / raw)
  To: Linus Walleij; +Cc: linux-kernel, Lee Jones, Vinod Koul

On Friday 26 April 2013 11:06:54 Linus Walleij wrote:
> The documentation already says these are physical addresses, and
> we have concluded that any translation into the DMA address space
> needs to reside in the dmaengine driver, so change the type of
> the passed arguments.
> 
> Cc: Arnd Bergmann <arnd@arndb.de>
> Cc: Lee Jones <lee.jones@linaro.org>
> Cc: Vinod Koul <vinod.koul@intel.com>
> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>

Acked-by: Arnd Bergmann <arnd@arndb.de>

^ permalink raw reply	[flat|nested] 23+ messages in thread

* Re: [PATCH] dmaengine: use phys_addr_t for slave configuration
  2013-04-26  9:06 [PATCH] dmaengine: use phys_addr_t for slave configuration Linus Walleij
@ 2015-07-08 10:12   ` Geert Uytterhoeven
  2013-04-26  9:40 ` Arnd Bergmann
  2015-07-08 10:12   ` Geert Uytterhoeven
  2 siblings, 0 replies; 23+ messages in thread
From: Geert Uytterhoeven @ 2015-07-08 10:12 UTC (permalink / raw)
  To: Linus Walleij
  Cc: linux-kernel, Arnd Bergmann, Lee Jones, Vinod Koul, dmaengine,
	Linux-sh list

On Fri, Apr 26, 2013 at 11:06 AM, Linus Walleij
<linus.walleij@linaro.org> wrote:
> The documentation already says these are physical addresses, and
> we have concluded that any translation into the DMA address space
> needs to reside in the dmaengine driver, so change the type of
> the passed arguments.
>
> Cc: Arnd Bergmann <arnd@arndb.de>
> Cc: Lee Jones <lee.jones@linaro.org>
> Cc: Vinod Koul <vinod.koul@intel.com>
> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>

What's the status of this one, which has been acked by Lee and Arnd?

Thanks!

> ---
>  include/linux/dmaengine.h | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/include/linux/dmaengine.h b/include/linux/dmaengine.h
> index 91ac8da..681df5f9 100644
> --- a/include/linux/dmaengine.h
> +++ b/include/linux/dmaengine.h
> @@ -361,8 +361,8 @@ enum dma_slave_buswidth {
>   */
>  struct dma_slave_config {
>         enum dma_transfer_direction direction;
> -       dma_addr_t src_addr;
> -       dma_addr_t dst_addr;
> +       phys_addr_t src_addr;
> +       phys_addr_t dst_addr;
>         enum dma_slave_buswidth src_addr_width;
>         enum dma_slave_buswidth dst_addr_width;
>         u32 src_maxburst;
> --
> 1.8.1.4

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

^ permalink raw reply	[flat|nested] 23+ messages in thread

* Re: [PATCH] dmaengine: use phys_addr_t for slave configuration
@ 2015-07-08 10:12   ` Geert Uytterhoeven
  0 siblings, 0 replies; 23+ messages in thread
From: Geert Uytterhoeven @ 2015-07-08 10:12 UTC (permalink / raw)
  To: Linus Walleij
  Cc: linux-kernel, Arnd Bergmann, Lee Jones, Vinod Koul, dmaengine,
	Linux-sh list

On Fri, Apr 26, 2013 at 11:06 AM, Linus Walleij
<linus.walleij@linaro.org> wrote:
> The documentation already says these are physical addresses, and
> we have concluded that any translation into the DMA address space
> needs to reside in the dmaengine driver, so change the type of
> the passed arguments.
>
> Cc: Arnd Bergmann <arnd@arndb.de>
> Cc: Lee Jones <lee.jones@linaro.org>
> Cc: Vinod Koul <vinod.koul@intel.com>
> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>

What's the status of this one, which has been acked by Lee and Arnd?

Thanks!

> ---
>  include/linux/dmaengine.h | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/include/linux/dmaengine.h b/include/linux/dmaengine.h
> index 91ac8da..681df5f9 100644
> --- a/include/linux/dmaengine.h
> +++ b/include/linux/dmaengine.h
> @@ -361,8 +361,8 @@ enum dma_slave_buswidth {
>   */
>  struct dma_slave_config {
>         enum dma_transfer_direction direction;
> -       dma_addr_t src_addr;
> -       dma_addr_t dst_addr;
> +       phys_addr_t src_addr;
> +       phys_addr_t dst_addr;
>         enum dma_slave_buswidth src_addr_width;
>         enum dma_slave_buswidth dst_addr_width;
>         u32 src_maxburst;
> --
> 1.8.1.4

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

^ permalink raw reply	[flat|nested] 23+ messages in thread

* Re: [PATCH] dmaengine: use phys_addr_t for slave configuration
  2015-07-08 10:12   ` Geert Uytterhoeven
@ 2015-07-10  8:26     ` Vinod Koul
  -1 siblings, 0 replies; 23+ messages in thread
From: Vinod Koul @ 2015-07-10  8:14 UTC (permalink / raw)
  To: Geert Uytterhoeven
  Cc: Linus Walleij, linux-kernel, Arnd Bergmann, Lee Jones, dmaengine,
	Linux-sh list

On Wed, Jul 08, 2015 at 12:12:52PM +0200, Geert Uytterhoeven wrote:
> On Fri, Apr 26, 2013 at 11:06 AM, Linus Walleij
> <linus.walleij@linaro.org> wrote:
> > The documentation already says these are physical addresses, and
> > we have concluded that any translation into the DMA address space
> > needs to reside in the dmaengine driver, so change the type of
> > the passed arguments.
> >
> > Cc: Arnd Bergmann <arnd@arndb.de>
> > Cc: Lee Jones <lee.jones@linaro.org>
> > Cc: Vinod Koul <vinod.koul@intel.com>
> > Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
> 
> What's the status of this one, which has been acked by Lee and Arnd?
Looks to have slipped thru. I will redo it

-- 
~Vinod

> 
> Thanks!
> 
> > ---
> >  include/linux/dmaengine.h | 4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/include/linux/dmaengine.h b/include/linux/dmaengine.h
> > index 91ac8da..681df5f9 100644
> > --- a/include/linux/dmaengine.h
> > +++ b/include/linux/dmaengine.h
> > @@ -361,8 +361,8 @@ enum dma_slave_buswidth {
> >   */
> >  struct dma_slave_config {
> >         enum dma_transfer_direction direction;
> > -       dma_addr_t src_addr;
> > -       dma_addr_t dst_addr;
> > +       phys_addr_t src_addr;
> > +       phys_addr_t dst_addr;
> >         enum dma_slave_buswidth src_addr_width;
> >         enum dma_slave_buswidth dst_addr_width;
> >         u32 src_maxburst;
> > --
> > 1.8.1.4
> 
> Gr{oetje,eeting}s,
> 
>                         Geert
> 
> --
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
> 
> In personal conversations with technical people, I call myself a hacker. But
> when I'm talking to journalists I just say "programmer" or something like that.
>                                 -- Linus Torvalds

-- 

^ permalink raw reply	[flat|nested] 23+ messages in thread

* Re: [PATCH] dmaengine: use phys_addr_t for slave configuration
@ 2015-07-10  8:26     ` Vinod Koul
  0 siblings, 0 replies; 23+ messages in thread
From: Vinod Koul @ 2015-07-10  8:26 UTC (permalink / raw)
  To: Geert Uytterhoeven
  Cc: Linus Walleij, linux-kernel, Arnd Bergmann, Lee Jones, dmaengine,
	Linux-sh list

On Wed, Jul 08, 2015 at 12:12:52PM +0200, Geert Uytterhoeven wrote:
> On Fri, Apr 26, 2013 at 11:06 AM, Linus Walleij
> <linus.walleij@linaro.org> wrote:
> > The documentation already says these are physical addresses, and
> > we have concluded that any translation into the DMA address space
> > needs to reside in the dmaengine driver, so change the type of
> > the passed arguments.
> >
> > Cc: Arnd Bergmann <arnd@arndb.de>
> > Cc: Lee Jones <lee.jones@linaro.org>
> > Cc: Vinod Koul <vinod.koul@intel.com>
> > Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
> 
> What's the status of this one, which has been acked by Lee and Arnd?
Looks to have slipped thru. I will redo it

-- 
~Vinod

> 
> Thanks!
> 
> > ---
> >  include/linux/dmaengine.h | 4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/include/linux/dmaengine.h b/include/linux/dmaengine.h
> > index 91ac8da..681df5f9 100644
> > --- a/include/linux/dmaengine.h
> > +++ b/include/linux/dmaengine.h
> > @@ -361,8 +361,8 @@ enum dma_slave_buswidth {
> >   */
> >  struct dma_slave_config {
> >         enum dma_transfer_direction direction;
> > -       dma_addr_t src_addr;
> > -       dma_addr_t dst_addr;
> > +       phys_addr_t src_addr;
> > +       phys_addr_t dst_addr;
> >         enum dma_slave_buswidth src_addr_width;
> >         enum dma_slave_buswidth dst_addr_width;
> >         u32 src_maxburst;
> > --
> > 1.8.1.4
> 
> Gr{oetje,eeting}s,
> 
>                         Geert
> 
> --
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
> 
> In personal conversations with technical people, I call myself a hacker. But
> when I'm talking to journalists I just say "programmer" or something like that.
>                                 -- Linus Torvalds

-- 

^ permalink raw reply	[flat|nested] 23+ messages in thread

* Re: [PATCH] dmaengine: use phys_addr_t for slave configuration
  2015-07-08 10:12   ` Geert Uytterhoeven
@ 2015-07-16  9:22     ` Linus Walleij
  -1 siblings, 0 replies; 23+ messages in thread
From: Linus Walleij @ 2015-07-16  9:22 UTC (permalink / raw)
  To: Geert Uytterhoeven
  Cc: linux-kernel, Arnd Bergmann, Lee Jones, Vinod Koul, dmaengine,
	Linux-sh list

On Wed, Jul 8, 2015 at 12:12 PM, Geert Uytterhoeven
<geert@linux-m68k.org> wrote:
> On Fri, Apr 26, 2013 at 11:06 AM, Linus Walleij
> <linus.walleij@linaro.org> wrote:
>> The documentation already says these are physical addresses, and
>> we have concluded that any translation into the DMA address space
>> needs to reside in the dmaengine driver, so change the type of
>> the passed arguments.
>>
>> Cc: Arnd Bergmann <arnd@arndb.de>
>> Cc: Lee Jones <lee.jones@linaro.org>
>> Cc: Vinod Koul <vinod.koul@intel.com>
>> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
>
> What's the status of this one, which has been acked by Lee and Arnd?

I don't even remember writing this patch anymore, haha :D

Yours,
Linus Walleij

^ permalink raw reply	[flat|nested] 23+ messages in thread

* Re: [PATCH] dmaengine: use phys_addr_t for slave configuration
@ 2015-07-16  9:22     ` Linus Walleij
  0 siblings, 0 replies; 23+ messages in thread
From: Linus Walleij @ 2015-07-16  9:22 UTC (permalink / raw)
  To: Geert Uytterhoeven
  Cc: linux-kernel, Arnd Bergmann, Lee Jones, Vinod Koul, dmaengine,
	Linux-sh list

On Wed, Jul 8, 2015 at 12:12 PM, Geert Uytterhoeven
<geert@linux-m68k.org> wrote:
> On Fri, Apr 26, 2013 at 11:06 AM, Linus Walleij
> <linus.walleij@linaro.org> wrote:
>> The documentation already says these are physical addresses, and
>> we have concluded that any translation into the DMA address space
>> needs to reside in the dmaengine driver, so change the type of
>> the passed arguments.
>>
>> Cc: Arnd Bergmann <arnd@arndb.de>
>> Cc: Lee Jones <lee.jones@linaro.org>
>> Cc: Vinod Koul <vinod.koul@intel.com>
>> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
>
> What's the status of this one, which has been acked by Lee and Arnd?

I don't even remember writing this patch anymore, haha :D

Yours,
Linus Walleij

^ permalink raw reply	[flat|nested] 23+ messages in thread

* Re: [PATCH] dmaengine: use phys_addr_t for slave configuration
  2015-07-10  8:26     ` Vinod Koul
@ 2015-12-15 10:48       ` Geert Uytterhoeven
  -1 siblings, 0 replies; 23+ messages in thread
From: Geert Uytterhoeven @ 2015-12-15 10:48 UTC (permalink / raw)
  To: Vinod Koul
  Cc: Linus Walleij, linux-kernel, Arnd Bergmann, Lee Jones, dmaengine,
	Linux-sh list

Hi Vinod,

On Fri, Jul 10, 2015 at 10:14 AM, Vinod Koul <vinod.koul@intel.com> wrote:
> On Wed, Jul 08, 2015 at 12:12:52PM +0200, Geert Uytterhoeven wrote:
>> On Fri, Apr 26, 2013 at 11:06 AM, Linus Walleij
>> <linus.walleij@linaro.org> wrote:
>> > The documentation already says these are physical addresses, and
>> > we have concluded that any translation into the DMA address space
>> > needs to reside in the dmaengine driver, so change the type of
>> > the passed arguments.
>> >
>> > Cc: Arnd Bergmann <arnd@arndb.de>
>> > Cc: Lee Jones <lee.jones@linaro.org>
>> > Cc: Vinod Koul <vinod.koul@intel.com>
>> > Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
>>
>> What's the status of this one, which has been acked by Lee and Arnd?
> Looks to have slipped thru. I will redo it

Ping?

> --
> ~Vinod
>
>>
>> Thanks!
>>
>> > ---
>> >  include/linux/dmaengine.h | 4 ++--
>> >  1 file changed, 2 insertions(+), 2 deletions(-)
>> >
>> > diff --git a/include/linux/dmaengine.h b/include/linux/dmaengine.h
>> > index 91ac8da..681df5f9 100644
>> > --- a/include/linux/dmaengine.h
>> > +++ b/include/linux/dmaengine.h
>> > @@ -361,8 +361,8 @@ enum dma_slave_buswidth {
>> >   */
>> >  struct dma_slave_config {
>> >         enum dma_transfer_direction direction;
>> > -       dma_addr_t src_addr;
>> > -       dma_addr_t dst_addr;
>> > +       phys_addr_t src_addr;
>> > +       phys_addr_t dst_addr;
>> >         enum dma_slave_buswidth src_addr_width;
>> >         enum dma_slave_buswidth dst_addr_width;
>> >         u32 src_maxburst;
>> > --
>> > 1.8.1.4

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

^ permalink raw reply	[flat|nested] 23+ messages in thread

* Re: [PATCH] dmaengine: use phys_addr_t for slave configuration
@ 2015-12-15 10:48       ` Geert Uytterhoeven
  0 siblings, 0 replies; 23+ messages in thread
From: Geert Uytterhoeven @ 2015-12-15 10:48 UTC (permalink / raw)
  To: Vinod Koul
  Cc: Linus Walleij, linux-kernel, Arnd Bergmann, Lee Jones, dmaengine,
	Linux-sh list

Hi Vinod,

On Fri, Jul 10, 2015 at 10:14 AM, Vinod Koul <vinod.koul@intel.com> wrote:
> On Wed, Jul 08, 2015 at 12:12:52PM +0200, Geert Uytterhoeven wrote:
>> On Fri, Apr 26, 2013 at 11:06 AM, Linus Walleij
>> <linus.walleij@linaro.org> wrote:
>> > The documentation already says these are physical addresses, and
>> > we have concluded that any translation into the DMA address space
>> > needs to reside in the dmaengine driver, so change the type of
>> > the passed arguments.
>> >
>> > Cc: Arnd Bergmann <arnd@arndb.de>
>> > Cc: Lee Jones <lee.jones@linaro.org>
>> > Cc: Vinod Koul <vinod.koul@intel.com>
>> > Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
>>
>> What's the status of this one, which has been acked by Lee and Arnd?
> Looks to have slipped thru. I will redo it

Ping?

> --
> ~Vinod
>
>>
>> Thanks!
>>
>> > ---
>> >  include/linux/dmaengine.h | 4 ++--
>> >  1 file changed, 2 insertions(+), 2 deletions(-)
>> >
>> > diff --git a/include/linux/dmaengine.h b/include/linux/dmaengine.h
>> > index 91ac8da..681df5f9 100644
>> > --- a/include/linux/dmaengine.h
>> > +++ b/include/linux/dmaengine.h
>> > @@ -361,8 +361,8 @@ enum dma_slave_buswidth {
>> >   */
>> >  struct dma_slave_config {
>> >         enum dma_transfer_direction direction;
>> > -       dma_addr_t src_addr;
>> > -       dma_addr_t dst_addr;
>> > +       phys_addr_t src_addr;
>> > +       phys_addr_t dst_addr;
>> >         enum dma_slave_buswidth src_addr_width;
>> >         enum dma_slave_buswidth dst_addr_width;
>> >         u32 src_maxburst;
>> > --
>> > 1.8.1.4

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

^ permalink raw reply	[flat|nested] 23+ messages in thread

* Re: [PATCH] dmaengine: use phys_addr_t for slave configuration
  2015-12-15 10:48       ` Geert Uytterhoeven
@ 2015-12-15 17:38         ` Vinod Koul
  -1 siblings, 0 replies; 23+ messages in thread
From: Vinod Koul @ 2015-12-15 17:26 UTC (permalink / raw)
  To: Geert Uytterhoeven
  Cc: Linus Walleij, linux-kernel, Arnd Bergmann, Lee Jones, dmaengine,
	Linux-sh list

On Tue, Dec 15, 2015 at 11:48:24AM +0100, Geert Uytterhoeven wrote:
> Hi Vinod,
> 
> On Fri, Jul 10, 2015 at 10:14 AM, Vinod Koul <vinod.koul@intel.com> wrote:
> > On Wed, Jul 08, 2015 at 12:12:52PM +0200, Geert Uytterhoeven wrote:
> >> On Fri, Apr 26, 2013 at 11:06 AM, Linus Walleij
> >> <linus.walleij@linaro.org> wrote:
> >> > The documentation already says these are physical addresses, and
> >> > we have concluded that any translation into the DMA address space
> >> > needs to reside in the dmaengine driver, so change the type of
> >> > the passed arguments.
> >> >
> >> > Cc: Arnd Bergmann <arnd@arndb.de>
> >> > Cc: Lee Jones <lee.jones@linaro.org>
> >> > Cc: Vinod Koul <vinod.koul@intel.com>
> >> > Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
> >>
> >> What's the status of this one, which has been acked by Lee and Arnd?
> > Looks to have slipped thru. I will redo it
> 
> Ping?

I should be able to do this in next few days...

> 
> > --
> > ~Vinod
> >
> >>
> >> Thanks!
> >>
> >> > ---
> >> >  include/linux/dmaengine.h | 4 ++--
> >> >  1 file changed, 2 insertions(+), 2 deletions(-)
> >> >
> >> > diff --git a/include/linux/dmaengine.h b/include/linux/dmaengine.h
> >> > index 91ac8da..681df5f9 100644
> >> > --- a/include/linux/dmaengine.h
> >> > +++ b/include/linux/dmaengine.h
> >> > @@ -361,8 +361,8 @@ enum dma_slave_buswidth {
> >> >   */
> >> >  struct dma_slave_config {
> >> >         enum dma_transfer_direction direction;
> >> > -       dma_addr_t src_addr;
> >> > -       dma_addr_t dst_addr;
> >> > +       phys_addr_t src_addr;
> >> > +       phys_addr_t dst_addr;
> >> >         enum dma_slave_buswidth src_addr_width;
> >> >         enum dma_slave_buswidth dst_addr_width;
> >> >         u32 src_maxburst;
> >> > --
> >> > 1.8.1.4
> 
> Gr{oetje,eeting}s,
> 
>                         Geert
> 
> --
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
> 
> In personal conversations with technical people, I call myself a hacker. But
> when I'm talking to journalists I just say "programmer" or something like that.
>                                 -- Linus Torvalds

-- 
~Vinod

^ permalink raw reply	[flat|nested] 23+ messages in thread

* Re: [PATCH] dmaengine: use phys_addr_t for slave configuration
@ 2015-12-15 17:38         ` Vinod Koul
  0 siblings, 0 replies; 23+ messages in thread
From: Vinod Koul @ 2015-12-15 17:38 UTC (permalink / raw)
  To: Geert Uytterhoeven
  Cc: Linus Walleij, linux-kernel, Arnd Bergmann, Lee Jones, dmaengine,
	Linux-sh list

On Tue, Dec 15, 2015 at 11:48:24AM +0100, Geert Uytterhoeven wrote:
> Hi Vinod,
> 
> On Fri, Jul 10, 2015 at 10:14 AM, Vinod Koul <vinod.koul@intel.com> wrote:
> > On Wed, Jul 08, 2015 at 12:12:52PM +0200, Geert Uytterhoeven wrote:
> >> On Fri, Apr 26, 2013 at 11:06 AM, Linus Walleij
> >> <linus.walleij@linaro.org> wrote:
> >> > The documentation already says these are physical addresses, and
> >> > we have concluded that any translation into the DMA address space
> >> > needs to reside in the dmaengine driver, so change the type of
> >> > the passed arguments.
> >> >
> >> > Cc: Arnd Bergmann <arnd@arndb.de>
> >> > Cc: Lee Jones <lee.jones@linaro.org>
> >> > Cc: Vinod Koul <vinod.koul@intel.com>
> >> > Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
> >>
> >> What's the status of this one, which has been acked by Lee and Arnd?
> > Looks to have slipped thru. I will redo it
> 
> Ping?

I should be able to do this in next few days...

> 
> > --
> > ~Vinod
> >
> >>
> >> Thanks!
> >>
> >> > ---
> >> >  include/linux/dmaengine.h | 4 ++--
> >> >  1 file changed, 2 insertions(+), 2 deletions(-)
> >> >
> >> > diff --git a/include/linux/dmaengine.h b/include/linux/dmaengine.h
> >> > index 91ac8da..681df5f9 100644
> >> > --- a/include/linux/dmaengine.h
> >> > +++ b/include/linux/dmaengine.h
> >> > @@ -361,8 +361,8 @@ enum dma_slave_buswidth {
> >> >   */
> >> >  struct dma_slave_config {
> >> >         enum dma_transfer_direction direction;
> >> > -       dma_addr_t src_addr;
> >> > -       dma_addr_t dst_addr;
> >> > +       phys_addr_t src_addr;
> >> > +       phys_addr_t dst_addr;
> >> >         enum dma_slave_buswidth src_addr_width;
> >> >         enum dma_slave_buswidth dst_addr_width;
> >> >         u32 src_maxburst;
> >> > --
> >> > 1.8.1.4
> 
> Gr{oetje,eeting}s,
> 
>                         Geert
> 
> --
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
> 
> In personal conversations with technical people, I call myself a hacker. But
> when I'm talking to journalists I just say "programmer" or something like that.
>                                 -- Linus Torvalds

-- 
~Vinod

^ permalink raw reply	[flat|nested] 23+ messages in thread

* Re: [PATCH] dmaengine: use phys_addr_t for slave configuration
  2015-12-15 17:38         ` Vinod Koul
@ 2016-02-03 11:17           ` Geert Uytterhoeven
  -1 siblings, 0 replies; 23+ messages in thread
From: Geert Uytterhoeven @ 2016-02-03 11:17 UTC (permalink / raw)
  To: Vinod Koul
  Cc: Linus Walleij, linux-kernel, Arnd Bergmann, Lee Jones, dmaengine,
	linux-renesas-soc, linux-arm-kernel, Niklas Söderlund

Hi Vinod,

On Tue, Dec 15, 2015 at 6:26 PM, Vinod Koul <vinod.koul@intel.com> wrote:
> On Tue, Dec 15, 2015 at 11:48:24AM +0100, Geert Uytterhoeven wrote:
>> On Fri, Jul 10, 2015 at 10:14 AM, Vinod Koul <vinod.koul@intel.com> wrote:
>> > On Wed, Jul 08, 2015 at 12:12:52PM +0200, Geert Uytterhoeven wrote:
>> >> On Fri, Apr 26, 2013 at 11:06 AM, Linus Walleij

(yes, 2013)

>> >> <linus.walleij@linaro.org> wrote:
>> >> > The documentation already says these are physical addresses, and
>> >> > we have concluded that any translation into the DMA address space
>> >> > needs to reside in the dmaengine driver, so change the type of
>> >> > the passed arguments.
>> >> >
>> >> > Cc: Arnd Bergmann <arnd@arndb.de>
>> >> > Cc: Lee Jones <lee.jones@linaro.org>
>> >> > Cc: Vinod Koul <vinod.koul@intel.com>
>> >> > Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
>> >>
>> >> What's the status of this one, which has been acked by Lee and Arnd?
>> > Looks to have slipped thru. I will redo it
>>
>> Ping?
>
> I should be able to do this in next few days...

Ping?

This is a dependency for adding iommu support to the rcar-dmac driver, cfr.
"[PATCH v2 0/5] dmaengine: rcar-dmac: add iommu support for slave transfers".
http://www.spinics.net/lists/linux-renesas-soc/msg00066.html
https://www.mail-archive.com/linux-renesas-soc@vger.kernel.org/msg00108.html

Thank you for applying!

>> >> > ---
>> >> >  include/linux/dmaengine.h | 4 ++--
>> >> >  1 file changed, 2 insertions(+), 2 deletions(-)
>> >> >
>> >> > diff --git a/include/linux/dmaengine.h b/include/linux/dmaengine.h
>> >> > index 91ac8da..681df5f9 100644
>> >> > --- a/include/linux/dmaengine.h
>> >> > +++ b/include/linux/dmaengine.h
>> >> > @@ -361,8 +361,8 @@ enum dma_slave_buswidth {
>> >> >   */
>> >> >  struct dma_slave_config {
>> >> >         enum dma_transfer_direction direction;
>> >> > -       dma_addr_t src_addr;
>> >> > -       dma_addr_t dst_addr;
>> >> > +       phys_addr_t src_addr;
>> >> > +       phys_addr_t dst_addr;
>> >> >         enum dma_slave_buswidth src_addr_width;
>> >> >         enum dma_slave_buswidth dst_addr_width;
>> >> >         u32 src_maxburst;

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

^ permalink raw reply	[flat|nested] 23+ messages in thread

* [PATCH] dmaengine: use phys_addr_t for slave configuration
@ 2016-02-03 11:17           ` Geert Uytterhoeven
  0 siblings, 0 replies; 23+ messages in thread
From: Geert Uytterhoeven @ 2016-02-03 11:17 UTC (permalink / raw)
  To: linux-arm-kernel

Hi Vinod,

On Tue, Dec 15, 2015 at 6:26 PM, Vinod Koul <vinod.koul@intel.com> wrote:
> On Tue, Dec 15, 2015 at 11:48:24AM +0100, Geert Uytterhoeven wrote:
>> On Fri, Jul 10, 2015 at 10:14 AM, Vinod Koul <vinod.koul@intel.com> wrote:
>> > On Wed, Jul 08, 2015 at 12:12:52PM +0200, Geert Uytterhoeven wrote:
>> >> On Fri, Apr 26, 2013 at 11:06 AM, Linus Walleij

(yes, 2013)

>> >> <linus.walleij@linaro.org> wrote:
>> >> > The documentation already says these are physical addresses, and
>> >> > we have concluded that any translation into the DMA address space
>> >> > needs to reside in the dmaengine driver, so change the type of
>> >> > the passed arguments.
>> >> >
>> >> > Cc: Arnd Bergmann <arnd@arndb.de>
>> >> > Cc: Lee Jones <lee.jones@linaro.org>
>> >> > Cc: Vinod Koul <vinod.koul@intel.com>
>> >> > Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
>> >>
>> >> What's the status of this one, which has been acked by Lee and Arnd?
>> > Looks to have slipped thru. I will redo it
>>
>> Ping?
>
> I should be able to do this in next few days...

Ping?

This is a dependency for adding iommu support to the rcar-dmac driver, cfr.
"[PATCH v2 0/5] dmaengine: rcar-dmac: add iommu support for slave transfers".
http://www.spinics.net/lists/linux-renesas-soc/msg00066.html
https://www.mail-archive.com/linux-renesas-soc at vger.kernel.org/msg00108.html

Thank you for applying!

>> >> > ---
>> >> >  include/linux/dmaengine.h | 4 ++--
>> >> >  1 file changed, 2 insertions(+), 2 deletions(-)
>> >> >
>> >> > diff --git a/include/linux/dmaengine.h b/include/linux/dmaengine.h
>> >> > index 91ac8da..681df5f9 100644
>> >> > --- a/include/linux/dmaengine.h
>> >> > +++ b/include/linux/dmaengine.h
>> >> > @@ -361,8 +361,8 @@ enum dma_slave_buswidth {
>> >> >   */
>> >> >  struct dma_slave_config {
>> >> >         enum dma_transfer_direction direction;
>> >> > -       dma_addr_t src_addr;
>> >> > -       dma_addr_t dst_addr;
>> >> > +       phys_addr_t src_addr;
>> >> > +       phys_addr_t dst_addr;
>> >> >         enum dma_slave_buswidth src_addr_width;
>> >> >         enum dma_slave_buswidth dst_addr_width;
>> >> >         u32 src_maxburst;

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert at linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

^ permalink raw reply	[flat|nested] 23+ messages in thread

* Re: [PATCH] dmaengine: use phys_addr_t for slave configuration
  2016-02-03 11:17           ` Geert Uytterhoeven
@ 2016-02-09 22:57             ` Wolfram Sang
  -1 siblings, 0 replies; 23+ messages in thread
From: Wolfram Sang @ 2016-02-09 22:57 UTC (permalink / raw)
  To: Geert Uytterhoeven
  Cc: Vinod Koul, Linus Walleij, linux-kernel, Arnd Bergmann,
	Lee Jones, dmaengine, linux-renesas-soc, linux-arm-kernel,
	Niklas Söderlund

[-- Attachment #1: Type: text/plain, Size: 394 bytes --]


> This is a dependency for adding iommu support to the rcar-dmac driver, cfr.
> "[PATCH v2 0/5] dmaengine: rcar-dmac: add iommu support for slave transfers".
> http://www.spinics.net/lists/linux-renesas-soc/msg00066.html
> https://www.mail-archive.com/linux-renesas-soc@vger.kernel.org/msg00108.html
> 
> Thank you for applying!

Yup, we really need it. Anything we can do to help?


[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

^ permalink raw reply	[flat|nested] 23+ messages in thread

* [PATCH] dmaengine: use phys_addr_t for slave configuration
@ 2016-02-09 22:57             ` Wolfram Sang
  0 siblings, 0 replies; 23+ messages in thread
From: Wolfram Sang @ 2016-02-09 22:57 UTC (permalink / raw)
  To: linux-arm-kernel


> This is a dependency for adding iommu support to the rcar-dmac driver, cfr.
> "[PATCH v2 0/5] dmaengine: rcar-dmac: add iommu support for slave transfers".
> http://www.spinics.net/lists/linux-renesas-soc/msg00066.html
> https://www.mail-archive.com/linux-renesas-soc at vger.kernel.org/msg00108.html
> 
> Thank you for applying!

Yup, we really need it. Anything we can do to help?

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20160209/1375b676/attachment.sig>

^ permalink raw reply	[flat|nested] 23+ messages in thread

* Re: [PATCH] dmaengine: use phys_addr_t for slave configuration
  2016-02-09 22:57             ` Wolfram Sang
@ 2016-02-15 17:30               ` Vinod Koul
  -1 siblings, 0 replies; 23+ messages in thread
From: Vinod Koul @ 2016-02-15 17:30 UTC (permalink / raw)
  To: Wolfram Sang
  Cc: Geert Uytterhoeven, Linus Walleij, linux-kernel, Arnd Bergmann,
	Lee Jones, dmaengine, linux-renesas-soc, linux-arm-kernel,
	Niklas Söderlund

[-- Attachment #1: Type: text/plain, Size: 595 bytes --]

On Tue, Feb 09, 2016 at 11:57:24PM +0100, Wolfram Sang wrote:
> 
> > This is a dependency for adding iommu support to the rcar-dmac driver, cfr.
> > "[PATCH v2 0/5] dmaengine: rcar-dmac: add iommu support for slave transfers".
> > http://www.spinics.net/lists/linux-renesas-soc/msg00066.html
> > https://www.mail-archive.com/linux-renesas-soc@vger.kernel.org/msg00108.html
> > 
> > Thank you for applying!
> 
> Yup, we really need it. Anything we can do to help?

I have done this change and discussing wider changes
I will send CFT hopefully before EOW, pls test :)

-- 
~Vinod

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

^ permalink raw reply	[flat|nested] 23+ messages in thread

* [PATCH] dmaengine: use phys_addr_t for slave configuration
@ 2016-02-15 17:30               ` Vinod Koul
  0 siblings, 0 replies; 23+ messages in thread
From: Vinod Koul @ 2016-02-15 17:30 UTC (permalink / raw)
  To: linux-arm-kernel

On Tue, Feb 09, 2016 at 11:57:24PM +0100, Wolfram Sang wrote:
> 
> > This is a dependency for adding iommu support to the rcar-dmac driver, cfr.
> > "[PATCH v2 0/5] dmaengine: rcar-dmac: add iommu support for slave transfers".
> > http://www.spinics.net/lists/linux-renesas-soc/msg00066.html
> > https://www.mail-archive.com/linux-renesas-soc at vger.kernel.org/msg00108.html
> > 
> > Thank you for applying!
> 
> Yup, we really need it. Anything we can do to help?

I have done this change and discussing wider changes
I will send CFT hopefully before EOW, pls test :)

-- 
~Vinod
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20160215/f4513e05/attachment.sig>

^ permalink raw reply	[flat|nested] 23+ messages in thread

* Re: [PATCH] dmaengine: use phys_addr_t for slave configuration
  2016-02-15 17:30               ` Vinod Koul
@ 2016-02-15 17:34                 ` Wolfram Sang
  -1 siblings, 0 replies; 23+ messages in thread
From: Wolfram Sang @ 2016-02-15 17:34 UTC (permalink / raw)
  To: Vinod Koul
  Cc: Geert Uytterhoeven, Linus Walleij, linux-kernel, Arnd Bergmann,
	Lee Jones, dmaengine, linux-renesas-soc, linux-arm-kernel,
	Niklas Söderlund

[-- Attachment #1: Type: text/plain, Size: 648 bytes --]


> > > This is a dependency for adding iommu support to the rcar-dmac driver, cfr.
> > > "[PATCH v2 0/5] dmaengine: rcar-dmac: add iommu support for slave transfers".
> > > http://www.spinics.net/lists/linux-renesas-soc/msg00066.html
> > > https://www.mail-archive.com/linux-renesas-soc@vger.kernel.org/msg00108.html
> > > 
> > > Thank you for applying!
> > 
> > Yup, we really need it. Anything we can do to help?
> 
> I have done this change and discussing wider changes
> I will send CFT hopefully before EOW, pls test :)

\o/ Thank you, Vinod!

If you cc linux-renesas-soc@vger.kernel.org, you'll surely have some
testers :)


[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

^ permalink raw reply	[flat|nested] 23+ messages in thread

* [PATCH] dmaengine: use phys_addr_t for slave configuration
@ 2016-02-15 17:34                 ` Wolfram Sang
  0 siblings, 0 replies; 23+ messages in thread
From: Wolfram Sang @ 2016-02-15 17:34 UTC (permalink / raw)
  To: linux-arm-kernel


> > > This is a dependency for adding iommu support to the rcar-dmac driver, cfr.
> > > "[PATCH v2 0/5] dmaengine: rcar-dmac: add iommu support for slave transfers".
> > > http://www.spinics.net/lists/linux-renesas-soc/msg00066.html
> > > https://www.mail-archive.com/linux-renesas-soc at vger.kernel.org/msg00108.html
> > > 
> > > Thank you for applying!
> > 
> > Yup, we really need it. Anything we can do to help?
> 
> I have done this change and discussing wider changes
> I will send CFT hopefully before EOW, pls test :)

\o/ Thank you, Vinod!

If you cc linux-renesas-soc at vger.kernel.org, you'll surely have some
testers :)

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20160215/8db026bf/attachment.sig>

^ permalink raw reply	[flat|nested] 23+ messages in thread

* Re: [PATCH] dmaengine: use phys_addr_t for slave configuration
  2016-02-15 17:30               ` Vinod Koul
@ 2016-02-16 20:42                 ` Niklas Söderlund
  -1 siblings, 0 replies; 23+ messages in thread
From: Niklas Söderlund @ 2016-02-16 20:42 UTC (permalink / raw)
  To: Vinod Koul
  Cc: Wolfram Sang, Geert Uytterhoeven, Linus Walleij, linux-kernel,
	Arnd Bergmann, Lee Jones, dmaengine, linux-renesas-soc,
	linux-arm-kernel

On 2016-02-15 23:00:53 +0530, Vinod Koul wrote:
> On Tue, Feb 09, 2016 at 11:57:24PM +0100, Wolfram Sang wrote:
> >
> > > This is a dependency for adding iommu support to the rcar-dmac driver, cfr.
> > > "[PATCH v2 0/5] dmaengine: rcar-dmac: add iommu support for slave transfers".
> > > http://www.spinics.net/lists/linux-renesas-soc/msg00066.html
> > > https://www.mail-archive.com/linux-renesas-soc@vger.kernel.org/msg00108.html
> > >
> > > Thank you for applying!
> >
> > Yup, we really need it. Anything we can do to help?
>
> I have done this change and discussing wider changes
> I will send CFT hopefully before EOW, pls test :)

Thanks Vinod for looking at this!

^ permalink raw reply	[flat|nested] 23+ messages in thread

* [PATCH] dmaengine: use phys_addr_t for slave configuration
@ 2016-02-16 20:42                 ` Niklas Söderlund
  0 siblings, 0 replies; 23+ messages in thread
From: Niklas Söderlund @ 2016-02-16 20:42 UTC (permalink / raw)
  To: linux-arm-kernel

On 2016-02-15 23:00:53 +0530, Vinod Koul wrote:
> On Tue, Feb 09, 2016 at 11:57:24PM +0100, Wolfram Sang wrote:
> >
> > > This is a dependency for adding iommu support to the rcar-dmac driver, cfr.
> > > "[PATCH v2 0/5] dmaengine: rcar-dmac: add iommu support for slave transfers".
> > > http://www.spinics.net/lists/linux-renesas-soc/msg00066.html
> > > https://www.mail-archive.com/linux-renesas-soc at vger.kernel.org/msg00108.html
> > >
> > > Thank you for applying!
> >
> > Yup, we really need it. Anything we can do to help?
>
> I have done this change and discussing wider changes
> I will send CFT hopefully before EOW, pls test :)

Thanks Vinod for looking at this!

^ permalink raw reply	[flat|nested] 23+ messages in thread

end of thread, other threads:[~2016-02-16 20:42 UTC | newest]

Thread overview: 23+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-04-26  9:06 [PATCH] dmaengine: use phys_addr_t for slave configuration Linus Walleij
2013-04-26  9:14 ` Lee Jones
2013-04-26  9:40 ` Arnd Bergmann
2015-07-08 10:12 ` Geert Uytterhoeven
2015-07-08 10:12   ` Geert Uytterhoeven
2015-07-10  8:14   ` Vinod Koul
2015-07-10  8:26     ` Vinod Koul
2015-12-15 10:48     ` Geert Uytterhoeven
2015-12-15 10:48       ` Geert Uytterhoeven
2015-12-15 17:26       ` Vinod Koul
2015-12-15 17:38         ` Vinod Koul
2016-02-03 11:17         ` Geert Uytterhoeven
2016-02-03 11:17           ` Geert Uytterhoeven
2016-02-09 22:57           ` Wolfram Sang
2016-02-09 22:57             ` Wolfram Sang
2016-02-15 17:30             ` Vinod Koul
2016-02-15 17:30               ` Vinod Koul
2016-02-15 17:34               ` Wolfram Sang
2016-02-15 17:34                 ` Wolfram Sang
2016-02-16 20:42               ` Niklas Söderlund
2016-02-16 20:42                 ` Niklas Söderlund
2015-07-16  9:22   ` Linus Walleij
2015-07-16  9:22     ` Linus Walleij

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.