From: Baolin Wang <baolin.wang@linaro.org> To: Mark Brown <broonie@kernel.org> Cc: Baolin Wang <baolin.wang@spreadtrum.com>, Rob Herring <robh+dt@kernel.org>, Mark Rutland <mark.rutland@arm.com>, linux-spi@vger.kernel.org, devicetree@vger.kernel.org, LKML <linux-kernel@vger.kernel.org> Subject: Re: [PATCH 1/2] dt-bindings: spi: Add Spreadtrum ADI controller documentation Date: Fri, 8 Sep 2017 09:57:17 +0800 [thread overview] Message-ID: <CAMz4kuK+jMBRtcO-0b3Lk_hnvDOxr6yyDLkMRc-VCk21bvz4WQ@mail.gmail.com> (raw) In-Reply-To: <20170907114401.kz2rfss2bkslybtq@sirena.co.uk> On 7 September 2017 at 19:44, Mark Brown <broonie@kernel.org> wrote: > On Thu, Sep 07, 2017 at 07:03:18PM +0800, Baolin Wang wrote: >> On 7 September 2017 at 17:54, Mark Brown <broonie@kernel.org> wrote: >> > On Thu, Sep 07, 2017 at 11:29:05AM +0800, Baolin Wang wrote: > >> >> The hwspinlock name should be "adi", and I will make it clear in next version. > >> > So there's other drivers that might also be accessing this IP block? > >> Yes. Other drivers (like regulator, RTC or charger ... ) can access >> analog chip (like PMIC) by ADI controller. But the hardware spinlock >> is used to synchronize between the multiple subsystems, since we only >> have one ADI controller. > > If it were other drivers then the kernel should already be doing that > but... Not only kernel drivers, but also other systems' drivers will access ADI too. So here we need one hardware spinlock to protect, I will add more documentation. > >> > So does this driver control all the channels or are there other drivers >> > (or hardware components) that control some of the other channels? > >> The ADI driver only controls 2 software channels (read/write), and >> other hardware channels can be controlled by hardware components if we >> set the hardware config. > > ...if it can be configured to allow other things to use it independently > then this is fine, just needs a bit more documentation so someone can > understand how the bindings and hardware match up. OK. Thanks for your comments. -- Baolin.wang Best Regards
WARNING: multiple messages have this Message-ID (diff)
From: Baolin Wang <baolin.wang-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org> To: Mark Brown <broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org> Cc: Baolin Wang <baolin.wang-lxIno14LUO0EEoCn2XhGlw@public.gmane.org>, Rob Herring <robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>, Mark Rutland <mark.rutland-5wv7dgnIgG8@public.gmane.org>, linux-spi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, LKML <linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org> Subject: Re: [PATCH 1/2] dt-bindings: spi: Add Spreadtrum ADI controller documentation Date: Fri, 8 Sep 2017 09:57:17 +0800 [thread overview] Message-ID: <CAMz4kuK+jMBRtcO-0b3Lk_hnvDOxr6yyDLkMRc-VCk21bvz4WQ@mail.gmail.com> (raw) In-Reply-To: <20170907114401.kz2rfss2bkslybtq-7j8lgAiuQgnQXOPxS62xeg@public.gmane.org> On 7 September 2017 at 19:44, Mark Brown <broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org> wrote: > On Thu, Sep 07, 2017 at 07:03:18PM +0800, Baolin Wang wrote: >> On 7 September 2017 at 17:54, Mark Brown <broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org> wrote: >> > On Thu, Sep 07, 2017 at 11:29:05AM +0800, Baolin Wang wrote: > >> >> The hwspinlock name should be "adi", and I will make it clear in next version. > >> > So there's other drivers that might also be accessing this IP block? > >> Yes. Other drivers (like regulator, RTC or charger ... ) can access >> analog chip (like PMIC) by ADI controller. But the hardware spinlock >> is used to synchronize between the multiple subsystems, since we only >> have one ADI controller. > > If it were other drivers then the kernel should already be doing that > but... Not only kernel drivers, but also other systems' drivers will access ADI too. So here we need one hardware spinlock to protect, I will add more documentation. > >> > So does this driver control all the channels or are there other drivers >> > (or hardware components) that control some of the other channels? > >> The ADI driver only controls 2 software channels (read/write), and >> other hardware channels can be controlled by hardware components if we >> set the hardware config. > > ...if it can be configured to allow other things to use it independently > then this is fine, just needs a bit more documentation so someone can > understand how the bindings and hardware match up. OK. Thanks for your comments. -- Baolin.wang Best Regards -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2017-09-08 1:57 UTC|newest] Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top 2017-09-06 6:10 [PATCH 1/2] dt-bindings: spi: Add Spreadtrum ADI controller documentation Baolin Wang 2017-09-06 6:10 ` Baolin Wang 2017-09-06 6:10 ` Baolin Wang 2017-09-06 6:10 ` [PATCH 2/2] spi: Add ADI driver for Spreadtrum platform Baolin Wang 2017-09-06 6:10 ` Baolin Wang 2017-09-06 15:04 ` Mark Brown 2017-09-06 15:04 ` Mark Brown 2017-09-07 3:13 ` Baolin Wang 2017-09-07 3:13 ` Baolin Wang 2017-09-07 10:10 ` Mark Brown 2017-09-07 10:10 ` Mark Brown 2017-09-07 11:21 ` Baolin Wang 2017-09-06 14:59 ` [PATCH 1/2] dt-bindings: spi: Add Spreadtrum ADI controller documentation Mark Brown 2017-09-06 14:59 ` Mark Brown 2017-09-07 3:29 ` Baolin Wang 2017-09-07 3:29 ` Baolin Wang 2017-09-07 9:54 ` Mark Brown 2017-09-07 11:03 ` Baolin Wang 2017-09-07 11:44 ` Mark Brown 2017-09-08 1:57 ` Baolin Wang [this message] 2017-09-08 1:57 ` Baolin Wang
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=CAMz4kuK+jMBRtcO-0b3Lk_hnvDOxr6yyDLkMRc-VCk21bvz4WQ@mail.gmail.com \ --to=baolin.wang@linaro.org \ --cc=baolin.wang@spreadtrum.com \ --cc=broonie@kernel.org \ --cc=devicetree@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-spi@vger.kernel.org \ --cc=mark.rutland@arm.com \ --cc=robh+dt@kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.