All of lore.kernel.org
 help / color / mirror / Atom feed
From: Benjamin Tissoires <benjamin.tissoires@gmail.com>
To: Jiri Kosina <jikos@kernel.org>
Cc: Andrej Shadura <andrew.shadura@collabora.co.uk>,
	linux-input <linux-input@vger.kernel.org>,
	linux-usb@vger.kernel.org,
	Andrzej Pietrasiewicz <andrzej.p@collabora.com>,
	kernel@collabora.com, "Theodore Ts'o" <tytso@mit.edu>,
	Vasily Khoruzhick <anarsoul@gmail.com>,
	Nick Kossifidis <mickflemm@gmail.com>,
	linux-crypto@vger.kernel.org
Subject: Re: [PATCH v3] HID: add driver for U2F Zero built-in LED and RNG
Date: Thu, 11 Apr 2019 11:58:26 +0200	[thread overview]
Message-ID: <CAN+gG=H6TGtB68-XJ+Pg53EhL_M2m8MG1z33Yenvd9PhXJ=Oqw@mail.gmail.com> (raw)
In-Reply-To: <nycvar.YFH.7.76.1904101400520.9803@cbobk.fhfr.pm>

On Wed, Apr 10, 2019 at 3:14 PM Jiri Kosina <jikos@kernel.org> wrote:
>
> On Mon, 1 Apr 2019, Andrej Shadura wrote:
>
> > U2F Zero supports custom commands for blinking the LED and getting data
> > from the internal hardware RNG. Expose the blinking function as a LED
> > device, and the internal hardware RNG as an HWRNG so that it can be used
> > to feed the enthropy pool.
>
> So I still am not really happy about this being wired up into generic HID
> although it's really a USB driver, but we've discussed that already, and I
> don't see any option that'd work substantially better in this case,
> especially from the UX point of view. Oh well. Applied to for-5.2/u2fzero,
> thanks!
>

Hi wish I were CC-ed on these threads.

My CI script now fails because hid-u2fzero.ko needs
devm_hwrng_register and the Kconfig doesn't force pulling the right
dependency.

Also, you probably want to add in .probe() a check for the actual
transport driver (`hid_is_using_ll_driver(hdev, &usb_hid_driver)`) or
you can not use the usbhid functions without crashing the kernel.

Cheers,
Benjamin

WARNING: multiple messages have this Message-ID (diff)
From: Benjamin Tissoires <benjamin.tissoires@gmail.com>
To: Jiri Kosina <jikos@kernel.org>
Cc: Andrej Shadura <andrew.shadura@collabora.co.uk>,
	linux-input <linux-input@vger.kernel.org>,
	linux-usb@vger.kernel.org,
	Andrzej Pietrasiewicz <andrzej.p@collabora.com>,
	kernel@collabora.com, Theodore Ts'o <tytso@mit.edu>,
	Vasily Khoruzhick <anarsoul@gmail.com>,
	Nick Kossifidis <mickflemm@gmail.com>,
	linux-crypto@vger.kernel.org
Subject: [v3] HID: add driver for U2F Zero built-in LED and RNG
Date: Thu, 11 Apr 2019 11:58:26 +0200	[thread overview]
Message-ID: <CAN+gG=H6TGtB68-XJ+Pg53EhL_M2m8MG1z33Yenvd9PhXJ=Oqw@mail.gmail.com> (raw)

On Wed, Apr 10, 2019 at 3:14 PM Jiri Kosina <jikos@kernel.org> wrote:
>
> On Mon, 1 Apr 2019, Andrej Shadura wrote:
>
> > U2F Zero supports custom commands for blinking the LED and getting data
> > from the internal hardware RNG. Expose the blinking function as a LED
> > device, and the internal hardware RNG as an HWRNG so that it can be used
> > to feed the enthropy pool.
>
> So I still am not really happy about this being wired up into generic HID
> although it's really a USB driver, but we've discussed that already, and I
> don't see any option that'd work substantially better in this case,
> especially from the UX point of view. Oh well. Applied to for-5.2/u2fzero,
> thanks!
>

Hi wish I were CC-ed on these threads.

My CI script now fails because hid-u2fzero.ko needs
devm_hwrng_register and the Kconfig doesn't force pulling the right
dependency.

Also, you probably want to add in .probe() a check for the actual
transport driver (`hid_is_using_ll_driver(hdev, &usb_hid_driver)`) or
you can not use the usbhid functions without crashing the kernel.

Cheers,
Benjamin

  reply	other threads:[~2019-04-11  9:58 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-04-01 12:42 [PATCH v3] HID: add driver for U2F Zero built-in LED and RNG Andrej Shadura
2019-04-01 12:42 ` [v3] " Andrej Shadura
2019-04-10 12:02 ` [PATCH v3] " Jiri Kosina
2019-04-10 12:02   ` [v3] " Jiri Kosina
2019-04-11  9:58   ` Benjamin Tissoires [this message]
2019-04-11  9:58     ` Benjamin Tissoires
2019-04-11 10:35     ` [PATCH v3] " Jiri Kosina
2019-04-11 10:35       ` [v3] " Jiri Kosina
2019-04-11 11:52       ` [PATCH v3] " Andrej Shadura
2019-04-11 11:52         ` [v3] " Andrej Shadura
2019-04-17 14:43         ` [PATCH v3] " Jiri Kosina
2019-04-17 14:43           ` [v3] " Jiri Kosina
2019-04-17 14:47           ` [PATCH v3] " Andrej Shadura
2019-04-17 14:47             ` [v3] " Andrej Shadura
2019-10-03  7:19 ` [PATCH v3] " Andrej Shadura
2019-10-03 15:25   ` Alan Stern

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAN+gG=H6TGtB68-XJ+Pg53EhL_M2m8MG1z33Yenvd9PhXJ=Oqw@mail.gmail.com' \
    --to=benjamin.tissoires@gmail.com \
    --cc=anarsoul@gmail.com \
    --cc=andrew.shadura@collabora.co.uk \
    --cc=andrzej.p@collabora.com \
    --cc=jikos@kernel.org \
    --cc=kernel@collabora.com \
    --cc=linux-crypto@vger.kernel.org \
    --cc=linux-input@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=mickflemm@gmail.com \
    --cc=tytso@mit.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.