All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andrej Shadura <andrew.shadura@collabora.co.uk>
To: Jiri Kosina <jikos@kernel.org>,
	Benjamin Tissoires <benjamin.tissoires@gmail.com>
Cc: linux-input <linux-input@vger.kernel.org>,
	linux-usb@vger.kernel.org,
	Andrzej Pietrasiewicz <andrzej.p@collabora.com>,
	kernel@collabora.com, linux-crypto@vger.kernel.org
Subject: Re: [PATCH v3] HID: add driver for U2F Zero built-in LED and RNG
Date: Thu, 11 Apr 2019 13:52:45 +0200	[thread overview]
Message-ID: <d33b8772-bae6-1d20-8ff0-3397095f6e4b@collabora.co.uk> (raw)
In-Reply-To: <nycvar.YFH.7.76.1904111234080.9803@cbobk.fhfr.pm>

On 11/04/2019 12:35, Jiri Kosina wrote:
> On Thu, 11 Apr 2019, Benjamin Tissoires wrote:
> 
>>> So I still am not really happy about this being wired up into generic HID
>>> although it's really a USB driver, but we've discussed that already, and I
>>> don't see any option that'd work substantially better in this case,
>>> especially from the UX point of view. Oh well. Applied to for-5.2/u2fzero,
>>> thanks!
>>>
>>
>> Hi wish I were CC-ed on these threads.
> 
> Gah, for some reason I was convinced you were.
> 
>> My CI script now fails because hid-u2fzero.ko needs devm_hwrng_register 
>> and the Kconfig doesn't force pulling the right dependency.

>> Also, you probably want to add in .probe() a check for the actual 
>> transport driver (`hid_is_using_ll_driver(hdev, &usb_hid_driver)`) or 
>> you can not use the usbhid functions without crashing the kernel.

Thanks, that’s very useful.

> Benjamin, I love your CI :)
> 
> Andrej, could you please send fixups on top of the applied patch?

Sure, will do.

-- 
Cheers,
  Andrej

WARNING: multiple messages have this Message-ID (diff)
From: Andrej Shadura <andrew.shadura@collabora.co.uk>
To: Jiri Kosina <jikos@kernel.org>,
	Benjamin Tissoires <benjamin.tissoires@gmail.com>
Cc: linux-input <linux-input@vger.kernel.org>,
	linux-usb@vger.kernel.org,
	Andrzej Pietrasiewicz <andrzej.p@collabora.com>,
	kernel@collabora.com, linux-crypto@vger.kernel.org
Subject: [v3] HID: add driver for U2F Zero built-in LED and RNG
Date: Thu, 11 Apr 2019 13:52:45 +0200	[thread overview]
Message-ID: <d33b8772-bae6-1d20-8ff0-3397095f6e4b@collabora.co.uk> (raw)

On 11/04/2019 12:35, Jiri Kosina wrote:
> On Thu, 11 Apr 2019, Benjamin Tissoires wrote:
> 
>>> So I still am not really happy about this being wired up into generic HID
>>> although it's really a USB driver, but we've discussed that already, and I
>>> don't see any option that'd work substantially better in this case,
>>> especially from the UX point of view. Oh well. Applied to for-5.2/u2fzero,
>>> thanks!
>>>
>>
>> Hi wish I were CC-ed on these threads.
> 
> Gah, for some reason I was convinced you were.
> 
>> My CI script now fails because hid-u2fzero.ko needs devm_hwrng_register 
>> and the Kconfig doesn't force pulling the right dependency.

>> Also, you probably want to add in .probe() a check for the actual 
>> transport driver (`hid_is_using_ll_driver(hdev, &usb_hid_driver)`) or 
>> you can not use the usbhid functions without crashing the kernel.

Thanks, that’s very useful.

> Benjamin, I love your CI :)
> 
> Andrej, could you please send fixups on top of the applied patch?

Sure, will do.

  reply	other threads:[~2019-04-11 11:52 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-04-01 12:42 [PATCH v3] HID: add driver for U2F Zero built-in LED and RNG Andrej Shadura
2019-04-01 12:42 ` [v3] " Andrej Shadura
2019-04-10 12:02 ` [PATCH v3] " Jiri Kosina
2019-04-10 12:02   ` [v3] " Jiri Kosina
2019-04-11  9:58   ` [PATCH v3] " Benjamin Tissoires
2019-04-11  9:58     ` [v3] " Benjamin Tissoires
2019-04-11 10:35     ` [PATCH v3] " Jiri Kosina
2019-04-11 10:35       ` [v3] " Jiri Kosina
2019-04-11 11:52       ` Andrej Shadura [this message]
2019-04-11 11:52         ` Andrej Shadura
2019-04-17 14:43         ` [PATCH v3] " Jiri Kosina
2019-04-17 14:43           ` [v3] " Jiri Kosina
2019-04-17 14:47           ` [PATCH v3] " Andrej Shadura
2019-04-17 14:47             ` [v3] " Andrej Shadura
2019-10-03  7:19 ` [PATCH v3] " Andrej Shadura
2019-10-03 15:25   ` Alan Stern

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d33b8772-bae6-1d20-8ff0-3397095f6e4b@collabora.co.uk \
    --to=andrew.shadura@collabora.co.uk \
    --cc=andrzej.p@collabora.com \
    --cc=benjamin.tissoires@gmail.com \
    --cc=jikos@kernel.org \
    --cc=kernel@collabora.com \
    --cc=linux-crypto@vger.kernel.org \
    --cc=linux-input@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.