All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ryan Lee <ryans.lee@maximintegrated.com>
To: Rob Herring <robh@kernel.org>
Cc: Liam Girdwood <lgirdwood@gmail.com>,
	Mark Brown <broonie@kernel.org>, <mark.rutland@arm.com>,
	<perex@perex.cz>, <tiwai@suse.com>,
	Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>,
	Arnd Bergmann <arnd@arndb.de>,
	<ckeepax@opensource.wolfsonmicro.com>, <lars@metafoo.de>,
	<bardliao@realtek.com>, <nh6z@nh6z.net>, <KCHSU0@nuvoton.com>,
	Axel Lin <axel.lin@ingics.com>, <romain.perier@collabora.com>,
	Srinivas Kandagatla <srinivas.kandagatla@linaro.org>,
	<oder_chiou@realtek.com>, <Paul.Handrigan@cirrus.com>,
	<alsa-devel@alsa-project.org>, <devicetree@vger.kernel.org>,
	<linux-kernel@vger.kernel.org>, Dylan Reid <dgreid@google.com>
Subject: Re: [PATCH v4] ASoC: Add support for Maxim Integrated MAX98927 Amplifier
Date: Mon, 3 Apr 2017 10:24:38 -0700	[thread overview]
Message-ID: <CAN4-ojkdnzp59zMVj8fQj0NBAW-AdNvMt-YhvOMjBnMLv30-rA@mail.gmail.com> (raw)
In-Reply-To: <20170403163053.u6b3yadkfyh4z7h5@rob-hp-laptop>

On Mon, Apr 3, 2017 at 9:30 AM, Rob Herring <robh@kernel.org> wrote:
> On Fri, Mar 31, 2017 at 10:16:34AM +0900, Ryan Lee wrote:
>> Signed-off-by: Ryan Lee <ryans.lee@maximintegrated.com>
>> ---
>>
>> Changes since v4:
>>       * Removed support for SND_SOC_DAIFMT_CBS_CFM.
>>       * Fixed coding style for indention.
>>       * Removed variables if it has only one user.
>>       * Assigned ch_size directly.
>>       * Removed oring.
>>       * Put the return false in the switch statement.
>>       * Removed 'Monomix Output' and 'Speaker Source' controls.
>>       * Modified control names per control-names.rst.
>>       * Moved Revision ID check code to i2c_probe function.
>>       * Added 'Current Limit' control.
>>       * Removed 'devm__kfree' function.
>>
>> Changes since v3:
>>       * Combined MAX98926 and MAX98927 binding. Kept existing property name.
>
> This looks fine, but:
>
>> Changes since v2:
>>       * Removed local register read/write function to avoid duplication of ASoC core function.
>>
>>  .../devicetree/bindings/sound/max98925.txt         |  22 -
>>  .../devicetree/bindings/sound/max98926.txt         |  32 -
>>  .../devicetree/bindings/sound/max9892x.txt         |  41 +
>>  sound/soc/codecs/Kconfig                           |   5 +
>>  sound/soc/codecs/Makefile                          |   2 +
>>  sound/soc/codecs/max98927.c                        | 841 +++++++++++++++++++++
>>  sound/soc/codecs/max98927.h                        | 272 +++++++
>>  7 files changed, 1161 insertions(+), 54 deletions(-)
>>  delete mode 100644 Documentation/devicetree/bindings/sound/max98925.txt
>>  delete mode 100644 Documentation/devicetree/bindings/sound/max98926.txt
>>  create mode 100755 Documentation/devicetree/bindings/sound/max9892x.txt
>>  mode change 100644 => 100755 sound/soc/codecs/Kconfig
>>  mode change 100644 => 100755 sound/soc/codecs/Makefile
>>  create mode 100755 sound/soc/codecs/max98927.c
>>  create mode 100755 sound/soc/codecs/max98927.h
>
> These should all be 644 mode.

I've changed the mode to 644. Thank you.

>
> Rob

WARNING: multiple messages have this Message-ID (diff)
From: Ryan Lee <ryans.lee-zxKO94PEStzToO697jQleEEOCMrvLtNR@public.gmane.org>
To: Rob Herring <robh-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
Cc: Liam Girdwood <lgirdwood-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
	Mark Brown <broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
	mark.rutland-5wv7dgnIgG8@public.gmane.org,
	perex-/Fr2/VpizcU@public.gmane.org,
	tiwai-IBi9RG/b67k@public.gmane.org,
	Kuninori Morimoto
	<kuninori.morimoto.gx-zM6kxYcvzFBBDgjK7y7TUQ@public.gmane.org>,
	Arnd Bergmann <arnd-r2nGTMty4D4@public.gmane.org>,
	ckeepax-yzvPICuk2AATkU/dhu1WVueM+bqZidxxQQ4Iyu8u01E@public.gmane.org,
	lars-Qo5EllUWu/uELgA04lAiVw@public.gmane.org,
	bardliao-Rasf1IRRPZFBDgjK7y7TUQ@public.gmane.org,
	nh6z-fFIq/eER6g8@public.gmane.org,
	KCHSU0-KrzQf0k3Iz9BDgjK7y7TUQ@public.gmane.org,
	Axel Lin <axel.lin-8E1dMatC8ynQT0dZR+AlfA@public.gmane.org>,
	romain.perier-ZGY8ohtN/8qB+jHODAdFcQ@public.gmane.org,
	Srinivas Kandagatla
	<srinivas.kandagatla-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>,
	oder_chiou-Rasf1IRRPZFBDgjK7y7TUQ@public.gmane.org,
	Paul.Handrigan-jGc1dHjMKG3QT0dZR+AlfA@public.gmane.org,
	alsa-devel-K7yf7f+aM1XWsZ/bQMPhNw@public.gmane.org,
	devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	Dylan Reid <dgreid-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>
Subject: Re: [PATCH v4] ASoC: Add support for Maxim Integrated MAX98927 Amplifier
Date: Mon, 3 Apr 2017 10:24:38 -0700	[thread overview]
Message-ID: <CAN4-ojkdnzp59zMVj8fQj0NBAW-AdNvMt-YhvOMjBnMLv30-rA@mail.gmail.com> (raw)
In-Reply-To: <20170403163053.u6b3yadkfyh4z7h5@rob-hp-laptop>

On Mon, Apr 3, 2017 at 9:30 AM, Rob Herring <robh-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org> wrote:
> On Fri, Mar 31, 2017 at 10:16:34AM +0900, Ryan Lee wrote:
>> Signed-off-by: Ryan Lee <ryans.lee-zxKO94PEStzToO697jQleEEOCMrvLtNR@public.gmane.org>
>> ---
>>
>> Changes since v4:
>>       * Removed support for SND_SOC_DAIFMT_CBS_CFM.
>>       * Fixed coding style for indention.
>>       * Removed variables if it has only one user.
>>       * Assigned ch_size directly.
>>       * Removed oring.
>>       * Put the return false in the switch statement.
>>       * Removed 'Monomix Output' and 'Speaker Source' controls.
>>       * Modified control names per control-names.rst.
>>       * Moved Revision ID check code to i2c_probe function.
>>       * Added 'Current Limit' control.
>>       * Removed 'devm__kfree' function.
>>
>> Changes since v3:
>>       * Combined MAX98926 and MAX98927 binding. Kept existing property name.
>
> This looks fine, but:
>
>> Changes since v2:
>>       * Removed local register read/write function to avoid duplication of ASoC core function.
>>
>>  .../devicetree/bindings/sound/max98925.txt         |  22 -
>>  .../devicetree/bindings/sound/max98926.txt         |  32 -
>>  .../devicetree/bindings/sound/max9892x.txt         |  41 +
>>  sound/soc/codecs/Kconfig                           |   5 +
>>  sound/soc/codecs/Makefile                          |   2 +
>>  sound/soc/codecs/max98927.c                        | 841 +++++++++++++++++++++
>>  sound/soc/codecs/max98927.h                        | 272 +++++++
>>  7 files changed, 1161 insertions(+), 54 deletions(-)
>>  delete mode 100644 Documentation/devicetree/bindings/sound/max98925.txt
>>  delete mode 100644 Documentation/devicetree/bindings/sound/max98926.txt
>>  create mode 100755 Documentation/devicetree/bindings/sound/max9892x.txt
>>  mode change 100644 => 100755 sound/soc/codecs/Kconfig
>>  mode change 100644 => 100755 sound/soc/codecs/Makefile
>>  create mode 100755 sound/soc/codecs/max98927.c
>>  create mode 100755 sound/soc/codecs/max98927.h
>
> These should all be 644 mode.

I've changed the mode to 644. Thank you.

>
> Rob
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

  reply	other threads:[~2017-04-03 17:24 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-03-31  1:16 [PATCH v4] ASoC: Add support for Maxim Integrated MAX98927 Amplifier Ryan Lee
2017-03-31  1:16 ` Ryan Lee
2017-04-03 16:30 ` Rob Herring
2017-04-03 17:24   ` Ryan Lee [this message]
2017-04-03 17:24     ` Ryan Lee
2017-04-06 18:55 ` Applied "ASoC: Add support for Maxim Integrated MAX98927 Amplifier" to the asoc tree Mark Brown
2017-04-06 18:55   ` Mark Brown
2017-04-07 21:29   ` Ryan Lee
2017-04-07 21:29     ` Ryan Lee
2017-04-25 16:24   ` Ryan Lee
2017-04-25 16:24     ` Ryan Lee
2017-04-25 16:28     ` Mark Brown
2017-04-25 16:28       ` Mark Brown
2017-04-25 16:51   ` Ryan Lee
2017-04-25 16:51     ` Ryan Lee
2017-04-26  2:51     ` Ryan Lee
2017-04-26  2:51       ` Ryan Lee

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAN4-ojkdnzp59zMVj8fQj0NBAW-AdNvMt-YhvOMjBnMLv30-rA@mail.gmail.com \
    --to=ryans.lee@maximintegrated.com \
    --cc=KCHSU0@nuvoton.com \
    --cc=Paul.Handrigan@cirrus.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=arnd@arndb.de \
    --cc=axel.lin@ingics.com \
    --cc=bardliao@realtek.com \
    --cc=broonie@kernel.org \
    --cc=ckeepax@opensource.wolfsonmicro.com \
    --cc=devicetree@vger.kernel.org \
    --cc=dgreid@google.com \
    --cc=kuninori.morimoto.gx@renesas.com \
    --cc=lars@metafoo.de \
    --cc=lgirdwood@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=nh6z@nh6z.net \
    --cc=oder_chiou@realtek.com \
    --cc=perex@perex.cz \
    --cc=robh@kernel.org \
    --cc=romain.perier@collabora.com \
    --cc=srinivas.kandagatla@linaro.org \
    --cc=tiwai@suse.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.