From: Anand Moon <linux.amoon@gmail.com>
To: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
Cc: devicetree <devicetree@vger.kernel.org>,
Neil Armstrong <narmstrong@baylibre.com>,
Kevin Hilman <khilman@baylibre.com>,
Kishon Vijay Abraham I <kishon@ti.com>,
Rob Herring <robh+dt@kernel.org>,
linux-amlogic@lists.infradead.org,
linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
Jerome Brunet <jbrunet@baylibre.com>
Subject: Re: [RFCv1 2/3] ARM: dts: meson8b: odroidc1: fix USB power supplies for phy
Date: Mon, 11 Feb 2019 20:38:57 +0530 [thread overview]
Message-ID: <CANAwSgRKgWCyNoDUxrK4asjZ_6z77Rew2nGCg1Yq9m3pi0Amrw@mail.gmail.com> (raw)
In-Reply-To: <CAFBinCBwDg21t+HT6w7CcUgH_aDuwh-UgoPs7GuZo9rABvPDig@mail.gmail.com>
Hi Martin,
On Mon, 11 Feb 2019 at 03:51, Martin Blumenstingl
<martin.blumenstingl@googlemail.com> wrote:
>
> Hi Anand,
>
> On Sat, Feb 9, 2019 at 6:55 PM Anand Moon <linux.amoon@gmail.com> wrote:
> [...]
> > > > But this dose not work setting the usb1_phy to use vbus-supply.
> > > >
> > > > &usb1_phy {
> > > > status = "okay";
> > > > + vbus-supply = <&usb_vbus>;
> > > > };
> > > >
> > > > I am attaching a small patch for testing.
> > > > [0] usbvbus.patch
> > > indeed, this is not working for me either.
> > > I checked my old notes at [0] -> it works for me when setting
> > > "vbus-supply" at the usb controller (not the PHY).
> > >
> > > with the following snippet:
> > > &usb1 {
> > > status = "okay";
> > > vbus-supply = <&usb_vbus>;
> > > };
> > > I get:
> > > # cat /sys/kernel/debug/regulator/regulator_summary | grep -i usb
> > > c90c0000.usb 1 0mA
> > > 0mV 0mV
> > > c90c0000.usb 1 0mA
> > > 0mV 0mV
> > > USB_VBUS 1 1 0 unknown 5000mV 0mA
> > > 5000mV 5000mV
> > > c90c0000.usb 1 0mA
> > > 0mV 0mV
> > >
> > > can you please try this on your board as well?
> > >
> > > > Here is the summary of the above patch.
> > > >
> > > > 1. hot-plugins of usb device is not working.
> > > > 2. only cold/warm boot let the device come up.
> > > > 3. not power is supplied to the usb ports.
> > > > 4. no power module is registered with the regulator summary.
> > > with "vbus-supply" moved to the usb1 node I get the following result:
> > > 1. same: hot-plugins of usb device is not working
> > > 2. different: a reboot doesn't make devices come up
> > > 3. same: no power is supplied to the USB ports (in my case this causes
> > > #2, but it's not clear why there's no power...)
> > > 4. different: the regulator is registered with the USB controller in debugfs
> > >
> > Here the the logs after I applied the above changes
> >
> > [1] https://pastebin.com/rVa8gxNG
> can you please provide the .dts patch for this log?
> I can see the following message in your log:
> [ 1.977367] USB_VBUS: disabling
>
Sorry for the confusion on the logs.
Above logs are generated with below setting.
&usb1 {
status = "okay";
vbus-supply = <&usb_vbus>;
};
> I have tried it with the attached patch, then I get:
> # dmesg | grep VBUS
> #
> # cat /sys/kernel/debug/regulator/regulator_summary
> regulator use open bypass opmode voltage current
> min max
> ---------------------------------------------------------------------------------------
> regulator-dummy 4 3 0 unknown 0mV 0mA
> 0mV 0mV
> c90c0000.usb 1 0mA
> 0mV 0mV
> c90c0000.usb 1 0mA
> 0mV 0mV
> VCCK 1 1 0 unknown 860mV 0mA
> 860mV 1140mV
> cpu0 0 0mA
> 860mV 860mV
> P5V0 3 4 0 unknown 5000mV 0mA
> 5000mV 5000mV
> VCC1V8 2 2 0 unknown 1800mV 0mA
> 1800mV 1800mV
> c1108680.adc 1 0mA
> 0mV 0mV
> c1108e00.mmc 1 0mA
> 1800mV 1950mV
> VCC3V3 2 3 0 unknown 3300mV 0mA
> 3300mV 3300mV
> c1108e00.mmc 1 0mA
> 3300mV 3400mV
> VDD_RTC 0 0 0 unknown 900mV 0mA
> 900mV 900mV
> TFLASH_VDD 1 1 0 unknown 3300mV 0mA
> 3300mV 3300mV
> c1108c20.mmc:slot@1 1 0mA
> 3300mV 3400mV
> DDR_VDDC 0 0 0 unknown 1500mV 0mA
> 1500mV 1500mV
> USB_VBUS 1 1 0 unknown 5000mV 0mA
> 5000mV 5000mV
> c90c0000.usb 1 0mA
> 0mV 0mV
> TF_IO 0 1 0 unknown 3300mV 0mA
> 1800mV 3300mV
> c1108c20.mmc:slot@1 0 0mA
> 0mV 0mV
>
> (my kernel build includes two more changes on top of Kevin's v5.1/dt
> branch which add two new regulators: it enables the RTC and the SDHC
> MMC controller, but these are not related to USB at all)
>
> USB ist still not working for me, but I believe my problem is
> different to yours.
>
>
> Regards
>
> Martin
Can we have other people who can test both the approach for
*vbus-supply* vs *phy-supply* setting.
Then we can conclude on the correct approach.
Honestly I am using power supply from dc jack rather than power via usb otg.
Best Regards
-Anand
WARNING: multiple messages have this Message-ID (diff)
From: Anand Moon <linux.amoon@gmail.com>
To: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
Cc: devicetree <devicetree@vger.kernel.org>,
Neil Armstrong <narmstrong@baylibre.com>,
Kevin Hilman <khilman@baylibre.com>,
Kishon Vijay Abraham I <kishon@ti.com>,
Rob Herring <robh+dt@kernel.org>,
linux-amlogic@lists.infradead.org,
linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
Jerome Brunet <jbrunet@baylibre.com>
Subject: Re: [RFCv1 2/3] ARM: dts: meson8b: odroidc1: fix USB power supplies for phy
Date: Mon, 11 Feb 2019 20:38:57 +0530 [thread overview]
Message-ID: <CANAwSgRKgWCyNoDUxrK4asjZ_6z77Rew2nGCg1Yq9m3pi0Amrw@mail.gmail.com> (raw)
In-Reply-To: <CAFBinCBwDg21t+HT6w7CcUgH_aDuwh-UgoPs7GuZo9rABvPDig@mail.gmail.com>
Hi Martin,
On Mon, 11 Feb 2019 at 03:51, Martin Blumenstingl
<martin.blumenstingl@googlemail.com> wrote:
>
> Hi Anand,
>
> On Sat, Feb 9, 2019 at 6:55 PM Anand Moon <linux.amoon@gmail.com> wrote:
> [...]
> > > > But this dose not work setting the usb1_phy to use vbus-supply.
> > > >
> > > > &usb1_phy {
> > > > status = "okay";
> > > > + vbus-supply = <&usb_vbus>;
> > > > };
> > > >
> > > > I am attaching a small patch for testing.
> > > > [0] usbvbus.patch
> > > indeed, this is not working for me either.
> > > I checked my old notes at [0] -> it works for me when setting
> > > "vbus-supply" at the usb controller (not the PHY).
> > >
> > > with the following snippet:
> > > &usb1 {
> > > status = "okay";
> > > vbus-supply = <&usb_vbus>;
> > > };
> > > I get:
> > > # cat /sys/kernel/debug/regulator/regulator_summary | grep -i usb
> > > c90c0000.usb 1 0mA
> > > 0mV 0mV
> > > c90c0000.usb 1 0mA
> > > 0mV 0mV
> > > USB_VBUS 1 1 0 unknown 5000mV 0mA
> > > 5000mV 5000mV
> > > c90c0000.usb 1 0mA
> > > 0mV 0mV
> > >
> > > can you please try this on your board as well?
> > >
> > > > Here is the summary of the above patch.
> > > >
> > > > 1. hot-plugins of usb device is not working.
> > > > 2. only cold/warm boot let the device come up.
> > > > 3. not power is supplied to the usb ports.
> > > > 4. no power module is registered with the regulator summary.
> > > with "vbus-supply" moved to the usb1 node I get the following result:
> > > 1. same: hot-plugins of usb device is not working
> > > 2. different: a reboot doesn't make devices come up
> > > 3. same: no power is supplied to the USB ports (in my case this causes
> > > #2, but it's not clear why there's no power...)
> > > 4. different: the regulator is registered with the USB controller in debugfs
> > >
> > Here the the logs after I applied the above changes
> >
> > [1] https://pastebin.com/rVa8gxNG
> can you please provide the .dts patch for this log?
> I can see the following message in your log:
> [ 1.977367] USB_VBUS: disabling
>
Sorry for the confusion on the logs.
Above logs are generated with below setting.
&usb1 {
status = "okay";
vbus-supply = <&usb_vbus>;
};
> I have tried it with the attached patch, then I get:
> # dmesg | grep VBUS
> #
> # cat /sys/kernel/debug/regulator/regulator_summary
> regulator use open bypass opmode voltage current
> min max
> ---------------------------------------------------------------------------------------
> regulator-dummy 4 3 0 unknown 0mV 0mA
> 0mV 0mV
> c90c0000.usb 1 0mA
> 0mV 0mV
> c90c0000.usb 1 0mA
> 0mV 0mV
> VCCK 1 1 0 unknown 860mV 0mA
> 860mV 1140mV
> cpu0 0 0mA
> 860mV 860mV
> P5V0 3 4 0 unknown 5000mV 0mA
> 5000mV 5000mV
> VCC1V8 2 2 0 unknown 1800mV 0mA
> 1800mV 1800mV
> c1108680.adc 1 0mA
> 0mV 0mV
> c1108e00.mmc 1 0mA
> 1800mV 1950mV
> VCC3V3 2 3 0 unknown 3300mV 0mA
> 3300mV 3300mV
> c1108e00.mmc 1 0mA
> 3300mV 3400mV
> VDD_RTC 0 0 0 unknown 900mV 0mA
> 900mV 900mV
> TFLASH_VDD 1 1 0 unknown 3300mV 0mA
> 3300mV 3300mV
> c1108c20.mmc:slot@1 1 0mA
> 3300mV 3400mV
> DDR_VDDC 0 0 0 unknown 1500mV 0mA
> 1500mV 1500mV
> USB_VBUS 1 1 0 unknown 5000mV 0mA
> 5000mV 5000mV
> c90c0000.usb 1 0mA
> 0mV 0mV
> TF_IO 0 1 0 unknown 3300mV 0mA
> 1800mV 3300mV
> c1108c20.mmc:slot@1 0 0mA
> 0mV 0mV
>
> (my kernel build includes two more changes on top of Kevin's v5.1/dt
> branch which add two new regulators: it enables the RTC and the SDHC
> MMC controller, but these are not related to USB at all)
>
> USB ist still not working for me, but I believe my problem is
> different to yours.
>
>
> Regards
>
> Martin
Can we have other people who can test both the approach for
*vbus-supply* vs *phy-supply* setting.
Then we can conclude on the correct approach.
Honestly I am using power supply from dc jack rather than power via usb otg.
Best Regards
-Anand
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: Anand Moon <linux.amoon@gmail.com>
To: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
Cc: devicetree <devicetree@vger.kernel.org>,
Neil Armstrong <narmstrong@baylibre.com>,
Kevin Hilman <khilman@baylibre.com>,
Kishon Vijay Abraham I <kishon@ti.com>,
Rob Herring <robh+dt@kernel.org>,
linux-amlogic@lists.infradead.org,
linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
Jerome Brunet <jbrunet@baylibre.com>
Subject: Re: [RFCv1 2/3] ARM: dts: meson8b: odroidc1: fix USB power supplies for phy
Date: Mon, 11 Feb 2019 20:38:57 +0530 [thread overview]
Message-ID: <CANAwSgRKgWCyNoDUxrK4asjZ_6z77Rew2nGCg1Yq9m3pi0Amrw@mail.gmail.com> (raw)
In-Reply-To: <CAFBinCBwDg21t+HT6w7CcUgH_aDuwh-UgoPs7GuZo9rABvPDig@mail.gmail.com>
Hi Martin,
On Mon, 11 Feb 2019 at 03:51, Martin Blumenstingl
<martin.blumenstingl@googlemail.com> wrote:
>
> Hi Anand,
>
> On Sat, Feb 9, 2019 at 6:55 PM Anand Moon <linux.amoon@gmail.com> wrote:
> [...]
> > > > But this dose not work setting the usb1_phy to use vbus-supply.
> > > >
> > > > &usb1_phy {
> > > > status = "okay";
> > > > + vbus-supply = <&usb_vbus>;
> > > > };
> > > >
> > > > I am attaching a small patch for testing.
> > > > [0] usbvbus.patch
> > > indeed, this is not working for me either.
> > > I checked my old notes at [0] -> it works for me when setting
> > > "vbus-supply" at the usb controller (not the PHY).
> > >
> > > with the following snippet:
> > > &usb1 {
> > > status = "okay";
> > > vbus-supply = <&usb_vbus>;
> > > };
> > > I get:
> > > # cat /sys/kernel/debug/regulator/regulator_summary | grep -i usb
> > > c90c0000.usb 1 0mA
> > > 0mV 0mV
> > > c90c0000.usb 1 0mA
> > > 0mV 0mV
> > > USB_VBUS 1 1 0 unknown 5000mV 0mA
> > > 5000mV 5000mV
> > > c90c0000.usb 1 0mA
> > > 0mV 0mV
> > >
> > > can you please try this on your board as well?
> > >
> > > > Here is the summary of the above patch.
> > > >
> > > > 1. hot-plugins of usb device is not working.
> > > > 2. only cold/warm boot let the device come up.
> > > > 3. not power is supplied to the usb ports.
> > > > 4. no power module is registered with the regulator summary.
> > > with "vbus-supply" moved to the usb1 node I get the following result:
> > > 1. same: hot-plugins of usb device is not working
> > > 2. different: a reboot doesn't make devices come up
> > > 3. same: no power is supplied to the USB ports (in my case this causes
> > > #2, but it's not clear why there's no power...)
> > > 4. different: the regulator is registered with the USB controller in debugfs
> > >
> > Here the the logs after I applied the above changes
> >
> > [1] https://pastebin.com/rVa8gxNG
> can you please provide the .dts patch for this log?
> I can see the following message in your log:
> [ 1.977367] USB_VBUS: disabling
>
Sorry for the confusion on the logs.
Above logs are generated with below setting.
&usb1 {
status = "okay";
vbus-supply = <&usb_vbus>;
};
> I have tried it with the attached patch, then I get:
> # dmesg | grep VBUS
> #
> # cat /sys/kernel/debug/regulator/regulator_summary
> regulator use open bypass opmode voltage current
> min max
> ---------------------------------------------------------------------------------------
> regulator-dummy 4 3 0 unknown 0mV 0mA
> 0mV 0mV
> c90c0000.usb 1 0mA
> 0mV 0mV
> c90c0000.usb 1 0mA
> 0mV 0mV
> VCCK 1 1 0 unknown 860mV 0mA
> 860mV 1140mV
> cpu0 0 0mA
> 860mV 860mV
> P5V0 3 4 0 unknown 5000mV 0mA
> 5000mV 5000mV
> VCC1V8 2 2 0 unknown 1800mV 0mA
> 1800mV 1800mV
> c1108680.adc 1 0mA
> 0mV 0mV
> c1108e00.mmc 1 0mA
> 1800mV 1950mV
> VCC3V3 2 3 0 unknown 3300mV 0mA
> 3300mV 3300mV
> c1108e00.mmc 1 0mA
> 3300mV 3400mV
> VDD_RTC 0 0 0 unknown 900mV 0mA
> 900mV 900mV
> TFLASH_VDD 1 1 0 unknown 3300mV 0mA
> 3300mV 3300mV
> c1108c20.mmc:slot@1 1 0mA
> 3300mV 3400mV
> DDR_VDDC 0 0 0 unknown 1500mV 0mA
> 1500mV 1500mV
> USB_VBUS 1 1 0 unknown 5000mV 0mA
> 5000mV 5000mV
> c90c0000.usb 1 0mA
> 0mV 0mV
> TF_IO 0 1 0 unknown 3300mV 0mA
> 1800mV 3300mV
> c1108c20.mmc:slot@1 0 0mA
> 0mV 0mV
>
> (my kernel build includes two more changes on top of Kevin's v5.1/dt
> branch which add two new regulators: it enables the RTC and the SDHC
> MMC controller, but these are not related to USB at all)
>
> USB ist still not working for me, but I believe my problem is
> different to yours.
>
>
> Regards
>
> Martin
Can we have other people who can test both the approach for
*vbus-supply* vs *phy-supply* setting.
Then we can conclude on the correct approach.
Honestly I am using power supply from dc jack rather than power via usb otg.
Best Regards
-Anand
_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic
next prev parent reply other threads:[~2019-02-11 15:08 UTC|newest]
Thread overview: 73+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-23 15:12 [RFCv1 0/3] Odroid c1+ usb fixs Anand Moon
2019-01-23 15:12 ` Anand Moon
2019-01-23 15:12 ` Anand Moon
2019-01-23 15:12 ` [RFCv1 1/3] phy: meson8b-usb2: Enable otg phy controller on Meson8b SoCs Anand Moon
2019-01-23 15:12 ` Anand Moon
2019-01-23 15:12 ` Anand Moon
2019-02-04 13:20 ` Martin Blumenstingl
2019-02-04 13:20 ` Martin Blumenstingl
2019-02-04 13:20 ` Martin Blumenstingl
2019-02-04 20:02 ` Anand Moon
2019-02-04 20:02 ` Anand Moon
2019-02-04 20:02 ` Anand Moon
2019-02-04 20:26 ` Martin Blumenstingl
2019-02-04 20:26 ` Martin Blumenstingl
2019-02-04 20:26 ` Martin Blumenstingl
2019-02-05 19:52 ` Anand Moon
2019-02-05 19:52 ` Anand Moon
2019-02-05 19:52 ` Anand Moon
2019-02-06 11:48 ` Martin Blumenstingl
2019-02-06 11:48 ` Martin Blumenstingl
2019-02-06 11:48 ` Martin Blumenstingl
2019-02-07 6:41 ` Anand Moon
2019-02-07 6:41 ` Anand Moon
2019-02-07 6:41 ` Anand Moon
2019-01-23 15:12 ` [RFCv1 2/3] ARM: dts: meson8b: odroidc1: fix USB power supplies for phy Anand Moon
2019-01-23 15:12 ` Anand Moon
2019-01-23 15:12 ` Anand Moon
2019-02-04 13:29 ` Martin Blumenstingl
2019-02-04 13:29 ` Martin Blumenstingl
2019-02-04 13:29 ` Martin Blumenstingl
2019-02-04 20:03 ` Anand Moon
2019-02-04 20:03 ` Anand Moon
2019-02-04 20:03 ` Anand Moon
2019-02-04 20:35 ` Martin Blumenstingl
2019-02-04 20:35 ` Martin Blumenstingl
2019-02-04 20:35 ` Martin Blumenstingl
2019-02-05 19:52 ` Anand Moon
2019-02-05 19:52 ` Anand Moon
2019-02-05 19:52 ` Anand Moon
2019-02-06 11:28 ` Martin Blumenstingl
2019-02-06 11:28 ` Martin Blumenstingl
2019-02-06 11:28 ` Martin Blumenstingl
2019-02-07 6:32 ` Anand Moon
2019-02-07 6:32 ` Anand Moon
2019-02-09 0:36 ` Martin Blumenstingl
2019-02-09 0:36 ` Martin Blumenstingl
2019-02-09 0:36 ` Martin Blumenstingl
2019-02-09 17:55 ` Anand Moon
2019-02-09 17:55 ` Anand Moon
2019-02-09 17:55 ` Anand Moon
2019-02-10 22:21 ` Martin Blumenstingl
2019-02-10 22:21 ` Martin Blumenstingl
2019-02-11 15:08 ` Anand Moon [this message]
2019-02-11 15:08 ` Anand Moon
2019-02-11 15:08 ` Anand Moon
2019-02-17 14:26 ` Martin Blumenstingl
2019-02-17 14:26 ` Martin Blumenstingl
2019-02-17 14:26 ` Martin Blumenstingl
2019-01-23 15:12 ` [RFCv1 3/3] ARM: dts: meson8b: odroidc1: enable the OTG capable USB controller Anand Moon
2019-01-23 15:12 ` Anand Moon
2019-01-23 15:12 ` Anand Moon
2019-02-04 13:51 ` [RFCv1 0/3] Odroid c1+ usb fixs Martin Blumenstingl
2019-02-04 13:51 ` Martin Blumenstingl
2019-02-04 13:51 ` Martin Blumenstingl
2019-02-04 20:04 ` Anand Moon
2019-02-04 20:04 ` Anand Moon
2019-02-04 20:04 ` Anand Moon
2019-02-04 20:38 ` Martin Blumenstingl
2019-02-04 20:38 ` Martin Blumenstingl
2019-02-04 20:38 ` Martin Blumenstingl
2019-02-05 19:53 ` Anand Moon
2019-02-05 19:53 ` Anand Moon
2019-02-05 19:53 ` Anand Moon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CANAwSgRKgWCyNoDUxrK4asjZ_6z77Rew2nGCg1Yq9m3pi0Amrw@mail.gmail.com \
--to=linux.amoon@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=jbrunet@baylibre.com \
--cc=khilman@baylibre.com \
--cc=kishon@ti.com \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=martin.blumenstingl@googlemail.com \
--cc=narmstrong@baylibre.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.