All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mathieu Poirier <mathieu.poirier@linaro.org>
To: Arvind Yadav <arvind.yadav.cs@gmail.com>
Cc: Greg KH <gregkh@linuxfoundation.org>,
	"linux-arm-kernel@lists.infradead.org" 
	<linux-arm-kernel@lists.infradead.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] hwtracing: coresight: constify attribute_group structures.
Date: Fri, 7 Jul 2017 09:28:58 -0600	[thread overview]
Message-ID: <CANLsYkxrT+d-HLpPAOM_pZVWfDgTU92Q-njo_0e=K-auYL=BYA@mail.gmail.com> (raw)
In-Reply-To: <97ff1c3f7145b0e4326fbbb246579cd5382880b3.1499233557.git.arvind.yadav.cs@gmail.com>

On 4 July 2017 at 23:49, Arvind Yadav <arvind.yadav.cs@gmail.com> wrote:
> attribute_groups are not supposed to change at runtime. All functions
> working with attribute_groups provided by <linux/sysfs.h> work with const
> attribute_group. So mark the non-const structs as const.
>
> File size before:
>   text     data     bss     dec     hex filename
>    2573     288     296    3157     c55 coresight-etm-perf.o
>
> File size After adding 'const':
>    text    data     bss     dec     hex filename
>    2613     224     296    3133     c3d coresight-etm-perf.o

Hi Arvind,

Did you find this using an automated tool or simply stumbled on it
while reviewing the code?  In case of the former it is usually a good
idea to specify which tool was used in the change log.

Thanks,
Mathieu

>
> Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
> ---
>  drivers/hwtracing/coresight/coresight-etm-perf.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/hwtracing/coresight/coresight-etm-perf.c b/drivers/hwtracing/coresight/coresight-etm-perf.c
> index 288a423..e97775d 100644
> --- a/drivers/hwtracing/coresight/coresight-etm-perf.c
> +++ b/drivers/hwtracing/coresight/coresight-etm-perf.c
> @@ -60,7 +60,7 @@ struct etm_event_data {
>         NULL,
>  };
>
> -static struct attribute_group etm_pmu_format_group = {
> +static const struct attribute_group etm_pmu_format_group = {
>         .name   = "format",
>         .attrs  = etm_config_formats_attr,
>  };
> --
> 1.9.1
>

WARNING: multiple messages have this Message-ID (diff)
From: mathieu.poirier@linaro.org (Mathieu Poirier)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] hwtracing: coresight: constify attribute_group structures.
Date: Fri, 7 Jul 2017 09:28:58 -0600	[thread overview]
Message-ID: <CANLsYkxrT+d-HLpPAOM_pZVWfDgTU92Q-njo_0e=K-auYL=BYA@mail.gmail.com> (raw)
In-Reply-To: <97ff1c3f7145b0e4326fbbb246579cd5382880b3.1499233557.git.arvind.yadav.cs@gmail.com>

On 4 July 2017 at 23:49, Arvind Yadav <arvind.yadav.cs@gmail.com> wrote:
> attribute_groups are not supposed to change at runtime. All functions
> working with attribute_groups provided by <linux/sysfs.h> work with const
> attribute_group. So mark the non-const structs as const.
>
> File size before:
>   text     data     bss     dec     hex filename
>    2573     288     296    3157     c55 coresight-etm-perf.o
>
> File size After adding 'const':
>    text    data     bss     dec     hex filename
>    2613     224     296    3133     c3d coresight-etm-perf.o

Hi Arvind,

Did you find this using an automated tool or simply stumbled on it
while reviewing the code?  In case of the former it is usually a good
idea to specify which tool was used in the change log.

Thanks,
Mathieu

>
> Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
> ---
>  drivers/hwtracing/coresight/coresight-etm-perf.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/hwtracing/coresight/coresight-etm-perf.c b/drivers/hwtracing/coresight/coresight-etm-perf.c
> index 288a423..e97775d 100644
> --- a/drivers/hwtracing/coresight/coresight-etm-perf.c
> +++ b/drivers/hwtracing/coresight/coresight-etm-perf.c
> @@ -60,7 +60,7 @@ struct etm_event_data {
>         NULL,
>  };
>
> -static struct attribute_group etm_pmu_format_group = {
> +static const struct attribute_group etm_pmu_format_group = {
>         .name   = "format",
>         .attrs  = etm_config_formats_attr,
>  };
> --
> 1.9.1
>

  reply	other threads:[~2017-07-07 15:29 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-07-05  5:49 [PATCH] hwtracing: coresight: constify attribute_group structures Arvind Yadav
2017-07-05  5:49 ` Arvind Yadav
2017-07-07 15:28 ` Mathieu Poirier [this message]
2017-07-07 15:28   ` Mathieu Poirier
2017-07-10  5:09   ` Arvind Yadav
2017-07-10  5:09     ` Arvind Yadav
2017-07-10 17:01 ` Mathieu Poirier
2017-07-10 17:01   ` Mathieu Poirier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CANLsYkxrT+d-HLpPAOM_pZVWfDgTU92Q-njo_0e=K-auYL=BYA@mail.gmail.com' \
    --to=mathieu.poirier@linaro.org \
    --cc=arvind.yadav.cs@gmail.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.