From: Mathieu Poirier <mathieu.poirier@linaro.org> To: Rabin Vincent <rabin@rab.in> Cc: Greg KH <gregkh@linuxfoundation.org>, Alexander Shishkin <alexander.shishkin@linux.intel.com>, Chunyan Zhang <zhang.chunyan@linaro.org>, Mike Leach <mike.leach@arm.com>, "Jeremiassen, Tor" <tor@ti.com>, Al Grant <al.grant@arm.com>, fainelli@broadcom.com, "linux-arm-kernel@lists.infradead.org" <linux-arm-kernel@lists.infradead.org>, linux-doc@vger.kernel.org, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>, Peter Zijlstra <a.p.zijlstra@chello.nl>, Ingo Molnar <mingo@redhat.com>, Arnaldo Carvalho de Melo <acme@kernel.org> Subject: Re: [PATCH V7 24/24] perf tools: adding coresight etm PMU record capabilities Date: Wed, 23 Dec 2015 09:46:29 -0700 [thread overview] Message-ID: <CANLsYkyZkb4=DwFGpPCsnny1KKiHd0reQSJxFniqerdB3P0shg@mail.gmail.com> (raw) In-Reply-To: <20151219172705.GC2437@debian> On 19 December 2015 at 10:27, Rabin Vincent <rabin@rab.in> wrote: > On Fri, Dec 18, 2015 at 01:59:20PM -0700, Mathieu Poirier wrote: >> +struct auxtrace_record >> +*auxtrace_record__init(struct perf_evlist *evlist, int *err) >> +{ >> + struct perf_pmu *cs_etm_pmu; >> + struct perf_evsel *evsel; >> + bool found_etm = false; >> + >> + cs_etm_pmu = perf_pmu__find(CORESIGHT_ETM_PMU_NAME); >> + >> + if (evlist) { >> + evlist__for_each(evlist, evsel) { >> + if (cs_etm_pmu && >> + evsel->attr.type == cs_etm_pmu->type) >> + found_etm = true; >> + } >> + } >> + >> + if (found_etm) >> + return cs_etm_record_init(err); >> + >> + *err = -EINVAL; > > This should not set an error code when found_etm is false. Otherwise > any attempt to uses perf record without a cs_etm event enabled errors > out. Yes, you're right. Many thanks for the thorough review, Mathieu > >> + return NULL; >> +}
WARNING: multiple messages have this Message-ID (diff)
From: mathieu.poirier@linaro.org (Mathieu Poirier) To: linux-arm-kernel@lists.infradead.org Subject: [PATCH V7 24/24] perf tools: adding coresight etm PMU record capabilities Date: Wed, 23 Dec 2015 09:46:29 -0700 [thread overview] Message-ID: <CANLsYkyZkb4=DwFGpPCsnny1KKiHd0reQSJxFniqerdB3P0shg@mail.gmail.com> (raw) In-Reply-To: <20151219172705.GC2437@debian> On 19 December 2015 at 10:27, Rabin Vincent <rabin@rab.in> wrote: > On Fri, Dec 18, 2015 at 01:59:20PM -0700, Mathieu Poirier wrote: >> +struct auxtrace_record >> +*auxtrace_record__init(struct perf_evlist *evlist, int *err) >> +{ >> + struct perf_pmu *cs_etm_pmu; >> + struct perf_evsel *evsel; >> + bool found_etm = false; >> + >> + cs_etm_pmu = perf_pmu__find(CORESIGHT_ETM_PMU_NAME); >> + >> + if (evlist) { >> + evlist__for_each(evlist, evsel) { >> + if (cs_etm_pmu && >> + evsel->attr.type == cs_etm_pmu->type) >> + found_etm = true; >> + } >> + } >> + >> + if (found_etm) >> + return cs_etm_record_init(err); >> + >> + *err = -EINVAL; > > This should not set an error code when found_etm is false. Otherwise > any attempt to uses perf record without a cs_etm event enabled errors > out. Yes, you're right. Many thanks for the thorough review, Mathieu > >> + return NULL; >> +}
next prev parent reply other threads:[~2015-12-23 16:46 UTC|newest] Thread overview: 84+ messages / expand[flat|nested] mbox.gz Atom feed top 2015-12-18 20:58 [PATCH V7 00/24] Coresight integration with perf Mathieu Poirier 2015-12-18 20:58 ` Mathieu Poirier 2015-12-18 20:58 ` [PATCH V7 01/24] coresight: implementing 'cpu_id()' API Mathieu Poirier 2015-12-18 20:58 ` Mathieu Poirier 2015-12-18 20:58 ` [PATCH V7 02/24] coresight: associating path with session rather than tracer Mathieu Poirier 2015-12-18 20:58 ` Mathieu Poirier 2015-12-20 15:29 ` Rabin Vincent 2015-12-20 15:29 ` Rabin Vincent 2015-12-23 16:23 ` Mathieu Poirier 2015-12-23 16:23 ` Mathieu Poirier 2016-01-04 18:24 ` Mathieu Poirier 2016-01-04 18:24 ` Mathieu Poirier 2016-01-05 13:15 ` Rabin Vincent 2016-01-05 13:15 ` Rabin Vincent [not found] ` <CANLsYkwN=SOnfDfd8oF-2Z5Ef8oTPao6H_auQhoMpVAnokYkrg@mail.gmail.com> 2016-01-10 15:43 ` Rabin Vincent 2016-01-10 15:43 ` Rabin Vincent 2016-01-13 21:47 ` Mathieu Poirier 2016-01-13 21:47 ` Mathieu Poirier 2016-01-16 13:54 ` Rabin Vincent 2016-01-16 13:54 ` Rabin Vincent 2016-01-19 23:54 ` Mathieu Poirier 2016-01-19 23:54 ` Mathieu Poirier 2015-12-18 20:58 ` [PATCH V7 03/24] coresight: add API to get sink from path Mathieu Poirier 2015-12-18 20:58 ` Mathieu Poirier 2015-12-18 20:59 ` [PATCH V7 04/24] coresight: moving PM runtime operations to core framework Mathieu Poirier 2015-12-18 20:59 ` Mathieu Poirier 2015-12-19 17:13 ` Rabin Vincent 2015-12-19 17:13 ` Rabin Vincent 2015-12-23 16:27 ` Mathieu Poirier 2015-12-23 16:27 ` Mathieu Poirier 2015-12-24 19:20 ` Rabin Vincent 2015-12-24 19:20 ` Rabin Vincent 2015-12-18 20:59 ` [PATCH V7 05/24] coresight: etm3x: moving etm_readl/writel to header file Mathieu Poirier 2015-12-18 20:59 ` Mathieu Poirier 2015-12-18 20:59 ` [PATCH V7 06/24] coresight: etm3x: moving sysFS entries to dedicated file Mathieu Poirier 2015-12-18 20:59 ` Mathieu Poirier 2015-12-18 20:59 ` [PATCH V7 07/24] coresight: etm3x: unlocking tracers in default arch init Mathieu Poirier 2015-12-18 20:59 ` Mathieu Poirier 2015-12-18 20:59 ` [PATCH V7 08/24] coresight: etm3x: splitting struct etm_drvdata Mathieu Poirier 2015-12-18 20:59 ` Mathieu Poirier 2015-12-18 20:59 ` [PATCH V7 09/24] coresight: etm3x: adding operation mode for etm_enable() Mathieu Poirier 2015-12-18 20:59 ` Mathieu Poirier 2015-12-18 20:59 ` [PATCH V7 10/24] coresight: etm3x: set progbit to stop trace collection Mathieu Poirier 2015-12-18 20:59 ` Mathieu Poirier 2015-12-18 20:59 ` [PATCH V7 11/24] coresight: etm3x: changing default trace configuration Mathieu Poirier 2015-12-18 20:59 ` Mathieu Poirier 2015-12-18 20:59 ` [PATCH V7 12/24] coresight: etm3x: consolidating initial config Mathieu Poirier 2015-12-18 20:59 ` Mathieu Poirier 2015-12-18 20:59 ` [PATCH V7 13/24] coresight: etm3x: implementing user/kernel mode tracing Mathieu Poirier 2015-12-18 20:59 ` Mathieu Poirier 2015-12-18 20:59 ` [PATCH V7 14/24] coresight: etm3x: implementing perf_enable/disable() API Mathieu Poirier 2015-12-18 20:59 ` Mathieu Poirier 2015-12-18 20:59 ` [PATCH V7 15/24] coresight: etb10: moving to local atomic operations Mathieu Poirier 2015-12-18 20:59 ` Mathieu Poirier 2015-12-18 20:59 ` [PATCH V7 16/24] coresight: etb10: adding operation mode for sink->enable() Mathieu Poirier 2015-12-18 20:59 ` Mathieu Poirier 2015-12-18 20:59 ` [PATCH V7 17/24] coresight: etb10: implementing AUX space API Mathieu Poirier 2015-12-18 20:59 ` Mathieu Poirier 2015-12-19 17:23 ` Rabin Vincent 2015-12-19 17:23 ` Rabin Vincent 2015-12-23 16:33 ` Mathieu Poirier 2015-12-23 16:33 ` Mathieu Poirier 2015-12-18 20:59 ` [PATCH V7 18/24] coresight: updating documentation to reflect integration with perf Mathieu Poirier 2015-12-18 20:59 ` Mathieu Poirier 2015-12-18 20:59 ` [PATCH V7 19/24] coresight: etm-perf: new PMU driver for ETM tracers Mathieu Poirier 2015-12-18 20:59 ` Mathieu Poirier 2015-12-18 20:59 ` [PATCH V7 20/24] coresight: introducing a global trace ID function Mathieu Poirier 2015-12-18 20:59 ` Mathieu Poirier 2015-12-18 20:59 ` [PATCH V7 21/24] perf tools: making function set_max_cpu_num() non static Mathieu Poirier 2015-12-18 20:59 ` Mathieu Poirier 2015-12-18 20:59 ` [PATCH V7 22/24] perf tools: adding perf_evlist to *info_priv_size() Mathieu Poirier 2015-12-18 20:59 ` Mathieu Poirier 2015-12-18 20:59 ` [PATCH V7 23/24] perf tools: making coresight PMU listable Mathieu Poirier 2015-12-18 20:59 ` Mathieu Poirier 2015-12-18 20:59 ` [PATCH V7 24/24] perf tools: adding coresight etm PMU record capabilities Mathieu Poirier 2015-12-18 20:59 ` Mathieu Poirier 2015-12-19 17:27 ` Rabin Vincent 2015-12-19 17:27 ` Rabin Vincent 2015-12-23 16:46 ` Mathieu Poirier [this message] 2015-12-23 16:46 ` Mathieu Poirier 2015-12-19 17:42 ` [PATCH V7 00/24] Coresight integration with perf Rabin Vincent 2015-12-19 17:42 ` Rabin Vincent 2015-12-23 16:29 ` Mathieu Poirier 2015-12-23 16:29 ` Mathieu Poirier
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to='CANLsYkyZkb4=DwFGpPCsnny1KKiHd0reQSJxFniqerdB3P0shg@mail.gmail.com' \ --to=mathieu.poirier@linaro.org \ --cc=a.p.zijlstra@chello.nl \ --cc=acme@kernel.org \ --cc=al.grant@arm.com \ --cc=alexander.shishkin@linux.intel.com \ --cc=fainelli@broadcom.com \ --cc=gregkh@linuxfoundation.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-doc@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=mike.leach@arm.com \ --cc=mingo@redhat.com \ --cc=rabin@rab.in \ --cc=tor@ti.com \ --cc=zhang.chunyan@linaro.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.