All of lore.kernel.org
 help / color / mirror / Atom feed
From: Michel Lespinasse <walken@google.com>
To: Jason Gunthorpe <jgg@ziepe.ca>
Cc: Andrew Morton <akpm@linux-foundation.org>,
	linux-mm <linux-mm@kvack.org>,
	LKML <linux-kernel@vger.kernel.org>,
	Peter Zijlstra <peterz@infradead.org>,
	Laurent Dufour <ldufour@linux.ibm.com>,
	Vlastimil Babka <vbabka@suse.cz>,
	Matthew Wilcox <willy@infradead.org>,
	Liam Howlett <Liam.Howlett@oracle.com>,
	Jerome Glisse <jglisse@redhat.com>,
	Davidlohr Bueso <dave@stgolabs.net>,
	David Rientjes <rientjes@google.com>,
	Hugh Dickins <hughd@google.com>, Ying Han <yinghan@google.com>,
	Markus Elfring <Markus.Elfring@web.de>
Subject: Re: [PATCH v2 01/10] mmap locking API: initial implementation as rwsem wrappers
Date: Fri, 27 Mar 2020 14:52:09 -0700	[thread overview]
Message-ID: <CANN689EDuc-9tcBcOOP+4CWeAxjKJq95yxJtZXvCo3H0GBcyrQ@mail.gmail.com> (raw)
In-Reply-To: <20200327121625.GS20941@ziepe.ca>

On Fri, Mar 27, 2020 at 5:16 AM Jason Gunthorpe <jgg@ziepe.ca> wrote:
>
> On Thu, Mar 26, 2020 at 07:10:49PM -0700, Michel Lespinasse wrote:
>
> > +static inline bool mmap_is_locked(struct mm_struct *mm)
> > +{
> > +     return rwsem_is_locked(&mm->mmap_sem) != 0;
> > +}
>
> I didn't notice any callers to this in the series? Can it be deleted?

Good catch. Yes, it should be deleted. There were 5 uses in v1 of this
patchset and I got rid of these in v2 of the patchset, but forgot to
actually remove the function definition here.

-- 
Michel "Walken" Lespinasse
A program is never fully debugged until the last user dies.

  reply	other threads:[~2020-03-27 21:52 UTC|newest]

Thread overview: 41+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-03-27  2:10 [PATCH v2 00/10] Add a new mmap locking API wrapping mmap_sem calls Michel Lespinasse
2020-03-27  2:10 ` Michel Lespinasse
2020-03-27  2:10 ` [PATCH v2 01/10] mmap locking API: initial implementation as rwsem wrappers Michel Lespinasse
2020-03-27  2:10   ` Michel Lespinasse
2020-03-27 12:16   ` Jason Gunthorpe
2020-03-27 21:52     ` Michel Lespinasse [this message]
2020-03-27 21:52       ` Michel Lespinasse
2020-03-27  2:10 ` [PATCH v2 02/10] MMU notifier: use the new mmap locking API Michel Lespinasse
2020-03-27  2:10   ` Michel Lespinasse
2020-03-27  2:10 ` [PATCH v2 03/10] DMA reservations: " Michel Lespinasse
2020-03-27  2:10   ` Michel Lespinasse
2020-03-27  2:10 ` [PATCH v2 04/10] mmap locking API: use coccinelle to convert mmap_sem rwsem call sites Michel Lespinasse
2020-03-27  2:10   ` Michel Lespinasse
2020-03-27  7:22   ` Markus Elfring
2020-03-27  7:22     ` [Cocci] " Markus Elfring
2020-03-27  7:44     ` Michel Lespinasse
2020-03-27  7:44       ` [Cocci] " Michel Lespinasse
2020-03-27  7:44       ` Michel Lespinasse
2020-03-27  8:00       ` [v2 " Markus Elfring
2020-03-27  8:00         ` [Cocci] " Markus Elfring
2020-03-27  8:08         ` Michel Lespinasse
2020-03-27  8:08           ` [Cocci] " Michel Lespinasse
2020-03-27  8:08           ` Michel Lespinasse
2020-03-27  2:10 ` [PATCH v2 05/10] mmap locking API: convert mmap_sem call sites missed by coccinelle Michel Lespinasse
2020-03-27  2:10   ` Michel Lespinasse
2020-03-27  8:21   ` Markus Elfring
2020-03-27  8:21     ` [Cocci] " Markus Elfring
2020-03-27  2:10 ` [PATCH v2 06/10] mmap locking API: convert nested write lock sites Michel Lespinasse
2020-03-27  2:10   ` Michel Lespinasse
2020-03-27  2:10 ` [PATCH v2 07/10] mmap locking API: add mmap_read_release() and mmap_read_unlock_non_owner() Michel Lespinasse
2020-03-27  2:10   ` Michel Lespinasse
2020-03-27  4:46   ` Davidlohr Bueso
2020-03-27  5:09     ` Michel Lespinasse
2020-03-27  5:09       ` Michel Lespinasse
2020-03-27  2:10 ` [PATCH v2 08/10] mmap locking API: add MMAP_LOCK_INITIALIZER Michel Lespinasse
2020-03-27  2:10   ` Michel Lespinasse
2020-03-27  2:10 ` [PATCH v2 09/10] mmap locking API: use lockdep_assert_held Michel Lespinasse
2020-03-27  2:10   ` Michel Lespinasse
2020-03-27  4:48   ` Davidlohr Bueso
2020-03-27  2:10 ` [PATCH v2 10/10] mmap locking API: rename mmap_sem to mmap_lock Michel Lespinasse
2020-03-27  2:10   ` Michel Lespinasse

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CANN689EDuc-9tcBcOOP+4CWeAxjKJq95yxJtZXvCo3H0GBcyrQ@mail.gmail.com \
    --to=walken@google.com \
    --cc=Liam.Howlett@oracle.com \
    --cc=Markus.Elfring@web.de \
    --cc=akpm@linux-foundation.org \
    --cc=dave@stgolabs.net \
    --cc=hughd@google.com \
    --cc=jgg@ziepe.ca \
    --cc=jglisse@redhat.com \
    --cc=ldufour@linux.ibm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=peterz@infradead.org \
    --cc=rientjes@google.com \
    --cc=vbabka@suse.cz \
    --cc=willy@infradead.org \
    --cc=yinghan@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.