All of lore.kernel.org
 help / color / mirror / Atom feed
From: Markus Elfring <Markus.Elfring@web.de>
To: Michel Lespinasse <walken@google.com>, linux-mm <linux-mm@kvack.org>
Cc: LKML <linux-kernel@vger.kernel.org>,
	Coccinelle <cocci@systeme.lip6.fr>,
	Andrew Morton <akpm@linux-foundation.org>,
	Vlastimil Babka <vbabka@suse.cz>,
	Matthew Wilcox <willy@infradead.org>,
	Liam Howlett <Liam.Howlett@oracle.com>,
	Jerome Glisse <jglisse@redhat.com>,
	Davidlohr Bueso <dave@stgolabs.net>,
	David Rientjes <rientjes@google.com>,
	Hugh Dickins <hughd@google.com>, Jason Gunthorpe <jgg@ziepe.ca>,
	Peter Zijlstra <peterz@infradead.org>,
	Laurent Dufour <ldufour@linux.ibm.com>,
	Ying Han <yinghan@google.com>
Subject: Re: [PATCH v2 04/10] mmap locking API: use coccinelle to convert mmap_sem rwsem call sites
Date: Fri, 27 Mar 2020 08:22:09 +0100	[thread overview]
Message-ID: <d780d91f-43fa-b2ec-1a08-80013b153a56@web.de> (raw)
In-Reply-To: <20200327021058.221911-5-walken@google.com>

> This change converts the existing mmap_sem rwsem calls to use the new
> mmap locking API instead.
>
> The change is generated using coccinelle with the following rules:

Would you like to apply only a single SmPL rule here?


> // spatch --sp-file mmap_lock_api.cocci --in-place --include-headers --dir .

Command parameters like “--jobs 8 --chunksize 1” can be also helpful
for a parallel execution of the desired software transformation.

I suggest to consider another possibility for a bit of fine-tuning in the shown
SmPL script if you would eventually care for nicer run time characteristics
for the application of such a SmPL disjunction.
How do you think about to order the elements according to a probable
function call frequency?

Regards,
Markus

WARNING: multiple messages have this Message-ID (diff)
From: Markus Elfring <Markus.Elfring@web.de>
To: Michel Lespinasse <walken@google.com>, linux-mm <linux-mm@kvack.org>
Cc: Davidlohr Bueso <dave@stgolabs.net>,
	Peter Zijlstra <peterz@infradead.org>,
	Hugh Dickins <hughd@google.com>,
	LKML <linux-kernel@vger.kernel.org>,
	Liam Howlett <Liam.Howlett@oracle.com>,
	Jason Gunthorpe <jgg@ziepe.ca>,
	Matthew Wilcox <willy@infradead.org>,
	Ying Han <yinghan@google.com>,
	David Rientjes <rientjes@google.com>,
	Andrew Morton <akpm@linux-foundation.org>,
	Laurent Dufour <ldufour@linux.ibm.com>,
	Coccinelle <cocci@systeme.lip6.fr>,
	Vlastimil Babka <vbabka@suse.cz>
Subject: Re: [Cocci] [PATCH v2 04/10] mmap locking API: use coccinelle to convert mmap_sem rwsem call sites
Date: Fri, 27 Mar 2020 08:22:09 +0100	[thread overview]
Message-ID: <d780d91f-43fa-b2ec-1a08-80013b153a56@web.de> (raw)
In-Reply-To: <20200327021058.221911-5-walken@google.com>

> This change converts the existing mmap_sem rwsem calls to use the new
> mmap locking API instead.
>
> The change is generated using coccinelle with the following rules:

Would you like to apply only a single SmPL rule here?


> // spatch --sp-file mmap_lock_api.cocci --in-place --include-headers --dir .

Command parameters like “--jobs 8 --chunksize 1” can be also helpful
for a parallel execution of the desired software transformation.

I suggest to consider another possibility for a bit of fine-tuning in the shown
SmPL script if you would eventually care for nicer run time characteristics
for the application of such a SmPL disjunction.
How do you think about to order the elements according to a probable
function call frequency?

Regards,
Markus
_______________________________________________
Cocci mailing list
Cocci@systeme.lip6.fr
https://systeme.lip6.fr/mailman/listinfo/cocci

  reply	other threads:[~2020-03-27  7:22 UTC|newest]

Thread overview: 41+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-03-27  2:10 [PATCH v2 00/10] Add a new mmap locking API wrapping mmap_sem calls Michel Lespinasse
2020-03-27  2:10 ` Michel Lespinasse
2020-03-27  2:10 ` [PATCH v2 01/10] mmap locking API: initial implementation as rwsem wrappers Michel Lespinasse
2020-03-27  2:10   ` Michel Lespinasse
2020-03-27 12:16   ` Jason Gunthorpe
2020-03-27 21:52     ` Michel Lespinasse
2020-03-27 21:52       ` Michel Lespinasse
2020-03-27  2:10 ` [PATCH v2 02/10] MMU notifier: use the new mmap locking API Michel Lespinasse
2020-03-27  2:10   ` Michel Lespinasse
2020-03-27  2:10 ` [PATCH v2 03/10] DMA reservations: " Michel Lespinasse
2020-03-27  2:10   ` Michel Lespinasse
2020-03-27  2:10 ` [PATCH v2 04/10] mmap locking API: use coccinelle to convert mmap_sem rwsem call sites Michel Lespinasse
2020-03-27  2:10   ` Michel Lespinasse
2020-03-27  7:22   ` Markus Elfring [this message]
2020-03-27  7:22     ` [Cocci] " Markus Elfring
2020-03-27  7:44     ` Michel Lespinasse
2020-03-27  7:44       ` [Cocci] " Michel Lespinasse
2020-03-27  7:44       ` Michel Lespinasse
2020-03-27  8:00       ` [v2 " Markus Elfring
2020-03-27  8:00         ` [Cocci] " Markus Elfring
2020-03-27  8:08         ` Michel Lespinasse
2020-03-27  8:08           ` [Cocci] " Michel Lespinasse
2020-03-27  8:08           ` Michel Lespinasse
2020-03-27  2:10 ` [PATCH v2 05/10] mmap locking API: convert mmap_sem call sites missed by coccinelle Michel Lespinasse
2020-03-27  2:10   ` Michel Lespinasse
2020-03-27  8:21   ` Markus Elfring
2020-03-27  8:21     ` [Cocci] " Markus Elfring
2020-03-27  2:10 ` [PATCH v2 06/10] mmap locking API: convert nested write lock sites Michel Lespinasse
2020-03-27  2:10   ` Michel Lespinasse
2020-03-27  2:10 ` [PATCH v2 07/10] mmap locking API: add mmap_read_release() and mmap_read_unlock_non_owner() Michel Lespinasse
2020-03-27  2:10   ` Michel Lespinasse
2020-03-27  4:46   ` Davidlohr Bueso
2020-03-27  5:09     ` Michel Lespinasse
2020-03-27  5:09       ` Michel Lespinasse
2020-03-27  2:10 ` [PATCH v2 08/10] mmap locking API: add MMAP_LOCK_INITIALIZER Michel Lespinasse
2020-03-27  2:10   ` Michel Lespinasse
2020-03-27  2:10 ` [PATCH v2 09/10] mmap locking API: use lockdep_assert_held Michel Lespinasse
2020-03-27  2:10   ` Michel Lespinasse
2020-03-27  4:48   ` Davidlohr Bueso
2020-03-27  2:10 ` [PATCH v2 10/10] mmap locking API: rename mmap_sem to mmap_lock Michel Lespinasse
2020-03-27  2:10   ` Michel Lespinasse

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d780d91f-43fa-b2ec-1a08-80013b153a56@web.de \
    --to=markus.elfring@web.de \
    --cc=Liam.Howlett@oracle.com \
    --cc=akpm@linux-foundation.org \
    --cc=cocci@systeme.lip6.fr \
    --cc=dave@stgolabs.net \
    --cc=hughd@google.com \
    --cc=jgg@ziepe.ca \
    --cc=jglisse@redhat.com \
    --cc=ldufour@linux.ibm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=peterz@infradead.org \
    --cc=rientjes@google.com \
    --cc=vbabka@suse.cz \
    --cc=walken@google.com \
    --cc=willy@infradead.org \
    --cc=yinghan@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.