ofono-qt - anything to add/improve?

ofono-qt - anything to add/improve?

[Alexander Kanavin]

[-- Attachment #1: Type: text/plain, Size: 521 bytes --]

Hi,

I am the maintainer of ofono-qt library, which provides Qt bindings to
ofono services and licensed under LGPL 2.1:
http://meego.gitorious.org/meego-cellular/ofono-qt

I would like to get in touch with everyone who is using it, or perhaps
would like to use it, and find out if there is anything incomplete,
missing or possible to improve there. Let me know please.

Also, if you know an easy way to find out what is dependent on this
library in Meego, that would be great too.

Regards,
-- 
Alexander

Re: ofono-qt - anything to add/improve?

[Christian Gagneraud]

[-- Attachment #1: Type: text/plain, Size: 3749 bytes --]

On 04/07/11 14:01, Alexander Kanavin wrote:
> Hi,
>
> I am the maintainer of ofono-qt library, which provides Qt bindings to
> ofono services and licensed under LGPL 2.1:
> http://meego.gitorious.org/meego-cellular/ofono-qt

Hi Alexander,

I started to use ofono-qt recently. And first of all, I would like to 
say, that it does offer a very nice DBUS abstraction.

I'm not a user of the voice call interfaces, just the modem, sim, 
network and connman (mobile broadband use case).

I'm actually integrating ofono(-qt) (and other stuff) into PTXdist 
(Reproducable Embedded Linux Systems) [1]

1. Releases.
I've found 2 places for the tarballs:
- git:
   path: 
http://meego.gitorious.org/meego-cellular/ofono-qt/archive-tarball/<version>
   filename: meego-cellular-ofono-qt-<version>.tar.gz
   (which uncompress into a folder named "meego-cellular-ofono-qt"
- meego: http://api.meego.com/public/source/Trunk/libofono-qt/
   name of the archives: ofono-qt-<version>
   which uncompress nicely into a folder named ofono-qt-<version>, 
unfortunately, this is not a repository, as it contains only the version 
used by meego something.

So, to make it clear and simple, is there any official repository for 
ofono-qt?

2. "slotification" of various member functions:

member functions like OfonoModem.setPowered(bool powered) could be 
declared slots, so that it can be connected to signals of same signature 
like QCheckBox.toggled(bool)

3. More convenient function members (I'm getting picky, I know)
example for OfonoModem:
  - existing: setPowered(bool powered), setOnline(bool online)
  - proposed addition: powerOn(), powerOff(), goOnline(), goOffline()

This with the proposed slotification, would make libofono-qt even easier 
to use.

4. Use enumeration instead of strings:
for example in OfonoConnmanContext:
enum ContextType {
	ContextTypeInternet,
	ContextTypeMms,
	ContextTypeWap,
	ContextTypeIms,
};
void setType(ContextType type);
instead of:
void setType(const QString& type)

I know, that it is less flexible (especially if the oFono DBUS API 
change), but it can help to reduce size of binaries and be slightly more 
efficient. [On an ARM9(a)200MHz, every little helps! ;)]

3. bug with path()?
Each time my code call OfonoXyz.path(), I get a message in the console:
QDBusArgument: read from a write-only object

I don't know where does it come from, perhaps it's not even related to 
ofono-qt...

4. partial interface implementation
There some classes that are missing properties/ function members.
On top of my head:
GSM band, UMTS band and fast dormancy in RadioSettings

5. More documentation (doxygen)
   I know that by reading the ofono DBUS API, it's easy to figure out 
how to use ofono-qt. But as ofono-qt offers an abstraction of the ofono 
DBUS API, it might be nice to have a full ofono-qt API documentation.
I guess it would be mainly copy/paste from ofono/doc/*-api.txt.

6. Enhance ofono-qt with a concept of PIN agent?
It's easy to use SimManager.pinRequiredChanged() signals, but perhaps a 
simple PIN agent class might be a nice thing to have.
At the SimManager level, or even better at the Modem level
OfonoModem.registerSimPinAgent(myAgent);

Just throwing some cheap ideas....


Regards,
Chris

[1] http://www.mail-archive.com/ptxdist(a)pengutronix.de/msg04566.html


>
> I would like to get in touch with everyone who is using it, or perhaps
> would like to use it, and find out if there is anything incomplete,
> missing or possible to improve there. Let me know please.
>
> Also, if you know an easy way to find out what is dependent on this
> library in Meego, that would be great too.
>
> Regards,

Re: ofono-qt - anything to add/improve?

[Alex Kanavin]

[-- Attachment #1: Type: text/plain, Size: 4039 bytes --]

2011/7/4 Christian Gagneraud <chris@techworks.ie>:

> So, to make it clear and simple, is there any official repository for
> ofono-qt?

If you mean a directory with official tarballs, there is no such
thing. I had assumed that anyone can roll their own tarball easily by
cloning the git repository and then using 'git archive'. Build systems
ought to be able to talk directly to git nowadays anyway :)

> 2. "slotification" of various member functions:
>
> member functions like OfonoModem.setPowered(bool powered) could be declared
> slots, so that it can be connected to signals of same signature like
> QCheckBox.toggled(bool)

Yes - this will be fixed. Although you should be careful in connecting
property setting directly to dual state ui widgets like chechboxes -
there can be significant lag. Better to have a third state that
indicates that a property is being set or disable the checkbox until
the setting completes or fails.

> 3. More convenient function members (I'm getting picky, I know)
> example for OfonoModem:
>  - existing: setPowered(bool powered), setOnline(bool online)
>  - proposed addition: powerOn(), powerOff(), goOnline(), goOffline()
>
> This with the proposed slotification, would make libofono-qt even easier to
> use.

It's an explicit design goal that ofono-qt provides a direct,
one-to-one mapping of ofono's d-bus interface. This means no
convinience functions on top or other bells and whistles (the only
exception is modem selection).

> 4. Use enumeration instead of strings:
> for example in OfonoConnmanContext:
> enum ContextType {
>        ContextTypeInternet,
>        ContextTypeMms,
>        ContextTypeWap,
>        ContextTypeIms,
> };
> void setType(ContextType type);
> instead of:
> void setType(const QString& type)
>
> I know, that it is less flexible (especially if the oFono DBUS API change),
> but it can help to reduce size of binaries and be slightly more efficient.
> [On an ARM9(a)200MHz, every little helps! ;)]

This adds significant maintenance overhead with a gazillion of enums
that need to be kept up to date. Ofono API changes often, and I don't
think it's worth it.

> 3. bug with path()?
> Each time my code call OfonoXyz.path(), I get a message in the console:
> QDBusArgument: read from a write-only object
>
> I don't know where does it come from, perhaps it's not even related to
> ofono-qt...

I have no idea where it comes from either, because path() returns a
class member, and never even touches d-bus. Can you provide a
testcase?

> 4. partial interface implementation
> There some classes that are missing properties/ function members.
> On top of my head:
> GSM band, UMTS band and fast dormancy in RadioSettings

Yep - I think these were added to ofono after the class had been
implemented. There is no easy way to keep those in sync (test cases
are not going to help here), but at some point I will go through the
ofono/doc/* and make a list of things to update. Or just send me
patches.

> 5. More documentation (doxygen)
>  I know that by reading the ofono DBUS API, it's easy to figure out how to
> use ofono-qt. But as ofono-qt offers an abstraction of the ofono DBUS API,
> it might be nice to have a full ofono-qt API documentation.
> I guess it would be mainly copy/paste from ofono/doc/*-api.txt.

Again, significant maintenance overhead with too little benefit. It
would be truly a mind-numbing task to first doxygenize the textfiles
and then keep them in sync.

> 6. Enhance ofono-qt with a concept of PIN agent?
> It's easy to use SimManager.pinRequiredChanged() signals, but perhaps a
> simple PIN agent class might be a nice thing to have.
> At the SimManager level, or even better at the Modem level
> OfonoModem.registerSimPinAgent(myAgent);

It's that way, because ofono works that way. :) For those interfaces
where ofono is using d-bus agents (e.g. SIM toolkit), there will be
agents in ofono-qt as well.

-- 
Alexander

Re: ofono-qt - anything to add/improve?

[Michael]

[-- Attachment #1: Type: text/plain, Size: 710 bytes --]


Hello Alexander,

On Mon., July 04, 2011, Alexander KANAVIN wrote:
>I am the maintainer of ofono-qt library, which provides Qt bindings
>to ofono services and licensed under LGPL 2.1:
>http://meego.gitorious.org/meego-cellular/ofono-qt
>
>I would like to get in touch with everyone who is using it, or perhaps
>would like to use it, and find out if there is anything incomplete,
>missing or possible to improve there. Let me know please.
>
Looking at the link you gave, its hard to understand what your
technology does (without digging into the sources.) Can you please
give us a summary about it? Maybe a typical use case and a ten line
'easiest implementation' scenario?

Thanks,
Michael

Re: ofono-qt - anything to add/improve?

[Alexander Kanavin]

[-- Attachment #1: Type: text/plain, Size: 1018 bytes --]

2011/7/4 Michael <ofonoconn@encambio.com>:
>>I am the maintainer of ofono-qt library, which provides Qt bindings
>>to ofono services and licensed under LGPL 2.1:
>>http://meego.gitorious.org/meego-cellular/ofono-qt
>>
>>I would like to get in touch with everyone who is using it, or perhaps
>>would like to use it, and find out if there is anything incomplete,
>>missing or possible to improve there. Let me know please.
>>
> Looking at the link you gave, its hard to understand what your
> technology does (without digging into the sources.) Can you please
> give us a summary about it? Maybe a typical use case and a ten line
> 'easiest implementation' scenario?

It's a library that you would perhaps be interested to use if you are
writing your code in Qt C++ and want to access oFono d-bus services.
It abstracts away details of d-bus communication, selects the modem
for you and takes care of asynchronous operations. And there's also a
test suite for catching API breaks.


-- 
Alexander

VS: [Meego-handset] ofono-qt - anything to add/improve?

[=?unknown-8bit?q?H=C3=A4rk=C3=B6nen?= Timo]

[-- Attachment #1: Type: text/plain, Size: 1377 bytes --]

Hi

This is from N900 Community Edition:

[root(a)localhost ~]# rpm -q --whatrequires libofono-qt
meegotouchcp-cellular-0.0.1-1.3.DE.armv7hl
meegotouchcp-gprs-0.17.4-12.2.DE.armv7hl
meego-pinquery-0.0.2-1.1.DE.armv7hl
meego-ux-settings-0.4.0-1.33.armv7hl

-Timo

ps. Sorry for top posting. using owa..
________________________________________
Lähettäjä: meego-handset-bounces(a)lists.meego.com [meego-handset-bounces(a)lists.meego.com] käyttäjän Alexander Kanavin [alex.kanavin(a)gmail.com] puolesta
Lähetetty: 4. heinäkuuta 2011 16:01
Vastaanottaja: ofono(a)ofono.org; meego-handset(a)lists.meego.com
Aihe: [Meego-handset] ofono-qt - anything to add/improve?

Hi,

I am the maintainer of ofono-qt library, which provides Qt bindings to
ofono services and licensed under LGPL 2.1:
http://meego.gitorious.org/meego-cellular/ofono-qt

I would like to get in touch with everyone who is using it, or perhaps
would like to use it, and find out if there is anything incomplete,
missing or possible to improve there. Let me know please.

Also, if you know an easy way to find out what is dependent on this
library in Meego, that would be great too.

Regards,
--
Alexander
_______________________________________________
MeeGo-handset mailing list
MeeGo-handset(a)lists.meego.com
http://lists.meego.com/listinfo/meego-handset

RE: [Meego-handset] ofono-qt - anything to add/improve?

[jukka.eklund]

[-- Attachment #1: Type: text/plain, Size: 2228 bytes --]

Right, so CE specifically has added those 3 first packages (cellular PIN query, and settings). Those are available for upstream also, but probably not accepted for a reason or other.

The last one is the new (Tablet) Settings application that is in MeeGo 1.2. Alex, you could at least get in touch with owner of that component.

________________________________________
From: meego-handset-bounces(a)lists.meego.com [meego-handset-bounces(a)lists.meego.com] on behalf of ext Härkönen Timo [Timo.Harkonen(a)digia.com]
Sent: 05 July 2011 08:57
To: Alexander Kanavin; ofono(a)ofono.org; meego-handset(a)lists.meego.com
Subject: Re: [Meego-handset] ofono-qt - anything to add/improve?

Hi

This is from N900 Community Edition:

[root(a)localhost ~]# rpm -q --whatrequires libofono-qt
meegotouchcp-cellular-0.0.1-1.3.DE.armv7hl
meegotouchcp-gprs-0.17.4-12.2.DE.armv7hl
meego-pinquery-0.0.2-1.1.DE.armv7hl
meego-ux-settings-0.4.0-1.33.armv7hl

-Timo

ps. Sorry for top posting. using owa..
________________________________________
Lähettäjä: meego-handset-bounces(a)lists.meego.com [meego-handset-bounces(a)lists.meego.com] käyttäjän Alexander Kanavin [alex.kanavin(a)gmail.com] puolesta
Lähetetty: 4. heinäkuuta 2011 16:01
Vastaanottaja: ofono(a)ofono.org; meego-handset(a)lists.meego.com
Aihe: [Meego-handset] ofono-qt - anything to add/improve?

Hi,

I am the maintainer of ofono-qt library, which provides Qt bindings to
ofono services and licensed under LGPL 2.1:
http://meego.gitorious.org/meego-cellular/ofono-qt

I would like to get in touch with everyone who is using it, or perhaps
would like to use it, and find out if there is anything incomplete,
missing or possible to improve there. Let me know please.

Also, if you know an easy way to find out what is dependent on this
library in Meego, that would be great too.

Regards,
--
Alexander
_______________________________________________
MeeGo-handset mailing list
MeeGo-handset(a)lists.meego.com
http://lists.meego.com/listinfo/meego-handset
_______________________________________________
MeeGo-handset mailing list
MeeGo-handset(a)lists.meego.com
http://lists.meego.com/listinfo/meego-handset

Re: [Meego-handset] ofono-qt - anything to add/improve?

[Antoine Reversat]

[-- Attachment #1: Type: text/plain, Size: 2769 bytes --]

Also from what I've heard the dialer is going to use ofono-qt at some
point. It would probably be good to have the insight of Shane or Tom
on what's missing, what needs to be improved, etc.

Unfortunately I think Shane is on vacation.

2011/7/5  <jukka.eklund@nokia.com>:
> Right, so CE specifically has added those 3 first packages (cellular PIN query, and settings). Those are available for upstream also, but probably not accepted for a reason or other.
>
> The last one is the new (Tablet) Settings application that is in MeeGo 1.2. Alex, you could at least get in touch with owner of that component.
>
> ________________________________________
> From: meego-handset-bounces(a)lists.meego.com [meego-handset-bounces(a)lists.meego.com] on behalf of ext Härkönen Timo [Timo.Harkonen(a)digia.com]
> Sent: 05 July 2011 08:57
> To: Alexander Kanavin; ofono(a)ofono.org; meego-handset(a)lists.meego.com
> Subject: Re: [Meego-handset] ofono-qt - anything to add/improve?
>
> Hi
>
> This is from N900 Community Edition:
>
> [root(a)localhost ~]# rpm -q --whatrequires libofono-qt
> meegotouchcp-cellular-0.0.1-1.3.DE.armv7hl
> meegotouchcp-gprs-0.17.4-12.2.DE.armv7hl
> meego-pinquery-0.0.2-1.1.DE.armv7hl
> meego-ux-settings-0.4.0-1.33.armv7hl
>
> -Timo
>
> ps. Sorry for top posting. using owa..
> ________________________________________
> Lähettäjä: meego-handset-bounces(a)lists.meego.com [meego-handset-bounces(a)lists.meego.com] k&#228;ytt&#228;j&#228;n Alexander Kanavin [alex.kanavin(a)gmail.com] puolesta
> Lähetetty: 4. heinäkuuta 2011 16:01
> Vastaanottaja: ofono(a)ofono.org; meego-handset(a)lists.meego.com
> Aihe: [Meego-handset] ofono-qt - anything to add/improve?
>
> Hi,
>
> I am the maintainer of ofono-qt library, which provides Qt bindings to
> ofono services and licensed under LGPL 2.1:
> http://meego.gitorious.org/meego-cellular/ofono-qt
>
> I would like to get in touch with everyone who is using it, or perhaps
> would like to use it, and find out if there is anything incomplete,
> missing or possible to improve there. Let me know please.
>
> Also, if you know an easy way to find out what is dependent on this
> library in Meego, that would be great too.
>
> Regards,
> --
> Alexander
> _______________________________________________
> MeeGo-handset mailing list
> MeeGo-handset(a)lists.meego.com
> http://lists.meego.com/listinfo/meego-handset
> _______________________________________________
> MeeGo-handset mailing list
> MeeGo-handset(a)lists.meego.com
> http://lists.meego.com/listinfo/meego-handset
> _______________________________________________
> MeeGo-handset mailing list
> MeeGo-handset(a)lists.meego.com
> http://lists.meego.com/listinfo/meego-handset
>

Re: [Meego-handset] ofono-qt - anything to add/improve?

[Shane Bryan]

[-- Attachment #1: Type: text/plain, Size: 3371 bytes --]

On Tue, Jul 05, 2011 at 09:21:10AM -0400, Antoine Reversat wrote:
> Also from what I've heard the dialer is going to use ofono-qt at some
> point. It would probably be good to have the insight of Shane or Tom
> on what's missing, what needs to be improved, etc.

Correct, and true for git master but not yet in a released "package".

I just SR'd the 0.1.4 version of libofono-qt prior to this weekend
and it's in Trunk:Testing at this point.  I can't release a new
package for dialer until this moves into Trunk and/or one of the
MeeGo 1.2 branches since it depends on the multiparty call APIs I
added a few weeks back.

FYI... An added complication was just revealed to me, all MTF packages
have been deleted/removed from Trunk.  So until dialer is completely
purged of all MTF deps (modulo anything provided by libmlite of course)
I can't push a new release of dialer into Trunk :(

Roland is doing a bunch of that work, and expects to be done around
July 18th.  As I've not seen any of it yet, and we're still trying
to completely merge the HRP fork *and* migrate to libofono-qt, I
expect some added time (~1 week is a guess) to work through any merge
conflicts that arise.

> Unfortunately I think Shane is on vacation.

Back now...

> > Lähettäjä: meego-handset-bounces(a)lists.meego.com [meego-handset-bounces(a)lists.meego.com] käyttäjän Alexander Kanavin [alex.kanavin(a)gmail.com] puolesta
> > Lähetetty: 4. heinäkuuta 2011 16:01
> > Vastaanottaja: ofono(a)ofono.org; meego-handset(a)lists.meego.com
> > Aihe: [Meego-handset] ofono-qt - anything to add/improve?
> >
> > Hi,
> >
> > I am the maintainer of ofono-qt library, which provides Qt bindings to
> > ofono services and licensed under LGPL 2.1:
> > http://meego.gitorious.org/meego-cellular/ofono-qt
> >
> > I would like to get in touch with everyone who is using it, or perhaps
> > would like to use it, and find out if there is anything incomplete,
> > missing or possible to improve there. Let me know please.

Alexander

Two things come to mind:

1) A document that identifies which version of oFono the libofono-qt is
   targeted for and some metric, like what percent of that version oFono's
   API is complete/covered by this library.

2) A bit harder to do, espcially for the currently used CallHistory plugin,
   but we need an API for getting call history signals and methods from the
   agent providing that data.

On a matter related to 1) above, what is your plan for keeping pace with
oFono upstream releases and (maybe more important to this list) keeping
pace with oFono package updates in MeeGo OBS?  No plan is a fine answer,
which should (hopefully) spark offers for help, but if you *do* have a
plan, I (and I assume others) would like to know what it is.

As usual I am happy to continue helping, but my responsiveness will still
only be as my time permits.

> > Also, if you know an easy way to find out what is dependent on this
> > library in Meego, that would be great too.

As Timo noted, rpm -q --whatrequires <package> does the trick on an
installed host.

I thought there was a zypper command to do something similar, but it's
not coming to me and a quick glance at the man pages is not revealing
an obvious answer... if anyone knows, please inform us ;)

Regards,

-- 
Shane...

Re: [Meego-handset] ofono-qt - anything to add/improve?

[Shane Bryan]

[-- Attachment #1: Type: text/plain, Size: 456 bytes --]

On Wed, Jul 06, 2011 at 10:32:37AM -0700, Shane Bryan wrote:
> Roland is doing a bunch of that work, and expects to be done around
> July 18th.  As I've not seen any of it yet, and we're still trying
> to completely merge the HRP fork *and* migrate to libofono-qt, I

Correction.  I meant to say *HFP*, the dialer used in IVI images,
forked at:

https://gitorious.org/~jimmyhuang/meego-handset-ux/jimmyhuangs-meego-handset-dialer

-- 
Shane...

Re: [Meego-handset] ofono-qt - anything to add/improve?

[Alex Kanavin]

[-- Attachment #1: Type: text/plain, Size: 1509 bytes --]

2011/7/6 Shane Bryan <shane.bryan@linux.intel.com>:
> Two things come to mind:
>
> 1) A document that identifies which version of oFono the libofono-qt is
>   targeted for and some metric, like what percent of that version oFono's
>   API is complete/covered by this library.

I haven't given much thought to the process of 'certifying' ofono-qt
for a specific version of ofono until now. Like I said, I plan to go
through the implemented APIs looking for things that are missing or
have changed and documenting them, and we can take it from there. We
can also change the versioning scheme to match ofono's.

> 2) A bit harder to do, espcially for the currently used CallHistory plugin,
>   but we need an API for getting call history signals and methods from the
>   agent providing that data.

Yep, I haven't done d-bus adaptors in Qt yet, so will take some time
to get it right.

> On a matter related to 1) above, what is your plan for keeping pace with
> oFono upstream releases and (maybe more important to this list) keeping
> pace with oFono package updates in MeeGo OBS?  No plan is a fine answer,
> which should (hopefully) spark offers for help, but if you *do* have a
> plan, I (and I assume others) would like to know what it is.

I suppose there should be a more formal way of tracking changes in
ofono/doc/*. Perhaps by making a diff between two version tags that
then would serve as a TODO :)

I will write up a wishlist and post it here.

-- 
Alexander

Re: [Meego-handset] ofono-qt - anything to add/improve?

[Alex Kanavin]

[-- Attachment #1: Type: text/plain, Size: 1261 bytes --]

2011/7/6 Alex Kanavin <ak@sensi.org>:
> I will write up a wishlist and post it here.

Right, so this is the list of things in no particular order. If you
want any of them to happen faster, you are very much welcome to help.

Check the API and get it up to date:
 - message manager should not use dbusobjectpath class
 - connman contextAdd should return object path
 - radio settings has missing stuff
 - there might be plenty of other things

More formal "certification" of ofono-qt to specific ofono versions
 - change the versioning to match ofono's
 - when new version of ofono is out, diff of ofono/doc/* could serve
   as a list of things to fix

Convert "void setPowered(bool powered)" type functions to public slots.

SIM toolkit bindings. This requires implementing a d-bus agent and some
kind of reasonable test.
 - same for CallHistory.

When automatic modem selection is used, and ofono-qt class moves to using a
new modem, in addition to property change signal also other d-bus signal
subscriptions should be moved to the new modem path.

When interface availability changes, in addition to properties also lists of
object paths (such as voice calls, messages, GPRS contexts etc) should be
refreshed.

-- 
Alexander