* [PATCH] scripts/Lindent: increase the maximum line length to 100
@ 2020-07-03 8:08 Zong Li
2020-07-03 8:51 ` Joe Perches
0 siblings, 1 reply; 8+ messages in thread
From: Zong Li @ 2020-07-03 8:08 UTC (permalink / raw)
To: joe, akpm, linux-kernel; +Cc: Zong Li
As the patch 'bdc48fa11e46 ("checkpatch/coding-style: deprecate
80-column warning")', increase the default limit to 100 characters,
we also increase the maximum line length to 100 for indent script.
Signed-off-by: Zong Li <zong.li@sifive.com>
---
scripts/Lindent | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/scripts/Lindent b/scripts/Lindent
index 1688c44c2df6..11f14a4f2048 100755
--- a/scripts/Lindent
+++ b/scripts/Lindent
@@ -1,7 +1,7 @@
#!/bin/sh
# SPDX-License-Identifier: GPL-2.0
-PARAM="-npro -kr -i8 -ts8 -sob -l80 -ss -ncs -cp1"
+PARAM="-npro -kr -i8 -ts8 -sob -l100 -ss -ncs -cp1"
RES=`indent --version | cut -d' ' -f3`
if [ "$RES" = "" ]; then
--
2.27.0
^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [PATCH] scripts/Lindent: increase the maximum line length to 100
2020-07-03 8:08 [PATCH] scripts/Lindent: increase the maximum line length to 100 Zong Li
@ 2020-07-03 8:51 ` Joe Perches
2020-07-03 9:19 ` Zong Li
2020-07-03 9:41 ` Miguel Ojeda
0 siblings, 2 replies; 8+ messages in thread
From: Joe Perches @ 2020-07-03 8:51 UTC (permalink / raw)
To: Zong Li, akpm, linux-kernel; +Cc: Miguel Ojeda
On Fri, 2020-07-03 at 16:08 +0800, Zong Li wrote:
> As the patch 'bdc48fa11e46 ("checkpatch/coding-style: deprecate
> 80-column warning")', increase the default limit to 100 characters,
> we also increase the maximum line length to 100 for indent script.
I'd prefer to delete Lindent instead.
Also any reformatting tool like this will
_always_ use up to whatever the maximum
line length is rather than use a preferred
length of 80 and and only use the allowed
maximum length of 100 when necessary for
human readability.
> Signed-off-by: Zong Li <zong.li@sifive.com>
> ---
> scripts/Lindent | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/scripts/Lindent b/scripts/Lindent
> index 1688c44c2df6..11f14a4f2048 100755
> --- a/scripts/Lindent
> +++ b/scripts/Lindent
> @@ -1,7 +1,7 @@
> #!/bin/sh
> # SPDX-License-Identifier: GPL-2.0
>
> -PARAM="-npro -kr -i8 -ts8 -sob -l80 -ss -ncs -cp1"
> +PARAM="-npro -kr -i8 -ts8 -sob -l100 -ss -ncs -cp1"
>
> RES=`indent --version | cut -d' ' -f3`
> if [ "$RES" = "" ]; then
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] scripts/Lindent: increase the maximum line length to 100
2020-07-03 8:51 ` Joe Perches
@ 2020-07-03 9:19 ` Zong Li
2020-07-03 9:39 ` Miguel Ojeda
2020-07-03 9:41 ` Miguel Ojeda
1 sibling, 1 reply; 8+ messages in thread
From: Zong Li @ 2020-07-03 9:19 UTC (permalink / raw)
To: Joe Perches
Cc: Andrew Morton, linux-kernel@vger.kernel.org List, Miguel Ojeda
On Fri, Jul 3, 2020 at 4:51 PM Joe Perches <joe@perches.com> wrote:
>
> On Fri, 2020-07-03 at 16:08 +0800, Zong Li wrote:
> > As the patch 'bdc48fa11e46 ("checkpatch/coding-style: deprecate
> > 80-column warning")', increase the default limit to 100 characters,
> > we also increase the maximum line length to 100 for indent script.
>
> I'd prefer to delete Lindent instead.
>
> Also any reformatting tool like this will
> _always_ use up to whatever the maximum
> line length is rather than use a preferred
> length of 80 and and only use the allowed
> maximum length of 100 when necessary for
> human readability.
>
Yes, as you mentioned, the reformatting tool uses up to the maximum line length,
it seems to me that we don't go this patch if you plan to post the
patch to delete it,
otherwise, we could consider to change it to 100.
> > Signed-off-by: Zong Li <zong.li@sifive.com>
> > ---
> > scripts/Lindent | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/scripts/Lindent b/scripts/Lindent
> > index 1688c44c2df6..11f14a4f2048 100755
> > --- a/scripts/Lindent
> > +++ b/scripts/Lindent
> > @@ -1,7 +1,7 @@
> > #!/bin/sh
> > # SPDX-License-Identifier: GPL-2.0
> >
> > -PARAM="-npro -kr -i8 -ts8 -sob -l80 -ss -ncs -cp1"
> > +PARAM="-npro -kr -i8 -ts8 -sob -l100 -ss -ncs -cp1"
> >
> > RES=`indent --version | cut -d' ' -f3`
> > if [ "$RES" = "" ]; then
>
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] scripts/Lindent: increase the maximum line length to 100
2020-07-03 9:19 ` Zong Li
@ 2020-07-03 9:39 ` Miguel Ojeda
0 siblings, 0 replies; 8+ messages in thread
From: Miguel Ojeda @ 2020-07-03 9:39 UTC (permalink / raw)
To: Zong Li; +Cc: Joe Perches, Andrew Morton, linux-kernel@vger.kernel.org List
On Fri, Jul 3, 2020 at 11:19 AM Zong Li <zong.li@sifive.com> wrote:
>
> Yes, as you mentioned, the reformatting tool uses up to the maximum line length,
> it seems to me that we don't go this patch if you plan to post the
> patch to delete it,
> otherwise, we could consider to change it to 100.
For reference, we discussed this for the limit in `.clang-format`, and
for the moment we will keep the limit at 80 there too.
See https://lore.kernel.org/lkml/20200610125147.2782142-1-christian.brauner@ubuntu.com/
Cheers,
Miguel
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] scripts/Lindent: increase the maximum line length to 100
2020-07-03 8:51 ` Joe Perches
2020-07-03 9:19 ` Zong Li
@ 2020-07-03 9:41 ` Miguel Ojeda
2020-07-03 9:51 ` Joe Perches
1 sibling, 1 reply; 8+ messages in thread
From: Miguel Ojeda @ 2020-07-03 9:41 UTC (permalink / raw)
To: Joe Perches; +Cc: Zong Li, Andrew Morton, linux-kernel
On Fri, Jul 3, 2020 at 10:51 AM Joe Perches <joe@perches.com> wrote:
>
> I'd prefer to delete Lindent instead.
+1, especially since there is `clang-format` now.
Cheers,
Miguel
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] scripts/Lindent: increase the maximum line length to 100
2020-07-03 9:41 ` Miguel Ojeda
@ 2020-07-03 9:51 ` Joe Perches
2020-07-03 10:22 ` Zong Li
0 siblings, 1 reply; 8+ messages in thread
From: Joe Perches @ 2020-07-03 9:51 UTC (permalink / raw)
To: Miguel Ojeda; +Cc: Zong Li, Andrew Morton, linux-kernel
On Fri, 2020-07-03 at 11:41 +0200, Miguel Ojeda wrote:
> On Fri, Jul 3, 2020 at 10:51 AM Joe Perches <joe@perches.com> wrote:
> > I'd prefer to delete Lindent instead.
>
> +1, especially since there is `clang-format` now.
Awhile back I did send a patch:
https://lore.kernel.org/lkml/1360610974.28491.6.camel@joe-AO722/
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] scripts/Lindent: increase the maximum line length to 100
2020-07-03 9:51 ` Joe Perches
@ 2020-07-03 10:22 ` Zong Li
2020-07-03 10:32 ` Joe Perches
0 siblings, 1 reply; 8+ messages in thread
From: Zong Li @ 2020-07-03 10:22 UTC (permalink / raw)
To: Joe Perches; +Cc: Miguel Ojeda, Andrew Morton, linux-kernel
On Fri, Jul 3, 2020 at 5:51 PM Joe Perches <joe@perches.com> wrote:
>
> On Fri, 2020-07-03 at 11:41 +0200, Miguel Ojeda wrote:
> > On Fri, Jul 3, 2020 at 10:51 AM Joe Perches <joe@perches.com> wrote:
> > > I'd prefer to delete Lindent instead.
> >
> > +1, especially since there is `clang-format` now.
Agree, it is often used.
>
> Awhile back I did send a patch:
> https://lore.kernel.org/lkml/1360610974.28491.6.camel@joe-AO722/
>
>
Cool, let us go the patch above.
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] scripts/Lindent: increase the maximum line length to 100
2020-07-03 10:22 ` Zong Li
@ 2020-07-03 10:32 ` Joe Perches
0 siblings, 0 replies; 8+ messages in thread
From: Joe Perches @ 2020-07-03 10:32 UTC (permalink / raw)
To: Zong Li; +Cc: Miguel Ojeda, Andrew Morton, linux-kernel
On Fri, 2020-07-03 at 18:22 +0800, Zong Li wrote:
> On Fri, Jul 3, 2020 at 5:51 PM Joe Perches <joe@perches.com> wrote:
> > On Fri, 2020-07-03 at 11:41 +0200, Miguel Ojeda wrote:
> > > On Fri, Jul 3, 2020 at 10:51 AM Joe Perches <joe@perches.com> wrote:
> > > > I'd prefer to delete Lindent instead.
> > >
> > > +1, especially since there is `clang-format` now.
>
> Agree, it is often used.
>
> > Awhile back I did send a patch:
> > https://lore.kernel.org/lkml/1360610974.28491.6.camel@joe-AO722/
> >
> Cool, let us go the patch above.
You are welcome to refresh it as a lot has
changed in the 7.5 years since then.
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2020-07-03 10:32 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-07-03 8:08 [PATCH] scripts/Lindent: increase the maximum line length to 100 Zong Li
2020-07-03 8:51 ` Joe Perches
2020-07-03 9:19 ` Zong Li
2020-07-03 9:39 ` Miguel Ojeda
2020-07-03 9:41 ` Miguel Ojeda
2020-07-03 9:51 ` Joe Perches
2020-07-03 10:22 ` Zong Li
2020-07-03 10:32 ` Joe Perches
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.