From: Miguel Ojeda <miguel.ojeda.sandonis@gmail.com>
To: Greg KH <gregkh@linuxfoundation.org>
Cc: Nick Desaulniers <ndesaulniers@google.com>,
Kees Cook <keescook@chromium.org>,
Linus Torvalds <torvalds@linux-foundation.org>,
Miguel Ojeda <ojeda@kernel.org>, Jonathan Corbet <corbet@lwn.net>,
Randy Dunlap <rdunlap@infradead.org>,
Joe Perches <joe@perches.com>,
Alexey Dobriyan <adobriyan@gmail.com>,
Rasmus Villemoes <linux@rasmusvillemoes.dk>,
Andrew Morton <akpm@linux-foundation.org>,
linux-kernel <linux-kernel@vger.kernel.org>,
Linux Doc Mailing List <linux-doc@vger.kernel.org>,
linux-hardening@vger.kernel.org
Subject: Re: [PATCH v4] docs: Explain the desired position of function attributes
Date: Sat, 2 Oct 2021 12:42:40 +0200 [thread overview]
Message-ID: <CANiq72=T9b_RgZGHuKDjj=E46c0nB2CHH3+Wsdws2Wt9YWcHVw@mail.gmail.com> (raw)
In-Reply-To: <YVf80rXg8Yd19Hmw@kroah.com>
On Sat, Oct 2, 2021 at 8:31 AM Greg KH <gregkh@linuxfoundation.org> wrote:
>
> Why would documenting the expected format have an affect on tools not
> being able to follow that exact expected format? Are we defining a
> format that is somehow impossible for them to use?
From a quick test, clang-format-12 with our current config keeps
attributes in the same line and it does not seem to reorder them, so
it seems OK (the developer has to do it by hand, but that is fine)
except for the `__malloc` in the second example which is in a
different line (but not in the first). Is that intended?
> If anything I would think that now we have a format that the tools can
> actually follow, while before it was semi-random as to what to pick as
> the "one true way".
In the future, clang-format could have a configuration option to pass
a sort order, in which case, having the sort order already defined in
the kernel would definitely be helpful.
In fact, we could use the fact that the kernel has one as a way to
tell upstream that such a feature would be nice to have :)
Cheers,
Miguel
next prev parent reply other threads:[~2021-10-02 10:42 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-30 23:57 [PATCH v4] docs: Explain the desired position of function attributes Kees Cook
2021-10-01 19:05 ` Nick Desaulniers
2021-10-01 20:23 ` Joe Perches
2021-10-02 0:00 ` Kees Cook
2021-10-02 6:31 ` Greg KH
2021-10-02 10:42 ` Miguel Ojeda [this message]
2021-10-02 15:22 ` Joe Perches
2021-10-02 16:29 ` Miguel Ojeda
2021-10-02 15:21 ` Joe Perches
2021-10-02 16:27 ` Miguel Ojeda
2021-10-02 21:42 ` Kees Cook
2021-10-02 10:46 ` Miguel Ojeda
2021-10-04 23:09 ` Jonathan Corbet
2021-10-05 8:28 ` Miguel Ojeda
2021-10-05 14:58 ` Kees Cook
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CANiq72=T9b_RgZGHuKDjj=E46c0nB2CHH3+Wsdws2Wt9YWcHVw@mail.gmail.com' \
--to=miguel.ojeda.sandonis@gmail.com \
--cc=adobriyan@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=corbet@lwn.net \
--cc=gregkh@linuxfoundation.org \
--cc=joe@perches.com \
--cc=keescook@chromium.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-hardening@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@rasmusvillemoes.dk \
--cc=ndesaulniers@google.com \
--cc=ojeda@kernel.org \
--cc=rdunlap@infradead.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.