All of lore.kernel.org
 help / color / mirror / Atom feed
From: Miguel Ojeda <miguel.ojeda.sandonis@gmail.com>
To: Joe Perches <joe@perches.com>
Cc: Greg KH <gregkh@linuxfoundation.org>,
	Nick Desaulniers <ndesaulniers@google.com>,
	Kees Cook <keescook@chromium.org>,
	Linus Torvalds <torvalds@linux-foundation.org>,
	Miguel Ojeda <ojeda@kernel.org>, Jonathan Corbet <corbet@lwn.net>,
	Randy Dunlap <rdunlap@infradead.org>,
	Alexey Dobriyan <adobriyan@gmail.com>,
	Rasmus Villemoes <linux@rasmusvillemoes.dk>,
	Andrew Morton <akpm@linux-foundation.org>,
	linux-kernel <linux-kernel@vger.kernel.org>,
	Linux Doc Mailing List <linux-doc@vger.kernel.org>,
	linux-hardening@vger.kernel.org
Subject: Re: [PATCH v4] docs: Explain the desired position of function attributes
Date: Sat, 2 Oct 2021 18:29:52 +0200	[thread overview]
Message-ID: <CANiq72=fOYUjoqjW6+kvf7krqb_AqxmYbkcCwn-Oaw-ApFq9LQ@mail.gmail.com> (raw)
In-Reply-To: <0cbd2549be1245b445796f6c57a27b910fa4dc9d.camel@perches.com>

On Sat, Oct 2, 2021 at 5:22 PM Joe Perches <joe@perches.com> wrote:
>
> It's not so much a sort order so much as it's a positional one.

Sure, there are two parts, the order w.r.t. the signature parts (e.g.
"before return type") and the order between the attributes themselves.
Both are included in what I meant.

By the way, clang-format-13 already has a way to pass it a list of the
"attribute macros" (such as `__unused`), so adding more information on
top seems reasonable.

Cheers,
Miguel

  reply	other threads:[~2021-10-02 16:30 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-30 23:57 [PATCH v4] docs: Explain the desired position of function attributes Kees Cook
2021-10-01 19:05 ` Nick Desaulniers
2021-10-01 20:23   ` Joe Perches
2021-10-02  0:00   ` Kees Cook
2021-10-02  6:31   ` Greg KH
2021-10-02 10:42     ` Miguel Ojeda
2021-10-02 15:22       ` Joe Perches
2021-10-02 16:29         ` Miguel Ojeda [this message]
2021-10-02 15:21     ` Joe Perches
2021-10-02 16:27       ` Miguel Ojeda
2021-10-02 21:42         ` Kees Cook
2021-10-02 10:46 ` Miguel Ojeda
2021-10-04 23:09 ` Jonathan Corbet
2021-10-05  8:28   ` Miguel Ojeda
2021-10-05 14:58     ` Kees Cook

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CANiq72=fOYUjoqjW6+kvf7krqb_AqxmYbkcCwn-Oaw-ApFq9LQ@mail.gmail.com' \
    --to=miguel.ojeda.sandonis@gmail.com \
    --cc=adobriyan@gmail.com \
    --cc=akpm@linux-foundation.org \
    --cc=corbet@lwn.net \
    --cc=gregkh@linuxfoundation.org \
    --cc=joe@perches.com \
    --cc=keescook@chromium.org \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-hardening@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@rasmusvillemoes.dk \
    --cc=ndesaulniers@google.com \
    --cc=ojeda@kernel.org \
    --cc=rdunlap@infradead.org \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.