All of lore.kernel.org
 help / color / mirror / Atom feed
From: Miguel Ojeda <miguel.ojeda.sandonis@gmail.com>
To: Masahiro Yamada <masahiroy@kernel.org>
Cc: "Lucas De Marchi" <lucas.demarchi@intel.com>,
	"Michal Suchánek" <msuchanek@suse.de>,
	"Gary Guo" <gary@garyguo.net>,
	"Kees Cook" <keescook@chromium.org>,
	linux-kbuild@vger.kernel.org,
	"Wedson Almeida Filho" <wedsonaf@google.com>,
	"Joel Stanley" <joel@jms.id.au>,
	"Alex Gaynor" <alex.gaynor@gmail.com>,
	"Miguel Ojeda" <ojeda@kernel.org>,
	"Wedson Almeida Filho" <wedsonaf@gmail.com>,
	"Nicolas Schier" <nicolas@fjasle.eu>,
	rust-for-linux@vger.kernel.org,
	"Guo Zhengkui" <guozhengkui@vivo.com>,
	"Boqun Feng" <boqun.feng@gmail.com>,
	"Nicholas Piggin" <npiggin@gmail.com>,
	"Björn Roy Baron" <bjorn3_gh@protonmail.com>,
	"Nathan Chancellor" <nathan@kernel.org>,
	"Nick Desaulniers" <ndesaulniers@google.com>,
	linux-kernel@vger.kernel.org,
	"Julia Lawall" <Julia.Lawall@inria.fr>,
	"Luis Chamberlain" <mcgrof@kernel.org>,
	linuxppc-dev@lists.ozlabs.org, linux-modules@vger.kernel.org
Subject: Re: [PATCH] modpost: support arbitrary symbol length in modversion
Date: Thu, 19 Jan 2023 20:19:56 +0100	[thread overview]
Message-ID: <CANiq72n4MbR+AE7eHfVQZOu26FeSttQnEEMT3Jpft+CcGwk9jw@mail.gmail.com> (raw)
In-Reply-To: <CAK7LNATsuszFR7JB5ZkqVS1W=hWr9=E7bTf+MvgJ+NXT3aZNwg@mail.gmail.com>

On Wed, Jan 18, 2023 at 8:02 AM Masahiro Yamada <masahiroy@kernel.org> wrote:
>
>     - *.mod.c is kept human readable.

On the topic of `.mod.c` readability: for approaches that may be less
readable, we could improve that by adding some extra comments or
rearrange things in a different way (it is a generated file, after
all!).

For instance, for the original approach: https://godbolt.org/z/6oh45axnc

Cheers,
Miguel

WARNING: multiple messages have this Message-ID (diff)
From: Miguel Ojeda <miguel.ojeda.sandonis@gmail.com>
To: Masahiro Yamada <masahiroy@kernel.org>
Cc: "Gary Guo" <gary@garyguo.net>,
	"Nicolas Schier" <nicolas@fjasle.eu>,
	"Guo Zhengkui" <guozhengkui@vivo.com>,
	"Wedson Almeida Filho" <wedsonaf@google.com>,
	"Joel Stanley" <joel@jms.id.au>,
	"Alex Gaynor" <alex.gaynor@gmail.com>,
	"Miguel Ojeda" <ojeda@kernel.org>,
	"Michal Suchánek" <msuchanek@suse.de>,
	"Wedson Almeida Filho" <wedsonaf@gmail.com>,
	"Kees Cook" <keescook@chromium.org>,
	rust-for-linux@vger.kernel.org, linux-kbuild@vger.kernel.org,
	"Boqun Feng" <boqun.feng@gmail.com>,
	"Lucas De Marchi" <lucas.demarchi@intel.com>,
	"Nicholas Piggin" <npiggin@gmail.com>,
	"Björn Roy Baron" <bjorn3_gh@protonmail.com>,
	"Nathan Chancellor" <nathan@kernel.org>,
	"Nick Desaulniers" <ndesaulniers@google.com>,
	linux-kernel@vger.kernel.org,
	"Julia Lawall" <Julia.Lawall@inria.fr>,
	"Luis Chamberlain" <mcgrof@kernel.org>,
	linuxppc-dev@lists.ozlabs.org, linux-modules@vger.kernel.org
Subject: Re: [PATCH] modpost: support arbitrary symbol length in modversion
Date: Thu, 19 Jan 2023 20:19:56 +0100	[thread overview]
Message-ID: <CANiq72n4MbR+AE7eHfVQZOu26FeSttQnEEMT3Jpft+CcGwk9jw@mail.gmail.com> (raw)
In-Reply-To: <CAK7LNATsuszFR7JB5ZkqVS1W=hWr9=E7bTf+MvgJ+NXT3aZNwg@mail.gmail.com>

On Wed, Jan 18, 2023 at 8:02 AM Masahiro Yamada <masahiroy@kernel.org> wrote:
>
>     - *.mod.c is kept human readable.

On the topic of `.mod.c` readability: for approaches that may be less
readable, we could improve that by adding some extra comments or
rearrange things in a different way (it is a generated file, after
all!).

For instance, for the original approach: https://godbolt.org/z/6oh45axnc

Cheers,
Miguel

  parent reply	other threads:[~2023-01-19 19:21 UTC|newest]

Thread overview: 44+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-01-11 16:11 [PATCH] modpost: support arbitrary symbol length in modversion Gary Guo
2023-01-11 16:11 ` Gary Guo
2023-01-12 21:40 ` Lucas De Marchi
2023-01-12 21:40   ` Lucas De Marchi
2023-01-13 18:18   ` Gary Guo
2023-01-13 18:18     ` Gary Guo
2023-01-17 17:51     ` Michal Suchánek
2023-01-17 17:51       ` Michal Suchánek
2023-01-17 19:22       ` Lucas De Marchi
2023-01-17 19:22         ` Lucas De Marchi
2023-01-18  7:01         ` Masahiro Yamada
2023-01-18  7:01           ` Masahiro Yamada
2023-01-19 19:02           ` Lucas De Marchi
2023-01-19 19:02             ` Lucas De Marchi
2023-01-19 19:19           ` Miguel Ojeda [this message]
2023-01-19 19:19             ` Miguel Ojeda
2023-01-19 15:09         ` Gary Guo
2023-01-19 15:09           ` Gary Guo
2023-01-19 15:18           ` Michal Suchánek
2023-01-19 15:18             ` Michal Suchánek
2023-01-19 15:57             ` Gary Guo
2023-01-19 15:57               ` Gary Guo
2023-03-13 20:32 ` Andrea Righi
2023-03-13 20:32   ` Andrea Righi
2023-03-13 21:48   ` Michal Suchánek
2023-03-13 21:48     ` Michal Suchánek
2023-03-13 21:53     ` Andrea Righi
2023-03-13 21:53       ` Andrea Righi
2023-03-13 22:02       ` Michal Suchánek
2023-03-13 22:02         ` Michal Suchánek
2023-03-13 22:09         ` Andrea Righi
2023-03-13 22:09           ` Andrea Righi
2023-03-14 14:38           ` Andrea Righi
2023-03-14 14:38             ` Andrea Righi
2023-03-14 14:59             ` Andrea Righi
2023-03-14 14:59               ` Andrea Righi
2023-03-15  0:15               ` Vincenzo Palazzo
2023-03-15  0:15                 ` Vincenzo Palazzo
2023-03-15  6:07                 ` Andrea Righi
2023-03-15  6:07                   ` Andrea Righi
2023-03-15 16:18             ` Masahiro Yamada
2023-03-15 16:18               ` Masahiro Yamada
2023-03-15 21:00               ` Andrea Righi
2023-03-15 21:00                 ` Andrea Righi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CANiq72n4MbR+AE7eHfVQZOu26FeSttQnEEMT3Jpft+CcGwk9jw@mail.gmail.com \
    --to=miguel.ojeda.sandonis@gmail.com \
    --cc=Julia.Lawall@inria.fr \
    --cc=alex.gaynor@gmail.com \
    --cc=bjorn3_gh@protonmail.com \
    --cc=boqun.feng@gmail.com \
    --cc=gary@garyguo.net \
    --cc=guozhengkui@vivo.com \
    --cc=joel@jms.id.au \
    --cc=keescook@chromium.org \
    --cc=linux-kbuild@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-modules@vger.kernel.org \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=lucas.demarchi@intel.com \
    --cc=masahiroy@kernel.org \
    --cc=mcgrof@kernel.org \
    --cc=msuchanek@suse.de \
    --cc=nathan@kernel.org \
    --cc=ndesaulniers@google.com \
    --cc=nicolas@fjasle.eu \
    --cc=npiggin@gmail.com \
    --cc=ojeda@kernel.org \
    --cc=rust-for-linux@vger.kernel.org \
    --cc=wedsonaf@gmail.com \
    --cc=wedsonaf@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.