From: Eric Dumazet <edumazet@google.com>
To: David Miller <davem@davemloft.net>
Cc: Vladislav.Zakharov@synopsys.com, netdev <netdev@vger.kernel.org>,
eladkan@mellanox.com, noamca@mellanox.com,
LKML <linux-kernel@vger.kernel.org>,
linux-snps-arc@lists.infradead.org
Subject: Re: [PATCH] ezchip: nps_enet: check if napi has been completed
Date: Wed, 29 Mar 2017 14:41:40 -0700 [thread overview]
Message-ID: <CANn89iJ1+7CrF=hJj-_pLWV+EDXxhUZGOL+3je6zjE8dJDcr=A@mail.gmail.com> (raw)
In-Reply-To: <20170329.143014.2001816338079751776.davem@davemloft.net>
On Wed, Mar 29, 2017 at 2:30 PM, David Miller <davem@davemloft.net> wrote:
Signed-off-by: Vlad Zakharov <vzakhar@synopsys.com>
>
> Applied.
>
> Eric, if this is really required now, we have 148 broken drivers still.
Piece of cake :/
If we get more reports like that, we might implement a logic to
prevent infinite loops.
It is not clear to me what exactly happened to this driver, since
testing napi_complete_done() was not mandatory.
WARNING: multiple messages have this Message-ID (diff)
From: Eric Dumazet <edumazet@google.com>
To: David Miller <davem@davemloft.net>
Cc: netdev <netdev@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
noamca@mellanox.com, Vladislav.Zakharov@synopsys.com,
linux-snps-arc@lists.infradead.org, eladkan@mellanox.com
Subject: Re: [PATCH] ezchip: nps_enet: check if napi has been completed
Date: Wed, 29 Mar 2017 14:41:40 -0700 [thread overview]
Message-ID: <CANn89iJ1+7CrF=hJj-_pLWV+EDXxhUZGOL+3je6zjE8dJDcr=A@mail.gmail.com> (raw)
In-Reply-To: <20170329.143014.2001816338079751776.davem@davemloft.net>
On Wed, Mar 29, 2017 at 2:30 PM, David Miller <davem@davemloft.net> wrote:
Signed-off-by: Vlad Zakharov <vzakhar@synopsys.com>
>
> Applied.
>
> Eric, if this is really required now, we have 148 broken drivers still.
Piece of cake :/
If we get more reports like that, we might implement a logic to
prevent infinite loops.
It is not clear to me what exactly happened to this driver, since
testing napi_complete_done() was not mandatory.
WARNING: multiple messages have this Message-ID (diff)
From: edumazet@google.com (Eric Dumazet)
To: linux-snps-arc@lists.infradead.org
Subject: [PATCH] ezchip: nps_enet: check if napi has been completed
Date: Wed, 29 Mar 2017 14:41:40 -0700 [thread overview]
Message-ID: <CANn89iJ1+7CrF=hJj-_pLWV+EDXxhUZGOL+3je6zjE8dJDcr=A@mail.gmail.com> (raw)
In-Reply-To: <20170329.143014.2001816338079751776.davem@davemloft.net>
On Wed, Mar 29, 2017@2:30 PM, David Miller <davem@davemloft.net> wrote:
Signed-off-by: Vlad Zakharov <vzakhar at synopsys.com>
>
> Applied.
>
> Eric, if this is really required now, we have 148 broken drivers still.
Piece of cake :/
If we get more reports like that, we might implement a logic to
prevent infinite loops.
It is not clear to me what exactly happened to this driver, since
testing napi_complete_done() was not mandatory.
next prev parent reply other threads:[~2017-03-29 21:43 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-29 10:41 [PATCH] ezchip: nps_enet: check if napi has been completed Vlad Zakharov
2017-03-29 10:41 ` Vlad Zakharov
2017-03-29 10:41 ` Vlad Zakharov
2017-03-29 14:52 ` Eric Dumazet
2017-03-29 14:52 ` Eric Dumazet
2017-03-29 21:30 ` David Miller
2017-03-29 21:30 ` David Miller
2017-03-29 21:30 ` David Miller
2017-03-29 21:41 ` Eric Dumazet [this message]
2017-03-29 21:41 ` Eric Dumazet
2017-03-29 21:41 ` Eric Dumazet
2017-03-30 9:16 ` Vlad Zakharov
2017-03-30 9:16 ` Vlad Zakharov
2017-03-30 9:16 ` Vlad Zakharov
2017-03-30 13:25 ` Eric Dumazet
2017-03-30 13:25 ` Eric Dumazet
2017-03-30 13:25 ` Eric Dumazet
2017-04-26 12:56 ` Vlad Zakharov
2017-04-26 12:56 ` Vlad Zakharov
2017-04-26 12:56 ` Vlad Zakharov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CANn89iJ1+7CrF=hJj-_pLWV+EDXxhUZGOL+3je6zjE8dJDcr=A@mail.gmail.com' \
--to=edumazet@google.com \
--cc=Vladislav.Zakharov@synopsys.com \
--cc=davem@davemloft.net \
--cc=eladkan@mellanox.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-snps-arc@lists.infradead.org \
--cc=netdev@vger.kernel.org \
--cc=noamca@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.