All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH 0/4] Move SCons to Python 3
@ 2019-06-07 23:47 Tim Orling
  2019-06-07 23:47 ` [PATCH 1/4] python3-scons-{native}: add recipe for v3.0.5 Tim Orling
                   ` (5 more replies)
  0 siblings, 6 replies; 23+ messages in thread
From: Tim Orling @ 2019-06-07 23:47 UTC (permalink / raw)
  To: openembedded-core

python-scons and python-scons-native are perhaps the last python2 only
recipes in oe-core. With Python 2 going EOL in or before 2020, it's time
to switch everything to Python 3.

I updated scons.bbclass to use python3-scons-native. Tested build with serf.

I also added a simple oeqa/runtime test while I was at it.

I did not drop python-scons and python-scons-native, although we should
at some point soon.

[YOCTO #13381]

The following changes since commit 666f6192aaa9e847ad0d920a487b82d984b58d26:

  gnutls: Use the sysconfdir variable for the ca-certificates path (2019-06-07 09:10:34 +0100)

are available in the Git repository at:

  git://git.openembedded.org/openembedded-core-contrib timo/python3-scons
  http://cgit.openembedded.org//log/?h=timo/python3-scons

Tim Orling (4):
  python3-scons-{native}: add recipe for v3.0.5
  scons.bbclass: use python3-scons
  serf: switch to python3-scons-native
  oeqa/runtime: add simple test for scons

 meta/classes/scons.bbclass                    |  2 +-
 meta/conf/distro/include/maintainers.inc      |  2 +
 meta/lib/oeqa/runtime/cases/scons.py          | 37 +++++++++++++++++++
 meta/lib/oeqa/runtime/files/SConstruct        |  1 +
 meta/lib/oeqa/runtime/files/hello.c           |  5 +++
 .../python/python3-scons-native_3.0.5.bb      |  8 ++++
 .../python/python3-scons_3.0.5.bb             | 29 +++++++++++++++
 meta/recipes-support/serf/serf_1.3.9.bb       |  2 +-
 8 files changed, 84 insertions(+), 2 deletions(-)
 create mode 100644 meta/lib/oeqa/runtime/cases/scons.py
 create mode 100644 meta/lib/oeqa/runtime/files/SConstruct
 create mode 100644 meta/lib/oeqa/runtime/files/hello.c
 create mode 100644 meta/recipes-devtools/python/python3-scons-native_3.0.5.bb
 create mode 100644 meta/recipes-devtools/python/python3-scons_3.0.5.bb

-- 
2.20.1



^ permalink raw reply	[flat|nested] 23+ messages in thread

* [PATCH 1/4] python3-scons-{native}: add recipe for v3.0.5
  2019-06-07 23:47 [PATCH 0/4] Move SCons to Python 3 Tim Orling
@ 2019-06-07 23:47 ` Tim Orling
  2019-06-08  0:56   ` Tim Orling
  2019-06-07 23:47 ` [PATCH 2/4] scons.bbclass: use python3-scons Tim Orling
                   ` (4 subsequent siblings)
  5 siblings, 1 reply; 23+ messages in thread
From: Tim Orling @ 2019-06-07 23:47 UTC (permalink / raw)
  To: openembedded-core

SCons has supported python 3 since v3.0.0
https://scons.org/tag/releases.html

Fix shebangs in scripts

[YOCTO #13381]

Signed-off-by: Tim Orling <timothy.t.orling@linux.intel.com>
---
 meta/conf/distro/include/maintainers.inc      |  2 ++
 .../python/python3-scons-native_3.0.5.bb      |  8 +++++
 .../python/python3-scons_3.0.5.bb             | 29 +++++++++++++++++++
 3 files changed, 39 insertions(+)
 create mode 100644 meta/recipes-devtools/python/python3-scons-native_3.0.5.bb
 create mode 100644 meta/recipes-devtools/python/python3-scons_3.0.5.bb

diff --git a/meta/conf/distro/include/maintainers.inc b/meta/conf/distro/include/maintainers.inc
index d6f66510e3..6ddf9f5fc7 100644
--- a/meta/conf/distro/include/maintainers.inc
+++ b/meta/conf/distro/include/maintainers.inc
@@ -604,6 +604,8 @@ RECIPE_MAINTAINER_pn-python3-pip = "Derek Straka <derek@asterius.io>"
 RECIPE_MAINTAINER_pn-python3-pycairo = "Derek Straka <derek@asterius.io>"
 RECIPE_MAINTAINER_pn-python3-pygments = "Derek Straka <derek@asterius.io>"
 RECIPE_MAINTAINER_pn-python3-pygobject = "Derek Straka <derek@asterius.io>"
+RECIPE_MAINTAINER_pn-python3-scons = "Tim Orling <timothy.t.orling@linux.intel.com>"
+RECIPE_MAINTAINER_pn-python3-scons-native = "Tim Orling <timothy.t.orling@linux.intel.como>"
 RECIPE_MAINTAINER_pn-python3-setuptools = "Derek Straka <derek@asterius.io>"
 RECIPE_MAINTAINER_pn-python3-six = "Derek Straka <derek@asterius.io>"
 RECIPE_MAINTAINER_pn-python3-smmap = "Derek Straka <derek@asterius.io>"
diff --git a/meta/recipes-devtools/python/python3-scons-native_3.0.5.bb b/meta/recipes-devtools/python/python3-scons-native_3.0.5.bb
new file mode 100644
index 0000000000..5cd5956625
--- /dev/null
+++ b/meta/recipes-devtools/python/python3-scons-native_3.0.5.bb
@@ -0,0 +1,8 @@
+require python3-scons_${PV}.bb
+inherit native python3native
+DEPENDS = "python3-native"
+RDEPENDS_${PN} = ""
+
+do_install_append() {
+    create_wrapper ${D}${bindir}/scons SCONS_LIB_DIR='${STAGING_DIR_HOST}/${PYTHON_SITEPACKAGES_DIR}' PYTHONNOUSERSITE='1'
+}
diff --git a/meta/recipes-devtools/python/python3-scons_3.0.5.bb b/meta/recipes-devtools/python/python3-scons_3.0.5.bb
new file mode 100644
index 0000000000..91e4a945e3
--- /dev/null
+++ b/meta/recipes-devtools/python/python3-scons_3.0.5.bb
@@ -0,0 +1,29 @@
+SUMMARY = "Software Construction tool (make/autotools replacement)"
+SECTION = "devel/python"
+LICENSE = "MIT"
+LIC_FILES_CHKSUM = "file://LICENSE.txt;md5=37bb53a08e6beaea0c90e7821d731284"
+
+SRC_URI = "${SOURCEFORGE_MIRROR}/scons/scons-${PV}.tar.gz"
+SRC_URI[md5sum] = "9f9c163e8bd48cf8cd92f03e85ca6395"
+SRC_URI[sha256sum] = "df676f23dc6d4bfa384fc389d95dcd21ab907e6349d4c848958ba4befb73c73e"
+
+S = "${WORKDIR}/scons-${PV}"
+
+UPSTREAM_CHECK_URI = "http://scons.org/pages/download.html"
+UPSTREAM_CHECK_REGEX = "(?P<pver>\d+(\.\d+)+)\.tar"
+
+inherit setuptools3
+
+do_install_prepend() {
+    sed -i -e "s:/usr/bin/env python:/usr/bin/env python3:g" ${S}/script/*
+}
+
+RDEPENDS_${PN} = "\
+  python3-core \
+  python3-fcntl \
+  python3-io \
+  python3-json \
+  python3-shell \
+  python3-pickle \
+  python3-pprint \
+  "
-- 
2.20.1



^ permalink raw reply related	[flat|nested] 23+ messages in thread

* [PATCH 2/4] scons.bbclass: use python3-scons
  2019-06-07 23:47 [PATCH 0/4] Move SCons to Python 3 Tim Orling
  2019-06-07 23:47 ` [PATCH 1/4] python3-scons-{native}: add recipe for v3.0.5 Tim Orling
@ 2019-06-07 23:47 ` Tim Orling
  2019-06-20 13:36   ` Khem Raj
  2019-06-07 23:47 ` [PATCH 3/4] serf: switch to python3-scons-native Tim Orling
                   ` (3 subsequent siblings)
  5 siblings, 1 reply; 23+ messages in thread
From: Tim Orling @ 2019-06-07 23:47 UTC (permalink / raw)
  To: openembedded-core

SCons has supported python3 since 3.0.0 release, use it.

[YOCTO #13381]

Signed-off-by: Tim Orling <timothy.t.orling@linux.intel.com>
---
 meta/classes/scons.bbclass | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/meta/classes/scons.bbclass b/meta/classes/scons.bbclass
index 9ee7d1587d..a8ddae35f7 100644
--- a/meta/classes/scons.bbclass
+++ b/meta/classes/scons.bbclass
@@ -1,4 +1,4 @@
-DEPENDS += "python-scons-native"
+DEPENDS += "python3-scons-native"
 
 EXTRA_OESCONS ?= ""
 
-- 
2.20.1



^ permalink raw reply related	[flat|nested] 23+ messages in thread

* [PATCH 3/4] serf: switch to python3-scons-native
  2019-06-07 23:47 [PATCH 0/4] Move SCons to Python 3 Tim Orling
  2019-06-07 23:47 ` [PATCH 1/4] python3-scons-{native}: add recipe for v3.0.5 Tim Orling
  2019-06-07 23:47 ` [PATCH 2/4] scons.bbclass: use python3-scons Tim Orling
@ 2019-06-07 23:47 ` Tim Orling
  2019-06-10  5:10   ` Mittal, Anuj
  2019-06-07 23:47 ` [PATCH 4/4] oeqa/runtime: add simple test for scons Tim Orling
                   ` (2 subsequent siblings)
  5 siblings, 1 reply; 23+ messages in thread
From: Tim Orling @ 2019-06-07 23:47 UTC (permalink / raw)
  To: openembedded-core

SCons has supported python3 since v3.0.0, use it.

Signed-off-by: Tim Orling <timothy.t.orling@linux.intel.com>
---
 meta/recipes-support/serf/serf_1.3.9.bb | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/meta/recipes-support/serf/serf_1.3.9.bb b/meta/recipes-support/serf/serf_1.3.9.bb
index 65a8114bb4..706c86be47 100644
--- a/meta/recipes-support/serf/serf_1.3.9.bb
+++ b/meta/recipes-support/serf/serf_1.3.9.bb
@@ -14,7 +14,7 @@ SRC_URI[sha256sum] = "549c2d21c577a8a9c0450facb5cca809f26591f048e466552240947bdf
 LICENSE = "Apache-2.0"
 LIC_FILES_CHKSUM = "file://LICENSE;md5=86d3f3a95c324c9479bd8986968f4327"
 
-DEPENDS = "python-scons-native openssl apr apr-util util-linux expat"
+DEPENDS = "python3-scons-native openssl apr apr-util util-linux expat"
 
 do_compile() {
 	${STAGING_BINDIR_NATIVE}/scons ${PARALLEL_MAKE} PREFIX=${prefix} \
-- 
2.20.1



^ permalink raw reply related	[flat|nested] 23+ messages in thread

* [PATCH 4/4] oeqa/runtime: add simple test for scons
  2019-06-07 23:47 [PATCH 0/4] Move SCons to Python 3 Tim Orling
                   ` (2 preceding siblings ...)
  2019-06-07 23:47 ` [PATCH 3/4] serf: switch to python3-scons-native Tim Orling
@ 2019-06-07 23:47 ` Tim Orling
  2019-06-08  3:54 ` ✗ patchtest: failure for Move SCons to Python 3 Patchwork
  2019-06-08  7:13 ` [PATCH 0/4] " Burton, Ross
  5 siblings, 0 replies; 23+ messages in thread
From: Tim Orling @ 2019-06-07 23:47 UTC (permalink / raw)
  To: openembedded-core

This test simply compiles a hello world program using scons.

Signed-off-by: Tim Orling <timothy.t.orling@linux.intel.com>
---
 meta/lib/oeqa/runtime/cases/scons.py   | 37 ++++++++++++++++++++++++++
 meta/lib/oeqa/runtime/files/SConstruct |  1 +
 meta/lib/oeqa/runtime/files/hello.c    |  5 ++++
 3 files changed, 43 insertions(+)
 create mode 100644 meta/lib/oeqa/runtime/cases/scons.py
 create mode 100644 meta/lib/oeqa/runtime/files/SConstruct
 create mode 100644 meta/lib/oeqa/runtime/files/hello.c

diff --git a/meta/lib/oeqa/runtime/cases/scons.py b/meta/lib/oeqa/runtime/cases/scons.py
new file mode 100644
index 0000000000..3c7c7f7270
--- /dev/null
+++ b/meta/lib/oeqa/runtime/cases/scons.py
@@ -0,0 +1,37 @@
+#
+# SPDX-License-Identifier: MIT
+#
+
+import os
+
+from oeqa.runtime.case import OERuntimeTestCase
+from oeqa.core.decorator.depends import OETestDepends
+from oeqa.runtime.decorator.package import OEHasPackage
+
+class SconsCompileTest(OERuntimeTestCase):
+
+    @classmethod
+    def setUp(cls):
+        dst = '/tmp/'
+        src = os.path.join(cls.tc.runtime_files_dir, 'hello.c')
+        cls.tc.target.copyTo(src, dst)
+
+        src = os.path.join(cls.tc.runtime_files_dir, 'SConstruct')
+        cls.tc.target.copyTo(src, dst)
+
+    @classmethod
+    def tearDown(cls):
+        files = '/tmp/hello.c /tmp/hello.o /tmp/hello /tmp/SConstruct'
+        cls.tc.target.run('rm %s' % files)
+
+    @OETestDepends(['ssh.SSHTest.test_ssh'])
+    @OEHasPackage(['gcc'])
+    @OEHasPackage(['python3-scons'])
+    def test_scons_compile(self):
+        status, output = self.target.run('cd /tmp/ && scons')
+        msg = 'scons compile failed, output: %s' % output
+        self.assertEqual(status, 0, msg=msg)
+
+        status, output = self.target.run('/tmp/hello')
+        msg = 'running compiled file failed, output: %s' % output
+        self.assertEqual(status, 0, msg=msg)
diff --git a/meta/lib/oeqa/runtime/files/SConstruct b/meta/lib/oeqa/runtime/files/SConstruct
new file mode 100644
index 0000000000..d2cb6dd122
--- /dev/null
+++ b/meta/lib/oeqa/runtime/files/SConstruct
@@ -0,0 +1 @@
+Program('hello.c')
diff --git a/meta/lib/oeqa/runtime/files/hello.c b/meta/lib/oeqa/runtime/files/hello.c
new file mode 100644
index 0000000000..b0697a3304
--- /dev/null
+++ b/meta/lib/oeqa/runtime/files/hello.c
@@ -0,0 +1,5 @@
+int
+      main()
+      {
+          printf("Hello, world!\n");
+      }
-- 
2.20.1



^ permalink raw reply related	[flat|nested] 23+ messages in thread

* Re: [PATCH 1/4] python3-scons-{native}: add recipe for v3.0.5
  2019-06-07 23:47 ` [PATCH 1/4] python3-scons-{native}: add recipe for v3.0.5 Tim Orling
@ 2019-06-08  0:56   ` Tim Orling
  0 siblings, 0 replies; 23+ messages in thread
From: Tim Orling @ 2019-06-08  0:56 UTC (permalink / raw)
  To: Tim Orling; +Cc: openembedded-core

[-- Attachment #1: Type: text/plain, Size: 3743 bytes --]

On Fri, Jun 7, 2019 at 4:49 PM Tim Orling <timothy.t.orling@linux.intel.com>
wrote:

> SCons has supported python 3 since v3.0.0
> https://scons.org/tag/releases.html
>
> Fix shebangs in scripts
>
> [YOCTO #13381]
>
> Signed-off-by: Tim Orling <timothy.t.orling@linux.intel.com>
> ---
>  meta/conf/distro/include/maintainers.inc      |  2 ++
>  .../python/python3-scons-native_3.0.5.bb      |  8 +++++
>  .../python/python3-scons_3.0.5.bb             | 29 +++++++++++++++++++
>  3 files changed, 39 insertions(+)
>  create mode 100644 meta/recipes-devtools/python/
> python3-scons-native_3.0.5.bb
>  create mode 100644 meta/recipes-devtools/python/python3-scons_3.0.5.bb
>
> diff --git a/meta/conf/distro/include/maintainers.inc
> b/meta/conf/distro/include/maintainers.inc
> index d6f66510e3..6ddf9f5fc7 100644
> --- a/meta/conf/distro/include/maintainers.inc
> +++ b/meta/conf/distro/include/maintainers.inc
> @@ -604,6 +604,8 @@ RECIPE_MAINTAINER_pn-python3-pip = "Derek Straka <
> derek@asterius.io>"
>  RECIPE_MAINTAINER_pn-python3-pycairo = "Derek Straka <derek@asterius.io>"
>  RECIPE_MAINTAINER_pn-python3-pygments = "Derek Straka <derek@asterius.io
> >"
>  RECIPE_MAINTAINER_pn-python3-pygobject = "Derek Straka <derek@asterius.io
> >"
> +RECIPE_MAINTAINER_pn-python3-scons = "Tim Orling <
> timothy.t.orling@linux.intel.com>"
> +RECIPE_MAINTAINER_pn-python3-scons-native = "Tim Orling
> <timothy.t.orling@linux.intel.como>"


Grr. Typo.


>  RECIPE_MAINTAINER_pn-python3-setuptools = "Derek Straka <
> derek@asterius.io>"
>  RECIPE_MAINTAINER_pn-python3-six = "Derek Straka <derek@asterius.io>"
>  RECIPE_MAINTAINER_pn-python3-smmap = "Derek Straka <derek@asterius.io>"
> diff --git a/meta/recipes-devtools/python/python3-scons-native_3.0.5.bb
> b/meta/recipes-devtools/python/python3-scons-native_3.0.5.bb
> new file mode 100644
> index 0000000000..5cd5956625
> --- /dev/null
> +++ b/meta/recipes-devtools/python/python3-scons-native_3.0.5.bb
> @@ -0,0 +1,8 @@
> +require python3-scons_${PV}.bb
> +inherit native python3native
> +DEPENDS = "python3-native"
> +RDEPENDS_${PN} = ""
> +
> +do_install_append() {
> +    create_wrapper ${D}${bindir}/scons
> SCONS_LIB_DIR='${STAGING_DIR_HOST}/${PYTHON_SITEPACKAGES_DIR}'
> PYTHONNOUSERSITE='1'
> +}
> diff --git a/meta/recipes-devtools/python/python3-scons_3.0.5.bb
> b/meta/recipes-devtools/python/python3-scons_3.0.5.bb
> new file mode 100644
> index 0000000000..91e4a945e3
> --- /dev/null
> +++ b/meta/recipes-devtools/python/python3-scons_3.0.5.bb
> @@ -0,0 +1,29 @@
> +SUMMARY = "Software Construction tool (make/autotools replacement)"
> +SECTION = "devel/python"
> +LICENSE = "MIT"
> +LIC_FILES_CHKSUM =
> "file://LICENSE.txt;md5=37bb53a08e6beaea0c90e7821d731284"
> +
> +SRC_URI = "${SOURCEFORGE_MIRROR}/scons/scons-${PV}.tar.gz"
> +SRC_URI[md5sum] = "9f9c163e8bd48cf8cd92f03e85ca6395"
> +SRC_URI[sha256sum] =
> "df676f23dc6d4bfa384fc389d95dcd21ab907e6349d4c848958ba4befb73c73e"
> +
> +S = "${WORKDIR}/scons-${PV}"
> +
> +UPSTREAM_CHECK_URI = "http://scons.org/pages/download.html"
> +UPSTREAM_CHECK_REGEX = "(?P<pver>\d+(\.\d+)+)\.tar"
> +
> +inherit setuptools3
> +
> +do_install_prepend() {
> +    sed -i -e "s:/usr/bin/env python:/usr/bin/env python3:g" ${S}/script/*
> +}
> +
> +RDEPENDS_${PN} = "\
> +  python3-core \
> +  python3-fcntl \
> +  python3-io \
> +  python3-json \
> +  python3-shell \
> +  python3-pickle \
> +  python3-pprint \
> +  "
> --
> 2.20.1
>
> --
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core
>

[-- Attachment #2: Type: text/html, Size: 6365 bytes --]

^ permalink raw reply	[flat|nested] 23+ messages in thread

* ✗ patchtest: failure for Move SCons to Python 3
  2019-06-07 23:47 [PATCH 0/4] Move SCons to Python 3 Tim Orling
                   ` (3 preceding siblings ...)
  2019-06-07 23:47 ` [PATCH 4/4] oeqa/runtime: add simple test for scons Tim Orling
@ 2019-06-08  3:54 ` Patchwork
  2019-06-08  4:04   ` Tim Orling
  2019-06-08  7:13 ` [PATCH 0/4] " Burton, Ross
  5 siblings, 1 reply; 23+ messages in thread
From: Patchwork @ 2019-06-08  3:54 UTC (permalink / raw)
  To: Tim Orling; +Cc: openembedded-core

== Series Details ==

Series: Move SCons to Python 3
Revision: 1
URL   : https://patchwork.openembedded.org/series/18049/
State : failure

== Summary ==


Thank you for submitting this patch series to OpenEmbedded Core. This is
an automated response. Several tests have been executed on the proposed
series by patchtest resulting in the following failures:



* Issue             Errors in your Python code were encountered [test_pylint] 
  Suggested fix    Correct the lines introduced by your patch
  Output           Please, fix the listed issues:
                   meta/lib/oeqa/runtime/cases/scons.py does not exist



If you believe any of these test results are incorrect, please reply to the
mailing list (openembedded-core@lists.openembedded.org) raising your concerns.
Otherwise we would appreciate you correcting the issues and submitting a new
version of the patchset if applicable. Please ensure you add/increment the
version number when sending the new version (i.e. [PATCH] -> [PATCH v2] ->
[PATCH v3] -> ...).

---
Guidelines:     https://www.openembedded.org/wiki/Commit_Patch_Message_Guidelines
Test framework: http://git.yoctoproject.org/cgit/cgit.cgi/patchtest
Test suite:     http://git.yoctoproject.org/cgit/cgit.cgi/patchtest-oe



^ permalink raw reply	[flat|nested] 23+ messages in thread

* Re: ✗ patchtest: failure for Move SCons to Python 3
  2019-06-08  3:54 ` ✗ patchtest: failure for Move SCons to Python 3 Patchwork
@ 2019-06-08  4:04   ` Tim Orling
  0 siblings, 0 replies; 23+ messages in thread
From: Tim Orling @ 2019-06-08  4:04 UTC (permalink / raw)
  To: openembedded-core

[-- Attachment #1: Type: text/plain, Size: 1708 bytes --]

False negative. The file was included in the series.

On Fri, Jun 7, 2019 at 9:00 PM Patchwork <
patchwork@patchwork.openembedded.org> wrote:

> == Series Details ==
>
> Series: Move SCons to Python 3
> Revision: 1
> URL   : https://patchwork.openembedded.org/series/18049/
> State : failure
>
> == Summary ==
>
>
> Thank you for submitting this patch series to OpenEmbedded Core. This is
> an automated response. Several tests have been executed on the proposed
> series by patchtest resulting in the following failures:
>
>
>
> * Issue             Errors in your Python code were encountered
> [test_pylint]
>   Suggested fix    Correct the lines introduced by your patch
>   Output           Please, fix the listed issues:
>                    meta/lib/oeqa/runtime/cases/scons.py does not exist
>
>
>
> If you believe any of these test results are incorrect, please reply to the
> mailing list (openembedded-core@lists.openembedded.org) raising your
> concerns.
> Otherwise we would appreciate you correcting the issues and submitting a
> new
> version of the patchset if applicable. Please ensure you add/increment the
> version number when sending the new version (i.e. [PATCH] -> [PATCH v2] ->
> [PATCH v3] -> ...).
>
> ---
> Guidelines:
> https://www.openembedded.org/wiki/Commit_Patch_Message_Guidelines
> Test framework: http://git.yoctoproject.org/cgit/cgit.cgi/patchtest
> Test suite:     http://git.yoctoproject.org/cgit/cgit.cgi/patchtest-oe
>
> --
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core
>

[-- Attachment #2: Type: text/html, Size: 2807 bytes --]

^ permalink raw reply	[flat|nested] 23+ messages in thread

* Re: [PATCH 0/4] Move SCons to Python 3
  2019-06-07 23:47 [PATCH 0/4] Move SCons to Python 3 Tim Orling
                   ` (4 preceding siblings ...)
  2019-06-08  3:54 ` ✗ patchtest: failure for Move SCons to Python 3 Patchwork
@ 2019-06-08  7:13 ` Burton, Ross
  5 siblings, 0 replies; 23+ messages in thread
From: Burton, Ross @ 2019-06-08  7:13 UTC (permalink / raw)
  To: Tim Orling; +Cc: OE-core

Hurrah, last time I looked at this the Py3 support wasn't quite ready yet.

Ross

On Sat, 8 Jun 2019 at 00:49, Tim Orling
<timothy.t.orling@linux.intel.com> wrote:
>
> python-scons and python-scons-native are perhaps the last python2 only
> recipes in oe-core. With Python 2 going EOL in or before 2020, it's time
> to switch everything to Python 3.
>
> I updated scons.bbclass to use python3-scons-native. Tested build with serf.
>
> I also added a simple oeqa/runtime test while I was at it.
>
> I did not drop python-scons and python-scons-native, although we should
> at some point soon.
>
> [YOCTO #13381]
>
> The following changes since commit 666f6192aaa9e847ad0d920a487b82d984b58d26:
>
>   gnutls: Use the sysconfdir variable for the ca-certificates path (2019-06-07 09:10:34 +0100)
>
> are available in the Git repository at:
>
>   git://git.openembedded.org/openembedded-core-contrib timo/python3-scons
>   http://cgit.openembedded.org//log/?h=timo/python3-scons
>
> Tim Orling (4):
>   python3-scons-{native}: add recipe for v3.0.5
>   scons.bbclass: use python3-scons
>   serf: switch to python3-scons-native
>   oeqa/runtime: add simple test for scons
>
>  meta/classes/scons.bbclass                    |  2 +-
>  meta/conf/distro/include/maintainers.inc      |  2 +
>  meta/lib/oeqa/runtime/cases/scons.py          | 37 +++++++++++++++++++
>  meta/lib/oeqa/runtime/files/SConstruct        |  1 +
>  meta/lib/oeqa/runtime/files/hello.c           |  5 +++
>  .../python/python3-scons-native_3.0.5.bb      |  8 ++++
>  .../python/python3-scons_3.0.5.bb             | 29 +++++++++++++++
>  meta/recipes-support/serf/serf_1.3.9.bb       |  2 +-
>  8 files changed, 84 insertions(+), 2 deletions(-)
>  create mode 100644 meta/lib/oeqa/runtime/cases/scons.py
>  create mode 100644 meta/lib/oeqa/runtime/files/SConstruct
>  create mode 100644 meta/lib/oeqa/runtime/files/hello.c
>  create mode 100644 meta/recipes-devtools/python/python3-scons-native_3.0.5.bb
>  create mode 100644 meta/recipes-devtools/python/python3-scons_3.0.5.bb
>
> --
> 2.20.1
>
> --
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core


^ permalink raw reply	[flat|nested] 23+ messages in thread

* Re: [PATCH 3/4] serf: switch to python3-scons-native
  2019-06-07 23:47 ` [PATCH 3/4] serf: switch to python3-scons-native Tim Orling
@ 2019-06-10  5:10   ` Mittal, Anuj
  2019-06-10  5:22     ` Tim Orling
  2019-06-12 20:52     ` Khem Raj
  0 siblings, 2 replies; 23+ messages in thread
From: Mittal, Anuj @ 2019-06-10  5:10 UTC (permalink / raw)
  To: openembedded-core, timothy.t.orling

This is causing on CentOS 7:

| DEBUG: Executing shell function do_compile
| scons: *** SCons version 3.0.5 does not run under Python version
3.4.8.
| Python 2.7 or >= 3.5 is required.

Looks like it's using host python which is at 3.4.8 in this case.

Thanks,

Anuj

On Fri, 2019-06-07 at 16:47 -0700, Tim Orling wrote:
> SCons has supported python3 since v3.0.0, use it.
> 
> Signed-off-by: Tim Orling <timothy.t.orling@linux.intel.com>
> ---
>  meta/recipes-support/serf/serf_1.3.9.bb | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/meta/recipes-support/serf/serf_1.3.9.bb b/meta/recipes-
> support/serf/serf_1.3.9.bb
> index 65a8114bb4..706c86be47 100644
> --- a/meta/recipes-support/serf/serf_1.3.9.bb
> +++ b/meta/recipes-support/serf/serf_1.3.9.bb
> @@ -14,7 +14,7 @@ SRC_URI[sha256sum] =
> "549c2d21c577a8a9c0450facb5cca809f26591f048e466552240947bdf
>  LICENSE = "Apache-2.0"
>  LIC_FILES_CHKSUM =
> "file://LICENSE;md5=86d3f3a95c324c9479bd8986968f4327"
>  
> -DEPENDS = "python-scons-native openssl apr apr-util util-linux
> expat"
> +DEPENDS = "python3-scons-native openssl apr apr-util util-linux
> expat"
>  
>  do_compile() {
>  	${STAGING_BINDIR_NATIVE}/scons ${PARALLEL_MAKE}
> PREFIX=${prefix} \
> -- 
> 2.20.1
> 


^ permalink raw reply	[flat|nested] 23+ messages in thread

* Re: [PATCH 3/4] serf: switch to python3-scons-native
  2019-06-10  5:10   ` Mittal, Anuj
@ 2019-06-10  5:22     ` Tim Orling
  2019-06-12 20:52     ` Khem Raj
  1 sibling, 0 replies; 23+ messages in thread
From: Tim Orling @ 2019-06-10  5:22 UTC (permalink / raw)
  To: Mittal, Anuj; +Cc: openembedded-core

[-- Attachment #1: Type: text/plain, Size: 1752 bytes --]

On Sun, Jun 9, 2019 at 10:10 PM Mittal, Anuj <anuj.mittal@intel.com> wrote:

> This is causing on CentOS 7:
>
> | DEBUG: Executing shell function do_compile
> | scons: *** SCons version 3.0.5 does not run under Python version
> 3.4.8.
> | Python 2.7 or >= 3.5 is required.
>
> Looks like it's using host python which is at 3.4.8 in this case.
>

Hmmm. Host contamination is bad. We should make sure it is using
python3native.


> Thanks,
>
> Anuj
>
> On Fri, 2019-06-07 at 16:47 -0700, Tim Orling wrote:
> > SCons has supported python3 since v3.0.0, use it.
> >
> > Signed-off-by: Tim Orling <timothy.t.orling@linux.intel.com>
> > ---
> >  meta/recipes-support/serf/serf_1.3.9.bb | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/meta/recipes-support/serf/serf_1.3.9.bb b/meta/recipes-
> > support/serf/serf_1.3.9.bb
> > index 65a8114bb4..706c86be47 100644
> > --- a/meta/recipes-support/serf/serf_1.3.9.bb
> > +++ b/meta/recipes-support/serf/serf_1.3.9.bb
> > @@ -14,7 +14,7 @@ SRC_URI[sha256sum] =
> > "549c2d21c577a8a9c0450facb5cca809f26591f048e466552240947bdf
> >  LICENSE = "Apache-2.0"
> >  LIC_FILES_CHKSUM =
> > "file://LICENSE;md5=86d3f3a95c324c9479bd8986968f4327"
> >
> > -DEPENDS = "python-scons-native openssl apr apr-util util-linux
> > expat"
> > +DEPENDS = "python3-scons-native openssl apr apr-util util-linux
> > expat"
> >
> >  do_compile() {
> >       ${STAGING_BINDIR_NATIVE}/scons ${PARALLEL_MAKE}
> > PREFIX=${prefix} \
> > --
> > 2.20.1
> >
>
> --
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core
>

[-- Attachment #2: Type: text/html, Size: 3065 bytes --]

^ permalink raw reply	[flat|nested] 23+ messages in thread

* Re: [PATCH 3/4] serf: switch to python3-scons-native
  2019-06-10  5:10   ` Mittal, Anuj
  2019-06-10  5:22     ` Tim Orling
@ 2019-06-12 20:52     ` Khem Raj
  1 sibling, 0 replies; 23+ messages in thread
From: Khem Raj @ 2019-06-12 20:52 UTC (permalink / raw)
  To: Mittal, Anuj; +Cc: openembedded-core

On Sun, Jun 9, 2019 at 10:10 PM Mittal, Anuj <anuj.mittal@intel.com> wrote:
>
> This is causing on CentOS 7:
>
> | DEBUG: Executing shell function do_compile
> | scons: *** SCons version 3.0.5 does not run under Python version
> 3.4.8.
> | Python 2.7 or >= 3.5 is required.
>
> Looks like it's using host python which is at 3.4.8 in this case.
>

same error on ubuntu 14.04 on both serf and serf-native
https://errors.yoctoproject.org/Errors/Details/248342/
https://errors.yoctoproject.org/Errors/Details/248341/

> Thanks,
>
> Anuj
>
> On Fri, 2019-06-07 at 16:47 -0700, Tim Orling wrote:
> > SCons has supported python3 since v3.0.0, use it.
> >
> > Signed-off-by: Tim Orling <timothy.t.orling@linux.intel.com>
> > ---
> >  meta/recipes-support/serf/serf_1.3.9.bb | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/meta/recipes-support/serf/serf_1.3.9.bb b/meta/recipes-
> > support/serf/serf_1.3.9.bb
> > index 65a8114bb4..706c86be47 100644
> > --- a/meta/recipes-support/serf/serf_1.3.9.bb
> > +++ b/meta/recipes-support/serf/serf_1.3.9.bb
> > @@ -14,7 +14,7 @@ SRC_URI[sha256sum] =
> > "549c2d21c577a8a9c0450facb5cca809f26591f048e466552240947bdf
> >  LICENSE = "Apache-2.0"
> >  LIC_FILES_CHKSUM =
> > "file://LICENSE;md5=86d3f3a95c324c9479bd8986968f4327"
> >
> > -DEPENDS = "python-scons-native openssl apr apr-util util-linux
> > expat"
> > +DEPENDS = "python3-scons-native openssl apr apr-util util-linux
> > expat"
> >
> >  do_compile() {
> >       ${STAGING_BINDIR_NATIVE}/scons ${PARALLEL_MAKE}
> > PREFIX=${prefix} \
> > --
> > 2.20.1
> >
>
> --
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core


^ permalink raw reply	[flat|nested] 23+ messages in thread

* Re: [PATCH 2/4] scons.bbclass: use python3-scons
  2019-06-07 23:47 ` [PATCH 2/4] scons.bbclass: use python3-scons Tim Orling
@ 2019-06-20 13:36   ` Khem Raj
  2019-06-21  0:18     ` Tim Orling
  0 siblings, 1 reply; 23+ messages in thread
From: Khem Raj @ 2019-06-20 13:36 UTC (permalink / raw)
  To: Tim Orling; +Cc: Patches and discussions about the oe-core layer

On Fri, Jun 7, 2019 at 5:50 PM Tim Orling
<timothy.t.orling@linux.intel.com> wrote:
>
> SCons has supported python3 since 3.0.0 release, use it.
>
> [YOCTO #13381]
>
> Signed-off-by: Tim Orling <timothy.t.orling@linux.intel.com>
> ---
>  meta/classes/scons.bbclass | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/meta/classes/scons.bbclass b/meta/classes/scons.bbclass
> index 9ee7d1587d..a8ddae35f7 100644
> --- a/meta/classes/scons.bbclass
> +++ b/meta/classes/scons.bbclass
> @@ -1,4 +1,4 @@
> -DEPENDS += "python-scons-native"
> +DEPENDS += "python3-scons-native"
>

some packages haven't upgraded to py3 but use scons see
https://errors.yoctoproject.org/Errors/Details/249271/

>  EXTRA_OESCONS ?= ""
>
> --
> 2.20.1
>
> --
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core


^ permalink raw reply	[flat|nested] 23+ messages in thread

* Re: [PATCH 2/4] scons.bbclass: use python3-scons
  2019-06-20 13:36   ` Khem Raj
@ 2019-06-21  0:18     ` Tim Orling
  2019-06-21  3:27       ` Khem Raj
  2019-06-24  2:41       ` Alistair Francis
  0 siblings, 2 replies; 23+ messages in thread
From: Tim Orling @ 2019-06-21  0:18 UTC (permalink / raw)
  To: Khem Raj; +Cc: Patches and discussions about the oe-core layer

[-- Attachment #1: Type: text/plain, Size: 1718 bytes --]

On Thu, Jun 20, 2019 at 6:37 AM Khem Raj <raj.khem@gmail.com> wrote:

> On Fri, Jun 7, 2019 at 5:50 PM Tim Orling
> <timothy.t.orling@linux.intel.com> wrote:
> >
> > SCons has supported python3 since 3.0.0 release, use it.
> >
> > [YOCTO #13381]
> >
> > Signed-off-by: Tim Orling <timothy.t.orling@linux.intel.com>
> > ---
> >  meta/classes/scons.bbclass | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/meta/classes/scons.bbclass b/meta/classes/scons.bbclass
> > index 9ee7d1587d..a8ddae35f7 100644
> > --- a/meta/classes/scons.bbclass
> > +++ b/meta/classes/scons.bbclass
> > @@ -1,4 +1,4 @@
> > -DEPENDS += "python-scons-native"
> > +DEPENDS += "python3-scons-native"
> >
>
> some packages haven't upgraded to py3 but use scons see
> https://errors.yoctoproject.org/Errors/Details/249271/
>


Thank you for reporting this. I was of course expecting some breakage and
am committed to fixes. Please do report any other issues.

Latest mongo release appears to be 4.3.0 and appears to support python3:

https://github.com/mongodb/mongo/blob/89e7419a897b2270931c9c029abf6de555d83e0f/SConstruct

Is this an aceptable upgrade? I am not savvy on which versions are
desirable.


> >  EXTRA_OESCONS ?= ""
> >
> > --
> > 2.20.1
> >
> > --
> > _______________________________________________
> > Openembedded-core mailing list
> > Openembedded-core@lists.openembedded.org
> > http://lists.openembedded.org/mailman/listinfo/openembedded-core
> --
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core
>

[-- Attachment #2: Type: text/html, Size: 3243 bytes --]

^ permalink raw reply	[flat|nested] 23+ messages in thread

* Re: [PATCH 2/4] scons.bbclass: use python3-scons
  2019-06-21  0:18     ` Tim Orling
@ 2019-06-21  3:27       ` Khem Raj
  2019-06-22  8:58         ` Adrian Bunk
  2019-06-24  2:41       ` Alistair Francis
  1 sibling, 1 reply; 23+ messages in thread
From: Khem Raj @ 2019-06-21  3:27 UTC (permalink / raw)
  To: Tim Orling; +Cc: Patches and discussions about the oe-core layer

[-- Attachment #1: Type: text/plain, Size: 1910 bytes --]

On Thu, Jun 20, 2019 at 6:18 PM Tim Orling <ticotimo@gmail.com> wrote:

>
>
> On Thu, Jun 20, 2019 at 6:37 AM Khem Raj <raj.khem@gmail.com> wrote:
>
>> On Fri, Jun 7, 2019 at 5:50 PM Tim Orling
>> <timothy.t.orling@linux.intel.com> wrote:
>> >
>> > SCons has supported python3 since 3.0.0 release, use it.
>> >
>> > [YOCTO #13381]
>> >
>> > Signed-off-by: Tim Orling <timothy.t.orling@linux.intel.com>
>> > ---
>> >  meta/classes/scons.bbclass | 2 +-
>> >  1 file changed, 1 insertion(+), 1 deletion(-)
>> >
>> > diff --git a/meta/classes/scons.bbclass b/meta/classes/scons.bbclass
>> > index 9ee7d1587d..a8ddae35f7 100644
>> > --- a/meta/classes/scons.bbclass
>> > +++ b/meta/classes/scons.bbclass
>> > @@ -1,4 +1,4 @@
>> > -DEPENDS += "python-scons-native"
>> > +DEPENDS += "python3-scons-native"
>> >
>>
>> some packages haven't upgraded to py3 but use scons see
>> https://errors.yoctoproject.org/Errors/Details/249271/
>>
>
>
> Thank you for reporting this. I was of course expecting some breakage and
> am committed to fixes. Please do report any other issues.
>
> Latest mongo release appears to be 4.3.0 and appears to support python3:
>
>
> https://github.com/mongodb/mongo/blob/89e7419a897b2270931c9c029abf6de555d83e0f/SConstruct
>
> Is this an aceptable upgrade? I am not savvy on which versions are
> desirable.
>

Yes for master this upgrade is fine

>
>
>> >  EXTRA_OESCONS ?= ""
>> >
>> > --
>> > 2.20.1
>> >
>> > --
>> > _______________________________________________
>> > Openembedded-core mailing list
>> > Openembedded-core@lists.openembedded.org
>> > http://lists.openembedded.org/mailman/listinfo/openembedded-core
>> --
>> _______________________________________________
>> Openembedded-core mailing list
>> Openembedded-core@lists.openembedded.org
>> http://lists.openembedded.org/mailman/listinfo/openembedded-core
>>
>

[-- Attachment #2: Type: text/html, Size: 3919 bytes --]

^ permalink raw reply	[flat|nested] 23+ messages in thread

* Re: [PATCH 2/4] scons.bbclass: use python3-scons
  2019-06-21  3:27       ` Khem Raj
@ 2019-06-22  8:58         ` Adrian Bunk
  2019-06-23  0:03           ` Khem Raj
  0 siblings, 1 reply; 23+ messages in thread
From: Adrian Bunk @ 2019-06-22  8:58 UTC (permalink / raw)
  To: Khem Raj; +Cc: Patches and discussions about the oe-core layer

On Thu, Jun 20, 2019 at 09:27:15PM -0600, Khem Raj wrote:
> On Thu, Jun 20, 2019 at 6:18 PM Tim Orling <ticotimo@gmail.com> wrote:
>...
> > Latest mongo release appears to be 4.3.0 and appears to support python3:
> >
> >
> > https://github.com/mongodb/mongo/blob/89e7419a897b2270931c9c029abf6de555d83e0f/SConstruct
> >
> > Is this an aceptable upgrade? I am not savvy on which versions are
> > desirable.
>
> Yes for master this upgrade is fine

Are you approving the changed licence for OE,
or were you not aware that this was the question?

cu
Adrian

-- 

       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed



^ permalink raw reply	[flat|nested] 23+ messages in thread

* Re: [PATCH 2/4] scons.bbclass: use python3-scons
  2019-06-22  8:58         ` Adrian Bunk
@ 2019-06-23  0:03           ` Khem Raj
  2019-06-23 16:44             ` Tim Orling
  0 siblings, 1 reply; 23+ messages in thread
From: Khem Raj @ 2019-06-23  0:03 UTC (permalink / raw)
  To: Adrian Bunk; +Cc: Patches and discussions about the oe-core layer

[-- Attachment #1: Type: text/plain, Size: 1019 bytes --]

On Sat, Jun 22, 2019 at 1:58 AM Adrian Bunk <bunk@stusta.de> wrote:

> On Thu, Jun 20, 2019 at 09:27:15PM -0600, Khem Raj wrote:
> > On Thu, Jun 20, 2019 at 6:18 PM Tim Orling <ticotimo@gmail.com> wrote:
> >...
> > > Latest mongo release appears to be 4.3.0 and appears to support
> python3:
> > >
> > >
> > >
> https://github.com/mongodb/mongo/blob/89e7419a897b2270931c9c029abf6de555d83e0f/SConstruct
> > >
> > > Is this an aceptable upgrade? I am not savvy on which versions are
> > > desirable.
> >
> > Yes for master this upgrade is fine
>
> Are you approving the changed licence for OE,
> or were you not aware that this was the question?
>

What has changed between 4.0.6 and 4.3.0 w.r.t. licensing ?


> cu
> Adrian
>
> --
>
>        "Is there not promise of rain?" Ling Tan asked suddenly out
>         of the darkness. There had been need of rain for many days.
>        "Only a promise," Lao Er said.
>                                        Pearl S. Buck - Dragon Seed
>
>

[-- Attachment #2: Type: text/html, Size: 1814 bytes --]

^ permalink raw reply	[flat|nested] 23+ messages in thread

* Re: [PATCH 2/4] scons.bbclass: use python3-scons
  2019-06-23  0:03           ` Khem Raj
@ 2019-06-23 16:44             ` Tim Orling
  2019-06-23 19:24               ` Adrian Bunk
  0 siblings, 1 reply; 23+ messages in thread
From: Tim Orling @ 2019-06-23 16:44 UTC (permalink / raw)
  To: Khem Raj; +Cc: Patches and discussions about the oe-core layer, Adrian Bunk

[-- Attachment #1: Type: text/plain, Size: 1324 bytes --]

On Sat, Jun 22, 2019 at 5:03 PM Khem Raj <raj.khem@gmail.com> wrote:

>
>
> On Sat, Jun 22, 2019 at 1:58 AM Adrian Bunk <bunk@stusta.de> wrote:
>
>> On Thu, Jun 20, 2019 at 09:27:15PM -0600, Khem Raj wrote:
>> > On Thu, Jun 20, 2019 at 6:18 PM Tim Orling <ticotimo@gmail.com> wrote:
>> >...
>> > > Latest mongo release appears to be 4.3.0 and appears to support
>> python3:
>> > >
>> > >
>> > >
>> https://github.com/mongodb/mongo/blob/89e7419a897b2270931c9c029abf6de555d83e0f/SConstruct
>> > >
>> > > Is this an aceptable upgrade? I am not savvy on which versions are
>> > > desirable.
>> >
>> > Yes for master this upgrade is fine
>>
>> Are you approving the changed licence for OE,
>> or were you not aware that this was the question?
>>
>
> What has changed between 4.0.6 and 4.3.0 w.r.t. licensing ?
>

The Server Side License is already in 4.0.6
https://github.com/mongodb/mongo/blob/caa42a1f75a56c7643d0b68d3880444375ec42e3/LICENSE-Community.txt

4.2.0+ use python 3 in SConstruct


>
>> cu
>> Adrian
>>
>> --
>>
>>        "Is there not promise of rain?" Ling Tan asked suddenly out
>>         of the darkness. There had been need of rain for many days.
>>        "Only a promise," Lao Er said.
>>                                        Pearl S. Buck - Dragon Seed
>>
>>

[-- Attachment #2: Type: text/html, Size: 2811 bytes --]

^ permalink raw reply	[flat|nested] 23+ messages in thread

* Re: [PATCH 2/4] scons.bbclass: use python3-scons
  2019-06-23 16:44             ` Tim Orling
@ 2019-06-23 19:24               ` Adrian Bunk
  2019-06-24  1:49                 ` Tim Orling
  0 siblings, 1 reply; 23+ messages in thread
From: Adrian Bunk @ 2019-06-23 19:24 UTC (permalink / raw)
  To: Tim Orling; +Cc: Patches and discussions about the oe-core layer

On Sun, Jun 23, 2019 at 09:44:07AM -0700, Tim Orling wrote:
> On Sat, Jun 22, 2019 at 5:03 PM Khem Raj <raj.khem@gmail.com> wrote:
> 
> >
> >
> > On Sat, Jun 22, 2019 at 1:58 AM Adrian Bunk <bunk@stusta.de> wrote:
> >
> >> On Thu, Jun 20, 2019 at 09:27:15PM -0600, Khem Raj wrote:
> >> > On Thu, Jun 20, 2019 at 6:18 PM Tim Orling <ticotimo@gmail.com> wrote:
> >> >...
> >> > > Latest mongo release appears to be 4.3.0 and appears to support
> >> python3:
> >> > >
> >> > >
> >> > >
> >> https://github.com/mongodb/mongo/blob/89e7419a897b2270931c9c029abf6de555d83e0f/SConstruct
> >> > >
> >> > > Is this an aceptable upgrade? I am not savvy on which versions are
> >> > > desirable.
> >> >
> >> > Yes for master this upgrade is fine
> >>
> >> Are you approving the changed licence for OE,
> >> or were you not aware that this was the question?
> >>
> >
> > What has changed between 4.0.6 and 4.3.0 w.r.t. licensing ?
> >
> 
> The Server Side License is already in 4.0.6
> https://github.com/mongodb/mongo/blob/caa42a1f75a56c7643d0b68d3880444375ec42e3/LICENSE-Community.txt
>...

Ah sorry, I missed that.

cu
Adrian

-- 

       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed



^ permalink raw reply	[flat|nested] 23+ messages in thread

* Re: [PATCH 2/4] scons.bbclass: use python3-scons
  2019-06-23 19:24               ` Adrian Bunk
@ 2019-06-24  1:49                 ` Tim Orling
  0 siblings, 0 replies; 23+ messages in thread
From: Tim Orling @ 2019-06-24  1:49 UTC (permalink / raw)
  To: Adrian Bunk; +Cc: Patches and discussions about the oe-core layer

[-- Attachment #1: Type: text/plain, Size: 1681 bytes --]

On Sun, Jun 23, 2019 at 12:24 PM Adrian Bunk <bunk@stusta.de> wrote:

> On Sun, Jun 23, 2019 at 09:44:07AM -0700, Tim Orling wrote:
> > On Sat, Jun 22, 2019 at 5:03 PM Khem Raj <raj.khem@gmail.com> wrote:
> >
> > >
> > >
> > > On Sat, Jun 22, 2019 at 1:58 AM Adrian Bunk <bunk@stusta.de> wrote:
> > >
> > >> On Thu, Jun 20, 2019 at 09:27:15PM -0600, Khem Raj wrote:
> > >> > On Thu, Jun 20, 2019 at 6:18 PM Tim Orling <ticotimo@gmail.com>
> wrote:
> > >> >...
> > >> > > Latest mongo release appears to be 4.3.0 and appears to support
> > >> python3:
> > >> > >
> > >> > >
> > >> > >
> > >>
> https://github.com/mongodb/mongo/blob/89e7419a897b2270931c9c029abf6de555d83e0f/SConstruct
> > >> > >
> > >> > > Is this an aceptable upgrade? I am not savvy on which versions are
> > >> > > desirable.
> > >> >
> > >> > Yes for master this upgrade is fine
> > >>
> > >> Are you approving the changed licence for OE,
> > >> or were you not aware that this was the question?
> > >>
> > >
> > > What has changed between 4.0.6 and 4.3.0 w.r.t. licensing ?
> > >
> >
> > The Server Side License is already in 4.0.6
> >
> https://github.com/mongodb/mongo/blob/caa42a1f75a56c7643d0b68d3880444375ec42e3/LICENSE-Community.txt
> >...
>
> Ah sorry, I missed that.


>
I didn’t know either. And you are correct in identifying what I was
asking.... (without asking)


> cu
> Adrian
>
> --
>
>        "Is there not promise of rain?" Ling Tan asked suddenly out
>         of the darkness. There had been need of rain for many days.
>        "Only a promise," Lao Er said.
>                                        Pearl S. Buck - Dragon Seed
>
>

[-- Attachment #2: Type: text/html, Size: 3115 bytes --]

^ permalink raw reply	[flat|nested] 23+ messages in thread

* Re: [PATCH 2/4] scons.bbclass: use python3-scons
  2019-06-21  0:18     ` Tim Orling
  2019-06-21  3:27       ` Khem Raj
@ 2019-06-24  2:41       ` Alistair Francis
  2019-06-24  8:20         ` Adrian Bunk
  1 sibling, 1 reply; 23+ messages in thread
From: Alistair Francis @ 2019-06-24  2:41 UTC (permalink / raw)
  To: Tim Orling; +Cc: Patches and discussions about the oe-core layer

On Thu, Jun 20, 2019 at 5:22 PM Tim Orling <ticotimo@gmail.com> wrote:
>
>
>
> On Thu, Jun 20, 2019 at 6:37 AM Khem Raj <raj.khem@gmail.com> wrote:
>>
>> On Fri, Jun 7, 2019 at 5:50 PM Tim Orling
>> <timothy.t.orling@linux.intel.com> wrote:
>> >
>> > SCons has supported python3 since 3.0.0 release, use it.
>> >
>> > [YOCTO #13381]
>> >
>> > Signed-off-by: Tim Orling <timothy.t.orling@linux.intel.com>
>> > ---
>> >  meta/classes/scons.bbclass | 2 +-
>> >  1 file changed, 1 insertion(+), 1 deletion(-)
>> >
>> > diff --git a/meta/classes/scons.bbclass b/meta/classes/scons.bbclass
>> > index 9ee7d1587d..a8ddae35f7 100644
>> > --- a/meta/classes/scons.bbclass
>> > +++ b/meta/classes/scons.bbclass
>> > @@ -1,4 +1,4 @@
>> > -DEPENDS += "python-scons-native"
>> > +DEPENDS += "python3-scons-native"
>> >
>>
>> some packages haven't upgraded to py3 but use scons see
>> https://errors.yoctoproject.org/Errors/Details/249271/
>
>
>
> Thank you for reporting this. I was of course expecting some breakage and am committed to fixes. Please do report any other issues.

This also breaks the gpsd install, I tried upgrading to the latest
release and that didn't help. I am going to send a patch for the
upgrade which I tested with this patch reverted.

Alistair

>
> Latest mongo release appears to be 4.3.0 and appears to support python3:
>
> https://github.com/mongodb/mongo/blob/89e7419a897b2270931c9c029abf6de555d83e0f/SConstruct
>
> Is this an aceptable upgrade? I am not savvy on which versions are desirable.
>
>>
>> >  EXTRA_OESCONS ?= ""
>> >
>> > --
>> > 2.20.1
>> >
>> > --
>> > _______________________________________________
>> > Openembedded-core mailing list
>> > Openembedded-core@lists.openembedded.org
>> > http://lists.openembedded.org/mailman/listinfo/openembedded-core
>> --
>> _______________________________________________
>> Openembedded-core mailing list
>> Openembedded-core@lists.openembedded.org
>> http://lists.openembedded.org/mailman/listinfo/openembedded-core
>
> --
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core


^ permalink raw reply	[flat|nested] 23+ messages in thread

* Re: [PATCH 2/4] scons.bbclass: use python3-scons
  2019-06-24  2:41       ` Alistair Francis
@ 2019-06-24  8:20         ` Adrian Bunk
  2019-06-24 17:27           ` Alistair Francis
  0 siblings, 1 reply; 23+ messages in thread
From: Adrian Bunk @ 2019-06-24  8:20 UTC (permalink / raw)
  To: Alistair Francis; +Cc: Patches and discussions about the oe-core layer

On Sun, Jun 23, 2019 at 07:41:05PM -0700, Alistair Francis wrote:
> On Thu, Jun 20, 2019 at 5:22 PM Tim Orling <ticotimo@gmail.com> wrote:
> >
> >
> >
> > On Thu, Jun 20, 2019 at 6:37 AM Khem Raj <raj.khem@gmail.com> wrote:
> >>
> >> On Fri, Jun 7, 2019 at 5:50 PM Tim Orling
> >> <timothy.t.orling@linux.intel.com> wrote:
> >> >
> >> > SCons has supported python3 since 3.0.0 release, use it.
> >> >
> >> > [YOCTO #13381]
> >> >
> >> > Signed-off-by: Tim Orling <timothy.t.orling@linux.intel.com>
> >> > ---
> >> >  meta/classes/scons.bbclass | 2 +-
> >> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >> >
> >> > diff --git a/meta/classes/scons.bbclass b/meta/classes/scons.bbclass
> >> > index 9ee7d1587d..a8ddae35f7 100644
> >> > --- a/meta/classes/scons.bbclass
> >> > +++ b/meta/classes/scons.bbclass
> >> > @@ -1,4 +1,4 @@
> >> > -DEPENDS += "python-scons-native"
> >> > +DEPENDS += "python3-scons-native"
> >> >
> >>
> >> some packages haven't upgraded to py3 but use scons see
> >> https://errors.yoctoproject.org/Errors/Details/249271/
> >
> >
> >
> > Thank you for reporting this. I was of course expecting some breakage and am committed to fixes. Please do report any other issues.
> 
> This also breaks the gpsd install, I tried upgrading to the latest
> release and that didn't help. I am going to send a patch for the
> upgrade which I tested with this patch reverted.

This is already workarounded:
http://git.openembedded.org/meta-openembedded/commit/?h=master-next&id=22bfe06d15e07cac0df3f34566a9d33007663bae

There are post-3.18.1 changes required for Python 3 scons,
but I went for this hack after seeing that a proper fix
would involve all of:
1. upgrading to 3.18.1
2. rebasing oe-only patches to 3.18.1
3. adding post-3.18.1 patches

> Alistair

cu
Adrian

-- 

       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed



^ permalink raw reply	[flat|nested] 23+ messages in thread

* Re: [PATCH 2/4] scons.bbclass: use python3-scons
  2019-06-24  8:20         ` Adrian Bunk
@ 2019-06-24 17:27           ` Alistair Francis
  0 siblings, 0 replies; 23+ messages in thread
From: Alistair Francis @ 2019-06-24 17:27 UTC (permalink / raw)
  To: Adrian Bunk; +Cc: Patches and discussions about the oe-core layer

On Mon, Jun 24, 2019 at 1:20 AM Adrian Bunk <bunk@stusta.de> wrote:
>
> On Sun, Jun 23, 2019 at 07:41:05PM -0700, Alistair Francis wrote:
> > On Thu, Jun 20, 2019 at 5:22 PM Tim Orling <ticotimo@gmail.com> wrote:
> > >
> > >
> > >
> > > On Thu, Jun 20, 2019 at 6:37 AM Khem Raj <raj.khem@gmail.com> wrote:
> > >>
> > >> On Fri, Jun 7, 2019 at 5:50 PM Tim Orling
> > >> <timothy.t.orling@linux.intel.com> wrote:
> > >> >
> > >> > SCons has supported python3 since 3.0.0 release, use it.
> > >> >
> > >> > [YOCTO #13381]
> > >> >
> > >> > Signed-off-by: Tim Orling <timothy.t.orling@linux.intel.com>
> > >> > ---
> > >> >  meta/classes/scons.bbclass | 2 +-
> > >> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > >> >
> > >> > diff --git a/meta/classes/scons.bbclass b/meta/classes/scons.bbclass
> > >> > index 9ee7d1587d..a8ddae35f7 100644
> > >> > --- a/meta/classes/scons.bbclass
> > >> > +++ b/meta/classes/scons.bbclass
> > >> > @@ -1,4 +1,4 @@
> > >> > -DEPENDS += "python-scons-native"
> > >> > +DEPENDS += "python3-scons-native"
> > >> >
> > >>
> > >> some packages haven't upgraded to py3 but use scons see
> > >> https://errors.yoctoproject.org/Errors/Details/249271/
> > >
> > >
> > >
> > > Thank you for reporting this. I was of course expecting some breakage and am committed to fixes. Please do report any other issues.
> >
> > This also breaks the gpsd install, I tried upgrading to the latest
> > release and that didn't help. I am going to send a patch for the
> > upgrade which I tested with this patch reverted.
>
> This is already workarounded:
> http://git.openembedded.org/meta-openembedded/commit/?h=master-next&id=22bfe06d15e07cac0df3f34566a9d33007663bae

Argh, I must not have pulled recently enough.

>
> There are post-3.18.1 changes required for Python 3 scons,
> but I went for this hack after seeing that a proper fix
> would involve all of:
> 1. upgrading to 3.18.1
> 2. rebasing oe-only patches to 3.18.1

I sent a patch (with you CCed) that does the first two.

> 3. adding post-3.18.1 patches

How hard would this be? I'm happy to look into it but I didn't see
anything in the gpsd tree that seemed to fix the issue.

Alistair

>
> > Alistair
>
> cu
> Adrian
>
> --
>
>        "Is there not promise of rain?" Ling Tan asked suddenly out
>         of the darkness. There had been need of rain for many days.
>        "Only a promise," Lao Er said.
>                                        Pearl S. Buck - Dragon Seed
>


^ permalink raw reply	[flat|nested] 23+ messages in thread

end of thread, other threads:[~2019-06-24 17:30 UTC | newest]

Thread overview: 23+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-06-07 23:47 [PATCH 0/4] Move SCons to Python 3 Tim Orling
2019-06-07 23:47 ` [PATCH 1/4] python3-scons-{native}: add recipe for v3.0.5 Tim Orling
2019-06-08  0:56   ` Tim Orling
2019-06-07 23:47 ` [PATCH 2/4] scons.bbclass: use python3-scons Tim Orling
2019-06-20 13:36   ` Khem Raj
2019-06-21  0:18     ` Tim Orling
2019-06-21  3:27       ` Khem Raj
2019-06-22  8:58         ` Adrian Bunk
2019-06-23  0:03           ` Khem Raj
2019-06-23 16:44             ` Tim Orling
2019-06-23 19:24               ` Adrian Bunk
2019-06-24  1:49                 ` Tim Orling
2019-06-24  2:41       ` Alistair Francis
2019-06-24  8:20         ` Adrian Bunk
2019-06-24 17:27           ` Alistair Francis
2019-06-07 23:47 ` [PATCH 3/4] serf: switch to python3-scons-native Tim Orling
2019-06-10  5:10   ` Mittal, Anuj
2019-06-10  5:22     ` Tim Orling
2019-06-12 20:52     ` Khem Raj
2019-06-07 23:47 ` [PATCH 4/4] oeqa/runtime: add simple test for scons Tim Orling
2019-06-08  3:54 ` ✗ patchtest: failure for Move SCons to Python 3 Patchwork
2019-06-08  4:04   ` Tim Orling
2019-06-08  7:13 ` [PATCH 0/4] " Burton, Ross

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.