All of lore.kernel.org
 help / color / mirror / Atom feed
* [meta-python][PATCH] python3-requests-toolbelt: Remove py3-mock from rdeps
@ 2020-07-06 14:51 Khem Raj
  2020-07-06 15:01 ` [oe] " Tim Orling
  0 siblings, 1 reply; 5+ messages in thread
From: Khem Raj @ 2020-07-06 14:51 UTC (permalink / raw)
  To: openembedded-devel; +Cc: Khem Raj, Sakib Sajal

python3-mock does not exist as independent package

Signed-off-by: Khem Raj <raj.khem@gmail.com>
Cc: Sakib Sajal <sakib.sajal@windriver.com>
---
 .../recipes-devtools/python/python3-requests-toolbelt_0.9.1.bb   | 1 -
 1 file changed, 1 deletion(-)

diff --git a/meta-python/recipes-devtools/python/python3-requests-toolbelt_0.9.1.bb b/meta-python/recipes-devtools/python/python3-requests-toolbelt_0.9.1.bb
index e075c019d0..27d122cd52 100644
--- a/meta-python/recipes-devtools/python/python3-requests-toolbelt_0.9.1.bb
+++ b/meta-python/recipes-devtools/python/python3-requests-toolbelt_0.9.1.bb
@@ -20,7 +20,6 @@ RDEPENDS_${PN} += " \
 RDEPENDS_${PN}-ptest += " \
 	${PYTHON_PN}-pytest \
 	${PYTHON_PN}-betamax \
-	${PYTHON_PN}-mock \
 "
 
 do_install_ptest() {
-- 
2.27.0


^ permalink raw reply related	[flat|nested] 5+ messages in thread

* Re: [oe] [meta-python][PATCH] python3-requests-toolbelt: Remove py3-mock from rdeps
  2020-07-06 14:51 [meta-python][PATCH] python3-requests-toolbelt: Remove py3-mock from rdeps Khem Raj
@ 2020-07-06 15:01 ` Tim Orling
  2020-07-06 17:51   ` Khem Raj
  2020-07-06 18:47   ` Trevor Gamblin
  0 siblings, 2 replies; 5+ messages in thread
From: Tim Orling @ 2020-07-06 15:01 UTC (permalink / raw)
  To: Sakib Sajal; +Cc: Khem Raj, openembedded-devel

[-- Attachment #1: Type: text/plain, Size: 1081 bytes --]

On Mon, Jul 6, 2020 at 7:51 AM Khem Raj <raj.khem@gmail.com> wrote:

> python3-mock does not exist as independent package
>

Sakib,
Perhaps you were bringing it in from meta-cloud-services?
http://layers.openembedded.org/layerindex/recipe/120255/


> Signed-off-by: Khem Raj <raj.khem@gmail.com>
> Cc: Sakib Sajal <sakib.sajal@windriver.com>
> ---
>  .../recipes-devtools/python/python3-requests-toolbelt_0.9.1.bb   | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/meta-python/recipes-devtools/python/
> python3-requests-toolbelt_0.9.1.bb b/meta-python/recipes-devtools/python/
> python3-requests-toolbelt_0.9.1.bb
> index e075c019d0..27d122cd52 100644
> --- a/meta-python/recipes-devtools/python/
> python3-requests-toolbelt_0.9.1.bb
> +++ b/meta-python/recipes-devtools/python/
> python3-requests-toolbelt_0.9.1.bb
> @@ -20,7 +20,6 @@ RDEPENDS_${PN} += " \
>  RDEPENDS_${PN}-ptest += " \
>         ${PYTHON_PN}-pytest \
>         ${PYTHON_PN}-betamax \
> -       ${PYTHON_PN}-mock \
>  "
>
>  do_install_ptest() {
> --
> 2.27.0
>
> 
>

[-- Attachment #2: Type: text/html, Size: 2292 bytes --]

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [oe] [meta-python][PATCH] python3-requests-toolbelt: Remove py3-mock from rdeps
  2020-07-06 15:01 ` [oe] " Tim Orling
@ 2020-07-06 17:51   ` Khem Raj
  2020-07-06 18:47   ` Trevor Gamblin
  1 sibling, 0 replies; 5+ messages in thread
From: Khem Raj @ 2020-07-06 17:51 UTC (permalink / raw)
  To: Tim Orling, Sakib Sajal; +Cc: openembedded-devel



On 7/6/20 8:01 AM, Tim Orling wrote:
> 
> 
> On Mon, Jul 6, 2020 at 7:51 AM Khem Raj <raj.khem@gmail.com 
> <mailto:raj.khem@gmail.com>> wrote:
> 
>     python3-mock does not exist as independent package
> 
> 
> Sakib,
> Perhaps you were bringing it in from meta-cloud-services?
> http://layers.openembedded.org/layerindex/recipe/120255/
> 

yeah, I have dropped the ptest addition patch for now which means I can 
drop this one too, so please send a v2 with this fixed as well along 
with other review comments addressed.

> 
>     Signed-off-by: Khem Raj <raj.khem@gmail.com <mailto:raj.khem@gmail.com>>
>     Cc: Sakib Sajal <sakib.sajal@windriver.com
>     <mailto:sakib.sajal@windriver.com>>
>     ---
>       .../recipes-devtools/python/python3-requests-toolbelt_0.9.1.bb
>     <http://python3-requests-toolbelt_0.9.1.bb>   | 1 -
>       1 file changed, 1 deletion(-)
> 
>     diff --git
>     a/meta-python/recipes-devtools/python/python3-requests-toolbelt_0.9.1.bb
>     <http://python3-requests-toolbelt_0.9.1.bb>
>     b/meta-python/recipes-devtools/python/python3-requests-toolbelt_0.9.1.bb
>     <http://python3-requests-toolbelt_0.9.1.bb>
>     index e075c019d0..27d122cd52 100644
>     ---
>     a/meta-python/recipes-devtools/python/python3-requests-toolbelt_0.9.1.bb
>     <http://python3-requests-toolbelt_0.9.1.bb>
>     +++
>     b/meta-python/recipes-devtools/python/python3-requests-toolbelt_0.9.1.bb
>     <http://python3-requests-toolbelt_0.9.1.bb>
>     @@ -20,7 +20,6 @@ RDEPENDS_${PN} += " \
>       RDEPENDS_${PN}-ptest += " \
>              ${PYTHON_PN}-pytest \
>              ${PYTHON_PN}-betamax \
>     -       ${PYTHON_PN}-mock \
>       "
> 
>       do_install_ptest() {
>     -- 
>     2.27.0
> 
>     
> 

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [oe] [meta-python][PATCH] python3-requests-toolbelt: Remove py3-mock from rdeps
  2020-07-06 15:01 ` [oe] " Tim Orling
  2020-07-06 17:51   ` Khem Raj
@ 2020-07-06 18:47   ` Trevor Gamblin
  2020-07-07  1:02     ` Tim Orling
  1 sibling, 1 reply; 5+ messages in thread
From: Trevor Gamblin @ 2020-07-06 18:47 UTC (permalink / raw)
  To: Tim Orling, Sakib Sajal; +Cc: Khem Raj, openembedded-devel

[-- Attachment #1: Type: text/plain, Size: 1937 bytes --]


On 7/6/20 11:01 AM, Tim Orling wrote:
>
>
> On Mon, Jul 6, 2020 at 7:51 AM Khem Raj <raj.khem@gmail.com 
> <mailto:raj.khem@gmail.com>> wrote:
>
>     python3-mock does not exist as independent package
>
>
> Sakib,
> Perhaps you were bringing it in from meta-cloud-services?
> http://layers.openembedded.org/layerindex/recipe/120255/
Yeah, he's been adding things to support python3-requests-toolbelt (with 
my help), but we missed that dependency. I think requests-toolbelt is 
minor enough (while being a useful addition) that it should be in 
meta-python alongside python3-requests, so for completeness' sake we 
should move python3-mock in as well.
>
>
>     Signed-off-by: Khem Raj <raj.khem@gmail.com
>     <mailto:raj.khem@gmail.com>>
>     Cc: Sakib Sajal <sakib.sajal@windriver.com
>     <mailto:sakib.sajal@windriver.com>>
>     ---
>      .../recipes-devtools/python/python3-requests-toolbelt_0.9.1.bb
>     <http://python3-requests-toolbelt_0.9.1.bb>  | 1 -
>      1 file changed, 1 deletion(-)
>
>     diff --git
>     a/meta-python/recipes-devtools/python/python3-requests-toolbelt_0.9.1.bb
>     <http://python3-requests-toolbelt_0.9.1.bb>
>     b/meta-python/recipes-devtools/python/python3-requests-toolbelt_0.9.1.bb
>     <http://python3-requests-toolbelt_0.9.1.bb>
>     index e075c019d0..27d122cd52 100644
>     ---
>     a/meta-python/recipes-devtools/python/python3-requests-toolbelt_0.9.1.bb
>     <http://python3-requests-toolbelt_0.9.1.bb>
>     +++
>     b/meta-python/recipes-devtools/python/python3-requests-toolbelt_0.9.1.bb
>     <http://python3-requests-toolbelt_0.9.1.bb>
>     @@ -20,7 +20,6 @@ RDEPENDS_${PN} += " \
>      RDEPENDS_${PN}-ptest += " \
>             ${PYTHON_PN}-pytest \
>             ${PYTHON_PN}-betamax \
>     -       ${PYTHON_PN}-mock \
>      "
>
>      do_install_ptest() {
>     -- 
>     2.27.0
>
>
>
> 

[-- Attachment #2: Type: text/html, Size: 4222 bytes --]

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [oe] [meta-python][PATCH] python3-requests-toolbelt: Remove py3-mock from rdeps
  2020-07-06 18:47   ` Trevor Gamblin
@ 2020-07-07  1:02     ` Tim Orling
  0 siblings, 0 replies; 5+ messages in thread
From: Tim Orling @ 2020-07-07  1:02 UTC (permalink / raw)
  To: Trevor Gamblin; +Cc: Khem Raj, Sakib Sajal, openembedded-devel

[-- Attachment #1: Type: text/plain, Size: 1878 bytes --]

On Mon, Jul 6, 2020 at 11:47 AM Trevor Gamblin <trevor.gamblin@windriver.com>
wrote:

>
> On 7/6/20 11:01 AM, Tim Orling wrote:
>
>
>
> On Mon, Jul 6, 2020 at 7:51 AM Khem Raj <raj.khem@gmail.com> wrote:
>
>> python3-mock does not exist as independent package
>>
>
> Sakib,
> Perhaps you were bringing it in from meta-cloud-services?
> http://layers.openembedded.org/layerindex/recipe/120255/
>
> Yeah, he's been adding things to support python3-requests-toolbelt (with
> my help), but we missed that dependency. I think requests-toolbelt is minor
> enough (while being a useful addition) that it should be in meta-python
> alongside python3-requests, so for completeness' sake we should move
> python3-mock in as well.
>
>
There are other things that need python3-mock to run ptests (not that I
remember an example off the top of my head at the moment), so I agree this
makes sense. Please coordinate with meta-cloud-services maintainers to make
sure they don’t have any concerns.

>
>
>> Signed-off-by: Khem Raj <raj.khem@gmail.com>
>> Cc: Sakib Sajal <sakib.sajal@windriver.com>
>> ---
>>  .../recipes-devtools/python/python3-requests-toolbelt_0.9.1.bb   | 1 -
>>  1 file changed, 1 deletion(-)
>>
>> diff --git a/meta-python/recipes-devtools/python/
>> python3-requests-toolbelt_0.9.1.bb b/meta-python/recipes-devtools/python/
>> python3-requests-toolbelt_0.9.1.bb
>> index e075c019d0..27d122cd52 100644
>> --- a/meta-python/recipes-devtools/python/
>> python3-requests-toolbelt_0.9.1.bb
>> +++ b/meta-python/recipes-devtools/python/
>> python3-requests-toolbelt_0.9.1.bb
>> @@ -20,7 +20,6 @@ RDEPENDS_${PN} += " \
>>  RDEPENDS_${PN}-ptest += " \
>>         ${PYTHON_PN}-pytest \
>>         ${PYTHON_PN}-betamax \
>> -       ${PYTHON_PN}-mock \
>>  "
>>
>>  do_install_ptest() {
>> --
>> 2.27.0
>>
>>
>>
> 
>
>

[-- Attachment #2: Type: text/html, Size: 4483 bytes --]

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2020-07-07  1:02 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-07-06 14:51 [meta-python][PATCH] python3-requests-toolbelt: Remove py3-mock from rdeps Khem Raj
2020-07-06 15:01 ` [oe] " Tim Orling
2020-07-06 17:51   ` Khem Raj
2020-07-06 18:47   ` Trevor Gamblin
2020-07-07  1:02     ` Tim Orling

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.